ticket: close role launch split

This commit is contained in:
Keisuke Hirata 2026-06-12 22:08:59 +09:00
parent 9ad5ed6d86
commit af00af0366
No known key found for this signature in database
3 changed files with 99 additions and 3 deletions

View File

@ -1,8 +1,8 @@
---
title: 'Ticket role launch inputを短縮し、role behaviorをInstruction/Workflowへ分離する'
state: 'done'
state: 'closed'
created_at: '2026-06-11T16:03:28Z'
updated_at: '2026-06-12T13:08:11Z'
updated_at: '2026-06-12T13:08:52Z'
assignee: null
risk_flags: ['prompt-context', 'workflow-boundary', 'role-launch']
queued_by: 'workspace-panel'

View File

@ -0,0 +1,32 @@
Ticket role launch の first-run user message を短縮し、role behavior / procedural guidance / control-plane metadata の所管を分離した。
実装概要:
- `crates/client/src/ticket_role.rs` の launch Submit text を短縮し、対象 Ticket / action instruction / per-launch context に限定した。
- `Profile selector`、`Workflow`、`Configured launch_prompt ref`、Ticket record language guidance、runtime workspace/cwd などの control-plane / environment 情報を first-run user text から外した。
- builtin role Profiles に `worker.instruction = "$yoi/role/<role>"` を設定し、role behavior を `resources/prompts/role/{intake,orchestrator,coder,reviewer}.md` へ移した。
- procedural guidance は Workflow resources 側に保持・移動した。
- obsolete な `resources/prompts/ticket_role/*.md` fragments を削除した。
- boundary を検証する focused unit tests を追加・更新した。
Review / integration:
- Implementation commit: `949531a0 client: shorten ticket role launch input`
- Reviewer: `yoi-reviewer-role-launch-input` が approve。
- Orchestrator merge commit: `bdbd955b merge: ticket role launch input split`
- Ticket completion commit: `9ad5ed6d ticket: mark role launch done`
Validation:
- `cargo test -p client ticket_role --lib`: pass
- `cargo test -p manifest builtin_role_profiles_are_registered_and_resolve --lib`: pass
- `cargo test -p pod builtin_ticket_role_instructions_resolve --lib`: pass
- `cargo fmt --check`: pass
- `git diff --check HEAD~1..HEAD`: pass
- `nix build .#yoi`: pass
- `./result/bin/yoi ticket doctor`: `doctor: ok`
Cleanup:
- coder/reviewer Pods stopped。
- child worktree `/home/hare/Projects/yoi/.worktree/shorten-ticket-role-launch-input` removed。
- branch `ticket/shorten-ticket-role-launch-input` deleted。
Non-blocking follow-up:
- 旧 `.yoi/prompts/ticket_role/*` override は launch Submit text には効かなくなるため、外部ユーザー向けには role behavior は Profile instruction、手順は Workflow override へ移す旨を必要に応じて案内すると安全。

View File

@ -284,7 +284,7 @@ Integrated implementation:
- Implementation branch: `ticket/shorten-ticket-role-launch-input`
- Implementation commit: `949531a0 client: shorten ticket role launch input`
- Reviewer result: approve, no blockers
- Orchestrator merge commit: `b18b8b5d merge: ticket role launch input split`
- Orchestrator merge commit: `bdbd955b merge: ticket role launch input split`
- Integration target: `orchestration/yoi-orchestrator`
Post-integration validation from Orchestrator worktree:
@ -308,3 +308,67 @@ Remaining non-blocking risk:
Implementation was merged into the Orchestrator branch, reviewer approved, and post-integration validation passed. Cleanup and closure will be recorded next.
---
<!-- event: implementation_report author: orchestrator at: 2026-06-12T13:08:36Z -->
## Implementation report
Cleanup completed.
- Stopped coder Pod: `yoi-coder-role-launch-input`
- Stopped reviewer Pod: `yoi-reviewer-role-launch-input`
- Removed child worktree: `/home/hare/Projects/yoi/.worktree/shorten-ticket-role-launch-input`
- Deleted implementation branch: `ticket/shorten-ticket-role-launch-input`
- Orchestrator worktree status after cleanup: clean
Cleanup was limited to child implementation worktree/branch and related child Pods. Root/original workspace was not touched.
---
<!-- event: state_changed author: hare at: 2026-06-12T13:08:52Z from: done to: closed reason: closed field: state -->
## State changed
Ticket を closed にしました。
---
<!-- event: close author: hare at: 2026-06-12T13:08:52Z status: closed -->
## 完了
Ticket role launch の first-run user message を短縮し、role behavior / procedural guidance / control-plane metadata の所管を分離した。
実装概要:
- `crates/client/src/ticket_role.rs` の launch Submit text を短縮し、対象 Ticket / action instruction / per-launch context に限定した。
- `Profile selector`、`Workflow`、`Configured launch_prompt ref`、Ticket record language guidance、runtime workspace/cwd などの control-plane / environment 情報を first-run user text から外した。
- builtin role Profiles に `worker.instruction = "$yoi/role/<role>"` を設定し、role behavior を `resources/prompts/role/{intake,orchestrator,coder,reviewer}.md` へ移した。
- procedural guidance は Workflow resources 側に保持・移動した。
- obsolete な `resources/prompts/ticket_role/*.md` fragments を削除した。
- boundary を検証する focused unit tests を追加・更新した。
Review / integration:
- Implementation commit: `949531a0 client: shorten ticket role launch input`
- Reviewer: `yoi-reviewer-role-launch-input` が approve。
- Orchestrator merge commit: `bdbd955b merge: ticket role launch input split`
- Ticket completion commit: `9ad5ed6d ticket: mark role launch done`
Validation:
- `cargo test -p client ticket_role --lib`: pass
- `cargo test -p manifest builtin_role_profiles_are_registered_and_resolve --lib`: pass
- `cargo test -p pod builtin_ticket_role_instructions_resolve --lib`: pass
- `cargo fmt --check`: pass
- `git diff --check HEAD~1..HEAD`: pass
- `nix build .#yoi`: pass
- `./result/bin/yoi ticket doctor`: `doctor: ok`
Cleanup:
- coder/reviewer Pods stopped。
- child worktree `/home/hare/Projects/yoi/.worktree/shorten-ticket-role-launch-input` removed。
- branch `ticket/shorten-ticket-role-launch-input` deleted。
Non-blocking follow-up:
- 旧 `.yoi/prompts/ticket_role/*` override は launch Submit text には効かなくなるため、外部ユーザー向けには role behavior は Profile instruction、手順は Workflow override へ移す旨を必要に応じて案内すると安全。
---