From af13a8bddbc2a3b01952d71f5bbd2efc80c1dad7 Mon Sep 17 00:00:00 2001 From: Hare Date: Mon, 8 Jun 2026 17:22:05 +0900 Subject: [PATCH] ticket: close ticket record language split --- .../artifacts/.gitkeep | 0 .../item.md | 6 +- .../resolution.md | 36 ++++++++++ .../thread.md | 68 +++++++++++++++++++ 4 files changed, 107 insertions(+), 3 deletions(-) rename .yoi/tickets/{open => closed}/20260608-032911-separate-ticket-record-language-from-worker-language/artifacts/.gitkeep (100%) rename .yoi/tickets/{open => closed}/20260608-032911-separate-ticket-record-language-from-worker-language/item.md (97%) create mode 100644 .yoi/tickets/closed/20260608-032911-separate-ticket-record-language-from-worker-language/resolution.md rename .yoi/tickets/{open => closed}/20260608-032911-separate-ticket-record-language-from-worker-language/thread.md (85%) diff --git a/.yoi/tickets/open/20260608-032911-separate-ticket-record-language-from-worker-language/artifacts/.gitkeep b/.yoi/tickets/closed/20260608-032911-separate-ticket-record-language-from-worker-language/artifacts/.gitkeep similarity index 100% rename from .yoi/tickets/open/20260608-032911-separate-ticket-record-language-from-worker-language/artifacts/.gitkeep rename to .yoi/tickets/closed/20260608-032911-separate-ticket-record-language-from-worker-language/artifacts/.gitkeep diff --git a/.yoi/tickets/open/20260608-032911-separate-ticket-record-language-from-worker-language/item.md b/.yoi/tickets/closed/20260608-032911-separate-ticket-record-language-from-worker-language/item.md similarity index 97% rename from .yoi/tickets/open/20260608-032911-separate-ticket-record-language-from-worker-language/item.md rename to .yoi/tickets/closed/20260608-032911-separate-ticket-record-language-from-worker-language/item.md index 52888f8e..663c7712 100644 --- a/.yoi/tickets/open/20260608-032911-separate-ticket-record-language-from-worker-language/item.md +++ b/.yoi/tickets/closed/20260608-032911-separate-ticket-record-language-from-worker-language/item.md @@ -2,13 +2,13 @@ id: '20260608-032911-separate-ticket-record-language-from-worker-language' slug: 'separate-ticket-record-language-from-worker-language' title: 'Separate Ticket record language from worker response language' -status: 'open' +status: 'closed' kind: 'task' priority: 'P2' labels: ['ticket', 'language', 'config', 'profile', 'workflow'] -workflow_state: 'inprogress' +workflow_state: 'done' created_at: '2026-06-08T03:29:11Z' -updated_at: '2026-06-08T08:18:46Z' +updated_at: '2026-06-08T08:21:55Z' assignee: null legacy_ticket: null queued_by: 'workspace-panel' diff --git a/.yoi/tickets/closed/20260608-032911-separate-ticket-record-language-from-worker-language/resolution.md b/.yoi/tickets/closed/20260608-032911-separate-ticket-record-language-from-worker-language/resolution.md new file mode 100644 index 00000000..201e282a --- /dev/null +++ b/.yoi/tickets/closed/20260608-032911-separate-ticket-record-language-from-worker-language/resolution.md @@ -0,0 +1,36 @@ +Merged and completed the Ticket record language split. + +Summary: +- Added optional `[ticket].language` support to Ticket config, independent from `worker.language` and `memory.language`. +- Set this repository's `.yoi/ticket.config.toml` to `language = "Japanese"` under `[ticket]`. +- Added scaffold support and validation for the new setting. +- Propagated configured Ticket record language through Ticket CLI/backend construction, built-in Ticket feature backend construction, Panel backend construction, and Ticket role launch context/prompt guidance. +- Added minimal generated-text support for configured Japanese on prominent generated Ticket record paths while preserving English/default behavior when absent or unsupported. +- Existing Tickets were not bulk-translated or rewritten. + +Merged branch/worktree: +- Branch: `separate-ticket-record-language-from-worker-language` +- Commit: `fb261bb feat: add ticket record language config` +- Merge commit on `develop`: `a74e315 merge: separate ticket record language` + +Validation passed after merge: +- `cargo test -p ticket config::tests --lib` +- `cargo test -p ticket create_uses_configured_japanese_record_language_for_generated_defaults --lib` +- `cargo test -p client configured_ticket_record_language_is_included_in_role_prompt --lib` +- `cargo test -p yoi ticket_cli_init_writes_explicit_ticket_config_scaffold` +- `cargo test -p client ticket_role --lib` +- `cargo test -p ticket --lib` +- `cargo check -p pod -p tui` +- `cargo fmt --check` +- `git diff --check` +- `cargo run -q -p yoi -- ticket doctor` +- `nix build .#yoi` + +Cleanup completed: +- Stopped coder/reviewer Pods and reclaimed scope. +- Removed `.worktree/separate-ticket-record-language-from-worker-language`. +- Deleted branch `separate-ticket-record-language-from-worker-language`. + +Residual notes: +- This is not full localization infrastructure. Some generated Ticket-related messages may remain English unless separately localized later. +- Japanese generation coverage is intentionally scoped to prominent configured record paths and role guidance. \ No newline at end of file diff --git a/.yoi/tickets/open/20260608-032911-separate-ticket-record-language-from-worker-language/thread.md b/.yoi/tickets/closed/20260608-032911-separate-ticket-record-language-from-worker-language/thread.md similarity index 85% rename from .yoi/tickets/open/20260608-032911-separate-ticket-record-language-from-worker-language/thread.md rename to .yoi/tickets/closed/20260608-032911-separate-ticket-record-language-from-worker-language/thread.md index 950c5cb0..e072da20 100644 --- a/.yoi/tickets/open/20260608-032911-separate-ticket-record-language-from-worker-language/thread.md +++ b/.yoi/tickets/closed/20260608-032911-separate-ticket-record-language-from-worker-language/thread.md @@ -333,3 +333,71 @@ Parent/human decision needs: - User has authorized merge-completion and cleanup after approved work. Proceeding to merge-completion unless merge conflict or post-merge validation fails. --- + + + +## Review: approve + +Final merge-completion approval after merge to `develop` and post-merge validation. + +Evidence: +- Merged branch `separate-ticket-record-language-from-worker-language` with `--no-ff`. +- Reviewer `reviewer-ticket-record-language` approved the branch-local implementation. +- Post-merge validation passed: focused Ticket config/generated-text tests, focused role prompt/scaffold tests, `cargo test -p client ticket_role --lib`, `cargo test -p ticket --lib`, `cargo check -p pod -p tui`, `cargo fmt --check`, `git diff --check`, `cargo run -q -p yoi -- ticket doctor`, and `nix build .#yoi`. +- Coder/reviewer Pods stopped and delegated scope reclaimed. +- Merged worktree removed and branch deleted. + +This approval is for the merged main-branch result, not merely the branch-local reviewer verdict. + +--- + + + +## State changed + +Merged to `develop`, post-merge validation passed, final merge-completion approval recorded, and Ticket-language branch/worktree/Pods cleaned up. + +--- + + + +## Closed + +Merged and completed the Ticket record language split. + +Summary: +- Added optional `[ticket].language` support to Ticket config, independent from `worker.language` and `memory.language`. +- Set this repository's `.yoi/ticket.config.toml` to `language = "Japanese"` under `[ticket]`. +- Added scaffold support and validation for the new setting. +- Propagated configured Ticket record language through Ticket CLI/backend construction, built-in Ticket feature backend construction, Panel backend construction, and Ticket role launch context/prompt guidance. +- Added minimal generated-text support for configured Japanese on prominent generated Ticket record paths while preserving English/default behavior when absent or unsupported. +- Existing Tickets were not bulk-translated or rewritten. + +Merged branch/worktree: +- Branch: `separate-ticket-record-language-from-worker-language` +- Commit: `fb261bb feat: add ticket record language config` +- Merge commit on `develop`: `a74e315 merge: separate ticket record language` + +Validation passed after merge: +- `cargo test -p ticket config::tests --lib` +- `cargo test -p ticket create_uses_configured_japanese_record_language_for_generated_defaults --lib` +- `cargo test -p client configured_ticket_record_language_is_included_in_role_prompt --lib` +- `cargo test -p yoi ticket_cli_init_writes_explicit_ticket_config_scaffold` +- `cargo test -p client ticket_role --lib` +- `cargo test -p ticket --lib` +- `cargo check -p pod -p tui` +- `cargo fmt --check` +- `git diff --check` +- `cargo run -q -p yoi -- ticket doctor` +- `nix build .#yoi` + +Cleanup completed: +- Stopped coder/reviewer Pods and reclaimed scope. +- Removed `.worktree/separate-ticket-record-language-from-worker-language`. +- Deleted branch `separate-ticket-record-language-from-worker-language`. + +Residual notes: +- This is not full localization infrastructure. Some generated Ticket-related messages may remain English unless separately localized later. +- Japanese generation coverage is intentionally scoped to prominent configured record paths and role guidance. + +---