merge: orchestration

web/workspace/src/lib/workspace-sidebar/types.ts

@@ -101,6 +101,7 @@ export type WorkerLaunchRuntimeOption = {
   display_name: string;
   built_in: boolean;
   can_spawn_worker: boolean;
+  working_directory_required: boolean;
   status: string;
   diagnostics: Diagnostic[];
 };

web/workspace/src/lib/workspace-sidebar/worker-launch.test.ts

@@ -25,6 +25,7 @@ const options: WorkerLaunchOptionsResponse = {
       status: "active",
       can_spawn_worker: true,
       built_in: false,
+      working_directory_required: true,
       diagnostics: [],
     },
     {
@@ -32,7 +33,8 @@ const options: WorkerLaunchOptionsResponse = {
       display_name: "Embedded",
       status: "active",
       can_spawn_worker: true,
-      built_in: false,
+      built_in: true,
+      working_directory_required: false,
       diagnostics: [],
     },
   ],
@@ -107,3 +109,23 @@ Deno.test("buildBrowserCreateWorkerRequest sends working_directory id and relati
     },
   });
 });
+
+Deno.test("buildBrowserCreateWorkerRequest omits working_directory for embedded no-workdir launches", () => {
+  const request = buildBrowserCreateWorkerRequest({
+    runtime_id: "embedded",
+    display_name: "Worker",
+    profile: "builtin:companion",
+    initial_text: "chat",
+    working_directory_id: "",
+    working_directory_repository_id: "",
+    working_directory_selector: "",
+    relative_cwd: "",
+  });
+
+  assertEquals(request, {
+    runtime_id: "embedded",
+    display_name: "Worker",
+    profile: "builtin:companion",
+    initial_text: "chat",
+  });
+});

web/workspace/src/routes/w/[workspaceId]/workers/new/+page.svelte

@@ -41,7 +41,14 @@
   let relativeCwd = $state('');
   let creatingWorkingDirectory = $state(false);
   let isNewWorkingDirectorySelected = $derived(workingDirectoryId === NEW_WORKING_DIRECTORY_VALUE);
-  let canStartWorker = $derived(Boolean(runtimeId && profile && workingDirectoryId && !isNewWorkingDirectorySelected));
+  let selectedRuntime = $derived(options?.runtimes.find((runtime) => runtime.runtime_id === runtimeId));
+  let selectedRuntimeAllowsNoWorkdir = $derived(selectedRuntime?.working_directory_required === false);
+  let hasSelectedExistingWorkdir = $derived(Boolean(workingDirectoryId && !isNewWorkingDirectorySelected));
+  let canStartWorker = $derived(Boolean(
+    runtimeId &&
+      profile &&
+      (hasSelectedExistingWorkdir || (selectedRuntimeAllowsNoWorkdir && !isNewWorkingDirectorySelected)),
+  ));
 
   function workerApiPath(path: string): string {
     return workspaceApiPath(workspaceId, path);
@@ -81,7 +88,7 @@
       runtimeId = form.runtime_id;
       displayName = form.display_name;
       profile = form.profile;
-      workingDirectoryId = form.working_directory_id || NEW_WORKING_DIRECTORY_VALUE;
+      workingDirectoryId = form.working_directory_id;
       workingDirectoryRepositoryId = form.working_directory_repository_id;
       workingDirectorySelector = form.working_directory_selector;
       relativeCwd = form.relative_cwd;
@@ -149,8 +156,8 @@
       submitError = { message: 'workspace id is unavailable', diagnostics: [] };
       return;
     }
-    if (isNewWorkingDirectorySelected || !workingDirectoryId) {
-      submitError = { message: 'select or create a workdir before starting a Worker', diagnostics: [] };
+    if (isNewWorkingDirectorySelected || (!workingDirectoryId && !selectedRuntimeAllowsNoWorkdir)) {
+      submitError = { message: 'select or create a workdir before starting a Worker; only embedded Runtime can start without one', diagnostics: [] };
       return;
     }
 
@@ -220,7 +227,7 @@
   <header class="worker-new-page-header">
     <div>
       <h1 id="new-worker-heading">New Worker</h1>
-      <p>Create a Worker on a selected Runtime and workdir.</p>
+      <p>Create a Worker on a selected Runtime. Workdir-less conversation Workers are only available on embedded Runtime.</p>
     </div>
     <a class="secondary-link" href={`/w/${workspaceId}`}>Back to workspace</a>
   </header>
@@ -237,7 +244,11 @@
         <div class="worker-launch-sentence">
           <span>Run at</span>
           <select class="worker-inline-select wd-select" bind:value={workingDirectoryId} aria-label="Workdir">
-            <option value="">Select workdir</option>
+            {#if selectedRuntimeAllowsNoWorkdir}
+              <option value="">No workdir · embedded conversation only</option>
+            {:else}
+              <option value="" disabled>Select workdir</option>
+            {/if}
             {#each options?.working_directories ?? [] as directory}
               <option value={directory.working_directory_id} disabled={directory.status !== 'active'}>
                 {directory.repository_id} · {directory.requested_selector ?? 'HEAD'}
@@ -259,6 +270,12 @@
           </select>
         </div>
 
+        {#if !selectedRuntimeAllowsNoWorkdir && !workingDirectoryId && !isNewWorkingDirectorySelected}
+          <p class="worker-workdir-note">This Runtime requires a selected workdir before starting a Worker.</p>
+        {:else if selectedRuntimeAllowsNoWorkdir && !workingDirectoryId}
+          <p class="worker-workdir-note">No filesystem tools or Bash will be available without a workdir.</p>
+        {/if}
+
         {#if isNewWorkingDirectorySelected}
           <div class="new-working-directory-panel">
             <h3>New workdir</h3>
@@ -286,10 +303,12 @@
           </div>
         {/if}
 
-        <label class="relative-cwd-field">
-          <span>Relative cwd inside workdir</span>
-          <input bind:value={relativeCwd} autocomplete="off" placeholder="Optional path inside workdir" />
-        </label>
+        {#if hasSelectedExistingWorkdir || isNewWorkingDirectorySelected}
+          <label class="relative-cwd-field">
+            <span>Relative cwd inside workdir</span>
+            <input bind:value={relativeCwd} autocomplete="off" placeholder="Optional path inside workdir" />
+          </label>
+        {/if}
       </section>
 
       <section class="worker-form-section" aria-labelledby="worker-details-heading">