ticket: close builtin role profiles
This commit is contained in:
parent
7daecca8c5
commit
b7a3dae543
|
|
@ -1,8 +1,8 @@
|
||||||
---
|
---
|
||||||
title: 'Project role profilesをbuiltin profilesへ移行する'
|
title: 'Project role profilesをbuiltin profilesへ移行する'
|
||||||
state: 'inprogress'
|
state: 'closed'
|
||||||
created_at: '2026-06-10T10:11:51Z'
|
created_at: '2026-06-10T10:11:51Z'
|
||||||
updated_at: '2026-06-10T15:26:32Z'
|
updated_at: '2026-06-11T00:05:19Z'
|
||||||
assignee: null
|
assignee: null
|
||||||
queued_by: 'workspace-panel'
|
queued_by: 'workspace-panel'
|
||||||
queued_at: '2026-06-10T11:16:43Z'
|
queued_at: '2026-06-10T11:16:43Z'
|
||||||
|
|
|
||||||
31
.yoi/tickets/00001KTRG8N9J/resolution.md
Normal file
31
.yoi/tickets/00001KTRG8N9J/resolution.md
Normal file
|
|
@ -0,0 +1,31 @@
|
||||||
|
完了しました。
|
||||||
|
|
||||||
|
実施内容:
|
||||||
|
- `builtin:companion` / `builtin:intake` / `builtin:orchestrator` / `builtin:coder` / `builtin:reviewer` を builtin Profile として追加しました。
|
||||||
|
- role Profile は `resources/profiles/*.lua` に移動し、global `yoi` style の standalone `yoi.profile { ... }` artifact として登録しました。
|
||||||
|
- `builtin:default` 由来の model ref / web secret / workspace write scope が role contract に混入しないよう、role Profiles は `builtin:default` を extend しない形にしました。
|
||||||
|
- `companion` / `intake` / `orchestrator` / `reviewer` は read scope、`coder` のみ write scope、`orchestrator` は reusable delegation intent として `delegation_scope = workspace_write()` を持ちます。
|
||||||
|
- `.yoi/ticket.config.toml` の role selectors を `project:*` から `builtin:*` に移行しました。
|
||||||
|
- project-local role Profile files を削除し、`.yoi/profiles.toml` は workspace default を `builtin:companion` に向けるだけに整理しました。
|
||||||
|
- Ticket config scaffold と client role launch tests を role-specific builtin defaults に合わせて更新しました。
|
||||||
|
- manifest tests に builtin role registry/resolution と role policy boundary の検証を追加しました。
|
||||||
|
|
||||||
|
Merge:
|
||||||
|
- Branch: `builtin-role-profiles`
|
||||||
|
- Implementation commit: `85c06dc6 feat: add builtin role profiles`
|
||||||
|
- Merge commit: `7daecca8 merge: builtin role profiles`
|
||||||
|
|
||||||
|
確認:
|
||||||
|
- Branch-local reviewer `reviewer-builtin-role-profiles` が初回 request_changes 後、修正済み branch を approve。
|
||||||
|
- `cargo fmt --check` passed。
|
||||||
|
- `git diff --check` passed。
|
||||||
|
- `cargo test -p manifest profile --lib` passed。
|
||||||
|
- `cargo test -p ticket config --lib` passed。
|
||||||
|
- `cargo test -p client ticket_role --lib` passed。
|
||||||
|
- `cargo check -p manifest -p ticket` passed。
|
||||||
|
- `target/debug/yoi ticket doctor` passed。
|
||||||
|
- typed `TicketDoctor` は 0 errors / 3 pre-existing diagnostics。
|
||||||
|
- `nix build .#yoi` passed。
|
||||||
|
|
||||||
|
残作業:
|
||||||
|
- なし。将来、role builtin Profile とは別に broad user/project profile import selector が必要になった場合は follow-up Ticket として扱えます。
|
||||||
|
|
@ -300,3 +300,88 @@ Parent/human decision needs:
|
||||||
- Panel launch guidance for this Ticket said to stop at merge-ready dossier without merge/close/final approval. Explicit merge-completion authorization is needed before merging `builtin-role-profiles`, running post-merge validation, closing the Ticket, and cleaning the worktree/branch.
|
- Panel launch guidance for this Ticket said to stop at merge-ready dossier without merge/close/final approval. Explicit merge-completion authorization is needed before merging `builtin-role-profiles`, running post-merge validation, closing the Ticket, and cleaning the worktree/branch.
|
||||||
|
|
||||||
---
|
---
|
||||||
|
|
||||||
|
<!-- event: review author: orchestrator at: 2026-06-11T00:05:00Z status: approve -->
|
||||||
|
|
||||||
|
## Review: approve
|
||||||
|
|
||||||
|
Main-branch review/merge-completion approval.
|
||||||
|
|
||||||
|
Verified before merge:
|
||||||
|
- Merge-ready dossier matched Ticket `00001KTRG8N9J`, branch `builtin-role-profiles`, worktree `.worktree/builtin-role-profiles`, and implementation commit `85c06dc6`.
|
||||||
|
- Branch-local reviewer `reviewer-builtin-role-profiles` approved after blocker fixes.
|
||||||
|
- Main workspace was clean before merge.
|
||||||
|
|
||||||
|
Merged:
|
||||||
|
- `git merge --no-ff builtin-role-profiles -m "merge: builtin role profiles"`
|
||||||
|
- Merge commit: `7daecca8 merge: builtin role profiles`
|
||||||
|
|
||||||
|
Post-merge validation:
|
||||||
|
- `cargo fmt --check` passed.
|
||||||
|
- `git diff --check` passed.
|
||||||
|
- `cargo test -p manifest profile --lib` passed.
|
||||||
|
- `cargo test -p ticket config --lib` passed.
|
||||||
|
- `cargo test -p client ticket_role --lib` passed.
|
||||||
|
- `cargo check -p manifest -p ticket` passed.
|
||||||
|
- `target/debug/yoi ticket doctor` passed.
|
||||||
|
- typed `TicketDoctor` reported 0 errors and 3 pre-existing diagnostics.
|
||||||
|
- `nix build .#yoi` passed.
|
||||||
|
|
||||||
|
Result: approve.
|
||||||
|
|
||||||
|
---
|
||||||
|
|
||||||
|
<!-- event: state_changed author: orchestrator at: 2026-06-11T00:05:00Z from: inprogress to: done reason: merged_and_validated field: state -->
|
||||||
|
|
||||||
|
## State changed
|
||||||
|
|
||||||
|
Merged branch `builtin-role-profiles` with merge commit `7daecca8`; branch-local review approved after fixes and post-merge validation passed (`cargo fmt --check`, `git diff --check`, `cargo test -p manifest profile --lib`, `cargo test -p ticket config --lib`, `cargo test -p client ticket_role --lib`, `cargo check -p manifest -p ticket`, `target/debug/yoi ticket doctor`, `nix build .#yoi`).
|
||||||
|
|
||||||
|
---
|
||||||
|
|
||||||
|
<!-- event: state_changed author: hare at: 2026-06-11T00:05:19Z from: done to: closed reason: closed field: state -->
|
||||||
|
|
||||||
|
## State changed
|
||||||
|
|
||||||
|
Ticket を closed にしました。
|
||||||
|
|
||||||
|
|
||||||
|
---
|
||||||
|
|
||||||
|
<!-- event: close author: hare at: 2026-06-11T00:05:19Z status: closed -->
|
||||||
|
|
||||||
|
## 完了
|
||||||
|
|
||||||
|
完了しました。
|
||||||
|
|
||||||
|
実施内容:
|
||||||
|
- `builtin:companion` / `builtin:intake` / `builtin:orchestrator` / `builtin:coder` / `builtin:reviewer` を builtin Profile として追加しました。
|
||||||
|
- role Profile は `resources/profiles/*.lua` に移動し、global `yoi` style の standalone `yoi.profile { ... }` artifact として登録しました。
|
||||||
|
- `builtin:default` 由来の model ref / web secret / workspace write scope が role contract に混入しないよう、role Profiles は `builtin:default` を extend しない形にしました。
|
||||||
|
- `companion` / `intake` / `orchestrator` / `reviewer` は read scope、`coder` のみ write scope、`orchestrator` は reusable delegation intent として `delegation_scope = workspace_write()` を持ちます。
|
||||||
|
- `.yoi/ticket.config.toml` の role selectors を `project:*` から `builtin:*` に移行しました。
|
||||||
|
- project-local role Profile files を削除し、`.yoi/profiles.toml` は workspace default を `builtin:companion` に向けるだけに整理しました。
|
||||||
|
- Ticket config scaffold と client role launch tests を role-specific builtin defaults に合わせて更新しました。
|
||||||
|
- manifest tests に builtin role registry/resolution と role policy boundary の検証を追加しました。
|
||||||
|
|
||||||
|
Merge:
|
||||||
|
- Branch: `builtin-role-profiles`
|
||||||
|
- Implementation commit: `85c06dc6 feat: add builtin role profiles`
|
||||||
|
- Merge commit: `7daecca8 merge: builtin role profiles`
|
||||||
|
|
||||||
|
確認:
|
||||||
|
- Branch-local reviewer `reviewer-builtin-role-profiles` が初回 request_changes 後、修正済み branch を approve。
|
||||||
|
- `cargo fmt --check` passed。
|
||||||
|
- `git diff --check` passed。
|
||||||
|
- `cargo test -p manifest profile --lib` passed。
|
||||||
|
- `cargo test -p ticket config --lib` passed。
|
||||||
|
- `cargo test -p client ticket_role --lib` passed。
|
||||||
|
- `cargo check -p manifest -p ticket` passed。
|
||||||
|
- `target/debug/yoi ticket doctor` passed。
|
||||||
|
- typed `TicketDoctor` は 0 errors / 3 pre-existing diagnostics。
|
||||||
|
- `nix build .#yoi` passed。
|
||||||
|
|
||||||
|
残作業:
|
||||||
|
- なし。将来、role builtin Profile とは別に broad user/project profile import selector が必要になった場合は follow-up Ticket として扱えます。
|
||||||
|
|
||||||
|
---
|
||||||
|
|
|
||||||
Loading…
Reference in New Issue
Block a user