diff --git a/work-items/open/20260531-054728-remove-insomnia-pod-binary/artifacts/.gitkeep b/work-items/closed/20260531-054728-remove-insomnia-pod-binary/artifacts/.gitkeep similarity index 100% rename from work-items/open/20260531-054728-remove-insomnia-pod-binary/artifacts/.gitkeep rename to work-items/closed/20260531-054728-remove-insomnia-pod-binary/artifacts/.gitkeep diff --git a/work-items/open/20260531-054728-remove-insomnia-pod-binary/item.md b/work-items/closed/20260531-054728-remove-insomnia-pod-binary/item.md similarity index 98% rename from work-items/open/20260531-054728-remove-insomnia-pod-binary/item.md rename to work-items/closed/20260531-054728-remove-insomnia-pod-binary/item.md index bc87eded..4920499e 100644 --- a/work-items/open/20260531-054728-remove-insomnia-pod-binary/item.md +++ b/work-items/closed/20260531-054728-remove-insomnia-pod-binary/item.md @@ -2,12 +2,12 @@ id: 20260531-054728-remove-insomnia-pod-binary slug: remove-insomnia-pod-binary title: CLI: remove insomnia-pod installed/runtime alias -status: open +status: closed kind: task priority: P2 labels: [cli, pod, nix, docs] created_at: 2026-05-31T05:47:28Z -updated_at: 2026-05-31T06:08:34Z +updated_at: 2026-05-31T06:10:39Z assignee: null legacy_ticket: null --- diff --git a/work-items/closed/20260531-054728-remove-insomnia-pod-binary/resolution.md b/work-items/closed/20260531-054728-remove-insomnia-pod-binary/resolution.md new file mode 100644 index 00000000..aa93a1ea --- /dev/null +++ b/work-items/closed/20260531-054728-remove-insomnia-pod-binary/resolution.md @@ -0,0 +1,26 @@ +Removed the old `insomnia-pod` installed/runtime alias and completed the next single-binary CLI phase. + +Implementation: +- Removed the `insomnia-pod` binary target from the `pod` crate and made it library-only with `autobins = false`. +- Deleted the old `crates/pod/src/main.rs` wrapper while keeping `pod::entrypoint` for `insomnia pod ...`. +- Updated runtime command resolution to default to the current `insomnia` executable plus the `pod` prefix argument, while preserving executable-only `INSOMNIA_POD_COMMAND` override behavior. +- Updated Nix packaging so `.#insomnia` installs `bin/insomnia` and asserts that `bin/insomnia-pod` is absent. +- Removed `apps.insomnia-pod` from `flake.nix` and removed the devshell `insomnia-pod` wrapper. +- Updated current docs to use `insomnia pod ...` instead of the old user-facing `insomnia-pod ...` command. + +Review: +- External reviewer `remove-insomnia-pod-reviewer-20260531` approved implementation commit `0d7d3c7bf1e1becb85ca8322e4b72730a91e3513`. +- Review was recorded in `thread.md` before merge. + +Validation on develop after merge: +- `cargo fmt --check` +- `cargo test -p tui parse_pod_subcommand_uses_runtime_mode` +- `cargo test -p pod-command` +- `cargo test -p pod --lib discovery::tests` +- `cargo test -p pod --test spawn_pod_test` +- `cargo check -p tui -p pod -p client` +- `nix build .#insomnia` +- `./result/bin/insomnia pod --help` +- `test ! -e ./result/bin/insomnia-pod` +- `./tickets.sh doctor` +- `git diff --check` diff --git a/work-items/open/20260531-054728-remove-insomnia-pod-binary/thread.md b/work-items/closed/20260531-054728-remove-insomnia-pod-binary/thread.md similarity index 66% rename from work-items/open/20260531-054728-remove-insomnia-pod-binary/thread.md rename to work-items/closed/20260531-054728-remove-insomnia-pod-binary/thread.md index 5c2f0d99..2f0ca010 100644 --- a/work-items/open/20260531-054728-remove-insomnia-pod-binary/thread.md +++ b/work-items/closed/20260531-054728-remove-insomnia-pod-binary/thread.md @@ -50,4 +50,38 @@ Validation adequacy: - Reviewer performed read-only static review, clean status/diff inspection, residual `insomnia-pod` search, and `git diff --check`. +--- + + + +## Closed + +Removed the old `insomnia-pod` installed/runtime alias and completed the next single-binary CLI phase. + +Implementation: +- Removed the `insomnia-pod` binary target from the `pod` crate and made it library-only with `autobins = false`. +- Deleted the old `crates/pod/src/main.rs` wrapper while keeping `pod::entrypoint` for `insomnia pod ...`. +- Updated runtime command resolution to default to the current `insomnia` executable plus the `pod` prefix argument, while preserving executable-only `INSOMNIA_POD_COMMAND` override behavior. +- Updated Nix packaging so `.#insomnia` installs `bin/insomnia` and asserts that `bin/insomnia-pod` is absent. +- Removed `apps.insomnia-pod` from `flake.nix` and removed the devshell `insomnia-pod` wrapper. +- Updated current docs to use `insomnia pod ...` instead of the old user-facing `insomnia-pod ...` command. + +Review: +- External reviewer `remove-insomnia-pod-reviewer-20260531` approved implementation commit `0d7d3c7bf1e1becb85ca8322e4b72730a91e3513`. +- Review was recorded in `thread.md` before merge. + +Validation on develop after merge: +- `cargo fmt --check` +- `cargo test -p tui parse_pod_subcommand_uses_runtime_mode` +- `cargo test -p pod-command` +- `cargo test -p pod --lib discovery::tests` +- `cargo test -p pod --test spawn_pod_test` +- `cargo check -p tui -p pod -p client` +- `nix build .#insomnia` +- `./result/bin/insomnia pod --help` +- `test ! -e ./result/bin/insomnia-pod` +- `./tickets.sh doctor` +- `git diff --check` + + ---