From bc48094dde08f5a1b20a060623b7a4c786d81ee2 Mon Sep 17 00:00:00 2001 From: Hare Date: Thu, 16 Jul 2026 06:32:07 +0900 Subject: [PATCH] fix: update workflow-free tui tests --- .yoi/tickets/00001KXKJGYGD/item.md | 2 +- .yoi/tickets/00001KXKJGYGD/thread.md | 23 +++++++++++++++++++++++ crates/tui/src/app.rs | 7 +++---- crates/tui/src/dashboard/tests.rs | 10 +--------- 4 files changed, 28 insertions(+), 14 deletions(-) diff --git a/.yoi/tickets/00001KXKJGYGD/item.md b/.yoi/tickets/00001KXKJGYGD/item.md index 5aa1b310..cffaf65b 100644 --- a/.yoi/tickets/00001KXKJGYGD/item.md +++ b/.yoi/tickets/00001KXKJGYGD/item.md @@ -2,7 +2,7 @@ title: 'Remove workflow tracking and workflow resources' state: 'inprogress' created_at: '2026-07-15T19:02:13Z' -updated_at: '2026-07-15T21:22:40Z' +updated_at: '2026-07-15T21:32:07Z' assignee: null queued_by: 'workspace-panel' queued_at: '2026-07-15T19:54:36Z' diff --git a/.yoi/tickets/00001KXKJGYGD/thread.md b/.yoi/tickets/00001KXKJGYGD/thread.md index 58c39947..239e8c60 100644 --- a/.yoi/tickets/00001KXKJGYGD/thread.md +++ b/.yoi/tickets/00001KXKJGYGD/thread.md @@ -209,4 +209,27 @@ Validation: - nix build .#yoi --no-link -> exit 0 +--- + + + +## Implementation report + +Follow-up fix for focused TUI re-review blocker. + +Summary: +- Updated `live_system_snapshot_replaces_task_store` so the task-store snapshot fixture is carried by active `task_reminder` SystemItem text instead of a legacy `kind: "workflow"` item. +- Legacy workflow SystemItems remain ignored/drop-diagnostic only; no workflow active behavior was re-enabled. +- While running the requested full TUI suite, updated stale dashboard routing-message test assertions to match the already workflow-free queue guidance. + +Validation: +- cargo test -p tui --lib live_system_snapshot_replaces_task_store -- --nocapture -> exit 0 +- cargo test -p tui --lib live_legacy_workflow_system_item_is_ignored -- --nocapture -> exit 0 +- git diff --check -> exit 0 +- cargo test -p tui --lib --tests -> exit 0 +- cargo check -p yoi -> exit 0 +- yoi ticket doctor -> exit 0 +- nix build .#yoi --no-link -> exit 0 + + --- diff --git a/crates/tui/src/app.rs b/crates/tui/src/app.rs index 1f968a0a..c46c42ac 100644 --- a/crates/tui/src/app.rs +++ b/crates/tui/src/app.rs @@ -3584,12 +3584,11 @@ mod completion_flow_tests { ```json\n{\n \"tasks\": [\n {\n \"taskid\": 4,\n \ \"status\": \"inprogress\",\n \"subject\": \"from snapshot\",\n \ \"description\": \"d\"\n }\n ]\n}\n```\n"; - // Snapshot text injected as a workflow body (kind doesn't matter - // for task-store parsing, only the text contents do). + // Snapshot text injected through an active system item kind; legacy + // workflow items are intentionally ignored and must not carry active state. app.handle_worker_event(Event::SystemItem { item: serde_json::json!({ - "kind": "workflow", - "slug": "task-snapshot", + "kind": "task_reminder", "body": snapshot, }), }); diff --git a/crates/tui/src/dashboard/tests.rs b/crates/tui/src/dashboard/tests.rs index 0282e835..9d7a2327 100644 --- a/crates/tui/src/dashboard/tests.rs +++ b/crates/tui/src/dashboard/tests.rs @@ -826,17 +826,9 @@ fn ticket_queue_notification_message_carries_routing_contract() { assert!(message.contains("before any worktree/SpawnWorker implementation side effects")); assert!(message.contains("After inprogress acceptance")); assert!(message.contains("implementation worktree")); - assert!(message.contains("`.worktree/`")); assert!(message.contains("tracked `.yoi` project records visible")); - assert!( - message.contains( - "`.yoi/memory` plus local/runtime/log/lock/secret-like `.yoi` paths excluded" - ) - ); + assert!(message.contains("generated/local/runtime/log/lock/secret-like `.yoi` paths excluded")); assert!(message.contains("sibling coder/reviewer Workers")); - assert!(message.contains("sibling coder/reviewer Workers")); - assert!(message.contains("coder narrow child-worktree write scope")); - assert!(message.contains("reviewer read-only by default")); assert!(message.contains( "integrate the implementation branch into the orchestration branch automatically" ));