ticket: close panel composer keys
This commit is contained in:
parent
57ed405890
commit
bebb0bd5da
|
|
@ -1,8 +1,8 @@
|
||||||
---
|
---
|
||||||
title: 'Improve workspace panel display and composer key handling'
|
title: 'Improve workspace panel display and composer key handling'
|
||||||
state: 'inprogress'
|
state: 'closed'
|
||||||
created_at: '2026-06-09T08:47:25Z'
|
created_at: '2026-06-09T08:47:25Z'
|
||||||
updated_at: '2026-06-09T11:25:57Z'
|
updated_at: '2026-06-09T11:28:33Z'
|
||||||
assignee: null
|
assignee: null
|
||||||
readiness: 'implementation_ready'
|
readiness: 'implementation_ready'
|
||||||
risk_flags: ['tui-input', 'ux-consistency']
|
risk_flags: ['tui-input', 'ux-consistency']
|
||||||
|
|
|
||||||
30
.yoi/tickets/20260609-084725-001/resolution.md
Normal file
30
.yoi/tickets/20260609-084725-001/resolution.md
Normal file
|
|
@ -0,0 +1,30 @@
|
||||||
|
Implemented, reviewed, merged, and validated.
|
||||||
|
|
||||||
|
Summary:
|
||||||
|
- Clarified Panel focus and composer key handling.
|
||||||
|
- Moved Panel target switching from `Ctrl+T` to `Tab`; `Ctrl+T` no longer switches Panel targets or appears in Panel help/actionbar as target switch.
|
||||||
|
- Added shared `composer_keys` handling used by normal TUI and workspace panel composer editing.
|
||||||
|
- Preserved bare-letter typing behavior; letters such as `j/k/o/r` enter composer text rather than acting as shortcuts.
|
||||||
|
- Made focus/Enter behavior clearer for global composer, selected row, and item action states.
|
||||||
|
- Fixed selected Ticket row + non-empty global composer ambiguity: actionbar/status now describes composer-target Enter behavior rather than row action.
|
||||||
|
- Added regression tests and updated Panel canonical-ID display tests.
|
||||||
|
|
||||||
|
Implementation:
|
||||||
|
- Coder commits: `20f06b3 tui: clarify panel focus and composer keys`, `573b02f tui: clarify panel composer enter hints`
|
||||||
|
- Reviewer approved after fix loop.
|
||||||
|
- Merge commit: `57ed405 merge: improve panel composer keys`
|
||||||
|
|
||||||
|
Validation after merge:
|
||||||
|
- `cargo test -p tui selected_ticket_row_with_non_empty_composer_shows_composer_enter_behavior`
|
||||||
|
- `cargo test -p tui multi_ctrl_t_does_not_switch_composer_target`
|
||||||
|
- `cargo test -p tui multi_bare_panel_letters_append_to_composer_and_arrows_select_when_blank`
|
||||||
|
- `cargo test -p tui multi_esc_clears_panel_focus_without_quitting`
|
||||||
|
- `cargo test -p tui ticket_queue_notification_message_carries_routing_contract`
|
||||||
|
- `cargo test -p tui panel_ticket_rows_use_aligned_columns_before_title`
|
||||||
|
- `cargo test -p tui panel_ticket_title_truncates_after_stable_columns`
|
||||||
|
- `cargo test -p tui` (291 passed)
|
||||||
|
- `cargo fmt --check`
|
||||||
|
- `git diff --check`
|
||||||
|
- `cargo run -q -p yoi -- ticket doctor`
|
||||||
|
- `cargo check --workspace`
|
||||||
|
- `nix build .#yoi`
|
||||||
|
|
@ -544,4 +544,51 @@ Reviewer validation:
|
||||||
|
|
||||||
Residual risk: no blocking risk. Panel has no active completion popup/source yet, so Tab completion priority remains verified at the caller-boundary design level rather than by an active completion UI scenario.
|
Residual risk: no blocking risk. Panel has no active completion popup/source yet, so Tab completion priority remains verified at the caller-boundary design level rather than by an active completion UI scenario.
|
||||||
|
|
||||||
|
---
|
||||||
|
|
||||||
|
<!-- event: state_changed author: hare at: 2026-06-09T11:28:33Z from: inprogress to: closed reason: closed field: state -->
|
||||||
|
|
||||||
|
## State changed
|
||||||
|
|
||||||
|
Ticket を closed にしました。
|
||||||
|
|
||||||
|
|
||||||
|
---
|
||||||
|
|
||||||
|
<!-- event: close author: hare at: 2026-06-09T11:28:33Z status: closed -->
|
||||||
|
|
||||||
|
## 完了
|
||||||
|
|
||||||
|
Implemented, reviewed, merged, and validated.
|
||||||
|
|
||||||
|
Summary:
|
||||||
|
- Clarified Panel focus and composer key handling.
|
||||||
|
- Moved Panel target switching from `Ctrl+T` to `Tab`; `Ctrl+T` no longer switches Panel targets or appears in Panel help/actionbar as target switch.
|
||||||
|
- Added shared `composer_keys` handling used by normal TUI and workspace panel composer editing.
|
||||||
|
- Preserved bare-letter typing behavior; letters such as `j/k/o/r` enter composer text rather than acting as shortcuts.
|
||||||
|
- Made focus/Enter behavior clearer for global composer, selected row, and item action states.
|
||||||
|
- Fixed selected Ticket row + non-empty global composer ambiguity: actionbar/status now describes composer-target Enter behavior rather than row action.
|
||||||
|
- Added regression tests and updated Panel canonical-ID display tests.
|
||||||
|
|
||||||
|
Implementation:
|
||||||
|
- Coder commits: `20f06b3 tui: clarify panel focus and composer keys`, `573b02f tui: clarify panel composer enter hints`
|
||||||
|
- Reviewer approved after fix loop.
|
||||||
|
- Merge commit: `57ed405 merge: improve panel composer keys`
|
||||||
|
|
||||||
|
Validation after merge:
|
||||||
|
- `cargo test -p tui selected_ticket_row_with_non_empty_composer_shows_composer_enter_behavior`
|
||||||
|
- `cargo test -p tui multi_ctrl_t_does_not_switch_composer_target`
|
||||||
|
- `cargo test -p tui multi_bare_panel_letters_append_to_composer_and_arrows_select_when_blank`
|
||||||
|
- `cargo test -p tui multi_esc_clears_panel_focus_without_quitting`
|
||||||
|
- `cargo test -p tui ticket_queue_notification_message_carries_routing_contract`
|
||||||
|
- `cargo test -p tui panel_ticket_rows_use_aligned_columns_before_title`
|
||||||
|
- `cargo test -p tui panel_ticket_title_truncates_after_stable_columns`
|
||||||
|
- `cargo test -p tui` (291 passed)
|
||||||
|
- `cargo fmt --check`
|
||||||
|
- `git diff --check`
|
||||||
|
- `cargo run -q -p yoi -- ticket doctor`
|
||||||
|
- `cargo check --workspace`
|
||||||
|
- `nix build .#yoi`
|
||||||
|
|
||||||
|
|
||||||
---
|
---
|
||||||
|
|
|
||||||
Loading…
Reference in New Issue
Block a user