diff --git a/.yoi/tickets/00001KWHEM8YJ/item.md b/.yoi/tickets/00001KWHEM8YJ/item.md index 1858d7dc..e5942628 100644 --- a/.yoi/tickets/00001KWHEM8YJ/item.md +++ b/.yoi/tickets/00001KWHEM8YJ/item.md @@ -2,7 +2,7 @@ title: 'Workspace Browserから手動Coding Workerを作成する導線を追加する' state: 'inprogress' created_at: '2026-07-02T12:59:57Z' -updated_at: '2026-07-02T18:11:11Z' +updated_at: '2026-07-02T18:20:10Z' assignee: null queued_by: 'workspace-panel' queued_at: '2026-07-02T16:13:24Z' diff --git a/.yoi/tickets/00001KWHEM8YJ/thread.md b/.yoi/tickets/00001KWHEM8YJ/thread.md index 6093c1bf..d999c7df 100644 --- a/.yoi/tickets/00001KWHEM8YJ/thread.md +++ b/.yoi/tickets/00001KWHEM8YJ/thread.md @@ -260,3 +260,33 @@ Review-fix implementation report: - Requesting follow-up external review against `f2fead7e..47ed0ff8` and full combined implementation. --- + + + +## Review: approve + +External follow-up review result: approve + +Read-only follow-up review completed for both Tickets and fix commit `47ed0ff8` on top of `f2fead7e`. + +Evidence reviewed: +- Ticket records for `00001KWHHRTM9` and `00001KWHEM8YJ`. +- Fix diff `f2fead7e..47ed0ff8`. +- Relevant backend/web files including `crates/workspace-server/src/server.rs`, `config.rs`, `hosts.rs`, `worker-launch.ts`, `WorkersNavSection.svelte`, related tests/settings model files. +- Orchestrator-reported validation pass for `git diff --check`, `cargo test -p yoi-workspace-server`, `cargo check -p yoi`, `cd web/workspace && deno task test`, and `cd web/workspace && deno task check`. + +Reviewer findings: +- Previous blocker 1 resolved: runtime connection test now performs lightweight negotiation/probing for Browser-relevant operations and represents unsupported/not-observed operations with typed diagnostics and `unknown`/`unsupported` capability entries instead of blanket compatibility. +- Previous blocker 2 resolved: Browser-facing remote-test diagnostics omit raw endpoints/config paths/socket/session/store paths and use typed/sanitized diagnostics; tests assert projected responses do not contain the endpoint/runtime address. +- Previous blocker 3 resolved: `/api/workers` keeps product-level request shape and preserves runtime rejection diagnostics while adding typed `workspace_worker_create_not_accepted` diagnostic. +- Previous blocker 4 resolved: focused backend tests cover runtime connection test sanitization/compatibility, worker creation payload rejection, diagnostic preservation; web tests cover launch payload shaping/error handling. +- Persisted config, live registry summaries, and test observations remain separated. +- Browser-facing settings responses expose safe summaries rather than raw authority-bearing backend fields. +- New Worker UI consumes `/api/workers/options` candidates and submits only product-level `/api/workers` payload. + +Non-blocking follow-up: +- UI could later render backend diagnostic codes/details more richly on Worker launch failure, but current behavior is sanitized and merge-ready. + +No merge-blocking issues found. + +--- diff --git a/.yoi/tickets/00001KWHHRTM9/item.md b/.yoi/tickets/00001KWHHRTM9/item.md index 89584199..f6135e21 100644 --- a/.yoi/tickets/00001KWHHRTM9/item.md +++ b/.yoi/tickets/00001KWHHRTM9/item.md @@ -2,7 +2,7 @@ title: 'Workspace Backend Runtime接続の管理画面と永続configを追加する' state: 'inprogress' created_at: '2026-07-02T13:54:52Z' -updated_at: '2026-07-02T18:11:11Z' +updated_at: '2026-07-02T18:20:10Z' assignee: null queued_by: 'workspace-panel' queued_at: '2026-07-02T16:45:19Z' diff --git a/.yoi/tickets/00001KWHHRTM9/thread.md b/.yoi/tickets/00001KWHHRTM9/thread.md index 63f8514f..734af44f 100644 --- a/.yoi/tickets/00001KWHHRTM9/thread.md +++ b/.yoi/tickets/00001KWHHRTM9/thread.md @@ -280,3 +280,33 @@ Review-fix implementation report: - Requesting follow-up external review against `f2fead7e..47ed0ff8` and full combined implementation. --- + + + +## Review: approve + +External follow-up review result: approve + +Read-only follow-up review completed for both Tickets and fix commit `47ed0ff8` on top of `f2fead7e`. + +Evidence reviewed: +- Ticket records for `00001KWHHRTM9` and `00001KWHEM8YJ`. +- Fix diff `f2fead7e..47ed0ff8`. +- Relevant backend/web files including `crates/workspace-server/src/server.rs`, `config.rs`, `hosts.rs`, `worker-launch.ts`, `WorkersNavSection.svelte`, related tests/settings model files. +- Orchestrator-reported validation pass for `git diff --check`, `cargo test -p yoi-workspace-server`, `cargo check -p yoi`, `cd web/workspace && deno task test`, and `cd web/workspace && deno task check`. + +Reviewer findings: +- Previous blocker 1 resolved: runtime connection test now performs lightweight negotiation/probing for Browser-relevant operations and represents unsupported/not-observed operations with typed diagnostics and `unknown`/`unsupported` capability entries instead of blanket compatibility. +- Previous blocker 2 resolved: Browser-facing remote-test diagnostics omit raw endpoints/config paths/socket/session/store paths and use typed/sanitized diagnostics; tests assert projected responses do not contain the endpoint/runtime address. +- Previous blocker 3 resolved: `/api/workers` keeps product-level request shape and preserves runtime rejection diagnostics while adding typed `workspace_worker_create_not_accepted` diagnostic. +- Previous blocker 4 resolved: focused backend tests cover runtime connection test sanitization/compatibility, worker creation payload rejection, diagnostic preservation; web tests cover launch payload shaping/error handling. +- Persisted config, live registry summaries, and test observations remain separated. +- Browser-facing settings responses expose safe summaries rather than raw authority-bearing backend fields. +- New Worker UI consumes `/api/workers/options` candidates and submits only product-level `/api/workers` payload. + +Non-blocking follow-up: +- UI could later render backend diagnostic codes/details more richly on Worker launch failure, but current behavior is sanitized and merge-ready. + +No merge-blocking issues found. + +---