From c5a9f8a0ab5d6774a70fdb5f2ccf9fabd5e0f078 Mon Sep 17 00:00:00 2001 From: Hare Date: Thu, 9 Jul 2026 17:52:24 +0900 Subject: [PATCH] ticket: record profile source tree review fixes --- .yoi/tickets/00001KX1JNJ2Y/item.md | 2 +- .yoi/tickets/00001KX1JNJ2Y/thread.md | 29 ++++++++++++++++++++++++++++ 2 files changed, 30 insertions(+), 1 deletion(-) diff --git a/.yoi/tickets/00001KX1JNJ2Y/item.md b/.yoi/tickets/00001KX1JNJ2Y/item.md index 56eaeac3..5605b9b2 100644 --- a/.yoi/tickets/00001KX1JNJ2Y/item.md +++ b/.yoi/tickets/00001KX1JNJ2Y/item.md @@ -2,7 +2,7 @@ title: 'Add ProfileSourceTree virtual filesystem and Decodal profile editor' state: 'inprogress' created_at: '2026-07-08T19:18:25Z' -updated_at: '2026-07-09T08:32:35Z' +updated_at: '2026-07-09T08:52:14Z' assignee: null queued_by: 'workspace-panel' queued_at: '2026-07-09T07:56:07Z' diff --git a/.yoi/tickets/00001KX1JNJ2Y/thread.md b/.yoi/tickets/00001KX1JNJ2Y/thread.md index a7d6a28f..7935c581 100644 --- a/.yoi/tickets/00001KX1JNJ2Y/thread.md +++ b/.yoi/tickets/00001KX1JNJ2Y/thread.md @@ -220,3 +220,32 @@ Non-blocking follow-ups: - After blockers are fixed, add focused regression coverage for selected-root closure behavior, tree route smoke, Decodal editor extension wiring, UI create/delete flows, and symlinked-directory tree-write rejection-before-side-effect。 --- + + + +## Implementation report + +Review-fix implementation report: + +- Coder Pod completed requested changes and committed follow-up `941b9126 fix: complete profile source tree review fixes` on branch `work/00001KX1JNJ2Y-profile-source-tree`. +- Worktree status was clean after commit。 +- Fix summary: + - Added `decodal-codemirror@0.1.2` and wired `decodal()` into the CodeMirror 6 editor。 + - Added source tree settings route `/w//settings/profiles/trees/`。 + - Wired UI create/save/delete operations through Backend virtual-path source tree APIs。 + - Changed archive construction to selected selector/root + import closure only, avoiding unrelated project tree sources。 + - Added safe typed source/tree metadata including content type, content digest, and typed provenance。 + - Hardened tree writes against symlinked intermediate directories before any outside filesystem mutation。 + - Added focused regression coverage for selected-root closure-only archive contents, symlink write rejection before side effects, and web model smoke tests for tree routes / virtual create paths。 +- Orchestrator reran validation in the implementation worktree: + - `git diff --check`: pass + - `cargo test -p yoi-workspace-server`: pass（93 lib tests + 2 main tests） + - `cargo test -p worker-runtime --features ws-server,fs-store`: pass（47 lib tests + 5 main tests + doc tests） + - `cargo check -p yoi`: pass + - `cd web/workspace && deno task check`: pass（0 errors / 0 warnings） + - `cd web/workspace && deno task test`: pass（19 tests） + - `yoi ticket doctor`: ok + - `nix build .#yoi --no-link`: pass +- Requesting follow-up external review against `81abfa63..941b9126` and full combined implementation。 + +---