From ca10a130a73f14ff48aa138d45c14606d4181f61 Mon Sep 17 00:00:00 2001 From: Hare Date: Thu, 16 Jul 2026 07:31:24 +0900 Subject: [PATCH] ticket: record knowledge removal implementation --- .yoi/tickets/00001KXKP2A71/item.md | 2 +- .yoi/tickets/00001KXKP2A71/thread.md | 45 ++++++++++++++++++++++++++++ 2 files changed, 46 insertions(+), 1 deletion(-) diff --git a/.yoi/tickets/00001KXKP2A71/item.md b/.yoi/tickets/00001KXKP2A71/item.md index 6e2d6688..889c6294 100644 --- a/.yoi/tickets/00001KXKP2A71/item.md +++ b/.yoi/tickets/00001KXKP2A71/item.md @@ -2,7 +2,7 @@ title: 'Remove Knowledge support' state: 'inprogress' created_at: '2026-07-15T20:04:08Z' -updated_at: '2026-07-15T21:40:26Z' +updated_at: '2026-07-15T22:31:18Z' assignee: null queued_by: 'workspace-panel' queued_at: '2026-07-15T20:27:02Z' diff --git a/.yoi/tickets/00001KXKP2A71/thread.md b/.yoi/tickets/00001KXKP2A71/thread.md index e3b454aa..b3981082 100644 --- a/.yoi/tickets/00001KXKP2A71/thread.md +++ b/.yoi/tickets/00001KXKP2A71/thread.md @@ -161,3 +161,48 @@ Critical risks / reviewer focus: Workflow removal dependency/conflict is now closed and no blockers remain. Accepting queued Knowledge removal Ticket for implementation before creating worktree or spawning role Pods. --- + + + +## Implementation report + +Implementation progress report: + +- Coder Pod `yoi-coder-00001KXKP2A71-knowledge-removal` completed implementation in `/home/hare/Projects/yoi/.worktree/00001KXKP2A71-remove-knowledge-support` on branch `work/00001KXKP2A71-remove-knowledge-support`。 +- Implementation commit: `f786e019 feat: remove active knowledge support`。 +- Orchestrator inspected worktree status, branch log, commit stats, and `git diff --check f2106407..HEAD`; worktree was clean and diff check passed。 + +Implementation summary: +- Removed active `KnowledgeQuery` registration/schema exposure。 +- Removed `kind = knowledge` from Memory tool kind support and tool descriptions。 +- Removed active Knowledge frontmatter/schema/lint/query/resident-context handling from the Memory crate。 +- Removed Worker resident Knowledge injection and Knowledge completion state。 +- Removed protocol/TUI/web active `#` / Knowledge reference and completion paths。 +- Kept bounded persisted-session compatibility: old session `SystemItem` entries serialized as `knowledge` deserialize into `LegacyKnowledgeIgnored` and do not replay archived Knowledge text into model context。 +- Updated prompts/docs to describe Memory summary/decision/request behavior and note old `.yoi/knowledge/` as ignored/manual archive material。 +- Did not implement Agent Skills support。 + +Old `.yoi/knowledge` handling: +- `.yoi/knowledge/` is no longer classified, linted, queried, consolidated, extracted, resident-injected, or treated as workspace record authority。 +- Docs say older `.yoi/knowledge/` files are ignored by current memory tooling and can be manually archived/inspected if needed。 +- Persisted session Knowledge system items are ignored on restore rather than injected into model context。 + +Coder-reported validation passed: +- `rg "KnowledgeQuery|kind = knowledge|kind: knowledge|ResidentKnowledge|model_invokation|\\.yoi/knowledge|#" --glob '!target' --glob '!Cargo.lock'`: only remaining hit is historical ignored `.yoi/knowledge/` note in `docs/design/memory-knowledge.md`。 +- `rg "knowledge" crates resources docs README.md web --glob '!target' --glob '!Cargo.lock'`: remaining intended hits are historical/ignored `.yoi/knowledge/` docs, compatibility-only `LegacyKnowledgeIgnored`, doc filenames containing `memory-knowledge`, and unrelated `acknowledge` substrings。 +- `git diff --check` +- `cargo test -p memory --lib --tests` +- `cargo test -p worker --lib --tests` +- `cargo test -p session-store --lib --tests` +- `cargo test -p tui --lib --tests` +- `cargo test -p yoi --tests` +- `cd web/workspace && deno task check` (passed with pre-existing/accessibility warnings only) +- `cd web/workspace && deno task test` (`52 passed`) +- `cargo check -p yoi` +- `yoi ticket doctor` +- `nix build .#yoi --no-link` + +Next action: +- Route to external Reviewer Pod before merge/close decisions。 + +---