Hare/yoi
1
1
Fork 0
Code Actions Packages Releases Activity

ticket: record podclient reader review delegation

Browse Source
This commit is contained in:
Keisuke Hirata 2026-06-08 11:50:49 +09:00
parent a6c3ef1a79
commit ca9b5c69c0
No known key found for this signature in database
2 changed files with 43 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
.yoi/tickets/open/20260608-015630-abort-podclient-reader-task-on-drop/item.md
View File

@ -8,7 +8,7 @@ priority: 'P1'
labels: ['client', 'pod', 'tui', 'fd-leak', 'bug'] labels: ['client', 'pod', 'tui', 'fd-leak', 'bug']
workflow_state: 'inprogress' workflow_state: 'inprogress'
created_at: '2026-06-08T01:56:30Z' created_at: '2026-06-08T01:56:30Z'
updated_at: '2026-06-08T02:42:29Z' updated_at: '2026-06-08T02:50:42Z'
assignee: null assignee: null
legacy_ticket: null legacy_ticket: null
queued_by: 'workspace-panel' queued_by: 'workspace-panel'

42
.yoi/tickets/open/20260608-015630-abort-podclient-reader-task-on-drop/thread.md
View File

@ -138,3 +138,45 @@ Stop/completion policy:
- Because the human authorized cleanup after completion, this Orchestrator will proceed through reviewer approval, merge-completion validation, Ticket close, Pod stop, worktree removal, and branch deletion if the branch is approved and merge authority remains clear. - Because the human authorized cleanup after completion, this Orchestrator will proceed through reviewer approval, merge-completion validation, Ticket close, Pod stop, worktree removal, and branch deletion if the branch is approved and merge authority remains clear.
--- ---
<!-- event: implementation_report author: orchestrator at: 2026-06-08T02:50:42Z -->
## Implementation report
Coder completed and reviewer delegated.
Coder result:
- Pod: `coder-abort-podclient-reader`
- Commit: `aec75b3 fix: abort PodClient reader task on drop`
- Worktree status: clean after commit.
- Diff against `develop`: 1 file changed, 143 insertions, 2 deletions.
Files touched by coder:
- `crates/client/src/pod_client.rs`
Coder reported implementation:
- Added owned `reader_task: JoinHandle<()>` field to `PodClient`.
- Stored the background reader task created by `PodClient::connect()`.
- Implemented `Drop` for `PodClient` to abort the reader task.
- Preserved send and receive behavior while `PodClient` is alive.
- Added focused tests for receiving while alive, sending while alive, repeated connect/drop connection cleanup, and aborting a blocked reader so the Unix socket read half is released.
Coder reported validation:
- `cargo test -p client pod_client --lib`
- `cargo test -p client --lib`
- `cargo test -p tui pod_list --lib`
- `cargo fmt --check`
- `git diff --check`
- `cargo run -q -p yoi -- ticket doctor`
- `nix build .#yoi`
Reviewer delegation:
- Spawned sibling reviewer Pod: `reviewer-abort-podclient-reader`.
- Reviewer scope: read-only child worktree plus non-recursive parent-root read required by launch cwd validation.
- Reviewer was instructed to judge against the recorded Ticket requirements and binding decisions.
Pending:
- Await reviewer verdict before merge-ready dossier / merge-completion.
- No merge, close, final approval, or cleanup has occurred for this Ticket.
---