From cf7515fb35b4c5ed4e62189c5f2206ff3154c63a Mon Sep 17 00:00:00 2001 From: Hare Date: Sun, 6 Sep 2026 01:20:39 +0900 Subject: [PATCH] fix: keep tool overview neutral on failures --- web/workspace/src/lib/workspace/console/model.test.ts | 4 ++-- web/workspace/src/lib/workspace/console/model.ts | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/web/workspace/src/lib/workspace/console/model.test.ts b/web/workspace/src/lib/workspace/console/model.test.ts index e2dfdceb..6700d70c 100644 --- a/web/workspace/src/lib/workspace/console/model.test.ts +++ b/web/workspace/src/lib/workspace/console/model.test.ts @@ -2247,7 +2247,7 @@ Deno.test("overview hides thinking and aggregates uninterrupted tool activity", assertEquals(overview[4].body, "edited +2/-1"); }); -Deno.test("overview hides in-flight thinking and keeps tool failures visible", () => { +Deno.test("overview keeps tool failure counts without marking the activity as an error", () => { const overview = projectOverviewLines([ { ...consoleLine("thinking-in-flight", "in_flight"), @@ -2269,7 +2269,7 @@ Deno.test("overview hides in-flight thinking and keeps tool failures visible", ( assertEquals(overview.length, 1); assertEquals(overview[0].kind, "activity"); assertEquals(overview[0].body, "1 file read\n1 failed"); - assertEquals(overview[0].error, true); + assertEquals(overview[0].error, false); }); Deno.test("RunEnd appends TUI-compatible request and token stats", () => { diff --git a/web/workspace/src/lib/workspace/console/model.ts b/web/workspace/src/lib/workspace/console/model.ts index 4464c89a..7bac8543 100644 --- a/web/workspace/src/lib/workspace/console/model.ts +++ b/web/workspace/src/lib/workspace/console/model.ts @@ -442,7 +442,7 @@ function overviewToolActivityLine(group: ConsoleLine[]): ConsoleLine { body: [primary.join("・"), ...changes].filter(Boolean).join("\n"), source: "event", streaming: active, - error: failedCount > 0, + error: false, }; }