From d6e36a3268a3ec2fe81b42ce90a2ccb4c6369870 Mon Sep 17 00:00:00 2001 From: Hare Date: Mon, 1 Jun 2026 10:24:27 +0900 Subject: [PATCH] review: approve pod orchestration guidance --- .../item.md | 2 +- .../thread.md | 36 +++++++++++++++++++ 2 files changed, 37 insertions(+), 1 deletion(-) diff --git a/work-items/open/20260527-194421-pod-orchestration-system-guidance/item.md b/work-items/open/20260527-194421-pod-orchestration-system-guidance/item.md index 46735c0d..945d32de 100644 --- a/work-items/open/20260527-194421-pod-orchestration-system-guidance/item.md +++ b/work-items/open/20260527-194421-pod-orchestration-system-guidance/item.md @@ -7,7 +7,7 @@ kind: feature priority: P2 labels: [pod, workflow, prompt] created_at: 2026-05-27T19:44:21Z -updated_at: 2026-06-01T01:10:57Z +updated_at: 2026-06-01T01:24:27Z assignee: null legacy_ticket: null --- diff --git a/work-items/open/20260527-194421-pod-orchestration-system-guidance/thread.md b/work-items/open/20260527-194421-pod-orchestration-system-guidance/thread.md index f53b304e..7e60e907 100644 --- a/work-items/open/20260527-194421-pod-orchestration-system-guidance/thread.md +++ b/work-items/open/20260527-194421-pod-orchestration-system-guidance/thread.md @@ -112,4 +112,40 @@ The ticket affects prompt/system guidance and conditional prompt assembly, but t - `cargo fmt --check`. +--- + + + +## Review: approve + +External reviewer recommendation: approve. + +Summary: +- Static Pod orchestration guidance was added under `resources/prompts/common/pod-orchestration.md` and registered through the prompt catalog. +- The guidance is appended to the materialized system prompt only when available tool names include Pod-management capabilities. +- The gate uses registered tool definitions, not Worker kind, matching the ticket boundary. +- The prompt explicitly covers background notifications, natural stopping points, not keeping a turn open solely to wait, no `sleep`/polling loops for Pod output, evidence-before-completion, and no scheduler/authorization bypass. + +Intent / requirement mapping: +- Included when Pod management tools are enabled: satisfied. +- Omitted when Pod management tools are disabled: satisfied. +- Prompt body lives under `resources/prompts`: satisfied. +- Conditional prompt assembly tests exist: satisfied. + +Invariant check: +- No changes to PodEvent/notification protocol, TUI notification UI, spawned registry restore, Pod lifecycle behavior, scheduler/auto-maintain behavior, or notification-derived context injection. +- The implementation adds static guidance based on durable tool availability, not transient notification state. + +Blockers: none. + +Non-blocking follow-ups: +- A future small test could pin the intended "any Pod-management tool is enough" semantics with a single representative tool. +- Tool-name class recognition could be centralized later if more prompt gates need it. + +Reported validation from coder was considered sufficient: +- `cargo test -p pod pod_orchestration` +- `cargo test -p pod prompt::catalog` +- `cargo fmt --check` + + ---