From d9b3eb0e8be6eb9a6d6c527638b6270bf595125c Mon Sep 17 00:00:00 2001 From: Hare Date: Sat, 11 Jul 2026 02:22:18 +0900 Subject: [PATCH] ticket: record unmanaged workdir review blocker --- .yoi/tickets/00001KX6BPY7M/item.md | 2 +- .yoi/tickets/00001KX6BPY7M/thread.md | 29 ++++++++++++++++++++++++++++ 2 files changed, 30 insertions(+), 1 deletion(-) diff --git a/.yoi/tickets/00001KX6BPY7M/item.md b/.yoi/tickets/00001KX6BPY7M/item.md index b0f58250..3c2171f1 100644 --- a/.yoi/tickets/00001KX6BPY7M/item.md +++ b/.yoi/tickets/00001KX6BPY7M/item.md @@ -2,7 +2,7 @@ title: 'Add Backend Worker/Workdir registry and link model' state: 'inprogress' created_at: '2026-07-10T15:53:02Z' -updated_at: '2026-07-10T17:14:02Z' +updated_at: '2026-07-10T17:22:14Z' assignee: null queued_by: 'workspace-panel' queued_at: '2026-07-10T16:10:57Z' diff --git a/.yoi/tickets/00001KX6BPY7M/thread.md b/.yoi/tickets/00001KX6BPY7M/thread.md index 3cdd1cbf..47d50b7e 100644 --- a/.yoi/tickets/00001KX6BPY7M/thread.md +++ b/.yoi/tickets/00001KX6BPY7M/thread.md @@ -281,3 +281,32 @@ Next action: - Request focused external re-review against commits `3e5546ea..8695089f` and the whole Ticket acceptance criteria before merge/close decisions。 --- + + + +## Review: request changes + +Focused re-review result: request_changes + +Evidence reviewed: +- Implementation worktree is on `work/00001KX6BPY7M-worker-workdir-registry` at `8695089fba346b8f10d55016b8328337e1c37445`, clean。 +- Follow-up fixes most prior blockers: + - Worker list now syncs Runtime observations, then projects from `worker_registry` / `worker_workdir_links` (`workers_response`, `merge_worker_registry_projection`)。 + - Runtime Worker create now writes pending Backend Workdir rows, records Worker rows, and links selected/materialized Workdirs。 + - Stop path now updates Worker lifecycle and attempts linked Workdir status sync。 + - Store upsert preserves existing `pinned` when a Runtime sync supplies `normal`。 + - New registry records still do not store raw materialized Runtime paths。 + +Blocker: +- Unmanaged Runtime Workdirs are now mixed into normal Backend-managed Browser lists / launch options。 + - Ticket requires Runtime-direct/unmanaged Workdirs to be distinguishable and “not mixed into managed lists” (`item.md:61`)。 + - Follow-up syncs unknown Runtime Workdirs as `runtime_unmanaged`, but `working_directory_summaries()` returns all `workdir_registry` rows via `list_workdir_registry()` (`server.rs:3300-3308`)。 + - This feeds Browser launch options (`server.rs:3278`) and the workspace-scoped Workdirs list。 + - The worker-new UI select iterates `options.working_directories` without filtering or labeling `management_kind`, so a `runtime_unmanaged` Workdir can appear/select like a normal managed Workdir。 + - This is not a safe typed UI distinction and does not satisfy the Backend-managed vs unmanaged boundary。 + +Non-blocking notes: +- Runtime-scoped Workdir lists being typed from registry is a good direction。 +- Consider ensuring detail/cleanup/create responses also project through `workdir_summary_from_record`; several paths still return Runtime summaries with `management_kind: None`, even after storing a typed Backend record。 + +---