Hare/yoi
1
1
Fork 0
Code Actions Packages Releases Activity

ticket: approve panel alt-enter fix

Browse Source
This commit is contained in:
Keisuke Hirata 2026-06-15 15:50:32 +09:00
parent 3001bc6873
commit dba335f74a
No known key found for this signature in database
2 changed files with 36 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
.yoi/tickets/00001KV4ZDMV1/item.md
View File

@ -2,7 +2,7 @@
title: 'Panel composer で Alt+Enter 改行を SessionView と揃える' title: 'Panel composer で Alt+Enter 改行を SessionView と揃える'
state: 'inprogress' state: 'inprogress'
created_at: '2026-06-15T06:27:36Z' created_at: '2026-06-15T06:27:36Z'
updated_at: '2026-06-15T06:46:31Z' updated_at: '2026-06-15T06:50:25Z'
assignee: null assignee: null
readiness: 'implementation_ready' readiness: 'implementation_ready'
risk_flags: ['tui-input', 'ux-consistency'] risk_flags: ['tui-input', 'ux-consistency']

35
.yoi/tickets/00001KV4ZDMV1/thread.md
View File

@ -127,3 +127,38 @@ Repository status:
- Child implementation worktree clean after commit. - Child implementation worktree clean after commit.
--- ---
<!-- event: review author: yoi-reviewer-00001KV4ZDMV1 at: 2026-06-15T06:50:25Z status: approve -->
## Review: approve
Review result: approve
Evidence checked:
- Implementation commit `5c339177` against base `368249d6` in child worktree.
- Diff limited to:
- `crates/tui/src/composer_keys.rs`
- `crates/tui/src/multi_pod.rs`
- Shared composer policy maps `Alt+Enter` to `ComposerEditAction::InsertNewline` through `composer_edit_action`.
- Panel `handle_key` consults `composer_edit_action(key)` before bare `Enter` routing and immediately applies modifier composer actions.
- This prevents `Alt+Enter` from falling through to open / dispatch / Intake launch / Companion send.
- Existing bare `Enter` routing remains structurally unchanged.
- Bare `Enter` remains excluded from shared composer editing.
- Focused Panel tests cover text composer, blank Pod row selection, and blank Ticket action selection.
- Existing bare-Enter regression tests remain present.
Validation performed by reviewer:
- Passed: `git diff --check 368249d6..5c339177`
- Passed: `cargo fmt --check`
- Worktree remained clean.
Validation not run by reviewer:
- Cargo tests were not rerun because review scope was read-only and tests write build artifacts. Coder-reported focused test results were reviewed as evidence.
Broader-suite failure assessment:
- The reported broader `cargo test -p tui multi_pod --lib` failure in an orchestration-root test appears unrelated based on diff scope. The implementation does not touch orchestration worktree/root logic.
Conclusion:
- Approved. No blocker remains.
---