From ddd2f86e26be5ba7f1868f21d2f5bfc6cd769163 Mon Sep 17 00:00:00 2001 From: Hare Date: Tue, 23 Jun 2026 16:25:39 +0900 Subject: [PATCH] ticket: reroute workspace identity fixes --- .yoi/tickets/00001KVSKGDYS/item.md | 2 +- .yoi/tickets/00001KVSKGDYS/thread.md | 26 ++++++++++++++++++++++++++ 2 files changed, 27 insertions(+), 1 deletion(-) diff --git a/.yoi/tickets/00001KVSKGDYS/item.md b/.yoi/tickets/00001KVSKGDYS/item.md index c0c78605..36665d84 100644 --- a/.yoi/tickets/00001KVSKGDYS/item.md +++ b/.yoi/tickets/00001KVSKGDYS/item.md @@ -2,7 +2,7 @@ title: 'Persist local Workspace identity in .yoi/workspace.toml' state: 'inprogress' created_at: '2026-06-23T06:43:28Z' -updated_at: '2026-06-23T07:24:58Z' +updated_at: '2026-06-23T07:25:27Z' assignee: null queued_by: 'workspace-panel' queued_at: '2026-06-23T06:47:18Z' diff --git a/.yoi/tickets/00001KVSKGDYS/thread.md b/.yoi/tickets/00001KVSKGDYS/thread.md index 2a6a3986..5674ea5b 100644 --- a/.yoi/tickets/00001KVSKGDYS/thread.md +++ b/.yoi/tickets/00001KVSKGDYS/thread.md @@ -279,3 +279,29 @@ Reviewer notes generated ignored artifacts from validation remained in worktree: - `web/workspace/build/` --- + + + +## Comment + +Rerouted request-changes feedback to Coder Pod `yoi-coder-00001KVSKGDYS`. + +Requested fix: +- `WorkspaceIdentity::load_or_init` must return the identity actually persisted/read from `.yoi/workspace.toml`。 +- Missing-file creation must handle local bootstrap races without returning an unpersisted generated identity。 +- Avoid or safely handle TOCTOU / fixed temp-file clobbering around `workspace.toml.tmp`。 +- Add focused deterministic test coverage if feasible。 + +Validation requested after fix: +- `cargo fmt --check` +- `cargo test -p yoi-workspace-server` +- `cargo check -p yoi-workspace-server` +- `cd web/workspace && deno task check && deno task build` +- `git diff --check` +- `git diff --cached --check` +- `cargo run -p yoi -- ticket doctor` +- `nix build .#yoi --no-link` + +Coder was also asked to remove ignored validation artifacts before reporting。 + +---