From dfe3749af913d8f48398fcbf439e423802708db0 Mon Sep 17 00:00:00 2001 From: Hare Date: Tue, 9 Jun 2026 13:36:05 +0900 Subject: [PATCH] ticket: record identity simplification third review --- .../item.md | 2 +- .../thread.md | 29 +++++++++++++++++++ 2 files changed, 30 insertions(+), 1 deletion(-) diff --git a/.yoi/tickets/open/20260608-110940-simplify-ticket-identity-fields/item.md b/.yoi/tickets/open/20260608-110940-simplify-ticket-identity-fields/item.md index 766e9ff0..15a55311 100644 --- a/.yoi/tickets/open/20260608-110940-simplify-ticket-identity-fields/item.md +++ b/.yoi/tickets/open/20260608-110940-simplify-ticket-identity-fields/item.md @@ -8,7 +8,7 @@ priority: 'P1' labels: ['ticket', 'schema', 'identity', 'migration', 'orchestrator'] workflow_state: 'inprogress' created_at: '2026-06-08T11:09:40Z' -updated_at: '2026-06-09T04:28:16Z' +updated_at: '2026-06-09T04:35:54Z' assignee: null queued_by: 'workspace-panel' queued_at: '2026-06-09T02:13:30Z' diff --git a/.yoi/tickets/open/20260608-110940-simplify-ticket-identity-fields/thread.md b/.yoi/tickets/open/20260608-110940-simplify-ticket-identity-fields/thread.md index e1cf45fd..460939b2 100644 --- a/.yoi/tickets/open/20260608-110940-simplify-ticket-identity-fields/thread.md +++ b/.yoi/tickets/open/20260608-110940-simplify-ticket-identity-fields/thread.md @@ -500,3 +500,32 @@ Coder validation reported passed: Coder reports no remaining requested surface or design conflict. --- + + + +## Review: request changes + +Review result: request_changes + +The previous three blockers were fixed, and the requested validation set passed. However, one stale old-bucket TUI test setup remains and a focused test fails. + +Blocking issue: +- `crates/tui/src/multi_pod.rs` still contains an old bucket path in test setup: + - `.yoi/tickets/open/done-ticket` +- Focused test failure: + - `cargo test -p tui ticket_close_action_blocks_existing_resolution_without_moving_ticket` + - exits 101 because the test writes `resolution.md` under `.yoi/tickets/open/done-ticket/`, but the current flat layout no longer creates that parent path. + +This is a test/helper path rather than production runtime behavior, but the Ticket requires completion of the flat `.yoi/tickets//` migration and no current old-bucket route. Executable tests should not encode old bucket paths. + +Positive evidence: +- Built-in Ticket feature root validation no longer requires `open/`, `pending/`, `closed/` buckets. +- Maintained workflows/docs no longer expose `TicketStatus`, pending routing, or `defer_pending` as current guidance. +- Main requested validation passed: `cargo test -p pod ticket`, `cargo test -p ticket`, `cargo test -p yoi ticket_cli`, `cargo test -p tui ticket_action --no-run`, `cargo test -p tui workspace_panel`, `cargo fmt --check`, `git diff --check`, `cargo run -q -p yoi -- ticket doctor`, `cargo check --workspace`, `nix build .#yoi`. + +Required fix: +- Update the stale TUI test setup in `crates/tui/src/multi_pod.rs` to the flat layout/current state schema. +- Run the failing focused test: `cargo test -p tui ticket_close_action_blocks_existing_resolution_without_moving_ticket`. +- Re-run the relevant focused validation and core checks before re-review. + +---