From e159e9d338423a67dda876a87a0b84034725af73 Mon Sep 17 00:00:00 2001 From: Hare Date: Thu, 11 Jun 2026 17:52:36 +0900 Subject: [PATCH] ticket: close builtin workflow resources --- .yoi/tickets/00001KTGFMW70/item.md | 4 +- .yoi/tickets/00001KTGFMW70/resolution.md | 46 +++++++++++ .yoi/tickets/00001KTGFMW70/thread.md | 100 +++++++++++++++++++++++ 3 files changed, 148 insertions(+), 2 deletions(-) create mode 100644 .yoi/tickets/00001KTGFMW70/resolution.md diff --git a/.yoi/tickets/00001KTGFMW70/item.md b/.yoi/tickets/00001KTGFMW70/item.md index 15108796..1af4265e 100644 --- a/.yoi/tickets/00001KTGFMW70/item.md +++ b/.yoi/tickets/00001KTGFMW70/item.md @@ -1,8 +1,8 @@ --- title: "Builtin Workflow and Knowledge resources" -state: 'inprogress' +state: 'closed' created_at: "2026-06-07T07:27:08Z" -updated_at: '2026-06-11T08:50:25Z' +updated_at: '2026-06-11T08:52:22Z' queued_by: 'workspace-panel' queued_at: '2026-06-11T08:29:19Z' --- diff --git a/.yoi/tickets/00001KTGFMW70/resolution.md b/.yoi/tickets/00001KTGFMW70/resolution.md new file mode 100644 index 00000000..e6cebe64 --- /dev/null +++ b/.yoi/tickets/00001KTGFMW70/resolution.md @@ -0,0 +1,46 @@ +完了しました。 + +実施内容: +- embedded builtin Workflow resources を `resources/workflows` に追加しました。 + - `ticket-intake-workflow` + - `ticket-orchestrator-routing` + - `multi-agent-workflow` +- embedded builtin Knowledge resource を `resources/knowledge/workflow-resource-boundary.md` に追加しました。 +- `WorkflowSource::Builtin` を追加し、builtin Workflow registry loading を実装しました。 +- Workspace `.yoi/workflow/.md` が同 slug の builtin workflow を override します。 +- 既存 skill shadow behavior は維持しています。 +- Workflow invocation system item に workflow source provenance を表示します。 + - `from builtin workflow` + - `from workspace workflow` + - etc. +- Workflow-required Knowledge resolution は workspace `.yoi/knowledge/.md` を優先し、missing の場合だけ builtin Knowledge に fallback します。 +- required Knowledge system item に source provenance を表示します。 + - `from workspace` + - `from builtin` +- workspace Knowledge は同 slug の builtin Knowledge を override します。 +- tests を追加・更新しました。 + - builtin registry fallback + - workspace workflow override precedence + - builtin workflow provenance + - builtin required Knowledge fallback + - workspace Knowledge override + - existing workflow invocation behavior + +Merge: +- Branch: `builtin-workflow-knowledge-resources` +- Implementation commit: `2418ad33 feat: add builtin workflow resources` +- Merge commit: `ef2099c1 merge: builtin workflow knowledge resources` + +確認: +- Branch-local reviewer `reviewer-builtin-workflow-knowledge-resources` が approve。 +- `cargo fmt --check` passed。 +- `cargo test -p workflow --lib` passed（34 passed）。 +- `cargo test -p pod workflow --lib` passed（8 passed）。 +- `cargo check -p workflow -p pod` passed。 +- `git diff --check` passed。 +- `target/debug/yoi ticket doctor` passed。 +- typed `TicketDoctor` は 0 errors / 3 pre-existing diagnostics。 +- `nix build .#yoi` passed。 + +残作業: +- Broader builtin KnowledgeQuery / user-level Workflow-Knowledge resource directories は follow-up 境界です。 \ No newline at end of file diff --git a/.yoi/tickets/00001KTGFMW70/thread.md b/.yoi/tickets/00001KTGFMW70/thread.md index 8e93db43..723986ff 100644 --- a/.yoi/tickets/00001KTGFMW70/thread.md +++ b/.yoi/tickets/00001KTGFMW70/thread.md @@ -193,3 +193,103 @@ Validation run by reviewer: No files were intentionally modified and no final main-branch Ticket approval/close was recorded by reviewer. --- + + + +## Review: approve + +Main-branch review/merge-completion approval. + +Verified before merge: +- Merge target matched branch `builtin-workflow-knowledge-resources`, worktree `.worktree/builtin-workflow-knowledge-resources`, and implementation commit `2418ad33`. +- Branch-local reviewer `reviewer-builtin-workflow-knowledge-resources` approved with no blockers. +- Main workspace was clean before merge after restoring stale unrelated role-profile diffs and committing unrelated Ticket record updates. +- User has standing authorization to proceed through merge-completion when reviewer approval and safety checks pass. + +Merged: +- `git merge --no-ff builtin-workflow-knowledge-resources -m "merge: builtin workflow knowledge resources"` +- Merge commit: `ef2099c1 merge: builtin workflow knowledge resources` + +Post-merge validation: +- `cargo fmt --check` passed. +- `cargo test -p workflow --lib` passed (34 passed). +- `cargo test -p pod workflow --lib` passed (8 passed). +- `cargo check -p workflow -p pod` passed. +- `git diff --check` passed. +- `target/debug/yoi ticket doctor` passed. +- typed `TicketDoctor` reported 0 errors and 3 pre-existing diagnostics. +- `nix build .#yoi` passed. + +Result: approve. + +--- + + + +## State changed + +Merged branch `builtin-workflow-knowledge-resources` with merge commit `ef2099c1`; branch-local reviewer approved and post-merge validation passed (`cargo fmt --check`, `cargo test -p workflow --lib`, `cargo test -p pod workflow --lib`, `cargo check -p workflow -p pod`, `git diff --check`, `target/debug/yoi ticket doctor`, typed `TicketDoctor` 0 errors / 3 pre-existing diagnostics, `nix build .#yoi`). + +--- + + + +## State changed + +Ticket を closed にしました。 + + +--- + + + +## 完了 + +完了しました。 + +実施内容: +- embedded builtin Workflow resources を `resources/workflows` に追加しました。 + - `ticket-intake-workflow` + - `ticket-orchestrator-routing` + - `multi-agent-workflow` +- embedded builtin Knowledge resource を `resources/knowledge/workflow-resource-boundary.md` に追加しました。 +- `WorkflowSource::Builtin` を追加し、builtin Workflow registry loading を実装しました。 +- Workspace `.yoi/workflow/.md` が同 slug の builtin workflow を override します。 +- 既存 skill shadow behavior は維持しています。 +- Workflow invocation system item に workflow source provenance を表示します。 + - `from builtin workflow` + - `from workspace workflow` + - etc. +- Workflow-required Knowledge resolution は workspace `.yoi/knowledge/.md` を優先し、missing の場合だけ builtin Knowledge に fallback します。 +- required Knowledge system item に source provenance を表示します。 + - `from workspace` + - `from builtin` +- workspace Knowledge は同 slug の builtin Knowledge を override します。 +- tests を追加・更新しました。 + - builtin registry fallback + - workspace workflow override precedence + - builtin workflow provenance + - builtin required Knowledge fallback + - workspace Knowledge override + - existing workflow invocation behavior + +Merge: +- Branch: `builtin-workflow-knowledge-resources` +- Implementation commit: `2418ad33 feat: add builtin workflow resources` +- Merge commit: `ef2099c1 merge: builtin workflow knowledge resources` + +確認: +- Branch-local reviewer `reviewer-builtin-workflow-knowledge-resources` が approve。 +- `cargo fmt --check` passed。 +- `cargo test -p workflow --lib` passed（34 passed）。 +- `cargo test -p pod workflow --lib` passed（8 passed）。 +- `cargo check -p workflow -p pod` passed。 +- `git diff --check` passed。 +- `target/debug/yoi ticket doctor` passed。 +- typed `TicketDoctor` は 0 errors / 3 pre-existing diagnostics。 +- `nix build .#yoi` passed。 + +残作業: +- Broader builtin KnowledgeQuery / user-level Workflow-Knowledge resource directories は follow-up 境界です。 + +---