From e5510620cc13043bb0097d698f5b220cb0402a64 Mon Sep 17 00:00:00 2001 From: Hare Date: Sat, 20 Jun 2026 16:58:21 +0900 Subject: [PATCH] ticket: approve mcp stdio lifecycle client --- .yoi/tickets/00001KVHR3WRY/item.md | 2 +- .yoi/tickets/00001KVHR3WRY/thread.md | 36 ++++++++++++++++++++++++++++ 2 files changed, 37 insertions(+), 1 deletion(-) diff --git a/.yoi/tickets/00001KVHR3WRY/item.md b/.yoi/tickets/00001KVHR3WRY/item.md index 54ae69e5..52674c28 100644 --- a/.yoi/tickets/00001KVHR3WRY/item.md +++ b/.yoi/tickets/00001KVHR3WRY/item.md @@ -2,7 +2,7 @@ title: 'MCP: implement stdio JSON-RPC lifecycle client' state: 'inprogress' created_at: '2026-06-20T05:30:04Z' -updated_at: '2026-06-20T07:55:55Z' +updated_at: '2026-06-20T07:58:02Z' assignee: null readiness: 'implementation_ready' risk_flags: ['mcp', 'stdio', 'json-rpc', 'process-lifecycle', 'diagnostics'] diff --git a/.yoi/tickets/00001KVHR3WRY/thread.md b/.yoi/tickets/00001KVHR3WRY/thread.md index f3135d91..c9cf1824 100644 --- a/.yoi/tickets/00001KVHR3WRY/thread.md +++ b/.yoi/tickets/00001KVHR3WRY/thread.md @@ -266,3 +266,39 @@ Next action: - Route back to Reviewer for r2 verification of the redacted `Debug` blocker and final acceptance criteria。 --- + + + +## Review: approve + +Verdict: `approve` + +確認範囲: +- Ticket authority / Orchestrator IntentPacket。 +- r2 fix diff: `a114fa9d..f396e1a2`。 +- 全体実装 diff: `c0e760d7..f396e1a2`。 +- 主な対象: `crates/mcp/src/stdio.rs`, `crates/mcp/tests/stdio_lifecycle.rs`, new crate/workspace/package changes, ToolRegistry/resource/prompt registration leakage の有無。 + +Previous blocker verification: +- `McpStdioServerSpec` no longer derives `Debug`; it is `Clone` only。 +- Custom `fmt::Debug` now redacts env values and prints only non-sensitive metadata / env keys / `redaction_count`。 +- `redactions` contents are not printed。 +- Regression test confirms `format!("{spec:?}")` includes useful non-sensitive metadata and excludes plaintext env-like values。 + +Blocking issues: none。 + +Non-blocking concerns / follow-ups: +- None blocking for this Ticket。Implementation remains scoped to stdio lifecycle/protocol foundations and does not add ToolRegistry/resource/prompt registration or remote/OAuth surfaces。 + +Reviewer validation: +- `git diff --check c0e760d7..HEAD`: passed。 +- `cargo fmt --check`: passed。 +- `cargo test -p mcp`: passed; 5 tests passed including redacted Debug regression。 +- `cargo check`: passed。 +- `cargo tree -p mcp --depth 1`: inspected; dependencies limited to `libc`, `manifest`, `secrets`, `serde`, `serde_json`, `thiserror`, `tokio`; no product façade dependency。 +- `nix build .#yoi --no-link`: passed。 +- Additional grep found no added ToolRegistry/resource/prompt registration or remote/OAuth/HTTP scope creep。 + +Worktree status at review end: clean。 + +---