diff --git a/work-items/open/20260531-085959-remove-insomnia-pod-command-env/artifacts/.gitkeep b/work-items/closed/20260531-085959-remove-insomnia-pod-command-env/artifacts/.gitkeep similarity index 100% rename from work-items/open/20260531-085959-remove-insomnia-pod-command-env/artifacts/.gitkeep rename to work-items/closed/20260531-085959-remove-insomnia-pod-command-env/artifacts/.gitkeep diff --git a/work-items/open/20260531-085959-remove-insomnia-pod-command-env/item.md b/work-items/closed/20260531-085959-remove-insomnia-pod-command-env/item.md similarity index 97% rename from work-items/open/20260531-085959-remove-insomnia-pod-command-env/item.md rename to work-items/closed/20260531-085959-remove-insomnia-pod-command-env/item.md index 2e4ab0dd..5f680054 100644 --- a/work-items/open/20260531-085959-remove-insomnia-pod-command-env/item.md +++ b/work-items/closed/20260531-085959-remove-insomnia-pod-command-env/item.md @@ -2,12 +2,12 @@ id: 20260531-085959-remove-insomnia-pod-command-env slug: remove-insomnia-pod-command-env title: CLI: remove INSOMNIA_POD_COMMAND override -status: open +status: closed kind: task priority: P2 labels: [cli, pod, env] created_at: 2026-05-31T08:59:59Z -updated_at: 2026-05-31T10:09:52Z +updated_at: 2026-05-31T10:12:03Z assignee: null legacy_ticket: null --- diff --git a/work-items/closed/20260531-085959-remove-insomnia-pod-command-env/resolution.md b/work-items/closed/20260531-085959-remove-insomnia-pod-command-env/resolution.md new file mode 100644 index 00000000..5eb8a141 --- /dev/null +++ b/work-items/closed/20260531-085959-remove-insomnia-pod-command-env/resolution.md @@ -0,0 +1,22 @@ +Removed `INSOMNIA_POD_COMMAND` as an active runtime/config/test override. + +Implementation: +- `PodRuntimeCommand::resolve()` now always uses the typed default: current executable plus the `pod` prefix argument. +- Removed override/env parsing and related tests from the `insomnia` helper crate. +- Updated SpawnPod tests to use typed `PodRuntimeCommand` injection instead of process-wide env mutation. +- Preserved production spawn/restore behavior, detached process handling, and ready/socket delivery behavior. +- Updated docs so no active supported surface documents the removed env override. + +Review: +- External reviewer `remove-insomnia-pod-command-reviewer-20260531` approved implementation commit `c618fa6`. + +Validation after merge: +- `cargo fmt --check` +- `cargo test -p insomnia` +- `cargo test -p client -p insomnia` +- `cargo test -p pod --lib discovery::tests` +- `cargo test -p pod --test spawn_pod_test` +- `cargo check -p tui -p pod -p client -p insomnia` (passed with unrelated existing warnings) +- `./tickets.sh doctor` +- `git diff --check` +- `git grep -n "INSOMNIA_POD_COMMAND" -- ':!work-items' || true` produced no active references. diff --git a/work-items/open/20260531-085959-remove-insomnia-pod-command-env/thread.md b/work-items/closed/20260531-085959-remove-insomnia-pod-command-env/thread.md similarity index 58% rename from work-items/open/20260531-085959-remove-insomnia-pod-command-env/thread.md rename to work-items/closed/20260531-085959-remove-insomnia-pod-command-env/thread.md index 2608562d..09011986 100644 --- a/work-items/open/20260531-085959-remove-insomnia-pod-command-env/thread.md +++ b/work-items/closed/20260531-085959-remove-insomnia-pod-command-env/thread.md @@ -35,4 +35,34 @@ Validation adequacy: - Reviewer additionally reran targeted tests/checks in the implementation worktree and confirmed no active refs for `INSOMNIA_POD_COMMAND`, `POD_COMMAND_OVERRIDE_ENV`, `from_override_env`, or `executable_only` outside work items. +--- + + + +## Closed + +Removed `INSOMNIA_POD_COMMAND` as an active runtime/config/test override. + +Implementation: +- `PodRuntimeCommand::resolve()` now always uses the typed default: current executable plus the `pod` prefix argument. +- Removed override/env parsing and related tests from the `insomnia` helper crate. +- Updated SpawnPod tests to use typed `PodRuntimeCommand` injection instead of process-wide env mutation. +- Preserved production spawn/restore behavior, detached process handling, and ready/socket delivery behavior. +- Updated docs so no active supported surface documents the removed env override. + +Review: +- External reviewer `remove-insomnia-pod-command-reviewer-20260531` approved implementation commit `c618fa6`. + +Validation after merge: +- `cargo fmt --check` +- `cargo test -p insomnia` +- `cargo test -p client -p insomnia` +- `cargo test -p pod --lib discovery::tests` +- `cargo test -p pod --test spawn_pod_test` +- `cargo check -p tui -p pod -p client -p insomnia` (passed with unrelated existing warnings) +- `./tickets.sh doctor` +- `git diff --check` +- `git grep -n "INSOMNIA_POD_COMMAND" -- ':!work-items' || true` produced no active references. + + ---