diff --git a/work-items/open/20260531-085959-remove-insomnia-pod-command-env/item.md b/work-items/open/20260531-085959-remove-insomnia-pod-command-env/item.md index c26ebc91..2e4ab0dd 100644 --- a/work-items/open/20260531-085959-remove-insomnia-pod-command-env/item.md +++ b/work-items/open/20260531-085959-remove-insomnia-pod-command-env/item.md @@ -7,7 +7,7 @@ kind: task priority: P2 labels: [cli, pod, env] created_at: 2026-05-31T08:59:59Z -updated_at: 2026-05-31T08:59:59Z +updated_at: 2026-05-31T10:09:52Z assignee: null legacy_ticket: null --- diff --git a/work-items/open/20260531-085959-remove-insomnia-pod-command-env/thread.md b/work-items/open/20260531-085959-remove-insomnia-pod-command-env/thread.md index a8fff814..2608562d 100644 --- a/work-items/open/20260531-085959-remove-insomnia-pod-command-env/thread.md +++ b/work-items/open/20260531-085959-remove-insomnia-pod-command-env/thread.md @@ -4,4 +4,35 @@ Created by tickets.sh create. +--- + + + +## Review: approve + +External reviewer: `remove-insomnia-pod-command-reviewer-20260531` +Reviewed implementation commit: `c618fa6` (`cli: remove pod command env override`) +Verdict: approve + +Summary: +- `INSOMNIA_POD_COMMAND` is removed as an active runtime/config/test override. +- Pod runtime launch remains typed through `PodRuntimeCommand`, defaulting to current executable plus the `pod` prefix argument. +- SpawnPod tests now use typed injection rather than process-wide env mutation. +- Production spawn/restore paths still use `PodRuntimeCommand::resolve()`, preserve detached process handling, and retain the ready/socket delivery behavior. + +Requirements mapping: +- No active non-work-item `INSOMNIA_POD_COMMAND` references remain in the implementation branch. +- No replacement env var was introduced. +- No `insomnia-pod` binary/alias, Pod protocol/flag/profile semantic changes, or `tui` rename were introduced. + +Blockers: none. + +Non-blocking follow-up: +- Merge conflict in `docs/environment.md` is expected after `eliminate-test-only-env-vars`; integration should keep the newer generic test-only wording while preserving removal of explicit `INSOMNIA_POD_COMMAND` references. + +Validation adequacy: +- Coder validation covered fmt, helper/client/pod tests, cargo check, doctor, diff check, and active-reference grep. +- Reviewer additionally reran targeted tests/checks in the implementation worktree and confirmed no active refs for `INSOMNIA_POD_COMMAND`, `POD_COMMAND_OVERRIDE_ENV`, `from_override_env`, or `executable_only` outside work items. + + ---