From e8e50bfa6baaafd2d09af2fb5ea27f6ee014bf58 Mon Sep 17 00:00:00 2001 From: Hare Date: Sun, 31 May 2026 19:04:31 +0900 Subject: [PATCH] close: eliminate test-only env vars --- .../artifacts/.gitkeep | 0 .../item.md | 4 +-- .../resolution.md | 18 +++++++++++++ .../thread.md | 26 +++++++++++++++++++ 4 files changed, 46 insertions(+), 2 deletions(-) rename work-items/{open => closed}/20260531-085959-eliminate-test-only-env-vars/artifacts/.gitkeep (100%) rename work-items/{open => closed}/20260531-085959-eliminate-test-only-env-vars/item.md (98%) create mode 100644 work-items/closed/20260531-085959-eliminate-test-only-env-vars/resolution.md rename work-items/{open => closed}/20260531-085959-eliminate-test-only-env-vars/thread.md (59%) diff --git a/work-items/open/20260531-085959-eliminate-test-only-env-vars/artifacts/.gitkeep b/work-items/closed/20260531-085959-eliminate-test-only-env-vars/artifacts/.gitkeep similarity index 100% rename from work-items/open/20260531-085959-eliminate-test-only-env-vars/artifacts/.gitkeep rename to work-items/closed/20260531-085959-eliminate-test-only-env-vars/artifacts/.gitkeep diff --git a/work-items/open/20260531-085959-eliminate-test-only-env-vars/item.md b/work-items/closed/20260531-085959-eliminate-test-only-env-vars/item.md similarity index 98% rename from work-items/open/20260531-085959-eliminate-test-only-env-vars/item.md rename to work-items/closed/20260531-085959-eliminate-test-only-env-vars/item.md index e7f299fe..a3668d06 100644 --- a/work-items/open/20260531-085959-eliminate-test-only-env-vars/item.md +++ b/work-items/closed/20260531-085959-eliminate-test-only-env-vars/item.md @@ -2,12 +2,12 @@ id: 20260531-085959-eliminate-test-only-env-vars slug: eliminate-test-only-env-vars title: Tests: eliminate test-only environment variables -status: open +status: closed kind: task priority: P2 labels: [test, env, cleanup] created_at: 2026-05-31T08:59:59Z -updated_at: 2026-05-31T10:03:55Z +updated_at: 2026-05-31T10:04:28Z assignee: null legacy_ticket: null --- diff --git a/work-items/closed/20260531-085959-eliminate-test-only-env-vars/resolution.md b/work-items/closed/20260531-085959-eliminate-test-only-env-vars/resolution.md new file mode 100644 index 00000000..9bdf287c --- /dev/null +++ b/work-items/closed/20260531-085959-eliminate-test-only-env-vars/resolution.md @@ -0,0 +1,18 @@ +Removed test-only environment-variable usage from active code. + +Implementation: +- Removed `INSOMNIA_TEST_*` Brave WebSearch test key generation/dependency. +- Split Brave search request execution so tests can inject an API key directly into a private helper. +- Preserved production behavior: WebSearch still reads configured `web.search.api_key_env` and fails closed for missing/empty values. +- Updated `docs/environment.md` so test-only env vars are not listed as supported surface. + +Review: +- External reviewer `eliminate-test-env-vars-reviewer-20260531` approved implementation commit `e64a5595956c970b090cdce851cc962e92723a97`. + +Validation after merge: +- `cargo fmt --check` +- `cargo test -p tools` +- `cargo check -p tools` (passed with unrelated existing `llm-worker` dead_code warning) +- `./tickets.sh doctor` +- `git diff --check` +- `git grep -n "INSOMNIA_TEST" -- ':!work-items' || true` produced no active references. diff --git a/work-items/open/20260531-085959-eliminate-test-only-env-vars/thread.md b/work-items/closed/20260531-085959-eliminate-test-only-env-vars/thread.md similarity index 59% rename from work-items/open/20260531-085959-eliminate-test-only-env-vars/thread.md rename to work-items/closed/20260531-085959-eliminate-test-only-env-vars/thread.md index 8fd13058..ba081848 100644 --- a/work-items/open/20260531-085959-eliminate-test-only-env-vars/thread.md +++ b/work-items/closed/20260531-085959-eliminate-test-only-env-vars/thread.md @@ -35,4 +35,30 @@ Validation adequacy: - Reviewer performed read-only diff/source/docs/grep review and did not rerun tests. +--- + + + +## Closed + +Removed test-only environment-variable usage from active code. + +Implementation: +- Removed `INSOMNIA_TEST_*` Brave WebSearch test key generation/dependency. +- Split Brave search request execution so tests can inject an API key directly into a private helper. +- Preserved production behavior: WebSearch still reads configured `web.search.api_key_env` and fails closed for missing/empty values. +- Updated `docs/environment.md` so test-only env vars are not listed as supported surface. + +Review: +- External reviewer `eliminate-test-env-vars-reviewer-20260531` approved implementation commit `e64a5595956c970b090cdce851cc962e92723a97`. + +Validation after merge: +- `cargo fmt --check` +- `cargo test -p tools` +- `cargo check -p tools` (passed with unrelated existing `llm-worker` dead_code warning) +- `./tickets.sh doctor` +- `git diff --check` +- `git grep -n "INSOMNIA_TEST" -- ':!work-items' || true` produced no active references. + + ---