From f7448c832e11e4ed947043e0b1f6406036c90424 Mon Sep 17 00:00:00 2001 From: Hare Date: Sun, 28 Jun 2026 04:46:48 +0900 Subject: [PATCH] ticket: record worker execution backend fix --- .yoi/tickets/00001KW55B32Y/item.md | 2 +- .yoi/tickets/00001KW55B32Y/thread.md | 38 ++++++++++++++++++++++++++++ 2 files changed, 39 insertions(+), 1 deletion(-) diff --git a/.yoi/tickets/00001KW55B32Y/item.md b/.yoi/tickets/00001KW55B32Y/item.md index 9a8bb9d7..aab3eaa8 100644 --- a/.yoi/tickets/00001KW55B32Y/item.md +++ b/.yoi/tickets/00001KW55B32Y/item.md @@ -2,7 +2,7 @@ title: 'worker-runtimeにWorker実行Backend境界を追加する' state: 'inprogress' created_at: '2026-06-27T18:26:46Z' -updated_at: '2026-06-27T19:41:12Z' +updated_at: '2026-06-27T19:46:45Z' assignee: null queued_by: 'workspace-panel' queued_at: '2026-06-27T19:06:28Z' diff --git a/.yoi/tickets/00001KW55B32Y/thread.md b/.yoi/tickets/00001KW55B32Y/thread.md index ac9f9ec6..a35f785e 100644 --- a/.yoi/tickets/00001KW55B32Y/thread.md +++ b/.yoi/tickets/00001KW55B32Y/thread.md @@ -255,3 +255,41 @@ request_changes - 作業ツリーは review 後も clean。 --- + + + +## Implementation report + +Change-response implementation report: + +Reviewer blocker を修正済み。マージ / close / cleanup は未実施。 + +Fix commit: +- `761b60c85750d03c119733a088fb5073f9b37e9a fix: initialize restored worker observations` + +修正内容: + +`RuntimeState::from_persisted` の fs-store restore path で、`ws-server` feature 有効時の observation bus 状態を初期化するようにした。 + +追加初期化: +- `next_observation_sequence: 1` +- `observation_events: VecDeque::new()` +- `observation_tx: broadcast::channel(256).0` + +また、`fs_store_restores_workers_events_and_transcripts` に `ws-server` 有効時の focused assertion を追加し、restore 後の Runtime でも `observe_worker_event` / `read_worker_observation_events` が動くことを確認した。 + +Validation: +- `CARGO_TARGET_DIR=/tmp/yoi-review-target-00001KW55B32Y cargo check -p worker-runtime --features "ws-server fs-store"`: success +- `cargo fmt --all`: success +- `cargo test -p worker-runtime --features ws-server`: success +- `cargo test -p worker-runtime --features "ws-server fs-store"`: success +- `cargo test -p yoi-workspace-server`: success +- `cargo check -p yoi`: success +- `git diff --check`: success +- `nix build .#yoi --no-link`: success + +Residual risk / review focus: +- observation events 自体は fs-store 永続化対象ではないため、restore 後の observation backlog は空から開始する。これは既存の observation bus/backlog の揮発的性質に沿った修正。 +- 今回は compile blocker の修正に限定し、backend adapter や永続 observation replay の設計拡張は行っていない。 + +---