Hare/yoi
1
1
Fork 0
Code Actions Packages Releases Activity

review: multi pod status probes

Browse Source
This commit is contained in:
Keisuke Hirata 2026-05-30 14:45:14 +09:00
parent 6899b446c7
commit f74cf78187
No known key found for this signature in database
2 changed files with 34 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
work-items/open/20260530-053259-multi-pod-parallel-status-probes/item.md
View File

@ -7,7 +7,7 @@ kind: task
priority: P2 priority: P2
labels: [tui, pod-dashboard, performance] labels: [tui, pod-dashboard, performance]
created_at: 2026-05-30T05:32:59Z created_at: 2026-05-30T05:32:59Z
updated_at: 2026-05-30T05:33:43Z updated_at: 2026-05-30T05:45:14Z
assignee: null assignee: null
legacy_ticket: null legacy_ticket: null
--- ---

33
work-items/open/20260530-053259-multi-pod-parallel-status-probes/thread.md
View File

@ -27,4 +27,37 @@ Critical risks:
- Avoid duplicating discovery logic outside shared `PodList`. - Avoid duplicating discovery logic outside shared `PodList`.
---
<!-- event: review author: hare at: 2026-05-30T05:45:14Z status: approve -->
## Review: approve
Approve.
The implementation addresses the ticket in the shared `PodList` live-probe path. Live status probes now run concurrently with a more realistic per-Pod timeout, reachable sockets without reported status remain live/attachable, and the multi-Pod label is softened from `live unknown` to `live` while explicit statuses remain unchanged.
Blocker findings: none.
Requirement coverage:
- Per-Pod timeout increased to 200ms.
- Probes are concurrent and bounded by the slowest bounded probe rather than `N * timeout`.
- Reachable sockets with no status remain reachable/live/attachable.
- Restoreability remains separate and unchanged.
- No last-known status is persisted to pod-store.
- Explicit `live idle`, `live running`, and `live paused` labels remain.
- `status = None` renders as `live`.
- The implementation changes shared `PodList` live-probe logic rather than duplicating dashboard-only logic.
- Tests cover concurrency, timeout/no-status reachable handling, and label rendering.
Validation reviewed:
- `cargo fmt --check` — passed.
- `cargo test -p tui pod_list` — passed.
- `cargo test -p tui multi_pod` — passed.
- `cargo test -p tui` — passed.
- Reviewer additionally ran `./tickets.sh doctor` — passed.
Final verdict: approve.
--- ---