ticket: record knowledge docs review blocker

This commit is contained in:
Keisuke Hirata 2026-07-16 07:53:26 +09:00
parent ff8e3c1114
commit fae9bbe84a
No known key found for this signature in database
2 changed files with 22 additions and 1 deletions

View File

@ -2,7 +2,7 @@
title: 'Remove Knowledge support'
state: 'inprogress'
created_at: '2026-07-15T20:04:08Z'
updated_at: '2026-07-15T22:50:56Z'
updated_at: '2026-07-15T22:53:20Z'
assignee: null
queued_by: 'workspace-panel'
queued_at: '2026-07-15T20:27:02Z'

View File

@ -322,3 +322,24 @@ Next action:
- Request focused re-review of the remaining hash completion blocker and overall acceptance before merge/close decisions。
---
<!-- event: review author: reviewer at: 2026-07-15T22:53:20Z status: request_changes -->
## Review: request changes
Focused re-review result: request_changes
Fixed:
- Web `#` completion blocker is fixed: `web/workspace/src/lib/workspace/console/composer-completion.ts:4,38,80-88` now only accepts `:`/`@`, has no fallback remapping to file, and `composer-completion.test.ts:35` asserts `ask #plain` is not a token。
- Prior code blockers remain fixed: no `KnowledgeQuery`, `MemoryToolKind` is summary/decision/request only, resident injection is summary-only, protocol `CompletionKind` is file-only, `.yoi/knowledge` appears only in the explicit legacy/manual archive note, legacy Knowledge SystemItems return empty history text, and no Skills files/diff were found。
Remaining acceptance blocker:
- Stale active docs/report guidance still advertises Knowledge as active record/tool behavior。
- `docs/report/test-validity-20260612/yoi.md:41` says `memory/Knowledge record path` is linted。
- `docs/report/test-validity-20260612/memory.md:46` refers to `MemoryWrite` “Knowledge/Request 作成”。
- These are not framed as historical/ignored compatibility and violate the docs/prompts cleanup acceptance。
Validation performed:
- Static read-only review only; no tests rerun because static docs acceptance blocker remains。
---