From 34836d97ae9439498a2a9446451fe647a11d9b99 Mon Sep 17 00:00:00 2001 From: Hare Date: Tue, 7 Jul 2026 04:54:37 +0900 Subject: [PATCH 1/9] ticket: accept workspace id route scoping --- .../artifacts/orchestration-plan.jsonl | 1 + .yoi/tickets/00001KWWE8E04/item.md | 4 +- .yoi/tickets/00001KWWE8E04/thread.md | 106 ++++++++++++++++++ 3 files changed, 109 insertions(+), 2 deletions(-) create mode 100644 .yoi/tickets/00001KWWE8E04/artifacts/orchestration-plan.jsonl diff --git a/.yoi/tickets/00001KWWE8E04/artifacts/orchestration-plan.jsonl b/.yoi/tickets/00001KWWE8E04/artifacts/orchestration-plan.jsonl new file mode 100644 index 00000000..b2f10e29 --- /dev/null +++ b/.yoi/tickets/00001KWWE8E04/artifacts/orchestration-plan.jsonl @@ -0,0 +1 @@ +{"id":"orch-plan-20260706-195421-1","ticket_id":"00001KWWE8E04","kind":"accepted_plan","accepted_plan":{"summary":"Ticket 00001KWWE8E04 は独立 queued Ticket で blocker なし。Workspace Browser の canonical route/API を `/w/` / `/api/w/` に scope する。human authorized routing 済みのため queued->inprogress acceptance 後に worktree + coder/reviewer loop へ進める。","branch":"work/00001KWWE8E04-workspace-id-routes","worktree":"/home/hare/Projects/yoi/.worktree/00001KWWE8E04-workspace-id-routes","role_plan":"単一 sibling Coder Pod に implementation worktree を委譲し、workspace id scoped Browser routes/API/backend mismatch guard/frontend link/API helpers/tests を実装する。完了後、別 sibling Reviewer Pod で Ticket IntentPacket / authority boundary / acceptance criteria に照らして read-only review する。"},"author":"orchestrator","at":"2026-07-06T19:54:21Z"} diff --git a/.yoi/tickets/00001KWWE8E04/item.md b/.yoi/tickets/00001KWWE8E04/item.md index f54fa8e8..2e531925 100644 --- a/.yoi/tickets/00001KWWE8E04/item.md +++ b/.yoi/tickets/00001KWWE8E04/item.md @@ -1,8 +1,8 @@ --- title: 'Scope Workspace Browser routes and API by workspace id' -state: 'queued' +state: 'inprogress' created_at: '2026-07-06T19:25:08Z' -updated_at: '2026-07-06T19:53:14Z' +updated_at: '2026-07-06T19:54:30Z' assignee: null queued_by: 'workspace-panel' queued_at: '2026-07-06T19:53:14Z' diff --git a/.yoi/tickets/00001KWWE8E04/thread.md b/.yoi/tickets/00001KWWE8E04/thread.md index f7f6ea45..4f125f94 100644 --- a/.yoi/tickets/00001KWWE8E04/thread.md +++ b/.yoi/tickets/00001KWWE8E04/thread.md @@ -30,4 +30,110 @@ Marked ready by `yoi ticket state`. Ticket を `workspace-panel` が queued にしました。 +--- + + + +## Decision + +Routing decision: implementation_ready + +Reason: +- Ticket は Workspace Browser route/API を immutable workspace id で scope する具体的な URL/API contract、acceptance criteria、非目標を明記している。 +- 1 Backend = 1 Workspace の現状でも request path の `workspace-id` と Backend current `workspace_id` を照合するという authority boundary が明確。 +- Runtime `/v1/...` API とは混同しないこと、multi-workspace DB migration / slug / admin UI は非目標であることが明確。 +- typed relation blocker は 0 件、OrchestrationPlan record は 0 件。 +- queued notification は human authorized routing であり、今回の routing acceptance 後にのみ implementation side effect へ進める。 + +Evidence checked: +- Ticket body / thread / artifacts。 +- `TicketRelationQuery(00001KWWE8E04)`: 0 件。 +- `TicketOrchestrationPlanQuery(00001KWWE8E04)`: 0 件。 +- Orchestrator worktree git status: clean on `orchestration`。 +- queued Ticket 一覧: この Ticket 1件のみ。inprogress は 0 件。 +- visible Pods: previous execution-workspace child Pods が idle で残っているが、`StopPod` 不使用方針のため停止せず、新規 unique Pod を使う。capacity blocker ではない。 +- `TicketDoctor`: 0 errors / 既存 diagnostics のみ。 +- Bounded code map: `crates/workspace-server/src/{identity.rs,server.rs,hosts.rs,config.rs,records.rs,repositories.rs}`, `web/workspace/src/routes/**`, `web/workspace/src/lib/workspace-sidebar/**`, workspace settings/sidebar/console helpers。 + +IntentPacket: + +Intent: +- Workspace Browser の canonical UI route を `/w//...` に移し、Frontend が Browser-facing API を `/api/w//...` 経由で呼ぶようにする。 +- 1 Backend = 1 Workspace の現状でも、path workspace id と serving workspace id を照合し、mismatch を typed sanitized diagnostic として fail closed する。 + +Binding decisions / invariants: +- Workspace URL は slug/renameable handle ではなく immutable `workspace_id` を使う。 +- canonical route prefix は短い `/w//...`。 +- Browser-facing scoped API prefix は `/api/w//...`。 +- Runtime API `/v1/runtime`, `/v1/workers` はこの Ticket の scope 外であり、workspace id segment を追加しない。 +- Backend canonical store の multi-workspace DB migration、Workspace slug/alias/rename、global admin UI は非目標。 +- 既存 unscoped API/routes は互換 alias / redirect として残してよいが、Frontend の own calls/tests は scoped API/route を期待する。 +- workspace id mismatch response は typed sanitized error とし、raw path / internal store / authority-bearing internals を漏らさない。 + +Requirements / acceptance criteria: +- `/w/` が overview を表示する。 +- `/w//repositories/` が Repository detail を表示する。 +- `/w//objectives` と `/w//objectives/` が動く。 +- `/w//settings` が Settings を表示する。 +- `/w//runtimes//workers//console` が Worker console を表示する。 +- Frontend API calls use `/api/w//...` for workspace/repositories/objectives/workers/settings runtime-connections and relevant worker console endpoints。 +- Sidebar/settings/repository/objectives/worker-console links include workspace id。 +- mismatched workspace id returns typed 404 or equivalent mismatch diagnostic。 +- Focused backend/web tests cover scoped API, mismatch, and frontend scoped API/link construction。 + +Implementation latitude: +- Route grouping/layout structure, helper naming, redirect vs compatibility route choice, and scoped API client abstraction can follow current SvelteKit/backend style。 +- Existing unscoped API can remain as compatibility alias if scoped variants are canonical for frontend use。 +- A small workspace route helper/client module is acceptable to avoid string duplication。 +- Tests may cover helper/model/API routing rather than full browser E2E, consistent with current project constraints。 + +Escalate if: +- Multi-workspace DB/store authority must be implemented to satisfy routing。 +- Workspace slug/handle/rename/alias becomes necessary。 +- Runtime `/v1/...` API needs workspace id path segment。 +- Browser-facing mismatch diagnostics require exposing raw internal paths/store/runtime details。 + +Validation: +- `cd web/workspace && deno task check && deno task test` +- `cargo test -p yoi-workspace-server` +- `cargo check -p yoi` +- `git diff --check` +- `yoi ticket doctor` +- `nix build .#yoi --no-link` は Cargo.lock / dependency / resource packaging / Nix 変更がある場合だけ実行し、未実行なら理由を報告する。 + +Current code map: +- Workspace identity: `crates/workspace-server/src/identity.rs`, config/server setup in `config.rs`, `main.rs`。 +- Backend routes/API: `crates/workspace-server/src/server.rs`, host/worker API context in `hosts.rs`, project records in `records.rs`, repository API in `repositories.rs`。 +- Frontend routes: `web/workspace/src/routes/+layout.ts`, `+layout.svelte`, `+page.ts`, `+page.svelte`, `routes/repositories/[repositoryId]`, `routes/objectives`, `routes/settings`, `routes/runtimes/[runtimeId]/workers/[workerId]/console`。 +- Frontend navigation/API call surfaces: `web/workspace/src/lib/workspace-sidebar/**`, settings model/page, worker console page, repository navigation helpers。 + +Critical risks / reviewer focus: +- Frontend must not keep calling unscoped `/api/...` for workspace-scoped data。 +- Links must include the route `workspaceId`; no hardcoded current workspace routes should remain as canonical links。 +- Scoped API mismatch must fail closed with sanitized typed diagnostics。 +- Runtime `/v1/...` API must remain unchanged。 +- Compatibility aliases must not become the frontend canonical path。 +- workspace id should be treated as immutable id, not slug/alias。 + +--- + + + +## State changed + +Queued acceptance recorded after Workspace Dashboard Queue notification authorized Orchestrator routing. + +Checked context: +- Ticket body / thread / artifacts。 +- `TicketRelationQuery(00001KWWE8E04)`: blocking relation 0 件。 +- `TicketOrchestrationPlanQuery(00001KWWE8E04)`: prior record 0 件。今回 accepted_plan を記録済み。 +- Orchestrator worktree git status: clean on `orchestration`。 +- queued Ticket はこの Ticket 1件のみ。inprogress は 0 件。 +- visible Pods / TicketDoctor / bounded code map を確認。 + +Acceptance basis: +- concrete missing decision / information は残っていない。 +- Ticket の scope は Browser route/API workspace-id scoping に閉じており、multi-workspace DB migration / slug/alias / Runtime `/v1` scope change は非目標として明確。 +- side effect はこの `queued -> inprogress` acceptance 後に、worktree-workflow に沿って implementation worktree を作成してから開始する。 + --- From ab33c30d7cc67f30283d1ebfc6b63616e0365bf6 Mon Sep 17 00:00:00 2001 From: Hare Date: Tue, 7 Jul 2026 04:55:32 +0900 Subject: [PATCH 2/9] ticket: route workspace id scoping coder --- .yoi/tickets/00001KWWE8E04/item.md | 2 +- .yoi/tickets/00001KWWE8E04/thread.md | 17 +++++++++++++++++ 2 files changed, 18 insertions(+), 1 deletion(-) diff --git a/.yoi/tickets/00001KWWE8E04/item.md b/.yoi/tickets/00001KWWE8E04/item.md index 2e531925..745cce5a 100644 --- a/.yoi/tickets/00001KWWE8E04/item.md +++ b/.yoi/tickets/00001KWWE8E04/item.md @@ -2,7 +2,7 @@ title: 'Scope Workspace Browser routes and API by workspace id' state: 'inprogress' created_at: '2026-07-06T19:25:08Z' -updated_at: '2026-07-06T19:54:30Z' +updated_at: '2026-07-06T19:55:26Z' assignee: null queued_by: 'workspace-panel' queued_at: '2026-07-06T19:53:14Z' diff --git a/.yoi/tickets/00001KWWE8E04/thread.md b/.yoi/tickets/00001KWWE8E04/thread.md index 4f125f94..fc6edef7 100644 --- a/.yoi/tickets/00001KWWE8E04/thread.md +++ b/.yoi/tickets/00001KWWE8E04/thread.md @@ -137,3 +137,20 @@ Acceptance basis: - side effect はこの `queued -> inprogress` acceptance 後に、worktree-workflow に沿って implementation worktree を作成してから開始する。 --- + + + +## Implementation report + +Implementation routing update: + +- Worktree-workflow に従い implementation worktree を作成した。 + - Worktree: `/home/hare/Projects/yoi/.worktree/00001KWWE8E04-workspace-id-routes` + - Branch: `work/00001KWWE8E04-workspace-id-routes` +- Worktree には tracked `.yoi` project records が見えている。 +- `.yoi/memory` / `.yoi/runtime` / `.yoi/log` / `.yoi/logs` / `.yoi/local` / `.yoi/*.lock` / `.yoi/*secret*` は作成直後に存在しないことを確認した。 +- Sibling Coder Pod `yoi-coder-00001KWWE8E04-workspace-routes` を起動した。 +- Scope policy: runtime workspace root は read-only、implementation worktree は write 可。Coder task では root/original workspace での read/write/validation/git operation を禁止し、この implementation worktree だけを作業対象に指定した。 +- 完了後は diff / validation evidence を Orchestrator が確認し、別 sibling Reviewer Pod に read-only review を依頼する。`StopPod` は既知の不具合があるため使用しない。 + +--- From f6ad9cfcd3c4705e6bafc0a1d6333db6e8e5df1c Mon Sep 17 00:00:00 2001 From: Hare Date: Tue, 7 Jul 2026 05:26:03 +0900 Subject: [PATCH 3/9] feat: scope workspace routes by id --- crates/workspace-server/src/lib.rs | 2 + crates/workspace-server/src/server.rs | 546 +++++++++++++++++- web/workspace/deno.json | 2 +- .../src/lib/workspace-api/http.test.ts | 22 + web/workspace/src/lib/workspace-api/http.ts | 13 + .../src/lib/workspace-console/model.test.ts | 4 +- .../src/lib/workspace-console/model.ts | 24 +- .../worker-console.ui.test.ts | 22 +- .../ObjectivesNavSection.svelte | 8 +- .../RepositoriesNavSection.svelte | 5 +- .../WorkersNavSection.svelte | 16 +- .../workspace-sidebar/WorkspaceSidebar.svelte | 12 +- .../workspace-sidebar/repository-nav.test.ts | 7 +- .../lib/workspace-sidebar/repository-nav.ts | 6 +- web/workspace/src/routes/+layout.ts | 12 +- web/workspace/src/routes/+page.svelte | 3 +- web/workspace/src/routes/+page.ts | 12 +- .../src/routes/objectives/+page.svelte | 4 +- web/workspace/src/routes/objectives/+page.ts | 10 +- .../objectives/[objectiveId]/+page.svelte | 4 +- .../routes/objectives/[objectiveId]/+page.ts | 17 +- .../repositories/[repositoryId]/+page.ts | 13 +- .../workers/[workerId]/console/+page.svelte | 22 +- .../workers/[workerId]/console/+page.ts | 10 +- .../src/routes/settings/+page.svelte | 21 +- .../src/routes/w/[workspaceId]/+page.svelte | 133 +++++ .../src/routes/w/[workspaceId]/+page.ts | 19 + .../w/[workspaceId]/objectives/+page.svelte | 46 ++ .../w/[workspaceId]/objectives/+page.ts | 17 + .../objectives/[objectiveId]/+page.svelte | 76 +++ .../objectives/[objectiveId]/+page.ts | 27 + .../repositories/[repositoryId]/+page.svelte | 105 ++++ .../repositories/[repositoryId]/+page.ts | 36 ++ .../workers/[workerId]/console/+page.svelte | 399 +++++++++++++ .../workers/[workerId]/console/+page.ts | 9 + .../w/[workspaceId]/settings/+page.svelte | 487 ++++++++++++++++ 36 files changed, 2082 insertions(+), 89 deletions(-) create mode 100644 web/workspace/src/lib/workspace-api/http.test.ts create mode 100644 web/workspace/src/routes/w/[workspaceId]/+page.svelte create mode 100644 web/workspace/src/routes/w/[workspaceId]/+page.ts create mode 100644 web/workspace/src/routes/w/[workspaceId]/objectives/+page.svelte create mode 100644 web/workspace/src/routes/w/[workspaceId]/objectives/+page.ts create mode 100644 web/workspace/src/routes/w/[workspaceId]/objectives/[objectiveId]/+page.svelte create mode 100644 web/workspace/src/routes/w/[workspaceId]/objectives/[objectiveId]/+page.ts create mode 100644 web/workspace/src/routes/w/[workspaceId]/repositories/[repositoryId]/+page.svelte create mode 100644 web/workspace/src/routes/w/[workspaceId]/repositories/[repositoryId]/+page.ts create mode 100644 web/workspace/src/routes/w/[workspaceId]/runtimes/[runtimeId]/workers/[workerId]/console/+page.svelte create mode 100644 web/workspace/src/routes/w/[workspaceId]/runtimes/[runtimeId]/workers/[workerId]/console/+page.ts create mode 100644 web/workspace/src/routes/w/[workspaceId]/settings/+page.svelte diff --git a/crates/workspace-server/src/lib.rs b/crates/workspace-server/src/lib.rs index ad3dfc4b..d279a8d2 100644 --- a/crates/workspace-server/src/lib.rs +++ b/crates/workspace-server/src/lib.rs @@ -71,6 +71,8 @@ pub enum Error { }, #[error("unknown local repository `{0}`")] UnknownRepository(String), + #[error("workspace id does not match this Workspace backend")] + WorkspaceIdMismatch, #[error("workspace identity error: {0}")] WorkspaceIdentity(String), #[error("store error: {0}")] diff --git a/crates/workspace-server/src/server.rs b/crates/workspace-server/src/server.rs index 7e266f3a..9ff23033 100644 --- a/crates/workspace-server/src/server.rs +++ b/crates/workspace-server/src/server.rs @@ -221,84 +221,193 @@ impl WorkspaceApi { pub fn build_router(api: WorkspaceApi) -> Router { Router::new() .route("/api/workspace", get(get_workspace)) + .route("/api/w/{workspace_id}/workspace", get(scoped_get_workspace)) .route("/api/tickets", get(list_tickets)) + .route("/api/w/{workspace_id}/tickets", get(scoped_list_tickets)) .route("/api/tickets/{id}", get(get_ticket)) + .route("/api/w/{workspace_id}/tickets/{id}", get(scoped_get_ticket)) .route("/api/objectives", get(list_objectives)) + .route( + "/api/w/{workspace_id}/objectives", + get(scoped_list_objectives), + ) .route("/api/objectives/{id}", get(get_objective)) + .route( + "/api/w/{workspace_id}/objectives/{id}", + get(scoped_get_objective), + ) .route("/api/repositories", get(list_repositories)) + .route( + "/api/w/{workspace_id}/repositories", + get(scoped_list_repositories), + ) .route("/api/repositories/{repository_id}", get(repository_detail)) + .route( + "/api/w/{workspace_id}/repositories/{repository_id}", + get(scoped_repository_detail), + ) .route("/api/repositories/{repository_id}/log", get(repository_log)) + .route( + "/api/w/{workspace_id}/repositories/{repository_id}/log", + get(scoped_repository_log), + ) .route( "/api/repositories/{repository_id}/tickets", get(repository_tickets), ) + .route( + "/api/w/{workspace_id}/repositories/{repository_id}/tickets", + get(scoped_repository_tickets), + ) .route("/api/hosts", get(list_hosts)) + .route("/api/w/{workspace_id}/hosts", get(scoped_list_hosts)) .route("/api/runtimes", get(list_runtimes)) + .route("/api/w/{workspace_id}/runtimes", get(scoped_list_runtimes)) .route( "/api/workers", get(list_workers).post(create_workspace_worker), ) + .route( + "/api/w/{workspace_id}/workers", + get(scoped_list_workers).post(scoped_create_workspace_worker), + ) .route( "/api/workers/launch-options", get(get_worker_launch_options), ) + .route( + "/api/w/{workspace_id}/workers/launch-options", + get(scoped_get_worker_launch_options), + ) .route( "/api/settings/runtime-connections", get(get_runtime_connection_settings), ) + .route( + "/api/w/{workspace_id}/settings/runtime-connections", + get(scoped_get_runtime_connection_settings), + ) .route( "/api/settings/runtime-connections/remotes", post(add_remote_runtime_connection), ) + .route( + "/api/w/{workspace_id}/settings/runtime-connections/remotes", + post(scoped_add_remote_runtime_connection), + ) .route( "/api/settings/runtime-connections/remotes/{runtime_id}", delete(delete_remote_runtime_connection), ) + .route( + "/api/w/{workspace_id}/settings/runtime-connections/remotes/{runtime_id}", + delete(scoped_delete_remote_runtime_connection), + ) .route( "/api/settings/runtime-connections/remotes/{runtime_id}/test", post(test_remote_runtime_connection), ) + .route( + "/api/w/{workspace_id}/settings/runtime-connections/remotes/{runtime_id}/test", + post(scoped_test_remote_runtime_connection), + ) .route("/api/companion/status", get(get_companion_status)) + .route( + "/api/w/{workspace_id}/companion/status", + get(scoped_get_companion_status), + ) .route("/api/companion/transcript", get(get_companion_transcript)) + .route( + "/api/w/{workspace_id}/companion/transcript", + get(scoped_get_companion_transcript), + ) .route("/api/companion/messages", post(post_companion_message)) + .route( + "/api/w/{workspace_id}/companion/messages", + post(scoped_post_companion_message), + ) .route("/api/companion/cancel", post(post_companion_cancel)) + .route( + "/api/w/{workspace_id}/companion/cancel", + post(scoped_post_companion_cancel), + ) .route( "/api/runtimes/{runtime_id}/workers", post(create_runtime_worker), ) + .route( + "/api/w/{workspace_id}/runtimes/{runtime_id}/workers", + post(scoped_create_runtime_worker), + ) .route( "/api/runtimes/{runtime_id}/config-bundles", post(sync_runtime_config_bundle), ) + .route( + "/api/w/{workspace_id}/runtimes/{runtime_id}/config-bundles", + post(scoped_sync_runtime_config_bundle), + ) .route( "/api/runtimes/{runtime_id}/config-bundles/{bundle_id}/availability", get(check_runtime_config_bundle), ) + .route( + "/api/w/{workspace_id}/runtimes/{runtime_id}/config-bundles/{bundle_id}/availability", + get(scoped_check_runtime_config_bundle), + ) .route( "/api/runtimes/{runtime_id}/workers/{worker_id}", get(get_runtime_worker), ) + .route( + "/api/w/{workspace_id}/runtimes/{runtime_id}/workers/{worker_id}", + get(scoped_get_runtime_worker), + ) .route( "/api/runtimes/{runtime_id}/workers/{worker_id}/input", post(send_runtime_worker_input), ) + .route( + "/api/w/{workspace_id}/runtimes/{runtime_id}/workers/{worker_id}/input", + post(scoped_send_runtime_worker_input), + ) .route( "/api/runtimes/{runtime_id}/workers/{worker_id}/stop", post(stop_runtime_worker), ) + .route( + "/api/w/{workspace_id}/runtimes/{runtime_id}/workers/{worker_id}/stop", + post(scoped_stop_runtime_worker), + ) .route( "/api/runtimes/{runtime_id}/workers/{worker_id}/cancel", post(cancel_runtime_worker), ) + .route( + "/api/w/{workspace_id}/runtimes/{runtime_id}/workers/{worker_id}/cancel", + post(scoped_cancel_runtime_worker), + ) .route( "/api/runtimes/{runtime_id}/workers/{worker_id}/transcript", get(get_runtime_worker_transcript), ) + .route( + "/api/w/{workspace_id}/runtimes/{runtime_id}/workers/{worker_id}/transcript", + get(scoped_get_runtime_worker_transcript), + ) .route( "/api/runtimes/{runtime_id}/workers/{worker_id}/events/ws", get(worker_observation_ws), ) + .route( + "/api/w/{workspace_id}/runtimes/{runtime_id}/workers/{worker_id}/events/ws", + get(scoped_worker_observation_ws), + ) .route("/api/hosts/{host_id}/workers", get(list_host_workers)) + .route( + "/api/w/{workspace_id}/hosts/{host_id}/workers", + get(scoped_list_host_workers), + ) .fallback(get(static_or_spa_fallback)) .with_state(api) } @@ -522,6 +631,363 @@ struct TranscriptQuery { limit: Option, } +#[derive(Debug, Deserialize)] +struct ScopedWorkspacePath { + workspace_id: String, +} + +#[derive(Debug, Deserialize)] +struct ScopedRecordPath { + workspace_id: String, + id: String, +} + +#[derive(Debug, Deserialize)] +struct ScopedRepositoryPath { + workspace_id: String, + repository_id: String, +} + +#[derive(Debug, Deserialize)] +struct ScopedHostPath { + workspace_id: String, + host_id: String, +} + +#[derive(Debug, Deserialize)] +struct ScopedRuntimePath { + workspace_id: String, + runtime_id: String, +} + +#[derive(Debug, Deserialize)] +struct ScopedConfigBundlePath { + workspace_id: String, + runtime_id: String, + bundle_id: String, +} + +#[derive(Debug, Deserialize)] +struct ScopedRuntimeWorkerPath { + workspace_id: String, + runtime_id: String, + worker_id: String, +} + +fn validate_workspace_scope(api: &WorkspaceApi, workspace_id: &str) -> ApiResult<()> { + if workspace_id == api.workspace_id() { + Ok(()) + } else { + Err(workspace_id_mismatch_error()) + } +} + +async fn scoped_get_workspace( + State(api): State, + AxumPath(path): AxumPath, +) -> ApiResult> { + validate_workspace_scope(&api, &path.workspace_id)?; + get_workspace(State(api)).await +} + +async fn scoped_list_tickets( + State(api): State, + AxumPath(path): AxumPath, +) -> ApiResult>> { + validate_workspace_scope(&api, &path.workspace_id)?; + list_tickets(State(api)).await +} + +async fn scoped_get_ticket( + State(api): State, + AxumPath(path): AxumPath, +) -> ApiResult> { + validate_workspace_scope(&api, &path.workspace_id)?; + get_ticket(State(api), AxumPath(path.id)).await +} + +async fn scoped_list_objectives( + State(api): State, + AxumPath(path): AxumPath, +) -> ApiResult>> { + validate_workspace_scope(&api, &path.workspace_id)?; + list_objectives(State(api)).await +} + +async fn scoped_get_objective( + State(api): State, + AxumPath(path): AxumPath, +) -> ApiResult> { + validate_workspace_scope(&api, &path.workspace_id)?; + get_objective(State(api), AxumPath(path.id)).await +} + +async fn scoped_list_repositories( + State(api): State, + AxumPath(path): AxumPath, +) -> ApiResult> { + validate_workspace_scope(&api, &path.workspace_id)?; + list_repositories(State(api)).await +} + +async fn scoped_repository_detail( + State(api): State, + AxumPath(path): AxumPath, +) -> ApiResult> { + validate_workspace_scope(&api, &path.workspace_id)?; + repository_detail(State(api), AxumPath(path.repository_id)).await +} + +async fn scoped_repository_log( + State(api): State, + AxumPath(path): AxumPath, + Query(query): Query, +) -> ApiResult> { + validate_workspace_scope(&api, &path.workspace_id)?; + repository_log(State(api), AxumPath(path.repository_id), Query(query)).await +} + +async fn scoped_repository_tickets( + State(api): State, + AxumPath(path): AxumPath, + Query(query): Query, +) -> ApiResult> { + validate_workspace_scope(&api, &path.workspace_id)?; + repository_tickets(State(api), AxumPath(path.repository_id), Query(query)).await +} + +async fn scoped_list_hosts( + State(api): State, + AxumPath(path): AxumPath, +) -> ApiResult>> { + validate_workspace_scope(&api, &path.workspace_id)?; + list_hosts(State(api)).await +} + +async fn scoped_list_runtimes( + State(api): State, + AxumPath(path): AxumPath, +) -> ApiResult>> { + validate_workspace_scope(&api, &path.workspace_id)?; + list_runtimes(State(api)).await +} + +async fn scoped_list_workers( + State(api): State, + AxumPath(path): AxumPath, +) -> ApiResult>> { + validate_workspace_scope(&api, &path.workspace_id)?; + list_workers(State(api)).await +} + +async fn scoped_create_workspace_worker( + State(api): State, + AxumPath(path): AxumPath, + Json(request): Json, +) -> ApiResult> { + validate_workspace_scope(&api, &path.workspace_id)?; + create_workspace_worker(State(api), Json(request)).await +} + +async fn scoped_get_worker_launch_options( + State(api): State, + AxumPath(path): AxumPath, +) -> ApiResult> { + validate_workspace_scope(&api, &path.workspace_id)?; + get_worker_launch_options(State(api)).await +} + +async fn scoped_get_runtime_connection_settings( + State(api): State, + AxumPath(path): AxumPath, +) -> ApiResult> { + validate_workspace_scope(&api, &path.workspace_id)?; + get_runtime_connection_settings(State(api)).await +} + +async fn scoped_add_remote_runtime_connection( + State(api): State, + AxumPath(path): AxumPath, + Json(request): Json, +) -> ApiResult> { + validate_workspace_scope(&api, &path.workspace_id)?; + add_remote_runtime_connection(State(api), Json(request)).await +} + +async fn scoped_delete_remote_runtime_connection( + State(api): State, + AxumPath(path): AxumPath, +) -> ApiResult> { + validate_workspace_scope(&api, &path.workspace_id)?; + delete_remote_runtime_connection(State(api), AxumPath(path.runtime_id)).await +} + +async fn scoped_test_remote_runtime_connection( + State(api): State, + AxumPath(path): AxumPath, +) -> ApiResult> { + validate_workspace_scope(&api, &path.workspace_id)?; + test_remote_runtime_connection(State(api), AxumPath(path.runtime_id)).await +} + +async fn scoped_get_companion_status( + State(api): State, + AxumPath(path): AxumPath, +) -> ApiResult> { + validate_workspace_scope(&api, &path.workspace_id)?; + get_companion_status(State(api)).await +} + +async fn scoped_get_companion_transcript( + State(api): State, + AxumPath(path): AxumPath, + Query(query): Query, +) -> ApiResult> { + validate_workspace_scope(&api, &path.workspace_id)?; + get_companion_transcript(State(api), Query(query)).await +} + +async fn scoped_post_companion_message( + State(api): State, + AxumPath(path): AxumPath, + Json(request): Json, +) -> ApiResult> { + validate_workspace_scope(&api, &path.workspace_id)?; + post_companion_message(State(api), Json(request)).await +} + +async fn scoped_post_companion_cancel( + State(api): State, + AxumPath(path): AxumPath, + Json(request): Json, +) -> ApiResult> { + validate_workspace_scope(&api, &path.workspace_id)?; + post_companion_cancel(State(api), Json(request)).await +} + +async fn scoped_create_runtime_worker( + State(api): State, + AxumPath(path): AxumPath, + Json(request): Json, +) -> ApiResult> { + validate_workspace_scope(&api, &path.workspace_id)?; + create_runtime_worker(State(api), AxumPath(path.runtime_id), Json(request)).await +} + +async fn scoped_sync_runtime_config_bundle( + State(api): State, + AxumPath(path): AxumPath, + Json(request): Json, +) -> ApiResult> { + validate_workspace_scope(&api, &path.workspace_id)?; + sync_runtime_config_bundle(State(api), AxumPath(path.runtime_id), Json(request)).await +} + +async fn scoped_check_runtime_config_bundle( + State(api): State, + AxumPath(path): AxumPath, + Query(query): Query, +) -> ApiResult> { + validate_workspace_scope(&api, &path.workspace_id)?; + check_runtime_config_bundle( + State(api), + AxumPath((path.runtime_id, path.bundle_id)), + Query(query), + ) + .await +} + +async fn scoped_get_runtime_worker( + State(api): State, + AxumPath(path): AxumPath, +) -> ApiResult> { + validate_workspace_scope(&api, &path.workspace_id)?; + get_runtime_worker(State(api), AxumPath((path.runtime_id, path.worker_id))).await +} + +async fn scoped_send_runtime_worker_input( + State(api): State, + AxumPath(path): AxumPath, + Json(request): Json, +) -> ApiResult> { + validate_workspace_scope(&api, &path.workspace_id)?; + send_runtime_worker_input( + State(api), + AxumPath((path.runtime_id, path.worker_id)), + Json(request), + ) + .await +} + +async fn scoped_stop_runtime_worker( + State(api): State, + AxumPath(path): AxumPath, + Json(request): Json, +) -> ApiResult> { + validate_workspace_scope(&api, &path.workspace_id)?; + stop_runtime_worker( + State(api), + AxumPath((path.runtime_id, path.worker_id)), + Json(request), + ) + .await +} + +async fn scoped_cancel_runtime_worker( + State(api): State, + AxumPath(path): AxumPath, + Json(request): Json, +) -> ApiResult> { + validate_workspace_scope(&api, &path.workspace_id)?; + cancel_runtime_worker( + State(api), + AxumPath((path.runtime_id, path.worker_id)), + Json(request), + ) + .await +} + +async fn scoped_get_runtime_worker_transcript( + State(api): State, + AxumPath(path): AxumPath, + Query(query): Query, +) -> ApiResult> { + validate_workspace_scope(&api, &path.workspace_id)?; + get_runtime_worker_transcript( + State(api), + AxumPath((path.runtime_id, path.worker_id)), + Query(query), + ) + .await +} + +async fn scoped_worker_observation_ws( + ws: WebSocketUpgrade, + State(api): State, + AxumPath(path): AxumPath, + Query(query): Query, +) -> Response { + if let Err(err) = validate_workspace_scope(&api, &path.workspace_id) { + return err.into_response(); + } + worker_observation_ws( + State(api), + AxumPath((path.runtime_id, path.worker_id)), + Query(query), + ws, + ) + .await + .into_response() +} + +async fn scoped_list_host_workers( + State(api): State, + AxumPath(path): AxumPath, +) -> ApiResult>> { + validate_workspace_scope(&api, &path.workspace_id)?; + list_host_workers(State(api), AxumPath(path.host_id)).await +} + async fn get_workspace(State(api): State) -> ApiResult> { let schema_version = api.store.schema_version().await?; let stored = api.store.get_workspace(api.workspace_id()).await?; @@ -1048,13 +1514,15 @@ async fn create_workspace_worker( })?; let runtime_id = worker.runtime_id.clone(); let worker_id = worker.worker_id.clone(); + let workspace_id = api.workspace_id().to_string(); let console_href = format!( - "/runtimes/{}/workers/{}/console", + "/w/{}/runtimes/{}/workers/{}/console", + encode_path_segment(&workspace_id), encode_path_segment(&runtime_id), encode_path_segment(&worker_id) ); Ok(Json(BrowserCreateWorkerResponse { - workspace_id: api.config.workspace_id, + workspace_id, runtime_id, worker_id, console_href, @@ -2263,6 +2731,12 @@ async fn static_or_spa_fallback(State(api): State, uri: Uri) -> Re .into_response(); } + if let Some(workspace_id) = workspace_id_from_ui_path(uri.path()) { + if workspace_id != api.workspace_id() { + return workspace_id_mismatch_error().into_response(); + } + } + let Some(static_root) = api.config.static_assets_dir.as_ref() else { return StatusCode::NOT_FOUND.into_response(); }; @@ -2279,6 +2753,16 @@ async fn static_or_spa_fallback(State(api): State, uri: Uri) -> Re } } +fn workspace_id_from_ui_path(path: &str) -> Option<&str> { + let tail = path.strip_prefix("/w/")?; + let workspace_id = tail.split('/').next().unwrap_or_default(); + if workspace_id.is_empty() { + None + } else { + Some(workspace_id) + } +} + struct StaticAsset { bytes: Vec, content_type: &'static str, @@ -2337,6 +2821,18 @@ fn content_type_for(path: &Path) -> &'static str { type ApiResult = std::result::Result; +fn workspace_id_mismatch_error() -> ApiError { + let message = "workspace id does not match this Workspace backend".to_string(); + ApiError::with_diagnostics( + Error::WorkspaceIdMismatch, + vec![RuntimeDiagnostic { + code: "workspace_id_mismatch".to_string(), + severity: DiagnosticSeverity::Error, + message, + }], + ) +} + struct ApiError { error: Error, diagnostics: Vec, @@ -2366,7 +2862,8 @@ impl IntoResponse for ApiError { | Error::UnknownHost(_) | Error::UnknownRuntime(_) | Error::UnknownWorker { .. } - | Error::UnknownRepository(_) => StatusCode::NOT_FOUND, + | Error::UnknownRepository(_) + | Error::WorkspaceIdMismatch => StatusCode::NOT_FOUND, Error::Ticket(_) => StatusCode::NOT_FOUND, Error::RuntimeCapabilityUnsupported { .. } => StatusCode::NOT_IMPLEMENTED, Error::RuntimeOperationFailed { code, .. } if code == "repository_not_configured" => { @@ -3076,6 +3573,31 @@ mod tests { ); } + let scoped_workspace = get_json( + app.clone(), + &format!("/api/w/{TEST_WORKSPACE_ID}/workspace"), + ) + .await; + assert_eq!(scoped_workspace["workspace_id"], TEST_WORKSPACE_ID); + + let mismatched_workspace = request_json( + app.clone(), + "GET", + "/api/w/not-this-workspace/workspace", + None, + StatusCode::NOT_FOUND, + ) + .await; + assert_eq!( + mismatched_workspace["diagnostics"][0]["code"], + "workspace_id_mismatch" + ); + assert!( + !mismatched_workspace + .to_string() + .contains(dir.path().to_string_lossy().as_ref()) + ); + let tickets = get_json(app.clone(), "/api/tickets").await; assert_eq!(tickets["items"][0]["id"], "00000000001J2"); assert_eq!(tickets["items"][0]["state"], "ready"); @@ -3083,6 +3605,18 @@ mod tests { let objectives = get_json(app.clone(), "/api/objectives").await; assert_eq!(objectives["items"][0]["id"], "00000000001J3"); assert_eq!(objectives["items"][0]["summary"], "Objective body."); + let scoped_objectives = get_json( + app.clone(), + &format!("/api/w/{TEST_WORKSPACE_ID}/objectives"), + ) + .await; + assert_eq!(scoped_objectives["items"][0]["id"], "00000000001J3"); + let scoped_objective = get_json( + app.clone(), + &format!("/api/w/{TEST_WORKSPACE_ID}/objectives/00000000001J3"), + ) + .await; + assert_eq!(scoped_objective["id"], "00000000001J3"); let repositories = get_json(app.clone(), "/api/repositories").await; assert_eq!(repositories["items"][0]["id"], TEST_REPOSITORY_ID); @@ -3099,6 +3633,12 @@ mod tests { let repository_detail = get_json(app.clone(), "/api/repositories/main").await; assert_eq!(repository_detail["item"]["id"], TEST_REPOSITORY_ID); + let scoped_repository_detail = get_json( + app.clone(), + &format!("/api/w/{TEST_WORKSPACE_ID}/repositories/main"), + ) + .await; + assert_eq!(scoped_repository_detail["item"]["id"], TEST_REPOSITORY_ID); let repository_log = get_json(app.clone(), "/api/repositories/main/log?limit=3").await; assert_eq!(repository_log["repository_id"], TEST_REPOSITORY_ID); diff --git a/web/workspace/deno.json b/web/workspace/deno.json index ae8656b4..0511dfa3 100644 --- a/web/workspace/deno.json +++ b/web/workspace/deno.json @@ -6,7 +6,7 @@ "dev": "deno run -A npm:vite@7.2.7 dev", "dev:backend": "cd ../.. && cargo run -p yoi-workspace-server -- serve --workspace . --db .yoi/workspace.db --listen 127.0.0.1:8787", "check": "deno run -A npm:@sveltejs/kit@2.49.4 sync && deno run -A npm:svelte-check@4.3.4 --tsconfig ./tsconfig.json", - "test": "deno test --allow-read=src src/lib/workspace-console/model.test.ts src/lib/workspace-console/worker-console.ui.test.ts src/lib/workspace-settings/model.test.ts src/lib/workspace-sidebar/worker-launch.test.ts src/lib/workspace-sidebar/repository-nav.test.ts", + "test": "deno test --allow-read=src src/lib/workspace-api/http.test.ts src/lib/workspace-console/model.test.ts src/lib/workspace-console/worker-console.ui.test.ts src/lib/workspace-settings/model.test.ts src/lib/workspace-sidebar/worker-launch.test.ts src/lib/workspace-sidebar/repository-nav.test.ts", "build": "deno run -A npm:vite@7.2.7 build", "preview": "deno run -A npm:vite@7.2.7 preview" }, diff --git a/web/workspace/src/lib/workspace-api/http.test.ts b/web/workspace/src/lib/workspace-api/http.test.ts new file mode 100644 index 00000000..99f1d73e --- /dev/null +++ b/web/workspace/src/lib/workspace-api/http.test.ts @@ -0,0 +1,22 @@ +import { workspaceApiPath, workspaceRoute } from "./http.ts"; + +declare const Deno: { + test(name: string, fn: () => void): void; +}; + +function assertEquals(actual: T, expected: T): void { + const actualJson = JSON.stringify(actual); + const expectedJson = JSON.stringify(expected); + if (actualJson !== expectedJson) { + throw new Error(`Expected ${expectedJson}, got ${actualJson}`); + } +} + +Deno.test("workspace route helpers scope browser routes and API by immutable workspace id", () => { + assertEquals(workspaceRoute("workspace 1"), "/w/workspace%201"); + assertEquals(workspaceRoute("workspace 1", "/objectives"), "/w/workspace%201/objectives"); + assertEquals( + workspaceApiPath("workspace 1", "/repositories/repo-a"), + "/api/w/workspace%201/repositories/repo-a", + ); +}); diff --git a/web/workspace/src/lib/workspace-api/http.ts b/web/workspace/src/lib/workspace-api/http.ts index 3f3573c8..92365eae 100644 --- a/web/workspace/src/lib/workspace-api/http.ts +++ b/web/workspace/src/lib/workspace-api/http.ts @@ -3,6 +3,19 @@ export type ApiResult = { error: string | null; }; +function normalizePath(path: string): string { + if (!path || path === '/') return ''; + return path.startsWith('/') ? path : `/${path}`; +} + +export function workspaceRoute(workspaceId: string, path = ''): string { + return `/w/${encodeURIComponent(workspaceId)}${normalizePath(path)}`; +} + +export function workspaceApiPath(workspaceId: string, path = ''): string { + return `/api/w/${encodeURIComponent(workspaceId)}${normalizePath(path)}`; +} + export async function loadJson( fetchFn: typeof fetch, path: string, diff --git a/web/workspace/src/lib/workspace-console/model.test.ts b/web/workspace/src/lib/workspace-console/model.test.ts index a918643a..42eaf18f 100644 --- a/web/workspace/src/lib/workspace-console/model.test.ts +++ b/web/workspace/src/lib/workspace-console/model.test.ts @@ -24,8 +24,8 @@ Deno.test("workerConsoleHref encodes runtime and worker target authority", () => workerConsoleHref({ runtime_id: "local runtime", worker_id: "worker/one", - }) === - "/runtimes/local%20runtime/workers/worker%2Fone/console", + }, "workspace-1") === + "/w/workspace-1/runtimes/local%20runtime/workers/worker%2Fone/console", "href should contain encoded runtime_id and worker_id segments", ); }); diff --git a/web/workspace/src/lib/workspace-console/model.ts b/web/workspace/src/lib/workspace-console/model.ts index d95d1feb..489c5169 100644 --- a/web/workspace/src/lib/workspace-console/model.ts +++ b/web/workspace/src/lib/workspace-console/model.ts @@ -4,6 +4,7 @@ import type { Segment, } from "$lib/generated/protocol"; import type { WorkerTranscriptItem } from "$lib/workspace-sidebar/types"; +import { workspaceRoute } from "$lib/workspace-api/http"; export type ConsoleLineKind = | "user" @@ -40,16 +41,23 @@ export type WorkerTarget = { worker_id: string; }; -export function workerConsoleHref(target: WorkerTarget): string { - return `/runtimes/${encodeURIComponent(target.runtime_id)}/workers/${ - encodeURIComponent( - target.worker_id, - ) - }/console`; +export function workerConsoleHref(target: WorkerTarget, workspaceId: string): string { + return workspaceRoute( + workspaceId, + `/runtimes/${encodeURIComponent(target.runtime_id)}/workers/${ + encodeURIComponent( + target.worker_id, + ) + }/console`, + ); } -export function workerConsolePath(runtimeId: string, workerId: string): string { - return workerConsoleHref({ runtime_id: runtimeId, worker_id: workerId }); +export function workerConsolePath( + workspaceId: string, + runtimeId: string, + workerId: string, +): string { + return workerConsoleHref({ runtime_id: runtimeId, worker_id: workerId }, workspaceId); } export function initialConsoleLines(items: WorkerTranscriptItem[]): ConsoleLine[] { diff --git a/web/workspace/src/lib/workspace-console/worker-console.ui.test.ts b/web/workspace/src/lib/workspace-console/worker-console.ui.test.ts index 2bf86df6..a688f57f 100644 --- a/web/workspace/src/lib/workspace-console/worker-console.ui.test.ts +++ b/web/workspace/src/lib/workspace-console/worker-console.ui.test.ts @@ -21,12 +21,12 @@ Deno.test("workspace Worker list and sidebar attach through Worker Console hrefs ); assert( - workspacePage.includes("workerConsoleHref(worker)") && + workspacePage.includes("workerConsoleHref(worker, workspaceId)") && workspacePage.includes("Open Console"), "top Worker list should expose an attach action per Worker", ); assert( - workersNav.includes("workerConsoleHref(worker)") && + workersNav.includes("workerConsoleHref(worker, workspaceId)") && workersNav.includes("aria-current"), "Workers sidebar rows should link to the Worker target Console route", ); @@ -40,26 +40,28 @@ Deno.test("workspace Worker list and sidebar attach through Worker Console hrefs Deno.test("Worker Console page is routed by runtime_id and worker_id through backend APIs", async () => { const consolePage = await Deno.readTextFile( new URL( - "./../../routes/runtimes/[runtimeId]/workers/[workerId]/console/+page.svelte", + "./../../routes/w/[workspaceId]/runtimes/[runtimeId]/workers/[workerId]/console/+page.svelte", import.meta.url, ), ); const routeLoad = await Deno.readTextFile( new URL( - "./../../routes/runtimes/[runtimeId]/workers/[workerId]/console/+page.ts", + "./../../routes/w/[workspaceId]/runtimes/[runtimeId]/workers/[workerId]/console/+page.ts", import.meta.url, ), ); assert( - routeLoad.includes("runtimeId") && routeLoad.includes("workerId"), - "route load should expose both target ids", + routeLoad.includes("workspaceId") && + routeLoad.includes("runtimeId") && routeLoad.includes("workerId"), + "route load should expose workspace and target ids", ); assert( - consolePage.includes( - "/api/runtimes/${encodeURIComponent(target.runtimeId)}/workers/${encodeURIComponent(target.workerId)}", - ), - "Worker detail should use the backend Worker detail API", + consolePage.includes("workspaceApiPath(workspaceId, path)") && + consolePage.includes( + "workerApiPath(`/runtimes/${encodeURIComponent(target.runtimeId)}/workers/${encodeURIComponent(target.workerId)}`)", + ), + "Worker detail should use the scoped backend Worker detail API", ); assert( consolePage.includes("/transcript?limit=200") && diff --git a/web/workspace/src/lib/workspace-sidebar/ObjectivesNavSection.svelte b/web/workspace/src/lib/workspace-sidebar/ObjectivesNavSection.svelte index 7052d95b..f0c3f204 100644 --- a/web/workspace/src/lib/workspace-sidebar/ObjectivesNavSection.svelte +++ b/web/workspace/src/lib/workspace-sidebar/ObjectivesNavSection.svelte @@ -1,9 +1,13 @@
@@ -11,7 +15,7 @@ Objectives - + Open Objectives workspace objectives diff --git a/web/workspace/src/lib/workspace-sidebar/RepositoriesNavSection.svelte b/web/workspace/src/lib/workspace-sidebar/RepositoriesNavSection.svelte index 2642eed3..63a9ebe8 100644 --- a/web/workspace/src/lib/workspace-sidebar/RepositoriesNavSection.svelte +++ b/web/workspace/src/lib/workspace-sidebar/RepositoriesNavSection.svelte @@ -6,10 +6,11 @@ repositories: RepositoryListResponse | null; repositoriesError?: string | null; currentPath?: string; + workspaceId: string; }; - let { repositories, repositoriesError = null, currentPath = '/' }: Props = $props(); - let navigation = $derived(projectRepositoryNav(repositories, currentPath)); + let { repositories, repositoriesError = null, currentPath = '/', workspaceId }: Props = $props(); + let navigation = $derived(projectRepositoryNav(repositories, currentPath, workspaceId));
diff --git a/web/workspace/src/lib/workspace-sidebar/WorkersNavSection.svelte b/web/workspace/src/lib/workspace-sidebar/WorkersNavSection.svelte index 613676c6..150f9459 100644 --- a/web/workspace/src/lib/workspace-sidebar/WorkersNavSection.svelte +++ b/web/workspace/src/lib/workspace-sidebar/WorkersNavSection.svelte @@ -1,4 +1,5 @@ diff --git a/web/workspace/src/lib/workspace-sidebar/repository-nav.test.ts b/web/workspace/src/lib/workspace-sidebar/repository-nav.test.ts index c87b28ea..e87d86df 100644 --- a/web/workspace/src/lib/workspace-sidebar/repository-nav.test.ts +++ b/web/workspace/src/lib/workspace-sidebar/repository-nav.test.ts @@ -36,7 +36,7 @@ Deno.test("repository nav does not invent main for an empty registry", () => { message: "No repositories configured", }, ], - }); + }, "/w/workspace-1", "workspace-1"); assertEquals(projection.count, 0); assertEquals(projection.items, []); @@ -56,14 +56,15 @@ Deno.test("repository nav links configured non-main repository ids", () => { diagnostics: [], }, ]), - "/repositories/infra", + "/w/workspace-1/repositories/infra", + "workspace-1", ); assertEquals(projection.count, 1); assertEquals(projection.items[0], { id: "infra", title: "Infrastructure", - href: "/repositories/infra", + href: "/w/workspace-1/repositories/infra", meta: "git repository · read-only", active: true, }); diff --git a/web/workspace/src/lib/workspace-sidebar/repository-nav.ts b/web/workspace/src/lib/workspace-sidebar/repository-nav.ts index a4057229..fb861367 100644 --- a/web/workspace/src/lib/workspace-sidebar/repository-nav.ts +++ b/web/workspace/src/lib/workspace-sidebar/repository-nav.ts @@ -1,3 +1,4 @@ +import { workspaceRoute } from "$lib/workspace-api/http"; import type { Diagnostic, RepositoryListResponse } from "./types"; export type RepositoryNavItem = { @@ -16,14 +17,15 @@ export type RepositoryNavProjection = { export function projectRepositoryNav( repositories: RepositoryListResponse | null, - currentPath = "/", + currentPath: string, + workspaceId: string, ): RepositoryNavProjection { const summaries = repositories?.items ?? []; return { count: summaries.length, diagnostics: repositories?.diagnostics ?? [], items: summaries.map((repository) => { - const href = `/repositories/${encodeURIComponent(repository.id)}`; + const href = workspaceRoute(workspaceId, `/repositories/${encodeURIComponent(repository.id)}`); return { id: repository.id, title: repository.display_name || repository.id, diff --git a/web/workspace/src/routes/+layout.ts b/web/workspace/src/routes/+layout.ts index cf187e8b..4fdaf406 100644 --- a/web/workspace/src/routes/+layout.ts +++ b/web/workspace/src/routes/+layout.ts @@ -1,4 +1,4 @@ -import { loadJson } from "$lib/workspace-api/http"; +import { loadJson, workspaceApiPath } from "$lib/workspace-api/http"; import type { RepositoryListResponse, WorkspaceResponse, @@ -8,10 +8,14 @@ import type { LayoutLoad } from "./$types"; export const ssr = false; export const prerender = false; -export const load: LayoutLoad = async ({ fetch }) => { +export const load: LayoutLoad = async ({ fetch, params }) => { + const workspaceId = params.workspaceId; + const apiPath = (path: string) => + workspaceId ? workspaceApiPath(workspaceId, path) : `/api${path}`; + const [workspace, repositories] = await Promise.all([ - loadJson(fetch, "/api/workspace"), - loadJson(fetch, "/api/repositories"), + loadJson(fetch, apiPath("/workspace")), + loadJson(fetch, apiPath("/repositories")), ]); return { diff --git a/web/workspace/src/routes/+page.svelte b/web/workspace/src/routes/+page.svelte index 9f1df537..34ca4a6a 100644 --- a/web/workspace/src/routes/+page.svelte +++ b/web/workspace/src/routes/+page.svelte @@ -3,6 +3,7 @@ import type { PageProps } from './$types'; let { data }: PageProps = $props(); + let workspaceId = $derived(data.workspace?.workspace_id ?? ''); @@ -116,7 +117,7 @@ {worker.state} · {worker.status} {worker.workspace.visibility} · {worker.workspace.identity} {worker.implementation.kind} - Open Console + Open Console {/each} diff --git a/web/workspace/src/routes/+page.ts b/web/workspace/src/routes/+page.ts index 0624eb86..9d2ca562 100644 --- a/web/workspace/src/routes/+page.ts +++ b/web/workspace/src/routes/+page.ts @@ -1,11 +1,15 @@ -import { loadJson } from "$lib/workspace-api/http"; +import { loadJson, workspaceApiPath } from "$lib/workspace-api/http"; import type { Host, ListResponse, Worker } from "$lib/workspace-sidebar/types"; import type { PageLoad } from "./$types"; -export const load: PageLoad = async ({ fetch }) => { +export const load: PageLoad = async ({ fetch, parent }) => { + const layout = await parent(); + const workspaceId = layout.workspace?.workspace_id ?? ""; + const apiPath = (path: string) => workspaceApiPath(workspaceId, path); + const [hosts, workers] = await Promise.all([ - loadJson>(fetch, "/api/hosts"), - loadJson>(fetch, "/api/workers"), + loadJson>(fetch, apiPath("/hosts")), + loadJson>(fetch, apiPath("/workers")), ]); return { diff --git a/web/workspace/src/routes/objectives/+page.svelte b/web/workspace/src/routes/objectives/+page.svelte index 5be8210d..088e66ec 100644 --- a/web/workspace/src/routes/objectives/+page.svelte +++ b/web/workspace/src/routes/objectives/+page.svelte @@ -1,5 +1,5 @@ + + + Yoi Workspace Control Plane + + + +
+

Workspace

+ {#if data.workspace} +
+
+
ID
+
{data.workspace.workspace_id}
+
+
+
Name
+
{data.workspace.display_name}
+
+
+
Record authority
+
{data.workspace.record_authority}
+
+
+
Host / Worker bridge
+
{data.workspace.extension_points.host_worker_bridge.status}
+
+
+ {:else if data.workspaceError} +

{data.workspaceError}

+ {:else} +

Waiting for /api/workspace…

+ {/if} +
+ +
+
+

Hosts

+ {#if data.hosts} + {#if data.hosts.items.length === 0} +

No local Hosts are visible.

+ {:else} +
+ {#each data.hosts.items as host} +
+
+ {host.label} + {host.status} +
+
+
+
ID
+
{host.host_id}
+
+
+
Kind
+
{host.kind}
+
+
+
Runtime
+
{host.runtime_id}
+
+
+
Scope
+
{host.capabilities.workspace_scope}
+
+
+
Platform
+
{host.capabilities.os} / {host.capabilities.arch}
+
+
+
+ {/each} +
+ {/if} + {:else if data.hostsError} +

{data.hostsError}

+ {:else} +

Waiting for /api/hosts…

+ {/if} +
+ +
+

Workers

+ {#if data.workers} + {#if data.workers.items.length === 0} +

No local Workers are visible.

+ {:else} +
+ + + + + + + + + + + + + {#each data.workers.items as worker} + + + + + + + + + {/each} + +
WorkerHostStateWorkspaceImplementationAttach
+ {worker.label} + {#if worker.role || worker.profile} + {worker.role ?? 'role unknown'} / {worker.profile ?? 'profile unknown'} + {/if} + {worker.host_id}{worker.state} · {worker.status}{worker.workspace.visibility} · {worker.workspace.identity}{worker.implementation.kind}Open Console
+
+ {/if} + {:else if data.workersError} +

{data.workersError}

+ {:else} +

Waiting for /api/workers…

+ {/if} +
+
diff --git a/web/workspace/src/routes/w/[workspaceId]/+page.ts b/web/workspace/src/routes/w/[workspaceId]/+page.ts new file mode 100644 index 00000000..c059d384 --- /dev/null +++ b/web/workspace/src/routes/w/[workspaceId]/+page.ts @@ -0,0 +1,19 @@ +import { loadJson, workspaceApiPath } from "$lib/workspace-api/http"; +import type { Host, ListResponse, Worker } from "$lib/workspace-sidebar/types"; +import type { PageLoad } from "./$types"; + +export const load: PageLoad = async ({ fetch, params }) => { + const apiPath = (path: string) => workspaceApiPath(params.workspaceId, path); + const [hosts, workers] = await Promise.all([ + loadJson>(fetch, apiPath("/hosts")), + loadJson>(fetch, apiPath("/workers")), + ]); + + return { + workspaceId: params.workspaceId, + hosts: hosts.data, + hostsError: hosts.error, + workers: workers.data, + workersError: workers.error, + }; +}; diff --git a/web/workspace/src/routes/w/[workspaceId]/objectives/+page.svelte b/web/workspace/src/routes/w/[workspaceId]/objectives/+page.svelte new file mode 100644 index 00000000..088e66ec --- /dev/null +++ b/web/workspace/src/routes/w/[workspaceId]/objectives/+page.svelte @@ -0,0 +1,46 @@ + + + + Objectives · Yoi Workspace + + +
+

Objectives

+

Objectives are read from canonical filesystem records through /api/objectives.

+ {#if data.objectives} + {#if data.objectives.items.length === 0} +

No Objective records are present.

+ {:else} +
+ {#each data.objectives.items as objective (objective.id)} + +
+
+ {objective.title} + {objective.state} +
+

{objective.summary || 'No summary text is available.'}

+
+
+ Updated {objective.updated_at ? formatDate(objective.updated_at) : 'unknown'} + {objective.linked_tickets?.length ? `${objective.linked_tickets.length} linked ticket(s)` : 'No linked tickets'} + {objective.id} +
+ + {/each} +
+ {/if} + {#if data.objectives.invalid_records.length > 0} +

{data.objectives.invalid_records.length} invalid objective record(s) hidden.

+ {/if} + {:else if data.objectivesError} +

{data.objectivesError}

+ {:else} +

Waiting for /api/objectives…

+ {/if} +
diff --git a/web/workspace/src/routes/w/[workspaceId]/objectives/+page.ts b/web/workspace/src/routes/w/[workspaceId]/objectives/+page.ts new file mode 100644 index 00000000..1e45b566 --- /dev/null +++ b/web/workspace/src/routes/w/[workspaceId]/objectives/+page.ts @@ -0,0 +1,17 @@ +import { loadJson, workspaceApiPath } from "$lib/workspace-api/http"; +import type { ObjectiveListResponse } from "$lib/workspace-sidebar/types"; +import type { PageLoad } from "./$types"; + +export const load: PageLoad = async ({ fetch, params }) => { + const apiPath = (path: string) => workspaceApiPath(params.workspaceId, path); + const objectives = await loadJson( + fetch, + apiPath("/objectives"), + ); + + return { + workspaceId: params.workspaceId, + objectives: objectives.data, + objectivesError: objectives.error, + }; +}; diff --git a/web/workspace/src/routes/w/[workspaceId]/objectives/[objectiveId]/+page.svelte b/web/workspace/src/routes/w/[workspaceId]/objectives/[objectiveId]/+page.svelte new file mode 100644 index 00000000..cf07c432 --- /dev/null +++ b/web/workspace/src/routes/w/[workspaceId]/objectives/[objectiveId]/+page.svelte @@ -0,0 +1,76 @@ + + + + {data.objective?.title ?? data.objectiveId} · Objective + + +
+

Objectives

+ {#if data.objectives} +
+ {#each data.objectives.items as objective (objective.id)} + +
+
+ {objective.title} + {objective.state} +
+

{objective.summary || 'No summary text is available.'}

+
+
+ Updated {objective.updated_at ? formatDate(objective.updated_at) : 'unknown'} + {objective.id} +
+ + {/each} +
+ {:else if data.objectivesError} +

{data.objectivesError}

+ {:else} +

Loading objectives…

+ {/if} +
+ +
+

Objective detail

+ {#if data.objective} +
+
+

{data.objective.title}

+

{data.objective.id}

+
+ {data.objective.state} +
+
+
+
Created
+
{data.objective.created_at ? formatDate(data.objective.created_at) : 'unknown'}
+
+
+
Updated
+
{data.objective.updated_at ? formatDate(data.objective.updated_at) : 'unknown'}
+
+
+
Record source
+
{data.objective.record_source}
+
+
+
Linked tickets
+
{data.objective.linked_tickets.length ? data.objective.linked_tickets.join(', ') : 'none'}
+
+
+ 
{data.objective.body}
+ {#if data.objective.body_truncated} +

Objective body was truncated by the Backend response limit.

+ {/if} + {:else if data.objectiveError} +

{data.objectiveError}

+ {:else} +

Loading objective detail…

+ {/if} +
diff --git a/web/workspace/src/routes/w/[workspaceId]/objectives/[objectiveId]/+page.ts b/web/workspace/src/routes/w/[workspaceId]/objectives/[objectiveId]/+page.ts new file mode 100644 index 00000000..395b4618 --- /dev/null +++ b/web/workspace/src/routes/w/[workspaceId]/objectives/[objectiveId]/+page.ts @@ -0,0 +1,27 @@ +import { loadJson, workspaceApiPath } from "$lib/workspace-api/http"; +import type { + ObjectiveDetail, + ObjectiveListResponse, +} from "$lib/workspace-sidebar/types"; +import type { PageLoad } from "./$types"; + +export const load: PageLoad = async ({ fetch, params }) => { + const apiPath = (path: string) => workspaceApiPath(params.workspaceId, path); + const objectiveId = params.objectiveId; + const [objectives, objective] = await Promise.all([ + loadJson(fetch, apiPath('/objectives')), + loadJson( + fetch, + apiPath(`/objectives/${encodeURIComponent(objectiveId)}`), + ), + ]); + + return { + workspaceId: params.workspaceId, + objectiveId, + objectives: objectives.data, + objectivesError: objectives.error, + objective: objective.data, + objectiveError: objective.error, + }; +}; diff --git a/web/workspace/src/routes/w/[workspaceId]/repositories/[repositoryId]/+page.svelte b/web/workspace/src/routes/w/[workspaceId]/repositories/[repositoryId]/+page.svelte new file mode 100644 index 00000000..d6493e49 --- /dev/null +++ b/web/workspace/src/routes/w/[workspaceId]/repositories/[repositoryId]/+page.svelte @@ -0,0 +1,105 @@ + + + + {data.repository?.item.display_name ?? data.repositoryId} · Repository + + +
+

Repository

+ {#if data.repository} +
+
+

{data.repository.item.display_name}

+

{data.repository.item.id}

+
+ {data.repository.item.git?.status ?? 'not observed'} +
+
+
+
Kind
+
{data.repository.item.kind}
+
+
+
Provider
+
{data.repository.item.provider}
+
+
+
Record authority
+
{data.repository.item.record_authority}
+
+
+
Default selector
+
{data.repository.item.default_selector ?? 'none configured'}
+
+
+
Branch
+
{data.repository.item.git?.branch ?? 'unknown'}
+
+
+
HEAD
+
{data.repository.item.git?.head ?? 'unknown'}
+
+
+
Dirty
+
{data.repository.item.git?.dirty ? 'yes' : 'no'}
+
+
+ {#if data.repository.item.diagnostics && data.repository.item.diagnostics.length > 0} +
    + {#each data.repository.item.diagnostics as diagnostic} +
  • {diagnostic.code}: {diagnostic.message}
    • + {/each} +
+ {/if} + {:else if data.repositoryError} +

{data.repositoryError}

+ {:else} +

Loading repository…

+ {/if} +
+ +
+

Recent commits

+ {#if data.repositoryLog} + {#if data.repositoryLog.items.length === 0} +

No recent commits are available.

+ {:else} +
+ {#each data.repositoryLog.items as commit} +
+ {commit.summary} + {commit.short_hash} · {commit.author_name} · {formatDate(commit.author_date)} +
+ {/each} +
+ {/if} + {#if data.repositoryLog.diagnostics.length > 0} +
    + {#each data.repositoryLog.diagnostics as diagnostic} +
  • {diagnostic.code}: {diagnostic.message}
    • + {/each} +
+ {/if} + {:else if data.repositoryLogError} +

{data.repositoryLogError}

+ {:else} +

Loading repository commits…

+ {/if} +
+ +
+

Repository Tickets

+ {#if data.repositoryTickets} + + {:else if data.repositoryTicketsError} +

{data.repositoryTicketsError}

+ {:else} +

Loading repository tickets…

+ {/if} +
diff --git a/web/workspace/src/routes/w/[workspaceId]/repositories/[repositoryId]/+page.ts b/web/workspace/src/routes/w/[workspaceId]/repositories/[repositoryId]/+page.ts new file mode 100644 index 00000000..db2b1cdb --- /dev/null +++ b/web/workspace/src/routes/w/[workspaceId]/repositories/[repositoryId]/+page.ts @@ -0,0 +1,36 @@ +import { loadJson, workspaceApiPath } from "$lib/workspace-api/http"; +import type { + RepositoryDetailResponse, + RepositoryLogResponse, + RepositoryTicketsResponse, +} from "$lib/workspace-sidebar/types"; +import type { PageLoad } from "./$types"; + +export const load: PageLoad = async ({ fetch, params }) => { + const apiPath = (path: string) => workspaceApiPath(params.workspaceId, path); + const repositoryId = params.repositoryId; + const [repository, log, tickets] = await Promise.all([ + loadJson( + fetch, + apiPath(`/repositories/${encodeURIComponent(repositoryId)}`), + ), + loadJson( + fetch, + apiPath(`/repositories/${encodeURIComponent(repositoryId)}/log`), + ), + loadJson( + fetch, + apiPath(`/repositories/${encodeURIComponent(repositoryId)}/tickets`), + ), + ]); + + return { + repositoryId, + repository: repository.data, + repositoryError: repository.error, + repositoryLog: log.data, + repositoryLogError: log.error, + repositoryTickets: tickets.data, + repositoryTicketsError: tickets.error, + }; +}; diff --git a/web/workspace/src/routes/w/[workspaceId]/runtimes/[runtimeId]/workers/[workerId]/console/+page.svelte b/web/workspace/src/routes/w/[workspaceId]/runtimes/[runtimeId]/workers/[workerId]/console/+page.svelte new file mode 100644 index 00000000..775be75e --- /dev/null +++ b/web/workspace/src/routes/w/[workspaceId]/runtimes/[runtimeId]/workers/[workerId]/console/+page.svelte @@ -0,0 +1,399 @@ + + + + Worker Console · Yoi Workspace + + + +
+
+
+

{worker?.label ?? workerId}

+
+
+
+ {worker?.state ?? 'unknown'} · {worker?.status ?? 'loading'} · stream {streamState} +
+ +
+
+ +
+
+ {#if projection.status || projection.usage} +

+ {#if projection.status}status: {projection.status}{/if} + {#if projection.status && projection.usage} · {/if} + {#if projection.usage}usage: {projection.usage}{/if} +

+ {/if} + + {#if workerError} +

{workerError}

+ {/if} + {#if transcriptError} +

{transcriptError}

+ {/if} + + {#if lines.length === 0} +

No console output is available for this Worker yet.

+ {:else} +
    + {#each lines as item} +
  1. + {#if lineClass(item) !== 'assistant' && lineClass(item) !== 'user'} +
    + {item.title} + {#if item.streaming}streaming{/if} +
    + {:else if item.streaming} +
    + streaming +
    + {/if} + 
    {item.body || '—'}
    + {#if item.detail} +
    + detail +

    {item.detail}

    +
    + {/if} +
    2. + {/each} +
+ {/if} +
+ +
+ + {#if workerDetailsOpen} + + {/if} + +
+ +
+ + {#if sendError}

{sendError}

{/if} +
+
+
diff --git a/web/workspace/src/routes/w/[workspaceId]/runtimes/[runtimeId]/workers/[workerId]/console/+page.ts b/web/workspace/src/routes/w/[workspaceId]/runtimes/[runtimeId]/workers/[workerId]/console/+page.ts new file mode 100644 index 00000000..4ea9fe95 --- /dev/null +++ b/web/workspace/src/routes/w/[workspaceId]/runtimes/[runtimeId]/workers/[workerId]/console/+page.ts @@ -0,0 +1,9 @@ +export function load( + { params }: { params: { workspaceId: string; runtimeId: string; workerId: string } }, +) { + return { + workspaceId: params.workspaceId, + runtimeId: params.runtimeId, + workerId: params.workerId, + }; +} diff --git a/web/workspace/src/routes/w/[workspaceId]/settings/+page.svelte b/web/workspace/src/routes/w/[workspaceId]/settings/+page.svelte new file mode 100644 index 00000000..1737a2bc --- /dev/null +++ b/web/workspace/src/routes/w/[workspaceId]/settings/+page.svelte @@ -0,0 +1,487 @@ + + + + Settings · Yoi Workspace + + +
+
+
+

Workspace Browser

+

Settings / Admin

+

+ Local administration surfaces for the Workspace backend. Runtime Connections v0 is editable through typed APIs; broader admin controls remain bounded placeholders. +

+
+ local only +
+ +
+
+

Authority boundary

+

No browser admin permission model

+

{SETTINGS_PERMISSION_NOTICE}

+
+
+ Restart-required + Runtime config changes are persisted, then applied after backend restart. +
+
+ +
+ {#each SETTINGS_SECTIONS as section} + + {section.label} + {section.status === "editable" ? "Editable" : section.status === "read-only" ? "Read-only" : "Placeholder"} + + {/each} +
+ +
+
+
+

editable

+

Runtime Connections

+
+ typed API +
+

{SETTINGS_SECTIONS.find((section) => section.id === "runtime-connections")?.summary}

+ + {#if runtimeLoading} +

Loading Runtime connections…

+ {:else if runtimeError} +

Runtime connection settings unavailable: {runtimeError}

+ {:else if runtimeSettings} +
+ +
+ + {#if showAddRuntimeForm} +
{ event.preventDefault(); void submitRemoteRuntime(); }}> +

Add remote Runtime

+

Endpoint is submitted to the Backend but not echoed back in settings responses.

+ + + + +
+ {/if} + + {#if mutationMessage} +

{mutationMessage}

+ {/if} + {@render DiagnosticsList({ diagnostics: mutationDiagnostics })} + +
+

Runtimes

+
+ + + + + + + + + + + + + + + + + + + {#if runtimeSettings.embedded.diagnostics.length > 0} + + + + {/if} + {#each runtimeSettings.remotes as remote (remote.runtime_id)} + + + + + + + + {#if remote.diagnostics.length > 0} + + + + {/if} + {#if tests[remote.runtime_id]} + {@const test = tests[remote.runtime_id]} + {@const available = capabilityOperations(test, "available")} + {@const unchecked = capabilityOperations(test, "unknown")} + + + + {/if} + {/each} + +
RuntimeSourceConnectionStatusActions
+ {runtimeSettings.embedded.display_name} + {runtimeSettings.embedded.runtime_id} + + embedded + Workspace backend process + Local Backend runtime + {runtimeSettings.embedded.status} + {#if runtimeSettings.embedded.restart_required} + restart required + {/if} + Managed by backend
{@render DiagnosticsList({ diagnostics: runtimeSettings.embedded.diagnostics })}
+ {remote.display_name} + {remote.runtime_id} + + remote + Configured Runtime endpoint + + Endpoint: {remote.endpoint_configured ? "configured" : "not configured"} + {#if remote.endpoint_configured}hidden{/if} + Token: {remote.token_ref_configured ? "configured" : "not configured"} + + {remote.status} + {#if remote.restart_required} + restart required + {/if} + +
+ + +
+
{@render DiagnosticsList({ diagnostics: remote.diagnostics })}
+
+ Test: {test.state} + {test.health_result} · {test.checked_at} +

{test.compatibility_basis}

+ {#if available.length > 0} +

Verified areas: {available.join(', ')}

+ {/if} + {#if unchecked.length > 0} +

Unchecked warning areas: {unchecked.join(', ')}

+ {/if} + {@render DiagnosticsList({ diagnostics: test.diagnostics })} +
+
+
+ {#if runtimeSettings.remotes.length === 0} +

No remote Runtime connections configured.

+ {/if} +
+ {/if} +
+ +
+ {#each SETTINGS_SECTIONS.filter((section) => section.id !== "runtime-connections") as section} +
+
+
+

{section.status}

+

{section.label}

+
+ {#if section.status === "placeholder"} + not implemented + {:else} + read-only + {/if} +
+

{section.summary}

+
    + {#each section.bullets as bullet} +
  • {bullet}
    • + {/each} +
+ + {#if section.id === "workspace-identity"} +
+
+
Workspace id
+
{workspace?.workspace_id ?? "loading"}
+
+
+
Display name
+
{workspace?.display_name ?? "loading"}
+
+
+
Record authority
+
.yoi tickets/objectives through the Backend projection
+
+
+ {/if} +
+ {/each} +
+ +
+
+

Implementation patterns

+

How settings should appear

+
+
+ {#each SETTINGS_PATTERNS as pattern} +
+

{pattern.title}

+

{pattern.body}

+
+ {/each} +
+
+ + {#if !workspace && !workspaceError} +

Loading workspace summary…

+ {:else if workspaceError} +

Workspace summary unavailable: {workspaceError}

+ {/if} +
+ +{#snippet DiagnosticsList({ diagnostics }: { diagnostics: Diagnostic[] })} + {#if diagnostics.length > 0} +
    + {#each diagnostics as diagnostic} +
  • + {diagnosticLabel(diagnostic)} + {diagnostic.message} +
    • + {/each} +
+ {/if} +{/snippet} From 55f93fd987134cba24734b89deeeacfc42af0d2c Mon Sep 17 00:00:00 2001 From: Hare Date: Tue, 7 Jul 2026 05:27:20 +0900 Subject: [PATCH 4/9] ticket: record workspace id route implementation evidence --- .yoi/tickets/00001KWWE8E04/item.md | 2 +- .yoi/tickets/00001KWWE8E04/thread.md | 30 ++++++++++++++++++++++++++++ 2 files changed, 31 insertions(+), 1 deletion(-) diff --git a/.yoi/tickets/00001KWWE8E04/item.md b/.yoi/tickets/00001KWWE8E04/item.md index 745cce5a..66cf2a34 100644 --- a/.yoi/tickets/00001KWWE8E04/item.md +++ b/.yoi/tickets/00001KWWE8E04/item.md @@ -2,7 +2,7 @@ title: 'Scope Workspace Browser routes and API by workspace id' state: 'inprogress' created_at: '2026-07-06T19:25:08Z' -updated_at: '2026-07-06T19:55:26Z' +updated_at: '2026-07-06T20:27:15Z' assignee: null queued_by: 'workspace-panel' queued_at: '2026-07-06T19:53:14Z' diff --git a/.yoi/tickets/00001KWWE8E04/thread.md b/.yoi/tickets/00001KWWE8E04/thread.md index fc6edef7..37f89306 100644 --- a/.yoi/tickets/00001KWWE8E04/thread.md +++ b/.yoi/tickets/00001KWWE8E04/thread.md @@ -154,3 +154,33 @@ Implementation routing update: - 完了後は diff / validation evidence を Orchestrator が確認し、別 sibling Reviewer Pod に read-only review を依頼する。`StopPod` は既知の不具合があるため使用しない。 --- + + + +## Implementation report + +Implementation progress report: + +- Coder Pod completed implementation and committed `f6ad9cfc feat: scope workspace routes by id` on branch `work/00001KWWE8E04-workspace-id-routes`. +- Worktree status was clean after commit. +- Changed files include backend `crates/workspace-server/src/server.rs` / `lib.rs`, scoped route/API helpers/tests, sidebar/repository/objective/settings/worker console links, and new SvelteKit route files under `web/workspace/src/routes/w/[workspaceId]/...`. +- Implementation summary: + - Added canonical Browser routes under `/w//...`。 + - Added Browser-facing scoped API routes under `/api/w//...`。 + - Added backend scoped workspace id validation against current immutable backend workspace id。 + - mismatch returns typed sanitized `workspace_id_mismatch` diagnostic with 404。 + - Runtime `/v1/...` APIs were not changed。 + - Frontend links/API calls now use scoped route/API helpers for workspace Browser surfaces。 + - Worker creation console hrefs point at scoped `/w//runtimes/.../console`。 + - Focused backend and frontend tests cover scoped API/mismatch and route/API/link helpers。 +- Orchestrator reran validation in the implementation worktree: + - `git diff --check`: pass + - `cd web/workspace && deno task check`: pass（0 errors / 0 warnings） + - `cd web/workspace && deno task test`: pass（16 tests） + - `cargo test -p yoi-workspace-server`: pass（65 lib tests + 2 main tests） + - `cargo check -p yoi`: pass + - `yoi ticket doctor`: ok +- `nix build .#yoi --no-link` は Cargo.lock / dependency / resource packaging / Nix 変更ではないため未実行。 +- External review will be requested via a read-only sibling Reviewer Pod. `StopPod` は使わない。 + +--- From a2f2e375858e2f39a60ee2020e9b5a42fc634f2a Mon Sep 17 00:00:00 2001 From: Hare Date: Tue, 7 Jul 2026 05:36:54 +0900 Subject: [PATCH 5/9] ticket: record workspace id route review blockers --- .yoi/tickets/00001KWWE8E04/item.md | 2 +- .yoi/tickets/00001KWWE8E04/thread.md | 32 ++++++++++++++++++++++++++++ 2 files changed, 33 insertions(+), 1 deletion(-) diff --git a/.yoi/tickets/00001KWWE8E04/item.md b/.yoi/tickets/00001KWWE8E04/item.md index 66cf2a34..89f130ae 100644 --- a/.yoi/tickets/00001KWWE8E04/item.md +++ b/.yoi/tickets/00001KWWE8E04/item.md @@ -2,7 +2,7 @@ title: 'Scope Workspace Browser routes and API by workspace id' state: 'inprogress' created_at: '2026-07-06T19:25:08Z' -updated_at: '2026-07-06T20:27:15Z' +updated_at: '2026-07-06T20:36:50Z' assignee: null queued_by: 'workspace-panel' queued_at: '2026-07-06T19:53:14Z' diff --git a/.yoi/tickets/00001KWWE8E04/thread.md b/.yoi/tickets/00001KWWE8E04/thread.md index 37f89306..051887cc 100644 --- a/.yoi/tickets/00001KWWE8E04/thread.md +++ b/.yoi/tickets/00001KWWE8E04/thread.md @@ -184,3 +184,35 @@ Implementation progress report: - External review will be requested via a read-only sibling Reviewer Pod. `StopPod` は使わない。 --- + + + +## Review: request changes + +External review result: request_changes + +Blockers: + +1. Unscoped UI routes still perform unscoped frontend API calls。 + - `web/workspace/src/routes/+layout.ts:11-18` falls back to `/api${path}` when `params.workspaceId` is absent。 + - As a result `/`, `/objectives`, `/settings` などが workspace-scoped data を `/api/workspace` / `/api/repositories` から通常 load し続ける。 + - これは Ticket / Intent の「Frontend own calls は workspace-scoped data に `/api/w//...` を使う」と衝突する。Compatibility aliases は redirect/bootstrap-only などにして、通常の unscoped data routes として残さない必要がある。 + +2. scoped/unscoped browser routes が大きな duplicated pages として実装され、route logic drift を作っている。 + - `web/workspace/src/routes/w/[workspaceId]/**` に full page copies が追加され、旧 route files も残っている。 + - `settings/+page.svelte` と `w/[workspaceId]/settings/+page.svelte`、worker console page などが byte-identical。 + - これは critical pages の substantial duplicated UI/control logic であり、thin compatibility shim ではなく co-canonical surface になっている。 + - Unscoped routes を `/w//...` に redirect するか、shared route components/load helpers に factor して canonical scoped routes だけを maintained surface にする必要がある。 + +Validated/inspected: +- Ticket item/thread と routing IntentPacket。 +- implementation worktree 内で `f6ad9cfc` diff/stat/check を inspection。 +- Backend scoped route pattern と mismatch handling は方向性として妥当。`validate_workspace_scope` は fail closed し、`workspace_id_mismatch` diagnostics は raw path/internal store details を漏らしていない。 +- Runtime `/v1/...` API は inspected diff では変更されていない。 +- Orchestrator-reported validations は pass として確認。Reviewer は heavy checks を再実行していない。 + +Non-blocking follow-ups: +- 一部 UI placeholder/help text が旧 `/api/...` paths に触れているため、canonical route/API behavior 修正後に掃除するとよい。 +- redirect/shared-route refactor 後、scoped settings/workers/console endpoints の direct coverage を増やすとよい。 + +--- From 71340b8999014bdcf699129f80f354cc0597f769 Mon Sep 17 00:00:00 2001 From: Hare Date: Tue, 7 Jul 2026 05:44:22 +0900 Subject: [PATCH 6/9] fix: redirect unscoped workspace routes --- crates/workspace-server/src/server.rs | 52 +- .../src/lib/workspace-api/http.test.ts | 35 +- .../worker-console.ui.test.ts | 2 +- .../WorkersNavSection.svelte | 12 + web/workspace/src/routes/+layout.ts | 31 +- web/workspace/src/routes/+page.svelte | 139 +---- web/workspace/src/routes/+page.ts | 20 +- .../src/routes/objectives/+page.svelte | 52 +- web/workspace/src/routes/objectives/+page.ts | 16 +- .../objectives/[objectiveId]/+page.svelte | 82 +-- .../routes/objectives/[objectiveId]/+page.ts | 25 +- .../repositories/[repositoryId]/+page.svelte | 111 +--- .../repositories/[repositoryId]/+page.ts | 37 +- .../workers/[workerId]/console/+page.svelte | 405 +------------- .../workers/[workerId]/console/+page.ts | 9 +- .../src/routes/settings/+page.svelte | 493 +----------------- 16 files changed, 162 insertions(+), 1359 deletions(-) diff --git a/crates/workspace-server/src/server.rs b/crates/workspace-server/src/server.rs index 9ff23033..f77148ac 100644 --- a/crates/workspace-server/src/server.rs +++ b/crates/workspace-server/src/server.rs @@ -3,7 +3,7 @@ use std::sync::Arc; use axum::extract::ws::{Message as WsMessage, WebSocket, WebSocketUpgrade}; use axum::extract::{Path as AxumPath, Query, State}; -use axum::http::header::CONTENT_TYPE; +use axum::http::header::{CONTENT_TYPE, LOCATION}; use axum::http::{StatusCode, Uri}; use axum::response::{IntoResponse, Response}; use axum::routing::{delete, get, post}; @@ -2737,6 +2737,12 @@ async fn static_or_spa_fallback(State(api): State, uri: Uri) -> Re } } + if let Some(location) = + unscoped_workspace_ui_redirect(uri.path(), uri.query(), api.workspace_id()) + { + return (StatusCode::TEMPORARY_REDIRECT, [(LOCATION, location)]).into_response(); + } + let Some(static_root) = api.config.static_assets_dir.as_ref() else { return StatusCode::NOT_FOUND.into_response(); }; @@ -2753,6 +2759,30 @@ async fn static_or_spa_fallback(State(api): State, uri: Uri) -> Re } } +fn unscoped_workspace_ui_redirect( + path: &str, + query: Option<&str>, + workspace_id: &str, +) -> Option { + let scoped_tail = if path == "/" { + "" + } else if ["/repositories", "/objectives", "/settings", "/runtimes"] + .iter() + .any(|prefix| path == *prefix || path.starts_with(&format!("{prefix}/"))) + { + path + } else { + return None; + }; + + let mut location = format!("/w/{}{}", encode_path_segment(workspace_id), scoped_tail); + if let Some(query) = query.filter(|query| !query.is_empty()) { + location.push('?'); + location.push_str(query); + } + Some(location) +} + fn workspace_id_from_ui_path(path: &str) -> Option<&str> { let tail = path.strip_prefix("/w/")?; let workspace_id = tail.split('/').next().unwrap_or_default(); @@ -3598,6 +3628,26 @@ mod tests { .contains(dir.path().to_string_lossy().as_ref()) ); + let unscoped_objectives = app + .clone() + .oneshot( + Request::builder() + .uri("/objectives?focus=active") + .body(Body::empty()) + .unwrap(), + ) + .await + .unwrap(); + assert_eq!(unscoped_objectives.status(), StatusCode::TEMPORARY_REDIRECT); + let expected_location = format!("/w/{TEST_WORKSPACE_ID}/objectives?focus=active"); + assert_eq!( + unscoped_objectives + .headers() + .get(LOCATION) + .and_then(|value| value.to_str().ok()), + Some(expected_location.as_str()) + ); + let tickets = get_json(app.clone(), "/api/tickets").await; assert_eq!(tickets["items"][0]["id"], "00000000001J2"); assert_eq!(tickets["items"][0]["state"], "ready"); diff --git a/web/workspace/src/lib/workspace-api/http.test.ts b/web/workspace/src/lib/workspace-api/http.test.ts index 99f1d73e..d18f7d43 100644 --- a/web/workspace/src/lib/workspace-api/http.test.ts +++ b/web/workspace/src/lib/workspace-api/http.test.ts @@ -1,7 +1,8 @@ import { workspaceApiPath, workspaceRoute } from "./http.ts"; declare const Deno: { - test(name: string, fn: () => void): void; + test(name: string, fn: () => Promise | void): void; + readTextFile(path: string | URL): Promise; }; function assertEquals(actual: T, expected: T): void { @@ -12,6 +13,12 @@ function assertEquals(actual: T, expected: T): void { } } +function assert(condition: unknown, message: string): asserts condition { + if (!condition) { + throw new Error(message); + } +} + Deno.test("workspace route helpers scope browser routes and API by immutable workspace id", () => { assertEquals(workspaceRoute("workspace 1"), "/w/workspace%201"); assertEquals(workspaceRoute("workspace 1", "/objectives"), "/w/workspace%201/objectives"); @@ -20,3 +27,29 @@ Deno.test("workspace route helpers scope browser routes and API by immutable wor "/api/w/workspace%201/repositories/repo-a", ); }); + +Deno.test("unscoped layout bootstraps then redirects instead of loading unscoped workspace data", async () => { + const layout = await Deno.readTextFile(new URL("../../routes/+layout.ts", import.meta.url)); + assert( + layout.includes('loadJson(fetch, "/api/workspace")'), + "unscoped layout may use only the workspace-id bootstrap endpoint", + ); + assert( + layout.includes("throw redirect(307") && layout.includes("workspaceRoute("), + "unscoped layout should redirect to the scoped workspace route", + ); + assert( + !layout.includes('`/api${path}`') && !layout.includes('"/api/repositories"'), + "layout must not fall back to unscoped workspace-scoped API calls", + ); + + const unscopedSettings = await Deno.readTextFile( + new URL("../../routes/settings/+page.svelte", import.meta.url), + ); + assert( + unscopedSettings.includes("Redirecting to scoped settings") && + !unscopedSettings.includes("fetch(") && + !unscopedSettings.includes("settingsApiPath"), + "unscoped settings route should remain a thin redirect shim, not a data/control surface", + ); +}); diff --git a/web/workspace/src/lib/workspace-console/worker-console.ui.test.ts b/web/workspace/src/lib/workspace-console/worker-console.ui.test.ts index a688f57f..2027b115 100644 --- a/web/workspace/src/lib/workspace-console/worker-console.ui.test.ts +++ b/web/workspace/src/lib/workspace-console/worker-console.ui.test.ts @@ -11,7 +11,7 @@ function assert(condition: unknown, message: string): asserts condition { Deno.test("workspace Worker list and sidebar attach through Worker Console hrefs", async () => { const workspacePage = await Deno.readTextFile( - new URL("./../../routes/+page.svelte", import.meta.url), + new URL("./../../routes/w/[workspaceId]/+page.svelte", import.meta.url), ); const workersNav = await Deno.readTextFile( new URL("../workspace-sidebar/WorkersNavSection.svelte", import.meta.url), diff --git a/web/workspace/src/lib/workspace-sidebar/WorkersNavSection.svelte b/web/workspace/src/lib/workspace-sidebar/WorkersNavSection.svelte index 150f9459..170d5cb9 100644 --- a/web/workspace/src/lib/workspace-sidebar/WorkersNavSection.svelte +++ b/web/workspace/src/lib/workspace-sidebar/WorkersNavSection.svelte @@ -37,6 +37,13 @@ let initialText = $state(''); $effect(() => { + if (!workspaceId) { + loading = false; + workers = []; + options = null; + return; + } + const controller = new AbortController(); void loadWorkers(controller.signal); void loadLaunchOptions(controller.signal); @@ -102,6 +109,11 @@ } async function createWorker() { + if (!workspaceId) { + submitError = 'workspace id is unavailable'; + return; + } + submitError = null; submitting = true; try { diff --git a/web/workspace/src/routes/+layout.ts b/web/workspace/src/routes/+layout.ts index 4fdaf406..f3e63f06 100644 --- a/web/workspace/src/routes/+layout.ts +++ b/web/workspace/src/routes/+layout.ts @@ -1,17 +1,32 @@ -import { loadJson, workspaceApiPath } from "$lib/workspace-api/http"; -import type { - RepositoryListResponse, - WorkspaceResponse, -} from "$lib/workspace-sidebar/types"; +import { redirect } from "@sveltejs/kit"; +import { loadJson, workspaceApiPath, workspaceRoute } from "$lib/workspace-api/http"; +import type { RepositoryListResponse, WorkspaceResponse } from "$lib/workspace-sidebar/types"; import type { LayoutLoad } from "./$types"; export const ssr = false; export const prerender = false; -export const load: LayoutLoad = async ({ fetch, params }) => { +export const load: LayoutLoad = async ({ fetch, params, url }) => { const workspaceId = params.workspaceId; - const apiPath = (path: string) => - workspaceId ? workspaceApiPath(workspaceId, path) : `/api${path}`; + + if (!workspaceId) { + const workspace = await loadJson(fetch, "/api/workspace"); + if (workspace.data) { + const scopedPath = workspaceRoute( + workspace.data.workspace_id, + url.pathname === "/" ? "" : url.pathname, + ); + throw redirect(307, `${scopedPath}${url.search}`); + } + return { + workspace: null, + workspaceError: workspace.error, + repositories: null, + repositoriesError: null, + }; + } + + const apiPath = (path: string) => workspaceApiPath(workspaceId, path); const [workspace, repositories] = await Promise.all([ loadJson(fetch, apiPath("/workspace")), diff --git a/web/workspace/src/routes/+page.svelte b/web/workspace/src/routes/+page.svelte index 34ca4a6a..87fceed3 100644 --- a/web/workspace/src/routes/+page.svelte +++ b/web/workspace/src/routes/+page.svelte @@ -1,133 +1,6 @@ - - - - Yoi Workspace Control Plane - - - -
-

Workspace

- {#if data.workspace} -
-
-
ID
-
{data.workspace.workspace_id}
-
-
-
Name
-
{data.workspace.display_name}
-
-
-
Record authority
-
{data.workspace.record_authority}
-
-
-
Host / Worker bridge
-
{data.workspace.extension_points.host_worker_bridge.status}
-
-
- {:else if data.workspaceError} -

{data.workspaceError}

- {:else} -

Waiting for /api/workspace…

- {/if} -
- -
-
-

Hosts

- {#if data.hosts} - {#if data.hosts.items.length === 0} -

No local Hosts are visible.

- {:else} -
- {#each data.hosts.items as host} -
-
- {host.label} - {host.status} -
-
-
-
ID
-
{host.host_id}
-
-
-
Kind
-
{host.kind}
-
-
-
Runtime
-
{host.runtime_id}
-
-
-
Scope
-
{host.capabilities.workspace_scope}
-
-
-
Platform
-
{host.capabilities.os} / {host.capabilities.arch}
-
-
-
- {/each} -
- {/if} - {:else if data.hostsError} -

{data.hostsError}

- {:else} -

Waiting for /api/hosts…

- {/if} -
- -
-

Workers

- {#if data.workers} - {#if data.workers.items.length === 0} -

No local Workers are visible.

- {:else} -
- - - - - - - - - - - - - {#each data.workers.items as worker} - - - - - - - - - {/each} - -
WorkerHostStateWorkspaceImplementationAttach
- {worker.label} - {#if worker.role || worker.profile} - {worker.role ?? 'role unknown'} / {worker.profile ?? 'profile unknown'} - {/if} - {worker.host_id}{worker.state} · {worker.status}{worker.workspace.visibility} · {worker.workspace.identity}{worker.implementation.kind}Open Console
-
- {/if} - {:else if data.workersError} -

{data.workersError}

- {:else} -

Waiting for /api/workers…

- {/if} -
-
+
+
+

Redirecting to scoped workspace…

+

This compatibility route bootstraps the current workspace id and redirects to the canonical /w/<workspace-id> route.

+
+
diff --git a/web/workspace/src/routes/+page.ts b/web/workspace/src/routes/+page.ts index 9d2ca562..7a066b58 100644 --- a/web/workspace/src/routes/+page.ts +++ b/web/workspace/src/routes/+page.ts @@ -1,21 +1,3 @@ -import { loadJson, workspaceApiPath } from "$lib/workspace-api/http"; -import type { Host, ListResponse, Worker } from "$lib/workspace-sidebar/types"; import type { PageLoad } from "./$types"; -export const load: PageLoad = async ({ fetch, parent }) => { - const layout = await parent(); - const workspaceId = layout.workspace?.workspace_id ?? ""; - const apiPath = (path: string) => workspaceApiPath(workspaceId, path); - - const [hosts, workers] = await Promise.all([ - loadJson>(fetch, apiPath("/hosts")), - loadJson>(fetch, apiPath("/workers")), - ]); - - return { - hosts: hosts.data, - hostsError: hosts.error, - workers: workers.data, - workersError: workers.error, - }; -}; +export const load: PageLoad = async () => ({}); diff --git a/web/workspace/src/routes/objectives/+page.svelte b/web/workspace/src/routes/objectives/+page.svelte index 088e66ec..c3cbc837 100644 --- a/web/workspace/src/routes/objectives/+page.svelte +++ b/web/workspace/src/routes/objectives/+page.svelte @@ -1,46 +1,6 @@ - - - - Objectives · Yoi Workspace - - -
-

Objectives

-

Objectives are read from canonical filesystem records through /api/objectives.

- {#if data.objectives} - {#if data.objectives.items.length === 0} -

No Objective records are present.

- {:else} -
- {#each data.objectives.items as objective (objective.id)} - -
-
- {objective.title} - {objective.state} -
-

{objective.summary || 'No summary text is available.'}

-
-
- Updated {objective.updated_at ? formatDate(objective.updated_at) : 'unknown'} - {objective.linked_tickets?.length ? `${objective.linked_tickets.length} linked ticket(s)` : 'No linked tickets'} - {objective.id} -
- - {/each} -
- {/if} - {#if data.objectives.invalid_records.length > 0} -

{data.objectives.invalid_records.length} invalid objective record(s) hidden.

- {/if} - {:else if data.objectivesError} -

{data.objectivesError}

- {:else} -

Waiting for /api/objectives…

- {/if} -
+
+
+

Redirecting to scoped objectives…

+

Objectives are available at the canonical /w/<workspace-id>/objectives route.

+
+
diff --git a/web/workspace/src/routes/objectives/+page.ts b/web/workspace/src/routes/objectives/+page.ts index 92690c1f..7a066b58 100644 --- a/web/workspace/src/routes/objectives/+page.ts +++ b/web/workspace/src/routes/objectives/+page.ts @@ -1,17 +1,3 @@ -import { loadJson, workspaceApiPath } from "$lib/workspace-api/http"; -import type { ObjectiveListResponse } from "$lib/workspace-sidebar/types"; import type { PageLoad } from "./$types"; -export const load: PageLoad = async ({ fetch, parent }) => { - const layout = await parent(); - const workspaceId = layout.workspace?.workspace_id ?? ""; - const objectives = await loadJson( - fetch, - workspaceApiPath(workspaceId, "/objectives"), - ); - return { - workspaceId, - objectives: objectives.data, - objectivesError: objectives.error, - }; -}; +export const load: PageLoad = async () => ({}); diff --git a/web/workspace/src/routes/objectives/[objectiveId]/+page.svelte b/web/workspace/src/routes/objectives/[objectiveId]/+page.svelte index cf07c432..37f9891b 100644 --- a/web/workspace/src/routes/objectives/[objectiveId]/+page.svelte +++ b/web/workspace/src/routes/objectives/[objectiveId]/+page.svelte @@ -1,76 +1,6 @@ - - - - {data.objective?.title ?? data.objectiveId} · Objective - - -
-

Objectives

- {#if data.objectives} -
- {#each data.objectives.items as objective (objective.id)} - -
-
- {objective.title} - {objective.state} -
-

{objective.summary || 'No summary text is available.'}

-
-
- Updated {objective.updated_at ? formatDate(objective.updated_at) : 'unknown'} - {objective.id} -
- - {/each} -
- {:else if data.objectivesError} -

{data.objectivesError}

- {:else} -

Loading objectives…

- {/if} -
- -
-

Objective detail

- {#if data.objective} -
-
-

{data.objective.title}

-

{data.objective.id}

-
- {data.objective.state} -
-
-
-
Created
-
{data.objective.created_at ? formatDate(data.objective.created_at) : 'unknown'}
-
-
-
Updated
-
{data.objective.updated_at ? formatDate(data.objective.updated_at) : 'unknown'}
-
-
-
Record source
-
{data.objective.record_source}
-
-
-
Linked tickets
-
{data.objective.linked_tickets.length ? data.objective.linked_tickets.join(', ') : 'none'}
-
-
- 
{data.objective.body}
- {#if data.objective.body_truncated} -

Objective body was truncated by the Backend response limit.

- {/if} - {:else if data.objectiveError} -

{data.objectiveError}

- {:else} -

Loading objective detail…

- {/if} -
+
+
+

Redirecting to scoped objective…

+

Objective detail routes are canonical under /w/<workspace-id>/objectives/<objective-id>.

+
+
diff --git a/web/workspace/src/routes/objectives/[objectiveId]/+page.ts b/web/workspace/src/routes/objectives/[objectiveId]/+page.ts index c3e034aa..7a066b58 100644 --- a/web/workspace/src/routes/objectives/[objectiveId]/+page.ts +++ b/web/workspace/src/routes/objectives/[objectiveId]/+page.ts @@ -1,26 +1,3 @@ -import { loadJson, workspaceApiPath } from "$lib/workspace-api/http"; -import type { ObjectiveDetail, ObjectiveListResponse } from "$lib/workspace-sidebar/types"; import type { PageLoad } from "./$types"; -export const load: PageLoad = async ({ fetch, params, parent }) => { - const layout = await parent(); - const workspaceId = layout.workspace?.workspace_id ?? ""; - const apiPath = (path: string) => workspaceApiPath(workspaceId, path); - const objectiveId = params.objectiveId; - const [objectives, objective] = await Promise.all([ - loadJson(fetch, apiPath("/objectives")), - loadJson( - fetch, - apiPath(`/objectives/${encodeURIComponent(objectiveId)}`), - ), - ]); - - return { - workspaceId, - objectiveId, - objectives: objectives.data, - objectivesError: objectives.error, - objective: objective.data, - objectiveError: objective.error, - }; -}; +export const load: PageLoad = async () => ({}); diff --git a/web/workspace/src/routes/repositories/[repositoryId]/+page.svelte b/web/workspace/src/routes/repositories/[repositoryId]/+page.svelte index d6493e49..c9ddef3c 100644 --- a/web/workspace/src/routes/repositories/[repositoryId]/+page.svelte +++ b/web/workspace/src/routes/repositories/[repositoryId]/+page.svelte @@ -1,105 +1,6 @@ - - - - {data.repository?.item.display_name ?? data.repositoryId} · Repository - - -
-

Repository

- {#if data.repository} -
-
-

{data.repository.item.display_name}

-

{data.repository.item.id}

-
- {data.repository.item.git?.status ?? 'not observed'} -
-
-
-
Kind
-
{data.repository.item.kind}
-
-
-
Provider
-
{data.repository.item.provider}
-
-
-
Record authority
-
{data.repository.item.record_authority}
-
-
-
Default selector
-
{data.repository.item.default_selector ?? 'none configured'}
-
-
-
Branch
-
{data.repository.item.git?.branch ?? 'unknown'}
-
-
-
HEAD
-
{data.repository.item.git?.head ?? 'unknown'}
-
-
-
Dirty
-
{data.repository.item.git?.dirty ? 'yes' : 'no'}
-
-
- {#if data.repository.item.diagnostics && data.repository.item.diagnostics.length > 0} -
    - {#each data.repository.item.diagnostics as diagnostic} -
  • {diagnostic.code}: {diagnostic.message}
    • - {/each} -
- {/if} - {:else if data.repositoryError} -

{data.repositoryError}

- {:else} -

Loading repository…

- {/if} -
- -
-

Recent commits

- {#if data.repositoryLog} - {#if data.repositoryLog.items.length === 0} -

No recent commits are available.

- {:else} -
- {#each data.repositoryLog.items as commit} -
- {commit.summary} - {commit.short_hash} · {commit.author_name} · {formatDate(commit.author_date)} -
- {/each} -
- {/if} - {#if data.repositoryLog.diagnostics.length > 0} -
    - {#each data.repositoryLog.diagnostics as diagnostic} -
  • {diagnostic.code}: {diagnostic.message}
    • - {/each} -
- {/if} - {:else if data.repositoryLogError} -

{data.repositoryLogError}

- {:else} -

Loading repository commits…

- {/if} -
- -
-

Repository Tickets

- {#if data.repositoryTickets} - - {:else if data.repositoryTicketsError} -

{data.repositoryTicketsError}

- {:else} -

Loading repository tickets…

- {/if} -
+
+
+

Redirecting to scoped repository…

+

Repository routes are canonical under /w/<workspace-id>/repositories/<repository-id>.

+
+
diff --git a/web/workspace/src/routes/repositories/[repositoryId]/+page.ts b/web/workspace/src/routes/repositories/[repositoryId]/+page.ts index 14b19f16..7a066b58 100644 --- a/web/workspace/src/routes/repositories/[repositoryId]/+page.ts +++ b/web/workspace/src/routes/repositories/[repositoryId]/+page.ts @@ -1,38 +1,3 @@ -import { loadJson, workspaceApiPath } from "$lib/workspace-api/http"; -import type { - RepositoryDetailResponse, - RepositoryLogResponse, - RepositoryTicketsResponse, -} from "$lib/workspace-sidebar/types"; import type { PageLoad } from "./$types"; -export const load: PageLoad = async ({ fetch, params, parent }) => { - const layout = await parent(); - const workspaceId = layout.workspace?.workspace_id ?? ""; - const apiPath = (path: string) => workspaceApiPath(workspaceId, path); - const repositoryId = params.repositoryId; - const [repository, log, tickets] = await Promise.all([ - loadJson( - fetch, - apiPath(`/repositories/${encodeURIComponent(repositoryId)}`), - ), - loadJson( - fetch, - apiPath(`/repositories/${encodeURIComponent(repositoryId)}/log`), - ), - loadJson( - fetch, - apiPath(`/repositories/${encodeURIComponent(repositoryId)}/tickets`), - ), - ]); - - return { - repositoryId, - repository: repository.data, - repositoryError: repository.error, - repositoryLog: log.data, - repositoryLogError: log.error, - repositoryTickets: tickets.data, - repositoryTicketsError: tickets.error, - }; -}; +export const load: PageLoad = async () => ({}); diff --git a/web/workspace/src/routes/runtimes/[runtimeId]/workers/[workerId]/console/+page.svelte b/web/workspace/src/routes/runtimes/[runtimeId]/workers/[workerId]/console/+page.svelte index 775be75e..5469576b 100644 --- a/web/workspace/src/routes/runtimes/[runtimeId]/workers/[workerId]/console/+page.svelte +++ b/web/workspace/src/routes/runtimes/[runtimeId]/workers/[workerId]/console/+page.svelte @@ -1,399 +1,6 @@ - - - - Worker Console · Yoi Workspace - - - -
-
-
-

{worker?.label ?? workerId}

-
-
-
- {worker?.state ?? 'unknown'} · {worker?.status ?? 'loading'} · stream {streamState} -
- -
-
- -
-
- {#if projection.status || projection.usage} -

- {#if projection.status}status: {projection.status}{/if} - {#if projection.status && projection.usage} · {/if} - {#if projection.usage}usage: {projection.usage}{/if} -

- {/if} - - {#if workerError} -

{workerError}

- {/if} - {#if transcriptError} -

{transcriptError}

- {/if} - - {#if lines.length === 0} -

No console output is available for this Worker yet.

- {:else} -
    - {#each lines as item} -
  1. - {#if lineClass(item) !== 'assistant' && lineClass(item) !== 'user'} -
    - {item.title} - {#if item.streaming}streaming{/if} -
    - {:else if item.streaming} -
    - streaming -
    - {/if} - 
    {item.body || '—'}
    - {#if item.detail} -
    - detail -

    {item.detail}

    -
    - {/if} -
    2. - {/each} -
- {/if} -
- -
- - {#if workerDetailsOpen} - - {/if} - -
- -
- - {#if sendError}

{sendError}

{/if} -
-
-
+
+
+

Redirecting to scoped Worker Console…

+

Worker Console routes are canonical under /w/<workspace-id>/runtimes/<runtime-id>/workers/<worker-id>/console.

+
+
diff --git a/web/workspace/src/routes/runtimes/[runtimeId]/workers/[workerId]/console/+page.ts b/web/workspace/src/routes/runtimes/[runtimeId]/workers/[workerId]/console/+page.ts index 56967e1f..7a066b58 100644 --- a/web/workspace/src/routes/runtimes/[runtimeId]/workers/[workerId]/console/+page.ts +++ b/web/workspace/src/routes/runtimes/[runtimeId]/workers/[workerId]/console/+page.ts @@ -1,10 +1,3 @@ import type { PageLoad } from "./$types"; -export const load: PageLoad = async ({ params, parent }) => { - const layout = await parent(); - return { - workspaceId: layout.workspace?.workspace_id ?? "", - runtimeId: params.runtimeId, - workerId: params.workerId, - }; -}; +export const load: PageLoad = async () => ({}); diff --git a/web/workspace/src/routes/settings/+page.svelte b/web/workspace/src/routes/settings/+page.svelte index 1737a2bc..18b67741 100644 --- a/web/workspace/src/routes/settings/+page.svelte +++ b/web/workspace/src/routes/settings/+page.svelte @@ -1,487 +1,6 @@ - - - - Settings · Yoi Workspace - - -
-
-
-

Workspace Browser

-

Settings / Admin

-

- Local administration surfaces for the Workspace backend. Runtime Connections v0 is editable through typed APIs; broader admin controls remain bounded placeholders. -

-
- local only -
- -
-
-

Authority boundary

-

No browser admin permission model

-

{SETTINGS_PERMISSION_NOTICE}

-
-
- Restart-required - Runtime config changes are persisted, then applied after backend restart. -
-
- -
- {#each SETTINGS_SECTIONS as section} - - {section.label} - {section.status === "editable" ? "Editable" : section.status === "read-only" ? "Read-only" : "Placeholder"} - - {/each} -
- -
-
-
-

editable

-

Runtime Connections

-
- typed API -
-

{SETTINGS_SECTIONS.find((section) => section.id === "runtime-connections")?.summary}

- - {#if runtimeLoading} -

Loading Runtime connections…

- {:else if runtimeError} -

Runtime connection settings unavailable: {runtimeError}

- {:else if runtimeSettings} -
- -
- - {#if showAddRuntimeForm} -
{ event.preventDefault(); void submitRemoteRuntime(); }}> -

Add remote Runtime

-

Endpoint is submitted to the Backend but not echoed back in settings responses.

- - - - -
- {/if} - - {#if mutationMessage} -

{mutationMessage}

- {/if} - {@render DiagnosticsList({ diagnostics: mutationDiagnostics })} - -
-

Runtimes

-
- - - - - - - - - - - - - - - - - - - {#if runtimeSettings.embedded.diagnostics.length > 0} - - - - {/if} - {#each runtimeSettings.remotes as remote (remote.runtime_id)} - - - - - - - - {#if remote.diagnostics.length > 0} - - - - {/if} - {#if tests[remote.runtime_id]} - {@const test = tests[remote.runtime_id]} - {@const available = capabilityOperations(test, "available")} - {@const unchecked = capabilityOperations(test, "unknown")} - - - - {/if} - {/each} - -
RuntimeSourceConnectionStatusActions
- {runtimeSettings.embedded.display_name} - {runtimeSettings.embedded.runtime_id} - - embedded - Workspace backend process - Local Backend runtime - {runtimeSettings.embedded.status} - {#if runtimeSettings.embedded.restart_required} - restart required - {/if} - Managed by backend
{@render DiagnosticsList({ diagnostics: runtimeSettings.embedded.diagnostics })}
- {remote.display_name} - {remote.runtime_id} - - remote - Configured Runtime endpoint - - Endpoint: {remote.endpoint_configured ? "configured" : "not configured"} - {#if remote.endpoint_configured}hidden{/if} - Token: {remote.token_ref_configured ? "configured" : "not configured"} - - {remote.status} - {#if remote.restart_required} - restart required - {/if} - -
- - -
-
{@render DiagnosticsList({ diagnostics: remote.diagnostics })}
-
- Test: {test.state} - {test.health_result} · {test.checked_at} -

{test.compatibility_basis}

- {#if available.length > 0} -

Verified areas: {available.join(', ')}

- {/if} - {#if unchecked.length > 0} -

Unchecked warning areas: {unchecked.join(', ')}

- {/if} - {@render DiagnosticsList({ diagnostics: test.diagnostics })} -
-
-
- {#if runtimeSettings.remotes.length === 0} -

No remote Runtime connections configured.

- {/if} -
- {/if} -
- -
- {#each SETTINGS_SECTIONS.filter((section) => section.id !== "runtime-connections") as section} -
-
-
-

{section.status}

-

{section.label}

-
- {#if section.status === "placeholder"} - not implemented - {:else} - read-only - {/if} -
-

{section.summary}

-
    - {#each section.bullets as bullet} -
  • {bullet}
    • - {/each} -
- - {#if section.id === "workspace-identity"} -
-
-
Workspace id
-
{workspace?.workspace_id ?? "loading"}
-
-
-
Display name
-
{workspace?.display_name ?? "loading"}
-
-
-
Record authority
-
.yoi tickets/objectives through the Backend projection
-
-
- {/if} -
- {/each} -
- -
-
-

Implementation patterns

-

How settings should appear

-
-
- {#each SETTINGS_PATTERNS as pattern} -
-

{pattern.title}

-

{pattern.body}

-
- {/each} -
-
- - {#if !workspace && !workspaceError} -

Loading workspace summary…

- {:else if workspaceError} -

Workspace summary unavailable: {workspaceError}

- {/if} -
- -{#snippet DiagnosticsList({ diagnostics }: { diagnostics: Diagnostic[] })} - {#if diagnostics.length > 0} -
    - {#each diagnostics as diagnostic} -
  • - {diagnosticLabel(diagnostic)} - {diagnostic.message} -
    • - {/each} -
- {/if} -{/snippet} +
+
+

Redirecting to scoped settings…

+

Settings are available at the canonical /w/<workspace-id>/settings route.

+
+
From 3315fa545804582af3af67c59a22c7cf6d722768 Mon Sep 17 00:00:00 2001 From: Hare Date: Tue, 7 Jul 2026 05:45:40 +0900 Subject: [PATCH 7/9] ticket: record workspace id route review fixes --- .yoi/tickets/00001KWWE8E04/item.md | 2 +- .yoi/tickets/00001KWWE8E04/thread.md | 27 +++++++++++++++++++++++++++ 2 files changed, 28 insertions(+), 1 deletion(-) diff --git a/.yoi/tickets/00001KWWE8E04/item.md b/.yoi/tickets/00001KWWE8E04/item.md index 89f130ae..444f5dca 100644 --- a/.yoi/tickets/00001KWWE8E04/item.md +++ b/.yoi/tickets/00001KWWE8E04/item.md @@ -2,7 +2,7 @@ title: 'Scope Workspace Browser routes and API by workspace id' state: 'inprogress' created_at: '2026-07-06T19:25:08Z' -updated_at: '2026-07-06T20:36:50Z' +updated_at: '2026-07-06T20:45:34Z' assignee: null queued_by: 'workspace-panel' queued_at: '2026-07-06T19:53:14Z' diff --git a/.yoi/tickets/00001KWWE8E04/thread.md b/.yoi/tickets/00001KWWE8E04/thread.md index 051887cc..04ad53e6 100644 --- a/.yoi/tickets/00001KWWE8E04/thread.md +++ b/.yoi/tickets/00001KWWE8E04/thread.md @@ -216,3 +216,30 @@ Non-blocking follow-ups: - redirect/shared-route refactor 後、scoped settings/workers/console endpoints の direct coverage を増やすとよい。 --- + + + +## Implementation report + +Review-fix implementation report: + +- Coder Pod completed requested changes and committed follow-up `71340b89 fix: redirect unscoped workspace routes` on branch `work/00001KWWE8E04-workspace-id-routes`. +- Worktree status was clean after commit. +- Fix summary: + - `+layout.ts` now uses `/api/workspace` only as bootstrap when route `workspaceId` is absent, then redirects to `/w/...`。 + - Silent `/api${path}` fallback for workspace-scoped data was removed。 + - Unscoped root/objectives/repository/settings/worker-console routes are thin redirect/shim surfaces instead of duplicated full data/control pages。 + - Backend SPA fallback redirects unscoped Browser routes such as `/objectives?...` to `/w//objectives?...`。 + - Canonical maintained page/control logic remains under `/w/[workspaceId]/**`。 + - Added/updated focused tests for bootstrap-then-redirect behavior, no unscoped workspace API fallback, thin settings shim, backend unscoped UI redirect, and canonical worker console scoped route references。 +- Orchestrator reran validation in the implementation worktree: + - `git diff --check`: pass + - `cd web/workspace && deno task check`: pass（0 errors / 0 warnings） + - `cd web/workspace && deno task test`: pass（17 tests） + - `cargo test -p yoi-workspace-server`: pass（65 lib tests + 2 main tests） + - `cargo check -p yoi`: pass + - `yoi ticket doctor`: ok +- `nix build .#yoi --no-link` は Cargo.lock / dependency / resource packaging / Nix 変更ではないため未実行。 +- Requesting follow-up external review against `f6ad9cfc..71340b89` and full combined implementation。 + +--- From f3fdc98319bfb4560a778a964c35971662a312cd Mon Sep 17 00:00:00 2001 From: Hare Date: Tue, 7 Jul 2026 05:52:46 +0900 Subject: [PATCH 8/9] ticket: approve workspace id route scoping --- .yoi/tickets/00001KWWE8E04/item.md | 2 +- .yoi/tickets/00001KWWE8E04/thread.md | 26 ++++++++++++++++++++++++++ 2 files changed, 27 insertions(+), 1 deletion(-) diff --git a/.yoi/tickets/00001KWWE8E04/item.md b/.yoi/tickets/00001KWWE8E04/item.md index 444f5dca..f044f2f9 100644 --- a/.yoi/tickets/00001KWWE8E04/item.md +++ b/.yoi/tickets/00001KWWE8E04/item.md @@ -2,7 +2,7 @@ title: 'Scope Workspace Browser routes and API by workspace id' state: 'inprogress' created_at: '2026-07-06T19:25:08Z' -updated_at: '2026-07-06T20:45:34Z' +updated_at: '2026-07-06T20:52:40Z' assignee: null queued_by: 'workspace-panel' queued_at: '2026-07-06T19:53:14Z' diff --git a/.yoi/tickets/00001KWWE8E04/thread.md b/.yoi/tickets/00001KWWE8E04/thread.md index 04ad53e6..e510d2a4 100644 --- a/.yoi/tickets/00001KWWE8E04/thread.md +++ b/.yoi/tickets/00001KWWE8E04/thread.md @@ -243,3 +243,29 @@ Review-fix implementation report: - Requesting follow-up external review against `f6ad9cfc..71340b89` and full combined implementation。 --- + + + +## Review: approve + +External follow-up review result: approve + +Blockers: none. + +Evidence reviewed in implementation worktree: +- Ticket `00001KWWE8E04`, fix commit `71340b89`, and combined relevant implementation。 + +Findings: +- Prior blocker 1 resolved: unscoped browser routes now bootstrap only through `/api/workspace` and redirect to `/w//...`; when no workspace id is available, layout returns empty/null state instead of loading workspace datasets through unscoped `/api/...`。 +- Prior blocker 2 resolved: canonical maintained UI/control logic is under `web/workspace/src/routes/w/[workspaceId]/...`; unscoped route files are thin empty-load/component shims and no longer duplicate critical page logic。 +- Frontend scoped API construction uses `/api/w//...` via shared helpers; scoped routes and links use `/w//...`。 +- Backend has scoped `/api/w/{workspace_id}/...` routes with centralized workspace-id assertion. Mismatches return typed/sanitized 404 diagnostic (`workspace_id_mismatch`) without raw paths, store paths, or runtime internals。 +- Runtime `/v1/...` API surface was not touched。 +- Tests meaningfully cover scoped API behavior, mismatch diagnostics, static unscoped redirect behavior, frontend scoped API/link construction, and unscoped shim/source-shape expectations。 + +Validation note: +- Reviewer did not rerun the full validation; reviewer relied on Orchestrator-reported passing validation and performed read-only inspection。 + +No merge-blocking issues found. + +--- From 1d88b333a9def6db0ca7507b8d7d689e83237d63 Mon Sep 17 00:00:00 2001 From: Hare Date: Tue, 7 Jul 2026 05:53:50 +0900 Subject: [PATCH 9/9] ticket: close workspace id route scoping --- .yoi/tickets/00001KWWE8E04/item.md | 4 +- .yoi/tickets/00001KWWE8E04/resolution.md | 32 +++++++++++ .yoi/tickets/00001KWWE8E04/thread.md | 73 ++++++++++++++++++++++++ 3 files changed, 107 insertions(+), 2 deletions(-) create mode 100644 .yoi/tickets/00001KWWE8E04/resolution.md diff --git a/.yoi/tickets/00001KWWE8E04/item.md b/.yoi/tickets/00001KWWE8E04/item.md index f044f2f9..93e402bf 100644 --- a/.yoi/tickets/00001KWWE8E04/item.md +++ b/.yoi/tickets/00001KWWE8E04/item.md @@ -1,8 +1,8 @@ --- title: 'Scope Workspace Browser routes and API by workspace id' -state: 'inprogress' +state: 'closed' created_at: '2026-07-06T19:25:08Z' -updated_at: '2026-07-06T20:52:40Z' +updated_at: '2026-07-06T20:53:44Z' assignee: null queued_by: 'workspace-panel' queued_at: '2026-07-06T19:53:14Z' diff --git a/.yoi/tickets/00001KWWE8E04/resolution.md b/.yoi/tickets/00001KWWE8E04/resolution.md new file mode 100644 index 00000000..e203ce9f --- /dev/null +++ b/.yoi/tickets/00001KWWE8E04/resolution.md @@ -0,0 +1,32 @@ +完了。 + +実装内容: +- Workspace Browser の canonical UI routes を `/w//...` に移行した。 +- Browser-facing Workspace API に `/api/w//...` scoped variants を追加した。 +- Backend current immutable `workspace_id` と path `workspace-id` を照合し、mismatch は typed sanitized `workspace_id_mismatch` diagnostic / 404 として fail closed するようにした。 +- Frontend の workspace-scoped data calls は `/api/w//...` helper 経由に変更した。 +- Sidebar / settings / repository / objectives / worker console links は workspace id を含む scoped links を使うようにした。 +- Runtime `/v1/...` API surface は変更しなかった。 +- Unscoped browser routes は `/api/workspace` bootstrap から scoped `/w//...` へ redirect する thin shim とし、通常の unscoped data route / duplicated co-canonical page surface を廃止した。 +- Backend SPA fallback でも unscoped Browser routes を scoped route に redirect するようにした。 +- Focused backend/web tests を追加/更新した。 + +主な commit / merge: +- implementation: `f6ad9cfc feat: scope workspace routes by id` +- review fix: `71340b89 fix: redirect unscoped workspace routes` +- merge into orchestration: `13e756e7 merge: workspace id route scoping` + +Review: +- 初回 external review は request_changes。 +- follow-up external review は approve。merge-blocking issue なし。 + +Final validation in Orchestrator worktree: +- `git diff --check`: pass +- `cd web/workspace && deno task check`: pass（0 errors / 0 warnings） +- `cd web/workspace && deno task test`: pass（17 tests） +- `cargo test -p yoi-workspace-server`: pass（65 lib tests + 2 main tests） +- `cargo check -p yoi`: pass +- `yoi ticket doctor`: ok + +未実行: +- `nix build .#yoi --no-link` は Cargo.lock / dependency / resource packaging / Nix 変更ではないため未実行。 \ No newline at end of file diff --git a/.yoi/tickets/00001KWWE8E04/thread.md b/.yoi/tickets/00001KWWE8E04/thread.md index e510d2a4..857cf929 100644 --- a/.yoi/tickets/00001KWWE8E04/thread.md +++ b/.yoi/tickets/00001KWWE8E04/thread.md @@ -269,3 +269,76 @@ Validation note: No merge-blocking issues found. --- + + + +## State changed + +Merge/validation acceptance: + +- Follow-up external review approved the implementation after blocker fix。 +- Implementation branch `work/00001KWWE8E04-workspace-id-routes` was merged into the orchestration branch with merge commit `13e756e7 merge: workspace id route scoping`。 +- Final validation in Orchestrator worktree passed: + - `git diff --check`: pass + - `cd web/workspace && deno task check`: pass（0 errors / 0 warnings） + - `cd web/workspace && deno task test`: pass（17 tests） + - `cargo test -p yoi-workspace-server`: pass（65 lib tests + 2 main tests） + - `cargo check -p yoi`: pass + - `yoi ticket doctor`: ok +- `nix build .#yoi --no-link` は Cargo.lock / dependency / resource packaging / Nix 変更ではないため未実行。 + +Implementation commits: +- `f6ad9cfc feat: scope workspace routes by id` +- `71340b89 fix: redirect unscoped workspace routes` + +No merge-blocking issues remain. + +--- + + + +## State changed + +Ticket を closed にしました。 + + +--- + + + +## 完了 + +完了。 + +実装内容: +- Workspace Browser の canonical UI routes を `/w//...` に移行した。 +- Browser-facing Workspace API に `/api/w//...` scoped variants を追加した。 +- Backend current immutable `workspace_id` と path `workspace-id` を照合し、mismatch は typed sanitized `workspace_id_mismatch` diagnostic / 404 として fail closed するようにした。 +- Frontend の workspace-scoped data calls は `/api/w//...` helper 経由に変更した。 +- Sidebar / settings / repository / objectives / worker console links は workspace id を含む scoped links を使うようにした。 +- Runtime `/v1/...` API surface は変更しなかった。 +- Unscoped browser routes は `/api/workspace` bootstrap から scoped `/w//...` へ redirect する thin shim とし、通常の unscoped data route / duplicated co-canonical page surface を廃止した。 +- Backend SPA fallback でも unscoped Browser routes を scoped route に redirect するようにした。 +- Focused backend/web tests を追加/更新した。 + +主な commit / merge: +- implementation: `f6ad9cfc feat: scope workspace routes by id` +- review fix: `71340b89 fix: redirect unscoped workspace routes` +- merge into orchestration: `13e756e7 merge: workspace id route scoping` + +Review: +- 初回 external review は request_changes。 +- follow-up external review は approve。merge-blocking issue なし。 + +Final validation in Orchestrator worktree: +- `git diff --check`: pass +- `cd web/workspace && deno task check`: pass（0 errors / 0 warnings） +- `cd web/workspace && deno task test`: pass（17 tests） +- `cargo test -p yoi-workspace-server`: pass（65 lib tests + 2 main tests） +- `cargo check -p yoi`: pass +- `yoi ticket doctor`: ok + +未実行: +- `nix build .#yoi --no-link` は Cargo.lock / dependency / resource packaging / Nix 変更ではないため未実行。 + +---