From ff8e3c11142500b9d8bd3fed95b03bcbcd514f43 Mon Sep 17 00:00:00 2001 From: Hare Date: Thu, 16 Jul 2026 07:51:05 +0900 Subject: [PATCH] ticket: record knowledge hash completion fix --- .yoi/tickets/00001KXKP2A71/item.md | 2 +- .yoi/tickets/00001KXKP2A71/thread.md | 30 ++++++++++++++++++++++++++++ 2 files changed, 31 insertions(+), 1 deletion(-) diff --git a/.yoi/tickets/00001KXKP2A71/item.md b/.yoi/tickets/00001KXKP2A71/item.md index 1661409d..c110b510 100644 --- a/.yoi/tickets/00001KXKP2A71/item.md +++ b/.yoi/tickets/00001KXKP2A71/item.md @@ -2,7 +2,7 @@ title: 'Remove Knowledge support' state: 'inprogress' created_at: '2026-07-15T20:04:08Z' -updated_at: '2026-07-15T22:44:47Z' +updated_at: '2026-07-15T22:50:56Z' assignee: null queued_by: 'workspace-panel' queued_at: '2026-07-15T20:27:02Z' diff --git a/.yoi/tickets/00001KXKP2A71/thread.md b/.yoi/tickets/00001KXKP2A71/thread.md index 811a9e92..db1f486f 100644 --- a/.yoi/tickets/00001KXKP2A71/thread.md +++ b/.yoi/tickets/00001KXKP2A71/thread.md @@ -292,3 +292,33 @@ Validation performed: - Static read-only review only; no tests rerun because the blocker is visible in source。 --- + + + +## Implementation report + +Second follow-up implementation progress report after request_changes: + +- Coder Pod `yoi-coder-00001KXKP2A71-knowledge-removal` completed the remaining web console `#` completion fix。 +- Follow-up commit: `20654f9c fix: disable hash console completions`。 +- Orchestrator inspected worktree status, branch log, commit stats, and `git diff --check f2106407..HEAD`; worktree was clean and diff check passed。 + +Fix summary: +- Removed `"#"` from `ComposerCompletionToken.sigil`。 +- Changed web console completion token regex from `[:@#]` to `[:@]`。 +- Removed fallback/default remapping that turned unknown sigils, including `#`, into file completion。 +- Added focused test asserting `ask #plain` is not a completion token。 +- No Knowledge/Skill compatibility or remapping was added。 + +Coder-reported validation passed: +- Focused grep over web console/route completion files for `"#"`, `[:@#]`, `case "#"`, `#`, `#`, `knowledge`: no hits。 +- `cd web/workspace && deno task check && deno task test` +- `git diff --check` +- `cargo check -p yoi` +- `yoi ticket doctor` +- `nix build .#yoi --no-link` + +Next action: +- Request focused re-review of the remaining hash completion blocker and overall acceptance before merge/close decisions。 + +---