Compare commits
No commits in common. "da047d56869a103ed3bed5d9b96feba5dbdf529e" and "8e449acd59f6c57f7ef8c08adc5d59bf4a0f57df" have entirely different histories.
da047d5686
...
8e449acd59
|
|
@ -1,8 +1,8 @@
|
|||
---
|
||||
title: 'Workspace Worker Consoleを任意Worker attach前提で再設計する'
|
||||
state: 'closed'
|
||||
state: 'done'
|
||||
created_at: '2026-06-26T17:42:10Z'
|
||||
updated_at: '2026-07-02T11:55:42Z'
|
||||
updated_at: '2026-06-26T18:22:51Z'
|
||||
assignee: null
|
||||
queued_by: 'workspace-panel'
|
||||
queued_at: '2026-06-26T17:45:40Z'
|
||||
|
|
|
|||
|
|
@ -1,3 +0,0 @@
|
|||
Ticket `00001KW2GCPYF` (`Workspace Worker Consoleを任意Worker attach前提で再設計する`) はすでに `state: done` に到達していたため、workspace Dashboard から close しました。
|
||||
|
||||
この Close action によって、実装作業、state 変更、Orchestrator/Companion launch、worker invocation は開始されていません。
|
||||
|
|
@ -378,24 +378,4 @@ Cleanup report:
|
|||
Operational note:
|
||||
- StopPod was executed sequentially, not in parallel.
|
||||
|
||||
---
|
||||
|
||||
<!-- event: state_changed author: hare at: 2026-07-02T11:55:42Z from: done to: closed reason: closed field: state -->
|
||||
|
||||
## State changed
|
||||
|
||||
Ticket を closed にしました。
|
||||
|
||||
|
||||
---
|
||||
|
||||
<!-- event: close author: hare at: 2026-07-02T11:55:42Z status: closed -->
|
||||
|
||||
## 完了
|
||||
|
||||
Ticket `00001KW2GCPYF` (`Workspace Worker Consoleを任意Worker attach前提で再設計する`) はすでに `state: done` に到達していたため、workspace Dashboard から close しました。
|
||||
|
||||
この Close action によって、実装作業、state 変更、Orchestrator/Companion launch、worker invocation は開始されていません。
|
||||
|
||||
|
||||
---
|
||||
|
|
|
|||
|
|
@ -1,3 +0,0 @@
|
|||
{"id":"orch-plan-20260702-164730-1","ticket_id":"00001KWHEM8YJ","kind":"waiting_capacity_note","note":"Dashboard 起動時の queue review。対象 Ticket は未指定で、ユーザー指示により explicit follow-up まで role Pod spawn / queued->inprogress acceptance は行わない human gate として待機する。確認済み: Ticket 本文/最近の thread、TicketRelationQuery（0件）、TicketOrchestrationPlanQuery（0件）、workspace git/worktree 状態、visible Pods、TicketDoctor（0 errors）。","author":"orchestrator","at":"2026-07-02T16:47:30Z"}
|
||||
{"id":"orch-plan-20260702-170047-2","ticket_id":"00001KWHEM8YJ","kind":"accepted_plan","accepted_plan":{"summary":"`00001KWHHRTM9` と `00001KWHEM8YJ` は workspace Browser の runtime/worker UI/API surface が重なるため、別 worktree 並列ではなく同一 branch/worktree で順序実装する。human gate は明示 follow-up で解除済み。","branch":"work/00001KWHHRTM9-00001KWHEM8YJ","worktree":"/home/hare/Projects/yoi/.worktree/00001KWHHRTM9-00001KWHEM8YJ","role_plan":"単一 sibling Coder Pod に同一 implementation worktree を委譲し、Runtime connection settings/API を先に実装してから Manual Coding Worker launch 導線を実装する。実装後は別 sibling Reviewer Pod で両 Ticket の recorded IntentPacket / invariants / acceptance criteria に照らしてレビューする。"},"author":"orchestrator","at":"2026-07-02T17:00:47Z"}
|
||||
{"id":"orch-plan-20260702-170054-3","ticket_id":"00001KWHEM8YJ","kind":"after","related_ticket":"00001KWHHRTM9","note":"同一 worktree で順序実装する。Manual Coding Worker launch は Runtime connection settings/API の candidate/projection 境界に合わせて後続実装する。","author":"orchestrator","at":"2026-07-02T17:00:54Z"}
|
||||
|
|
@ -1,188 +0,0 @@
|
|||
---
|
||||
title: 'Workspace Browserから手動Coding Workerを作成する導線を追加する'
|
||||
state: 'closed'
|
||||
created_at: '2026-07-02T12:59:57Z'
|
||||
updated_at: '2026-07-02T18:24:50Z'
|
||||
assignee: null
|
||||
queued_by: 'workspace-panel'
|
||||
queued_at: '2026-07-02T16:13:24Z'
|
||||
---
|
||||
|
||||
## 背景
|
||||
|
||||
Workspace Browser には Runtime / Worker catalog と Worker Console はあるが、ユーザーが Browser から「普通に読み書きできる coding agent Worker」を明示作成する導線がまだ無い。
|
||||
|
||||
現状の `workspace-server` には Runtime worker spawn の backend 経路があり、Browser-facing API としても `/api/runtimes/{runtime_id}/workers` が存在する。ただし、この既存 endpoint は Runtime create に近い field を受け取り得るため、Browser UI から `ConfigBundleRef`、requested capabilities、raw workspace path、cwd、secret、runtime store path などを直接渡す導線にしてはいけない。
|
||||
|
||||
この Ticket では、Workspace sidebar の WORKER セクションから明示的に New form を開き、Backend が coding preset を解決して Worker を作成し、作成後に Worker Console へ遷移する導線を作る。
|
||||
|
||||
## 目的
|
||||
|
||||
- Workspace Browser から手動で Coding Worker を作成できるようにする。
|
||||
- Sidebar の WORKER 見出し横に `New` button を置く。
|
||||
- Browser-facing request は product-level launch request とし、Runtime internal create request を直接露出しない。
|
||||
- Backend が coding preset から Profile / ConfigBundle / execution backend / workspace scope を解決する。
|
||||
- 作成成功後は Worker Console に遷移する。
|
||||
- 作成失敗時は sanitized diagnostic を form に表示する。
|
||||
|
||||
## UI 設計
|
||||
|
||||
### Sidebar entry point
|
||||
|
||||
`web/workspace/src/lib/workspace-sidebar/WorkersNavSection.svelte` の WORKER section heading 横に `New` button を追加する。
|
||||
|
||||
```text
|
||||
WORKER New
|
||||
```
|
||||
|
||||
`New` を押すと Worker 作成 form を開く。v0 は sidebar 内の inline panel でも modal/dialog でもよいが、既存 sidebar UX を壊さないこと。
|
||||
|
||||
### Form fields
|
||||
|
||||
v0 の form は次の 4 field に限定する。
|
||||
|
||||
- `display_name`
|
||||
- optional。
|
||||
- Worker identity ではなく表示名だけに使う。
|
||||
- `runtime_id`
|
||||
- 対象 Runtime。
|
||||
- default: embedded Runtime。
|
||||
- 候補は `/api/workspace` など既存 projection から `can_spawn_worker=true` の Runtime を使うか、v0 は embedded Runtime 固定でもよい。
|
||||
- `profile`
|
||||
- Worker の振る舞いを選ぶ Profile。
|
||||
- default: coding 用 Profile。
|
||||
- Browser の自由入力ではなく、Backend が公開する候補から選ぶ。
|
||||
- `initial_text`
|
||||
- optional。
|
||||
- 作成直後の user input として Worker に渡す。
|
||||
|
||||
`kind = coding` はこの endpoint の launch mode として Backend が持ってよいが、form の入力 field にはしない。
|
||||
|
||||
自由入力にしないもの:
|
||||
|
||||
- raw workspace path。
|
||||
- cwd。
|
||||
- tool scope。
|
||||
- `ConfigBundleRef`。
|
||||
- `requested_capabilities`。
|
||||
- secret / token。
|
||||
- Runtime endpoint / socket path / session path / store path。
|
||||
|
||||
### Success behavior
|
||||
|
||||
Worker 作成成功後:
|
||||
|
||||
1. Worker list を refresh する。
|
||||
2. 作成された Worker の Console に遷移する。
|
||||
|
||||
```text
|
||||
/runtimes/{runtime_id}/workers/{worker_id}/console
|
||||
```
|
||||
|
||||
### Error behavior
|
||||
|
||||
Worker 作成失敗時:
|
||||
|
||||
- form 内に sanitized diagnostic を表示する。
|
||||
- raw path、secret、Runtime endpoint、internal store path を表示しない。
|
||||
- form の入力値は保持する。
|
||||
|
||||
## Backend API 設計
|
||||
|
||||
Browser から既存 Runtime create payload を直接叩かせず、Workspace Backend に product-level endpoint を追加する。
|
||||
|
||||
候補:
|
||||
|
||||
```http
|
||||
POST /api/workers
|
||||
```
|
||||
|
||||
request v0:
|
||||
|
||||
```json
|
||||
{
|
||||
"runtime_id": "embedded-worker-runtime",
|
||||
"display_name": "scratch worker",
|
||||
"profile": "builtin:coder",
|
||||
"initial_text": "このリポジトリを確認して"
|
||||
}
|
||||
```
|
||||
|
||||
response:
|
||||
|
||||
```json
|
||||
{
|
||||
"runtime_id": "embedded-worker-runtime",
|
||||
"worker_id": "...",
|
||||
"worker": { ... existing WorkerSummary or WorkerDetail projection ... }
|
||||
}
|
||||
```
|
||||
|
||||
### Backend resolution
|
||||
|
||||
Backend は manual Coding Worker launch endpoint として、request の `profile` を次へ解決する。
|
||||
|
||||
- Profile 候補に存在するか検証する。
|
||||
- Profile から default ConfigBundle を解決 / sync / check する。
|
||||
- embedded / selected Runtime spawn を行う。
|
||||
- normal workspace read/write capable Worker execution path に接続する。
|
||||
- initial text を Worker input / initial input として送る。
|
||||
|
||||
Browser-facing request に `kind`、ConfigBundle identity、requested capabilities を持たせない。
|
||||
|
||||
### 既存 endpoint との関係
|
||||
|
||||
- `/api/runtimes/{runtime_id}/workers` は internal-ish Runtime spawn endpoint として残ってよい。
|
||||
- Browser の New Worker UI は新しい `/api/workers` product-level endpoint を使う。
|
||||
- 将来的に `/api/runtimes/{runtime_id}/workers` を debug/admin/internal に寄せるかは別 Ticket で扱う。
|
||||
|
||||
## Coding Worker の意味
|
||||
|
||||
この Ticket の Coding Worker は、一般的な coding agent と同様に workspace 内のファイルを読み書きできる Worker を指す。
|
||||
|
||||
ただし Browser が file path / scope / tool grant を直接指定するのではなく、Backend が現在の Workspace Backend 実行環境に基づいて既存 execution backend / tool host の範囲へ接続する。
|
||||
|
||||
v0 では embedded Runtime / local execution backend を対象にする。remote Runtime で workspace provisioning が未対応の場合は typed diagnostic で拒否してよい。
|
||||
|
||||
## 実装要件
|
||||
|
||||
- `WorkersNavSection.svelte` の heading 横に `New` button を追加する。
|
||||
- New form を追加し、display name / runtime / profile / initial text を入力できる。
|
||||
- Form submit で Browser-facing `/api/workers` launch endpoint を呼ぶ。
|
||||
- Backend に `/api/workers` POST endpoint を追加する。
|
||||
- Backend request type は product-level launch request とし、Runtime create request をそのまま deserialize しない。
|
||||
- Backend が request の `profile` を default coding Worker launch に解決する。
|
||||
- Browser-facing request/response に raw workspace path、cwd、ConfigBundleRef、requested capabilities、secret、Runtime endpoint、store path を含めない。
|
||||
- 作成成功後に Worker Console へ遷移する。
|
||||
- 作成失敗時に sanitized diagnostic を表示する。
|
||||
- Worker list refresh を行う。
|
||||
|
||||
## 受け入れ条件
|
||||
|
||||
- Sidebar WORKER heading 横に `New` button がある。
|
||||
- `New` で Worker 作成 form が開く。
|
||||
- Form には display name / runtime / profile / initial text だけがある。
|
||||
- Form から coding Worker を作成できる。
|
||||
- Form request は `/api/workers` product-level endpoint を使う。
|
||||
- Browser-facing payload に raw path / cwd / `ConfigBundleRef` / requested capabilities / secret / Runtime endpoint / store path が含まれない。
|
||||
- Backend が request の `profile` から Profile / ConfigBundle / execution backend を解決する。
|
||||
- 作成成功後、作成された Worker の Console に遷移する。
|
||||
- 作成失敗時、sanitized diagnostic が表示される。
|
||||
- remote Runtime など未対応対象では typed diagnostic で拒否される。
|
||||
- Focused tests が Backend launch endpoint、payload sanitization、success projection、unsupported runtime diagnostic、UI form rendering / submit path を確認する。
|
||||
- `cd web/workspace && deno task test` が通る。
|
||||
- `cd web/workspace && deno task check` が通る。
|
||||
- `cargo test -p yoi-workspace-server` が通る。
|
||||
- `cargo check -p yoi` が通る。
|
||||
- `git diff --check` が通る。
|
||||
- `nix build .#yoi --no-link` が通る。
|
||||
|
||||
## 対象外
|
||||
|
||||
- Remote Runtime workspace provisioning の完成。
|
||||
- per-worker cwd / tool scope の新 UI。
|
||||
- ConfigBundle editor UI。
|
||||
- Profile picker の本格実装。
|
||||
- multi-agent Ticket role launch UI。
|
||||
- Worker reconnect / stale recovery UI。
|
||||
- `/api/runtimes/{runtime_id}/workers` の削除。
|
||||
|
|
@ -1,31 +0,0 @@
|
|||
完了。
|
||||
|
||||
実装内容:
|
||||
- Workspace Sidebar の WORKER heading に `New` button と Worker 作成 form を追加した。
|
||||
- form は display name / runtime / profile / initial text の product-level fields のみを扱う。
|
||||
- Browser-facing `/api/workers` POST を追加/利用し、内部 Runtime create payload や raw authority-bearing fields を UI/API contract に露出しないようにした。
|
||||
- profile/runtime は Backend-published candidates から選択し、自由入力にしないようにした。
|
||||
- 作成成功時は Worker list を refresh し、`/runtimes/{runtime_id}/workers/{worker_id}/console` に遷移するようにした。
|
||||
- unsupported runtime / not accepted cases は Runtime diagnostics を sanitized typed diagnostics として保持するようにした。
|
||||
- Focused backend/web tests を追加した。
|
||||
|
||||
主な commit / merge:
|
||||
- implementation: `f2fead7e feat: add workspace runtime and worker controls`
|
||||
- review fix: `47ed0ff8 fix: harden runtime and worker launch controls`
|
||||
- merge to develop: `4edaa73d merge: runtime worker controls`
|
||||
- ticket-record merge before closure: `540e55d4 merge: runtime worker ticket records`
|
||||
|
||||
Review:
|
||||
- 初回 external review は request_changes。
|
||||
- follow-up external review は approve。merge-blocking issue なし。
|
||||
|
||||
Final validation on `develop`:
|
||||
- `git diff --check`: pass
|
||||
- `cargo test -p yoi-workspace-server`: pass（55 lib tests + 2 main tests）
|
||||
- `cargo check -p yoi`: pass
|
||||
- `cd web/workspace && deno task test`: pass（13 tests）
|
||||
- `cd web/workspace && deno task check`: pass（0 errors / 0 warnings）
|
||||
- `yoi ticket doctor`: ok
|
||||
|
||||
未実行:
|
||||
- `nix build .#yoi --no-link` は Cargo.lock / dependency / resource packaging / Nix 変更ではないため未実行。
|
||||
|
|
@ -1,360 +0,0 @@
|
|||
<!-- event: create author: "yoi ticket" at: 2026-07-02T12:59:57Z -->
|
||||
|
||||
## 作成
|
||||
|
||||
LocalTicketBackend によって作成されました。
|
||||
|
||||
---
|
||||
|
||||
<!-- event: plan author: hare at: 2026-07-02T13:00:58Z -->
|
||||
|
||||
## Plan
|
||||
|
||||
Workspace Browser から手動 Coding Worker を作成する導線として Ticket を詳細化した。
|
||||
|
||||
方針:
|
||||
- Sidebar WORKER heading 横に `New` button を追加する。
|
||||
- New form は runtime / display name / initial text の最小入力にする。
|
||||
- Browser は Runtime create request を直接送らず、product-level `/api/workers` endpoint を使う。
|
||||
- Backend が `kind=coding` を default coding Worker launch に解決する。
|
||||
- Browser-facing payload に raw path / cwd / ConfigBundleRef / requested capabilities / secret / Runtime endpoint / store path を含めない。
|
||||
- 成功後は作成 Worker の Console に遷移し、失敗時は sanitized diagnostic を form に表示する。
|
||||
|
||||
|
||||
---
|
||||
|
||||
<!-- event: decision author: hare at: 2026-07-02T13:06:46Z -->
|
||||
|
||||
## Decision
|
||||
|
||||
Manual Coding Worker create form fields を明確化した。
|
||||
|
||||
決定:
|
||||
- v0 form は `display_name`、`runtime_id`、`profile`、`initial_text` の 4 field に限定する。
|
||||
- `kind = coding` は endpoint / Backend 側 launch mode として扱い、form input や Browser-facing payload field にはしない。
|
||||
- `profile` は Browser 自由入力ではなく、Backend が公開する候補から選ぶ。
|
||||
- Browser-facing request は `runtime_id` / `display_name` / `profile` / `initial_text` にし、`ConfigBundleRef`、requested capabilities、raw path、cwd、secret、Runtime endpoint、store path は含めない。
|
||||
|
||||
|
||||
---
|
||||
|
||||
<!-- event: intake_summary author: hare at: 2026-07-02T15:39:49Z -->
|
||||
|
||||
## Intake summary
|
||||
|
||||
Marked ready by `yoi ticket state`.
|
||||
|
||||
---
|
||||
|
||||
<!-- event: state_changed author: "yoi ticket" at: 2026-07-02T15:39:49Z from: planning to: ready reason: cli_state field: state -->
|
||||
|
||||
## State changed
|
||||
|
||||
Marked ready by `yoi ticket state`.
|
||||
|
||||
|
||||
---
|
||||
|
||||
<!-- event: state_changed author: workspace-panel at: 2026-07-02T16:13:24Z from: ready to: queued reason: queued field: state -->
|
||||
|
||||
## State changed
|
||||
|
||||
Ticket を `workspace-panel` が queued にしました。
|
||||
|
||||
|
||||
---
|
||||
|
||||
<!-- event: decision author: orchestrator at: 2026-07-02T17:00:32Z -->
|
||||
|
||||
## Decision
|
||||
|
||||
Routing decision: implementation_ready
|
||||
|
||||
Reason:
|
||||
- Ticket は Manual Coding Worker launch の product-level API / Sidebar New form / sanitized payload / success Console navigation / unsupported runtime diagnostic を具体化しており、observable な acceptance criteria と validation がある。
|
||||
- typed relation blocker は 0 件、OrchestrationPlan は prior human-gate waiting note のみで、ユーザーから「2つとも消化して」と明示 follow-up があったため human gate は解除された。
|
||||
- `00001KWHHRTM9` の Runtime connection management と UI/API surface が近く、別 worktree 並列では衝突リスクが高いので、同一 implementation worktree/branch で `00001KWHHRTM9` を先に実装し、その Runtime candidate/projection を利用して本 Ticket を続けて実装する。
|
||||
|
||||
Evidence checked:
|
||||
- Ticket body / thread / artifacts。
|
||||
- `TicketRelationQuery(00001KWHEM8YJ)` は 0 件。
|
||||
- `TicketOrchestrationPlanQuery(00001KWHEM8YJ)` は prior human-gate waiting note のみ。
|
||||
- queued Ticket 一覧では `00001KWHHRTM9` も queued、ready/inprogress は 0 件。
|
||||
- workspace/orchestration git state と worktree 一覧、visible Pods、TicketDoctor（0 errors / 既存 warning のみ）。
|
||||
- Bounded code map: `web/workspace/src/lib/workspace-sidebar/WorkersNavSection.svelte`、console route under `web/workspace/src/routes/runtimes/[runtimeId]/workers/[workerId]/console/`、existing `/api/workers` list projection、`/api/runtimes/{runtime_id}/workers` internal-ish Runtime spawn path、`crates/workspace-server` runtime/backend/config areas。
|
||||
|
||||
IntentPacket:
|
||||
|
||||
Intent:
|
||||
- Workspace Browser sidebar の WORKER heading 横に `New` button と作成 form を追加し、Browser-facing `/api/workers` product-level endpoint から coding Worker を作成し、成功後に Worker Console へ遷移する。
|
||||
|
||||
Binding decisions / invariants:
|
||||
- Browser UI は existing Runtime create payload を直接露出しない。
|
||||
- Browser-facing request fields は `runtime_id` / `display_name` / `profile` / `initial_text` のみ。`kind` は endpoint/backend launch mode として扱い、form input や request field にしない。
|
||||
- Browser-facing payload/response/form に raw workspace path、cwd、tool scope、`ConfigBundleRef`、requested capabilities、secret/token、Runtime endpoint、socket/session/store path を含めない。
|
||||
- `profile` は Backend が公開する候補から選ばせ、自由入力にしない。
|
||||
- v0 は embedded/local Runtime を primary target とし、remote Runtime の workspace provisioning が未対応なら typed diagnostic で拒否してよい。
|
||||
- `/api/runtimes/{runtime_id}/workers` は残してよいが、New Worker UI は新しい product-level `/api/workers` POST を使う。
|
||||
|
||||
Requirements / acceptance criteria:
|
||||
- Sidebar WORKER heading 横に `New` button がある。
|
||||
- `New` で display name / runtime / profile / initial text だけの form が開く。
|
||||
- Form submit は `/api/workers` product-level endpoint を使い、coding Worker を作成できる。
|
||||
- Backend は request の `profile` から Profile / ConfigBundle / execution backend を解決する。
|
||||
- 作成成功後、Worker list を refresh し、`/runtimes/{runtime_id}/workers/{worker_id}/console` へ遷移する。
|
||||
- 作成失敗時、入力値を保持して sanitized diagnostic を form に表示する。
|
||||
- focused backend/UI tests を追加し、指定 validation を可能な範囲で実行する。
|
||||
|
||||
Implementation latitude:
|
||||
- Runtime candidate は `00001KWHHRTM9` の projection を利用する。v0 で embedded-only fallback が必要なら許容されるが、Browser 自由入力にはしない。
|
||||
- Product-level endpoint の internal mapping、response shape、Svelte form placement（inline/sidebar panel/modal）は既存 UX を壊さない範囲で選んでよい。
|
||||
- Profile candidate の v0 source は backend-provided static/builtin candidates でもよい。ただし自由入力化しない。
|
||||
|
||||
Escalate if:
|
||||
- Browser-facing API に raw path/cwd/scope/secret/runtime internal location を含めないと実装できない場合。
|
||||
- Profile/ConfigBundle resolution の既存 boundary を変える必要が出た場合。
|
||||
- remote runtime provisioning を完成させないと acceptance を満たせない場合。
|
||||
|
||||
Validation:
|
||||
- `cd web/workspace && deno task test`
|
||||
- `cd web/workspace && deno task check`
|
||||
- `cargo test -p yoi-workspace-server`
|
||||
- `cargo check -p yoi`
|
||||
- `git diff --check`
|
||||
- `nix build .#yoi --no-link` は時間/依存変更の重さを見て実行、未実行なら理由を report。
|
||||
|
||||
Current code map:
|
||||
- Sidebar UI: `web/workspace/src/lib/workspace-sidebar/WorkersNavSection.svelte`, `WorkspaceSidebar.svelte`。
|
||||
- Worker console/navigation: `web/workspace/src/lib/workspace-console/model`, `web/workspace/src/routes/runtimes/[runtimeId]/workers/[workerId]/console/`。
|
||||
- Existing worker list and runtime spawn APIs: `crates/workspace-server` `/api/workers` and `/api/runtimes/{runtime_id}/workers` handlers, worker-runtime `CreateWorkerRequest` / config bundle resolution paths。
|
||||
- Runtime candidates/settings base: `00001KWHHRTM9` implementation in the same worktree.
|
||||
|
||||
Critical risks / reviewer focus:
|
||||
- Product-level endpoint does not deserialize or expose the internal Runtime create request shape.
|
||||
- Browser-facing surfaces are sanitized and do not leak raw path/cwd/scope/ConfigBundleRef/requested capabilities/secret/runtime endpoint/socket/session/store path.
|
||||
- Profile/runtime selectors are bounded to backend-published choices.
|
||||
- Success navigation and worker list refresh are deterministic.
|
||||
- The combined implementation with `00001KWHHRTM9` keeps runtime connection management and manual worker launch contracts consistent.
|
||||
|
||||
---
|
||||
|
||||
<!-- event: state_changed author: orchestrator at: 2026-07-02T17:01:11Z from: queued to: inprogress reason: routing_acceptance_implementation_ready field: state -->
|
||||
|
||||
## State changed
|
||||
|
||||
Queued acceptance recorded after explicit user follow-up 「2つとも消化して」。
|
||||
|
||||
Checked context:
|
||||
- Ticket body / thread / artifacts。
|
||||
- `TicketRelationQuery(00001KWHEM8YJ)`: blocking relation 0 件。
|
||||
- `TicketOrchestrationPlanQuery(00001KWHEM8YJ)`: prior human-gate waiting note を確認し、今回 accepted_plan / after ordering を記録済み。
|
||||
- workspace/worktree/visible Pod/TicketDoctor/code-map の bounded check。
|
||||
|
||||
Acceptance basis:
|
||||
- concrete missing decision / information は残っていない。
|
||||
- `00001KWHHRTM9` と surface が重なるため、同一 implementation worktree で `00001KWHHRTM9` の後に実装する。
|
||||
- side effect はこの `queued -> inprogress` acceptance 後に開始する。
|
||||
|
||||
---
|
||||
|
||||
<!-- event: implementation_report author: orchestrator at: 2026-07-02T17:02:43Z -->
|
||||
|
||||
## Implementation report
|
||||
|
||||
Implementation side-effect recovery note:
|
||||
|
||||
- `queued -> inprogress` acceptance 後、implementation worktree `/home/hare/Projects/yoi/.worktree/00001KWHHRTM9-00001KWHEM8YJ` / branch `work/00001KWHHRTM9-00001KWHEM8YJ` は作成済み。
|
||||
- 最初の Coder Pod spawn は、child workspace root `/home/hare/Projects/yoi` を readable scope に含めていなかったため `workspace root is not readable under the configured scope` で失敗した。
|
||||
- Ticket は `inprogress` のまま、read scope に workspace root、write scope に implementation worktree だけを含める形で即時 retry する。raw runtime/socket/session details は implementation contract には含めない。
|
||||
|
||||
---
|
||||
|
||||
<!-- event: implementation_report author: orchestrator at: 2026-07-02T17:03:28Z -->
|
||||
|
||||
## Implementation report
|
||||
|
||||
Implementation routing update:
|
||||
|
||||
- Recovery retry succeeded: sibling Coder Pod `yoi-coder-00001KWHHRTM9-00001KWHEM8YJ` was spawned for the combined branch/worktree.
|
||||
- Scope policy: workspace root is readable for runtime workspace metadata; write authority is restricted to implementation worktree `/home/hare/Projects/yoi/.worktree/00001KWHHRTM9-00001KWHEM8YJ`.
|
||||
- Work order remains: `00001KWHHRTM9` first, then this Ticket; external review will be requested after coder completion evidence is available.
|
||||
|
||||
---
|
||||
|
||||
<!-- event: implementation_report author: orchestrator at: 2026-07-02T17:29:34Z -->
|
||||
|
||||
## Implementation report
|
||||
|
||||
Implementation progress report:
|
||||
|
||||
- Coder Pod completed the combined implementation and committed `f2fead7e feat: add workspace runtime and worker controls` on branch `work/00001KWHHRTM9-00001KWHEM8YJ`.
|
||||
- Worktree status was clean after commit.
|
||||
- Changed areas include `crates/workspace-server/src/config.rs`, `crates/workspace-server/src/hosts.rs`, `crates/workspace-server/src/server.rs`, Settings UI/model/tests, Worker sidebar UI/types, and workspace TS config/CSS.
|
||||
- Orchestrator reran validation:
|
||||
- `git diff --check`: pass
|
||||
- `cargo test -p yoi-workspace-server`: pass（51 lib tests + 2 main tests）
|
||||
- `cargo check -p yoi`: pass
|
||||
- `cd web/workspace && deno task test`: pass（11 tests）
|
||||
- `cd web/workspace && deno task check`: pass（0 errors / 0 warnings）
|
||||
- `nix build .#yoi --no-link` は dependency/resource packaging 変更ではないため未実行。
|
||||
- External review requested via sibling Reviewer Pod `yoi-reviewer-00001KWHHRTM9-00001KWHEM8YJ`.
|
||||
|
||||
---
|
||||
|
||||
<!-- event: review author: reviewer at: 2026-07-02T17:36:45Z status: request_changes -->
|
||||
|
||||
## Review: request changes
|
||||
|
||||
External review result: request_changes
|
||||
|
||||
Checked evidence:
|
||||
- 両 Ticket record と最新 IntentPacket / orchestration-plan を確認。
|
||||
- `f2fead7e` の diff/stat/check evidence を確認（10 files changed、`git diff --check f2fead7e^ f2fead7e` clean）。
|
||||
- `config.rs`, `hosts.rs`, `server.rs`, settings UI/model/tests, sidebar worker form/types, CSS/tsconfig を focused static review。
|
||||
- Reviewer は read-only で、validation 再実行はせず Orchestrator reported validation pass を参照。
|
||||
|
||||
Blockers:
|
||||
|
||||
1. Runtime connection `test` が recorded lightweight negotiation / compatibility contract を満たしていない。
|
||||
- Ticket は observed runtime capabilities の parse と Browser 必要 operation（list workers, observe detail, event websocket construction, spawn, input dispatch, config-bundle availability/sync）に対する compatibility check を要求している。
|
||||
- 現状 `test_remote_runtime_config` は `/v1/runtime` を呼び、狭い `RuntimeHttpSummaryResponse` を parse した後、operation compatibility check なしで常に `state: "compatible"`, `capabilities: Vec::new()` を返す。
|
||||
- acceptance criterion の sanitized compatibility/capabilities/diagnostics response を満たしていない。
|
||||
|
||||
2. Browser-facing diagnostic sanitization が endpoint/path leak invariant に対して不十分。
|
||||
- remote test failure path が `sanitize_backend_error(&error.to_string())` を Browser response に入れている。
|
||||
- sanitizer は `/home/`, `/Users/`, `\\`, `:\\` を含む message だけ置換するため、reqwest error の requested URL や non-home config/temp path が漏れる可能性がある。
|
||||
- Ticket は Runtime endpoint/config path/internal location を Browser-facing response に漏らさないことを要求しているため、raw backend error string ではなく fixed typed diagnostics にする必要がある。
|
||||
|
||||
3. Manual Worker launch が rejected Runtime operation の typed unsupported diagnostics を落としている。
|
||||
- `create_workspace_worker` が non-`Accepted` `WorkerOperationResult` を generic `workspace_worker_create_failed` に変換し、`result.diagnostics` を破棄している。
|
||||
- unsupported remote/runtime cases は typed sanitized diagnostics を返す必要がある。
|
||||
|
||||
4. key contracts の focused acceptance tests が不足。
|
||||
- backend は helper-level validation/sanitizer tests に寄っており、runtime connection list/add/delete/test negotiation、config persistence、restart_required、`/api/workers` POST success/unsupported diagnostics の route-level tests が足りない。
|
||||
- Web は settings model helper tests のみで、New Worker form rendering/submit-path test がない。
|
||||
|
||||
Non-blocking follow-ups:
|
||||
- manual Worker launch の `display_name` は optional と記録されているが backend/UI は non-empty を要求している。空なら default label derivation を検討。
|
||||
- Browser-facing request structs に `deny_unknown_fields` を付けると “only these fields” boundary が fail closed になる。
|
||||
- `nix build .#yoi --no-link` は dependency/resource packaging 変更ではないため未実行だが、acceptance evidence としては未検証。
|
||||
|
||||
---
|
||||
|
||||
<!-- event: implementation_report author: orchestrator at: 2026-07-02T18:11:11Z -->
|
||||
|
||||
## Implementation report
|
||||
|
||||
Review-fix implementation report:
|
||||
|
||||
- Coder Pod completed requested changes and committed follow-up `47ed0ff8 fix: harden runtime and worker launch controls` on branch `work/00001KWHHRTM9-00001KWHEM8YJ`.
|
||||
- Worktree status was clean after commit.
|
||||
- Fix changed `crates/workspace-server/src/server.rs`, `web/workspace/deno.json`, `WorkersNavSection.svelte`, and added `worker-launch.ts` / `worker-launch.test.ts`.
|
||||
- Reported fixes include lightweight runtime compatibility probes, fixed sanitized remote-test diagnostics without endpoint/path leakage, preservation of typed unsupported worker-create diagnostics, `deny_unknown_fields` on Browser-facing request structs, empty display-name default derivation, backend route/acceptance tests, and web worker-launch model tests.
|
||||
- Orchestrator reran validation:
|
||||
- `git diff --check`: pass
|
||||
- `cargo test -p yoi-workspace-server`: pass（55 lib tests + 2 main tests）
|
||||
- `cargo check -p yoi`: pass
|
||||
- `cd web/workspace && deno task test`: pass（13 tests）
|
||||
- `cd web/workspace && deno task check`: pass（0 errors / 0 warnings）
|
||||
- `nix build .#yoi --no-link` は dependency/resource packaging 変更ではないため未実行。
|
||||
- Requesting follow-up external review against `f2fead7e..47ed0ff8` and full combined implementation.
|
||||
|
||||
---
|
||||
|
||||
<!-- event: review author: reviewer at: 2026-07-02T18:20:10Z status: approve -->
|
||||
|
||||
## Review: approve
|
||||
|
||||
External follow-up review result: approve
|
||||
|
||||
Read-only follow-up review completed for both Tickets and fix commit `47ed0ff8` on top of `f2fead7e`.
|
||||
|
||||
Evidence reviewed:
|
||||
- Ticket records for `00001KWHHRTM9` and `00001KWHEM8YJ`.
|
||||
- Fix diff `f2fead7e..47ed0ff8`.
|
||||
- Relevant backend/web files including `crates/workspace-server/src/server.rs`, `config.rs`, `hosts.rs`, `worker-launch.ts`, `WorkersNavSection.svelte`, related tests/settings model files.
|
||||
- Orchestrator-reported validation pass for `git diff --check`, `cargo test -p yoi-workspace-server`, `cargo check -p yoi`, `cd web/workspace && deno task test`, and `cd web/workspace && deno task check`.
|
||||
|
||||
Reviewer findings:
|
||||
- Previous blocker 1 resolved: runtime connection test now performs lightweight negotiation/probing for Browser-relevant operations and represents unsupported/not-observed operations with typed diagnostics and `unknown`/`unsupported` capability entries instead of blanket compatibility.
|
||||
- Previous blocker 2 resolved: Browser-facing remote-test diagnostics omit raw endpoints/config paths/socket/session/store paths and use typed/sanitized diagnostics; tests assert projected responses do not contain the endpoint/runtime address.
|
||||
- Previous blocker 3 resolved: `/api/workers` keeps product-level request shape and preserves runtime rejection diagnostics while adding typed `workspace_worker_create_not_accepted` diagnostic.
|
||||
- Previous blocker 4 resolved: focused backend tests cover runtime connection test sanitization/compatibility, worker creation payload rejection, diagnostic preservation; web tests cover launch payload shaping/error handling.
|
||||
- Persisted config, live registry summaries, and test observations remain separated.
|
||||
- Browser-facing settings responses expose safe summaries rather than raw authority-bearing backend fields.
|
||||
- New Worker UI consumes `/api/workers/options` candidates and submits only product-level `/api/workers` payload.
|
||||
|
||||
Non-blocking follow-up:
|
||||
- UI could later render backend diagnostic codes/details more richly on Worker launch failure, but current behavior is sanitized and merge-ready.
|
||||
|
||||
No merge-blocking issues found.
|
||||
|
||||
---
|
||||
|
||||
<!-- event: state_changed author: orchestrator at: 2026-07-02T18:24:26Z from: inprogress to: done reason: merged_validated_review_approved field: state -->
|
||||
|
||||
## State changed
|
||||
|
||||
Merge/validation acceptance:
|
||||
|
||||
- Implementation branch `work/00001KWHHRTM9-00001KWHEM8YJ` was merged to `develop` with merge commit `4edaa73d merge: runtime worker controls`.
|
||||
- Ticket record branch was merged to `develop` with merge commit `540e55d4 merge: runtime worker ticket records` before final closure.
|
||||
- Final validation on `develop` passed:
|
||||
- `git diff --check`: pass
|
||||
- `cargo test -p yoi-workspace-server`: pass（55 lib tests + 2 main tests）
|
||||
- `cargo check -p yoi`: pass
|
||||
- `cd web/workspace && deno task test`: pass（13 tests）
|
||||
- `cd web/workspace && deno task check`: pass（0 errors / 0 warnings）
|
||||
- `yoi ticket doctor`: ok
|
||||
- `nix build .#yoi --no-link` は Cargo.lock / dependency / resource packaging / Nix 変更ではないため未実行。
|
||||
|
||||
External follow-up review approved the fix commit `47ed0ff8` and found no merge-blocking issues.
|
||||
|
||||
---
|
||||
|
||||
<!-- event: state_changed author: hare at: 2026-07-02T18:24:50Z from: done to: closed reason: closed field: state -->
|
||||
|
||||
## State changed
|
||||
|
||||
Ticket を closed にしました。
|
||||
|
||||
|
||||
---
|
||||
|
||||
<!-- event: close author: hare at: 2026-07-02T18:24:50Z status: closed -->
|
||||
|
||||
## 完了
|
||||
|
||||
完了。
|
||||
|
||||
実装内容:
|
||||
- Workspace Sidebar の WORKER heading に `New` button と Worker 作成 form を追加した。
|
||||
- form は display name / runtime / profile / initial text の product-level fields のみを扱う。
|
||||
- Browser-facing `/api/workers` POST を追加/利用し、内部 Runtime create payload や raw authority-bearing fields を UI/API contract に露出しないようにした。
|
||||
- profile/runtime は Backend-published candidates から選択し、自由入力にしないようにした。
|
||||
- 作成成功時は Worker list を refresh し、`/runtimes/{runtime_id}/workers/{worker_id}/console` に遷移するようにした。
|
||||
- unsupported runtime / not accepted cases は Runtime diagnostics を sanitized typed diagnostics として保持するようにした。
|
||||
- Focused backend/web tests を追加した。
|
||||
|
||||
主な commit / merge:
|
||||
- implementation: `f2fead7e feat: add workspace runtime and worker controls`
|
||||
- review fix: `47ed0ff8 fix: harden runtime and worker launch controls`
|
||||
- merge to develop: `4edaa73d merge: runtime worker controls`
|
||||
- ticket-record merge before closure: `540e55d4 merge: runtime worker ticket records`
|
||||
|
||||
Review:
|
||||
- 初回 external review は request_changes。
|
||||
- follow-up external review は approve。merge-blocking issue なし。
|
||||
|
||||
Final validation on `develop`:
|
||||
- `git diff --check`: pass
|
||||
- `cargo test -p yoi-workspace-server`: pass（55 lib tests + 2 main tests）
|
||||
- `cargo check -p yoi`: pass
|
||||
- `cd web/workspace && deno task test`: pass（13 tests）
|
||||
- `cd web/workspace && deno task check`: pass（0 errors / 0 warnings）
|
||||
- `yoi ticket doctor`: ok
|
||||
|
||||
未実行:
|
||||
- `nix build .#yoi --no-link` は Cargo.lock / dependency / resource packaging / Nix 変更ではないため未実行。
|
||||
|
||||
---
|
||||
|
|
@ -1,3 +0,0 @@
|
|||
{"id":"orch-plan-20260702-164730-1","ticket_id":"00001KWHHRTM9","kind":"waiting_capacity_note","note":"Dashboard 起動時の queue review。対象 Ticket は未指定で、ユーザー指示により explicit follow-up まで role Pod spawn / queued->inprogress acceptance は行わない human gate として待機する。確認済み: Ticket 本文/最近の thread、TicketRelationQuery（0件）、TicketOrchestrationPlanQuery（0件）、workspace git/worktree 状態、visible Pods、TicketDoctor（0 errors）。本文上の依存先 00001KWHJ0XH6 は TicketShow で closed を確認済み。","author":"orchestrator","at":"2026-07-02T16:47:30Z"}
|
||||
{"id":"orch-plan-20260702-170047-2","ticket_id":"00001KWHHRTM9","kind":"accepted_plan","accepted_plan":{"summary":"`00001KWHHRTM9` と `00001KWHEM8YJ` は workspace Browser の runtime/worker UI/API surface が重なるため、別 worktree 並列ではなく同一 branch/worktree で順序実装する。human gate は明示 follow-up で解除済み。","branch":"work/00001KWHHRTM9-00001KWHEM8YJ","worktree":"/home/hare/Projects/yoi/.worktree/00001KWHHRTM9-00001KWHEM8YJ","role_plan":"単一 sibling Coder Pod に同一 implementation worktree を委譲し、Runtime connection settings/API を先に実装してから Manual Coding Worker launch 導線を実装する。実装後は別 sibling Reviewer Pod で両 Ticket の recorded IntentPacket / invariants / acceptance criteria に照らしてレビューする。"},"author":"orchestrator","at":"2026-07-02T17:00:47Z"}
|
||||
{"id":"orch-plan-20260702-170054-3","ticket_id":"00001KWHHRTM9","kind":"before","related_ticket":"00001KWHEM8YJ","note":"同一 worktree で順序実装する。Runtime connection settings/API が Manual Coding Worker form の runtime candidate/projection 基盤になるため、まずこちらを実装する。","author":"orchestrator","at":"2026-07-02T17:00:54Z"}
|
||||
|
|
@ -1,286 +0,0 @@
|
|||
---
|
||||
title: 'Workspace Backend Runtime接続の管理画面と永続configを追加する'
|
||||
state: 'closed'
|
||||
created_at: '2026-07-02T13:54:52Z'
|
||||
updated_at: '2026-07-02T18:24:38Z'
|
||||
assignee: null
|
||||
queued_by: 'workspace-panel'
|
||||
queued_at: '2026-07-02T16:45:19Z'
|
||||
---
|
||||
|
||||
## 背景
|
||||
|
||||
Workspace Backend は embedded Runtime を process 内に持ち、remote Runtime は `ServerConfig.remote_runtime_sources` から `RuntimeRegistry` に登録する構造になっている。Runtime が Backend へ接続しに来るのではなく、Backend が Runtime source を registry に登録して呼び出す。
|
||||
|
||||
現状、remote Runtime 接続の永続化は `.yoi/workspace-backend.local.toml` の `[[runtimes.remote]]` schema として存在する。ただし、これを Browser から追加・削除・確認する管理画面/API はまだ無い。また `token_ref` は field としてあるが secret ref resolution は未実装で、raw token 値を config に保存する schema は無い。
|
||||
|
||||
手動 Coding Worker 作成フォームで Runtime を選ぶには、先に Runtime connection を Workspace Backend の設定として管理できる必要がある。この Ticket では Runtime 接続管理 UI/API と config 永続化を追加する。
|
||||
|
||||
## 目的
|
||||
|
||||
- Workspace Browser から Runtime connection を確認・追加・削除できるようにする。
|
||||
- Runtime connection config を `.yoi/workspace-backend.local.toml` に永続化する。
|
||||
- raw token 値、Runtime internal store path、socket path、event cursor などを保存・表示しない。
|
||||
- RuntimeRegistry の live state、persisted config、connection check / negotiation result の境界を明確にする。
|
||||
- 手動 Worker 作成 UI が選択できる Runtime 候補の基盤を作る。
|
||||
|
||||
## 依存関係
|
||||
|
||||
- `00001KWHJ0XH6 Workspace BrowserにSettings/Admin画面のshellとnavigationを追加する`
|
||||
- Settings/Admin entry point / route / shell / section navigation は先行 Ticket で用意する。
|
||||
- この Ticket はその Settings shell 上に Runtime Connections section と Backend API / config persistence を追加する。
|
||||
|
||||
## 現状整理
|
||||
|
||||
### embedded Runtime
|
||||
|
||||
- Backend process 内で作られる built-in Runtime。
|
||||
- `RuntimeRegistry::for_workspace(EmbeddedWorkerRuntime::...)` で登録される。
|
||||
- config file で追加・削除する対象ではない。
|
||||
- 管理画面では built-in として表示する。
|
||||
|
||||
### remote Runtime
|
||||
|
||||
- `.yoi/workspace-backend.local.toml` の `[[runtimes.remote]]` から読み込まれる。
|
||||
- `ServerConfig.remote_runtime_sources` を経由して `RuntimeRegistry` に登録される。
|
||||
- 現状は起動時登録だけで、UI/API からの追加・削除は無い。
|
||||
- `token_ref` は schema にあるが secret resolution は未実装なので、v0 では fail closed か未対応表示にする。
|
||||
- 現状は明示的な negotiation / handshake は無い。
|
||||
- Backend は remote Runtime 操作時に `GET /v1/runtime`、`GET /v1/workers` などを呼び、失敗時は diagnostic を返す。
|
||||
- `GET /v1/runtime` が事実上の疎通確認になっているが、protocol version、API compatibility、spawn/input/event stream support を接続時に合意する仕組みではない。
|
||||
- Runtime connection management の `test` は、この現状を踏まえて endpoint reachability だけでなく lightweight negotiation / compatibility check として設計する。
|
||||
|
||||
## Config schema
|
||||
|
||||
既存 schema を使う。
|
||||
|
||||
```toml
|
||||
[[runtimes.remote]]
|
||||
id = "example"
|
||||
endpoint = "http://127.0.0.1:8790"
|
||||
display_name = "Example Runtime"
|
||||
# token_ref = "local:example-runtime-token"
|
||||
```
|
||||
|
||||
保存するもの:
|
||||
|
||||
- `id`
|
||||
- `endpoint`
|
||||
- `display_name`
|
||||
- `token_ref`（secret ref resolution が実装されるまで v0 では UI から設定不可でもよい）
|
||||
|
||||
保存しないもの:
|
||||
|
||||
- bearer token 値。
|
||||
- connection health result。
|
||||
- Runtime worker list。
|
||||
- Runtime event cursor。
|
||||
- socket path / session path。
|
||||
- Runtime fs-store path。
|
||||
- live connection handle。
|
||||
|
||||
## Backend API 設計
|
||||
|
||||
Workspace Backend に Runtime connection settings API を追加する。
|
||||
|
||||
候補:
|
||||
|
||||
```http
|
||||
GET /api/settings/runtime-connections
|
||||
POST /api/settings/runtime-connections
|
||||
DELETE /api/settings/runtime-connections/{id}
|
||||
POST /api/settings/runtime-connections/{id}/test
|
||||
```
|
||||
|
||||
### GET
|
||||
|
||||
返すもの:
|
||||
|
||||
- embedded Runtime summary。
|
||||
- persisted remote Runtime connection configs。
|
||||
- live RuntimeRegistry projection との対応。
|
||||
- sanitized diagnostics。
|
||||
|
||||
返さないもの:
|
||||
|
||||
- config file path。
|
||||
- secret 値。
|
||||
- Runtime endpoint credential。
|
||||
- raw socket / session / store path。
|
||||
|
||||
### POST
|
||||
|
||||
request v0:
|
||||
|
||||
```json
|
||||
{
|
||||
"id": "remote-dev",
|
||||
"endpoint": "http://127.0.0.1:8790",
|
||||
"display_name": "Remote Dev Runtime"
|
||||
}
|
||||
```
|
||||
|
||||
v0 では `token_ref` は未対応でもよい。対応する場合も raw token 値は受け取らず、secret ref だけにする。
|
||||
|
||||
挙動:
|
||||
|
||||
- id / endpoint / display_name を validate する。
|
||||
- duplicate id は拒否する。
|
||||
- `.yoi/workspace-backend.local.toml` を read-modify-write する。
|
||||
- unknown TOML fields を壊さない方針が必要。実装が難しい場合は typed schema 全体を parse/serialize し、comments が失われることを diagnostic / docs に明記する。
|
||||
|
||||
### DELETE
|
||||
|
||||
- 指定 id の remote Runtime connection を config から削除する。
|
||||
- embedded Runtime は削除不可。
|
||||
- 存在しない id は typed diagnostic。
|
||||
|
||||
### TEST / negotiation
|
||||
|
||||
`test` は単なる ping ではなく、remote Runtime の lightweight negotiation / compatibility check として扱う。
|
||||
|
||||
v0 の check:
|
||||
|
||||
1. endpoint の URL / scheme を validate する。
|
||||
2. Backend-owned HTTP client で `GET /v1/runtime` を呼ぶ。
|
||||
3. JSON response が `worker-runtime` の runtime summary として parse できるか確認する。
|
||||
4. observed runtime id / display name / status / capabilities を読む。
|
||||
5. Browser が必要とする操作に対して compatibility を判定する。
|
||||
- list workers。
|
||||
- observe worker detail。
|
||||
- event websocket endpoint を構成できること。
|
||||
- spawn worker support。
|
||||
- input dispatch support。
|
||||
- ConfigBundle availability check / sync support。
|
||||
6. diagnostics を sanitized して返す。
|
||||
|
||||
現行 Runtime API に protocol version field が無い場合、fake version を作らない。代わりに次のように表現する。
|
||||
|
||||
```json
|
||||
{
|
||||
"protocol": {
|
||||
"compatible": true,
|
||||
"basis": "v1 runtime endpoint responded"
|
||||
}
|
||||
}
|
||||
```
|
||||
|
||||
version / feature negotiation field が必要なら、この Ticket 内で既存 API を確認して追加するか、別 Ticket に分ける。
|
||||
|
||||
`test` の response は config persistence と分ける。
|
||||
|
||||
保存しないもの:
|
||||
|
||||
- observed capabilities。
|
||||
- observed runtime status。
|
||||
- checked_at。
|
||||
- health result。
|
||||
- diagnostics。
|
||||
|
||||
v0 ではこれらは API response / UI 表示だけに使う。保存が必要になった場合は Backend DB の observation / cache として扱い、`.yoi/workspace-backend.local.toml` には入れない。
|
||||
|
||||
Unsupported Runtime の扱い:
|
||||
|
||||
- `test` では `compatible=false` と typed diagnostic を返す。
|
||||
- `POST` で保存前 check を必須にするかは実装時に決める。
|
||||
- 保存を許す場合でも UI は `not_compatible` / `restart will not make this usable` などの diagnostic を表示する。
|
||||
|
||||
## Live反映方針
|
||||
|
||||
v0 は config persistence を優先し、live RuntimeRegistry への hot register/unregister は必須にしない。
|
||||
|
||||
選択肢:
|
||||
|
||||
1. config 更新後に `restart_required = true` を返す。
|
||||
2. 追加だけ live register し、削除は restart required にする。
|
||||
3. 追加・削除とも live反映する。
|
||||
|
||||
この Ticket の v0 は **1** を基本とする。UI は「保存後、Backend restart で有効化」と表示する。
|
||||
|
||||
理由:
|
||||
|
||||
- RuntimeRegistry の unregister は worker selection / observation / console subscription への影響がある。
|
||||
- live / negotiated runtime state と persisted config を混ぜると責務が増える。
|
||||
- まずは永続 config 管理を作り、live反映は別 Ticket に分けられる。
|
||||
|
||||
## UI 設計
|
||||
|
||||
Settings / Runtime Connections 画面を追加する。
|
||||
|
||||
表示:
|
||||
|
||||
- Embedded Runtime
|
||||
- id
|
||||
- display name
|
||||
- built-in badge
|
||||
- status / diagnostics
|
||||
- delete不可
|
||||
- Remote Runtime connections
|
||||
- id
|
||||
- display name
|
||||
- endpoint
|
||||
- persisted / active / restart required / compatible status
|
||||
- Test
|
||||
- Delete
|
||||
|
||||
追加 form:
|
||||
|
||||
- id
|
||||
- display name
|
||||
- endpoint
|
||||
|
||||
v0 では token / secret input は出さない。secret ref 対応を入れる場合は separate field とし、raw token 値を入力・保存しない。
|
||||
|
||||
## Config read/write boundary
|
||||
|
||||
`.yoi/workspace-backend.local.toml` は既に `WorkspaceBackendConfigFile` として parse される。Runtime connection management はこの file を read-modify-write する。
|
||||
|
||||
要確認:
|
||||
|
||||
- comments を維持するか。
|
||||
- formatting を維持するか。
|
||||
- unknown fields の扱い。
|
||||
|
||||
v0 は typed TOML serialize で comments が失われてもよいが、その場合は実装 report と docs に明記する。comments を維持したい場合は TOML document editing crate の導入を検討する。
|
||||
|
||||
## 実装要件
|
||||
|
||||
- Runtime connection settings API を追加する。
|
||||
- `.yoi/workspace-backend.local.toml` の `[[runtimes.remote]]` を read-modify-write できる。
|
||||
- embedded Runtime は built-in connection として表示され、削除不可。
|
||||
- remote Runtime connection の add/delete/test negotiation ができる。
|
||||
- v0 では config 更新後 `restart_required = true` を返す。
|
||||
- raw token 値を request / response / config file に持たない。
|
||||
- RuntimeRegistry live state、persisted config、negotiation result を混同しない。
|
||||
- Settings / Runtime Connections UI を追加する。
|
||||
- Manual Coding Worker 作成 UI で使う Runtime candidate 情報に接続できる projection を用意する。
|
||||
|
||||
## 受け入れ条件
|
||||
|
||||
- Runtime Connections 管理画面がある。
|
||||
- embedded Runtime が built-in / delete不可として表示される。
|
||||
- remote Runtime connection を追加でき、`.yoi/workspace-backend.local.toml` に保存される。
|
||||
- remote Runtime connection を削除でき、config から消える。
|
||||
- remote Runtime connection の test negotiation ができ、compatibility / capabilities / diagnostics が sanitized response として返る。
|
||||
- config 更新 response が `restart_required = true` を返す。
|
||||
- negotiation result / observed capabilities / health result を `.yoi/workspace-backend.local.toml` に保存しない。
|
||||
- raw token 値を UI/API/config に保存・表示しない。
|
||||
- Runtime endpoint credential / socket path / session path / Runtime store path が Browser-facing API に漏れない。
|
||||
- duplicate id / invalid endpoint / incompatible runtime / embedded delete attempt が typed diagnostic になる。
|
||||
- Focused tests が API list/add/delete/test negotiation、config persistence、sanitization、restart_required、UI render/submit path を確認する。
|
||||
- `cd web/workspace && deno task test` が通る。
|
||||
- `cd web/workspace && deno task check` が通る。
|
||||
- `cargo test -p yoi-workspace-server` が通る。
|
||||
- `cargo check -p yoi` が通る。
|
||||
- `git diff --check` が通る。
|
||||
- `nix build .#yoi --no-link` が通る。
|
||||
|
||||
## 対象外
|
||||
|
||||
- RuntimeRegistry の live unregister 完成。
|
||||
- Remote Runtime workspace provisioning。
|
||||
- Secret store UI。
|
||||
- raw bearer token の保存。
|
||||
- Manual Coding Worker 作成 form の実装。
|
||||
- Runtime health monitoring daemon。
|
||||
- Runtime event cursor 永続化。
|
||||
|
|
@ -1,30 +0,0 @@
|
|||
完了。
|
||||
|
||||
実装内容:
|
||||
- Workspace Settings に Runtime Connections v0 を追加し、embedded Runtime を built-in / delete不可として表示するようにした。
|
||||
- remote Runtime connection の list/add/delete/test を Browser-facing API と Settings UI から扱えるようにした。
|
||||
- remote runtime config は `.yoi/workspace-backend.local.toml` の既存 `[[runtimes.remote]]` schema を typed read-modify-write で更新し、変更後は `restart_required = true` を返すようにした。
|
||||
- Runtime connection test は `/v1/runtime` の lightweight negotiation と Browser-relevant operation の compatibility/capability projection を行い、unsupported/unknown を typed sanitized diagnostics として返すようにした。
|
||||
- Browser-facing response から raw token/secret、Runtime endpoint、config path、workspace/internal paths、socket/session/store path、live handle 等が漏れないようにした。
|
||||
- Focused backend/web tests を追加した。
|
||||
|
||||
主な commit / merge:
|
||||
- implementation: `f2fead7e feat: add workspace runtime and worker controls`
|
||||
- review fix: `47ed0ff8 fix: harden runtime and worker launch controls`
|
||||
- merge to develop: `4edaa73d merge: runtime worker controls`
|
||||
- ticket-record merge before closure: `540e55d4 merge: runtime worker ticket records`
|
||||
|
||||
Review:
|
||||
- 初回 external review は request_changes。
|
||||
- follow-up external review は approve。merge-blocking issue なし。
|
||||
|
||||
Final validation on `develop`:
|
||||
- `git diff --check`: pass
|
||||
- `cargo test -p yoi-workspace-server`: pass（55 lib tests + 2 main tests）
|
||||
- `cargo check -p yoi`: pass
|
||||
- `cd web/workspace && deno task test`: pass（13 tests）
|
||||
- `cd web/workspace && deno task check`: pass（0 errors / 0 warnings）
|
||||
- `yoi ticket doctor`: ok
|
||||
|
||||
未実行:
|
||||
- `nix build .#yoi --no-link` は Cargo.lock / dependency / resource packaging / Nix 変更ではないため未実行。
|
||||
|
|
@ -1,379 +0,0 @@
|
|||
<!-- event: create author: "yoi ticket" at: 2026-07-02T13:54:52Z -->
|
||||
|
||||
## 作成
|
||||
|
||||
LocalTicketBackend によって作成されました。
|
||||
|
||||
---
|
||||
|
||||
<!-- event: plan author: hare at: 2026-07-02T13:56:05Z -->
|
||||
|
||||
## Plan
|
||||
|
||||
Workspace Backend Runtime connection management と永続 config の Ticket として詳細化した。
|
||||
|
||||
方針:
|
||||
- Runtime が Backend に接続するのではなく、Backend が Runtime source を RuntimeRegistry に登録する現行構造を前提にする。
|
||||
- embedded Runtime は built-in connection として表示し、config 管理対象や削除対象にしない。
|
||||
- remote Runtime connection は `.yoi/workspace-backend.local.toml` の `[[runtimes.remote]]` に保存する。
|
||||
- 管理 API は list/add/delete/test を提供する。
|
||||
- v0 は config persistence を優先し、config 更新後は `restart_required = true` とする。live register/unregister は対象外。
|
||||
- raw token 値、socket/session/store path、Runtime event cursor、live handle は UI/API/config に出さない。
|
||||
|
||||
|
||||
---
|
||||
|
||||
<!-- event: decision author: hare at: 2026-07-02T14:00:49Z -->
|
||||
|
||||
## Decision
|
||||
|
||||
Runtime connection management Ticket は Settings shell 先行 Ticket に依存する形へ整理した。
|
||||
|
||||
Decision:
|
||||
- `00001KWHJ0XH6` が Workspace-local Settings の entry point / route / shell / section navigation を用意する。
|
||||
- `00001KWHHRTM9` はその Settings shell 上に Runtime Connections section と Backend API / config persistence を追加する。
|
||||
- Runtime connection 管理 Ticket 内で Settings shell 設計を同時に進めない。
|
||||
|
||||
|
||||
---
|
||||
|
||||
<!-- event: decision author: hare at: 2026-07-02T14:55:21Z -->
|
||||
|
||||
## Decision
|
||||
|
||||
Runtime connection management に negotiation / compatibility check を含める方針へ更新した。
|
||||
|
||||
Decision:
|
||||
- 現状は明示的な negotiation / handshake は無く、`GET /v1/runtime` が事実上の疎通確認になっているだけ。
|
||||
- Runtime connection `test` は単なる ping ではなく lightweight negotiation / compatibility check として扱う。
|
||||
- v0 check は `GET /v1/runtime` の parse、observed runtime id/display/status/capabilities、worker list/detail、event websocket construction、spawn/input/config-bundle support などを確認する。
|
||||
- 現行 API に protocol version が無い場合は fake version を作らず、`v1 runtime endpoint responded` のような compatibility basis として表現する。
|
||||
- negotiation result / observed capabilities / health result / checked_at / diagnostics は persisted config に保存しない。必要になった場合は Backend DB の observation/cache として扱う。
|
||||
- persisted config、RuntimeRegistry live state、negotiation result を混同しない。
|
||||
|
||||
|
||||
---
|
||||
|
||||
<!-- event: intake_summary author: hare at: 2026-07-02T16:25:43Z -->
|
||||
|
||||
## Intake summary
|
||||
|
||||
Marked ready by `yoi ticket state`.
|
||||
|
||||
---
|
||||
|
||||
<!-- event: state_changed author: "yoi ticket" at: 2026-07-02T16:25:43Z from: planning to: ready reason: cli_state field: state -->
|
||||
|
||||
## State changed
|
||||
|
||||
Marked ready by `yoi ticket state`.
|
||||
|
||||
|
||||
---
|
||||
|
||||
<!-- event: state_changed author: workspace-panel at: 2026-07-02T16:45:19Z from: ready to: queued reason: queued field: state -->
|
||||
|
||||
## State changed
|
||||
|
||||
Ticket を `workspace-panel` が queued にしました。
|
||||
|
||||
|
||||
---
|
||||
|
||||
<!-- event: decision author: orchestrator at: 2026-07-02T16:59:57Z -->
|
||||
|
||||
## Decision
|
||||
|
||||
Routing decision: implementation_ready
|
||||
|
||||
Reason:
|
||||
- Ticket は Runtime connection settings API / `.yoi/workspace-backend.local.toml` 永続化 / Settings UI / sanitized diagnostics / restart_required の v0 境界を具体化しており、observable な acceptance criteria と validation がある。
|
||||
- 先行 Settings shell Ticket `00001KWHJ0XH6` は closed を確認済み。
|
||||
- typed relation blocker は 0 件、OrchestrationPlan は human gate の waiting note のみで、ユーザーから「2つとも消化して」と明示 follow-up があったため human gate は解除された。
|
||||
- Manual Coding Worker Ticket `00001KWHEM8YJ` と UI/API surface が近く、並列別 worktree では衝突リスクが高いので、同一 implementation worktree/branch で Runtime connection 管理を先に実装し、続けて manual Worker 作成導線を実装する。
|
||||
|
||||
Evidence checked:
|
||||
- Ticket body / thread / artifacts。
|
||||
- `TicketRelationQuery(00001KWHHRTM9)` は 0 件。
|
||||
- `TicketOrchestrationPlanQuery(00001KWHHRTM9)` は prior human-gate waiting note のみ。
|
||||
- `TicketShow(00001KWHJ0XH6)` は closed。
|
||||
- queued Ticket 一覧では `00001KWHEM8YJ` も queued、ready/inprogress は 0 件。
|
||||
- workspace/orchestration git state と worktree 一覧、visible Pods、TicketDoctor（0 errors / 既存 warning のみ）。
|
||||
- Bounded code map: `crates/workspace-server` の workspace backend / runtime registry / config file 周辺、`web/workspace/src/lib/workspace-settings/SettingsPage.svelte`、`web/workspace/src/routes/settings/+page.svelte`、既存 `/api/workers` / `/api/runtimes/{runtime_id}/workers` projection、`WorkersNavSection.svelte`。
|
||||
|
||||
IntentPacket:
|
||||
|
||||
Intent:
|
||||
- Workspace Browser の Settings / Runtime Connections で embedded Runtime 表示、remote Runtime connection の list/add/delete/test negotiation、`.yoi/workspace-backend.local.toml` 永続化、restart_required diagnostic を提供する。
|
||||
- `00001KWHEM8YJ` が使う Runtime candidate projection の基盤を作る。
|
||||
|
||||
Binding decisions / invariants:
|
||||
- Runtime が Backend に接続するのではなく、Backend が configured Runtime source を `RuntimeRegistry` に登録する現行構造を前提にする。
|
||||
- embedded Runtime は built-in として表示し、config 管理対象や削除対象にしない。
|
||||
- remote Runtime connection は既存 `[[runtimes.remote]]` schema に保存する。
|
||||
- v0 は config persistence 優先で、config 更新後は `restart_required = true`。live register/unregister は対象外。
|
||||
- raw token 値、secret、socket/session/store path、Runtime event cursor、live handle、config file path は UI/API response に出さない。
|
||||
- negotiation/test result、observed capabilities、health result、checked_at は local config に保存しない。
|
||||
- protocol version が無ければ fake version を作らず、compatibility basis として表現する。
|
||||
|
||||
Requirements / acceptance criteria:
|
||||
- Runtime Connections 管理画面が Settings shell 内にある。
|
||||
- embedded Runtime は built-in / delete不可として表示される。
|
||||
- remote connection を add/delete でき、config の `[[runtimes.remote]]` が read-modify-write される。
|
||||
- test negotiation は `GET /v1/runtime` parse と Browser 必要操作に対する compatibility/sanitized diagnostics を返す。
|
||||
- duplicate id / invalid endpoint / incompatible runtime / embedded delete attempt は typed diagnostic。
|
||||
- request/response/config に raw token 値や internal paths を含めない。
|
||||
- focused backend/UI tests を追加し、指定 validation を可能な範囲で実行する。
|
||||
|
||||
Implementation latitude:
|
||||
- TOML comments/format preservation は v0 で typed serialize により失われてもよい。ただし implementation report/docs/test で明記する。
|
||||
- POST 保存前に test を必須にするか、保存は許して test diagnostic を別扱いにするかは、Ticket の v0 境界内で選んでよい。
|
||||
- API response shape / Svelte component分割 / test helper構成は既存 style に合わせて選んでよい。
|
||||
|
||||
Escalate if:
|
||||
- secret store / raw token input / live RuntimeRegistry unregister / remote workspace provisioning / protocol version追加を必須にしないと満たせない場合。
|
||||
- existing config schema を壊す必要がある場合。
|
||||
- Browser-facing API に raw path/secret/runtime internal location を出す誘惑が出た場合。
|
||||
|
||||
Validation:
|
||||
- `cd web/workspace && deno task test`
|
||||
- `cd web/workspace && deno task check`
|
||||
- `cargo test -p yoi-workspace-server`
|
||||
- `cargo check -p yoi`
|
||||
- `git diff --check`
|
||||
- `nix build .#yoi --no-link` は時間/依存変更の重さを見て実行、未実行なら理由を report。
|
||||
|
||||
Current code map:
|
||||
- Settings UI: `web/workspace/src/lib/workspace-settings/SettingsPage.svelte`, `web/workspace/src/routes/settings/+page.svelte`。
|
||||
- Worker/sidebar UI: `web/workspace/src/lib/workspace-sidebar/WorkersNavSection.svelte`, console route under `web/workspace/src/routes/runtimes/[runtimeId]/workers/[workerId]/console/`。
|
||||
- Backend/runtime/config areas: `crates/workspace-server`, existing `/api/workers`, `/api/runtimes/{runtime_id}/workers`, `WorkspaceBackendConfigFile`, `ServerConfig.remote_runtime_sources`, `RuntimeRegistry`, `EmbeddedWorkerRuntime`。
|
||||
|
||||
Critical risks / reviewer focus:
|
||||
- persisted config、live registry state、test/negotiation observation を混同していないか。
|
||||
- Browser-facing API に secrets/internal paths/runtime store/socket/session/config file path が漏れていないか。
|
||||
- embedded delete が fail closed か。
|
||||
- restart_required semantics が UI/API で明確か。
|
||||
- `00001KWHEM8YJ` と同一 worktreeで実装し、runtime candidates の shared contract が破綻していないか。
|
||||
|
||||
---
|
||||
|
||||
<!-- event: state_changed author: orchestrator at: 2026-07-02T17:01:01Z from: queued to: inprogress reason: routing_acceptance_implementation_ready field: state -->
|
||||
|
||||
## State changed
|
||||
|
||||
Queued acceptance recorded after explicit user follow-up 「2つとも消化して」。
|
||||
|
||||
Checked context:
|
||||
- Ticket body / thread / artifacts。
|
||||
- `TicketRelationQuery(00001KWHHRTM9)`: blocking relation 0 件。
|
||||
- `TicketOrchestrationPlanQuery(00001KWHHRTM9)`: prior human-gate waiting note を確認し、今回 accepted_plan / before ordering を記録済み。
|
||||
- `00001KWHJ0XH6` は closed。
|
||||
- workspace/worktree/visible Pod/TicketDoctor/code-map の bounded check。
|
||||
|
||||
Acceptance basis:
|
||||
- concrete missing decision / information は残っていない。
|
||||
- `00001KWHEM8YJ` と surface が重なるため、同一 implementation worktree でこの Ticket を先に実装する。
|
||||
- side effect はこの `queued -> inprogress` acceptance 後に開始する。
|
||||
|
||||
---
|
||||
|
||||
<!-- event: implementation_report author: orchestrator at: 2026-07-02T17:02:35Z -->
|
||||
|
||||
## Implementation report
|
||||
|
||||
Implementation side-effect recovery note:
|
||||
|
||||
- `queued -> inprogress` acceptance 後、implementation worktree `/home/hare/Projects/yoi/.worktree/00001KWHHRTM9-00001KWHEM8YJ` / branch `work/00001KWHHRTM9-00001KWHEM8YJ` は作成済み。
|
||||
- 最初の Coder Pod spawn は、child workspace root `/home/hare/Projects/yoi` を readable scope に含めていなかったため `workspace root is not readable under the configured scope` で失敗した。
|
||||
- Ticket は `inprogress` のまま、read scope に workspace root、write scope に implementation worktree だけを含める形で即時 retry する。raw runtime/socket/session details は implementation contract には含めない。
|
||||
|
||||
---
|
||||
|
||||
<!-- event: implementation_report author: orchestrator at: 2026-07-02T17:03:28Z -->
|
||||
|
||||
## Implementation report
|
||||
|
||||
Implementation routing update:
|
||||
|
||||
- Recovery retry succeeded: sibling Coder Pod `yoi-coder-00001KWHHRTM9-00001KWHEM8YJ` was spawned for the combined branch/worktree.
|
||||
- Scope policy: workspace root is readable for runtime workspace metadata; write authority is restricted to implementation worktree `/home/hare/Projects/yoi/.worktree/00001KWHHRTM9-00001KWHEM8YJ`.
|
||||
- Work order remains: this Ticket first, then `00001KWHEM8YJ`; external review will be requested after coder completion evidence is available.
|
||||
|
||||
---
|
||||
|
||||
<!-- event: implementation_report author: orchestrator at: 2026-07-02T17:29:34Z -->
|
||||
|
||||
## Implementation report
|
||||
|
||||
Implementation progress report:
|
||||
|
||||
- Coder Pod completed the combined implementation and committed `f2fead7e feat: add workspace runtime and worker controls` on branch `work/00001KWHHRTM9-00001KWHEM8YJ`.
|
||||
- Worktree status was clean after commit.
|
||||
- Changed areas include `crates/workspace-server/src/config.rs`, `crates/workspace-server/src/hosts.rs`, `crates/workspace-server/src/server.rs`, Settings UI/model/tests, Worker sidebar UI/types, and workspace TS config/CSS.
|
||||
- Orchestrator reran validation:
|
||||
- `git diff --check`: pass
|
||||
- `cargo test -p yoi-workspace-server`: pass（51 lib tests + 2 main tests）
|
||||
- `cargo check -p yoi`: pass
|
||||
- `cd web/workspace && deno task test`: pass（11 tests）
|
||||
- `cd web/workspace && deno task check`: pass（0 errors / 0 warnings）
|
||||
- `nix build .#yoi --no-link` は dependency/resource packaging 変更ではないため未実行。
|
||||
- External review requested via sibling Reviewer Pod `yoi-reviewer-00001KWHHRTM9-00001KWHEM8YJ`.
|
||||
|
||||
---
|
||||
|
||||
<!-- event: review author: reviewer at: 2026-07-02T17:36:45Z status: request_changes -->
|
||||
|
||||
## Review: request changes
|
||||
|
||||
External review result: request_changes
|
||||
|
||||
Checked evidence:
|
||||
- 両 Ticket record と最新 IntentPacket / orchestration-plan を確認。
|
||||
- `f2fead7e` の diff/stat/check evidence を確認（10 files changed、`git diff --check f2fead7e^ f2fead7e` clean）。
|
||||
- `config.rs`, `hosts.rs`, `server.rs`, settings UI/model/tests, sidebar worker form/types, CSS/tsconfig を focused static review。
|
||||
- Reviewer は read-only で、validation 再実行はせず Orchestrator reported validation pass を参照。
|
||||
|
||||
Blockers:
|
||||
|
||||
1. Runtime connection `test` が recorded lightweight negotiation / compatibility contract を満たしていない。
|
||||
- Ticket は observed runtime capabilities の parse と Browser 必要 operation（list workers, observe detail, event websocket construction, spawn, input dispatch, config-bundle availability/sync）に対する compatibility check を要求している。
|
||||
- 現状 `test_remote_runtime_config` は `/v1/runtime` を呼び、狭い `RuntimeHttpSummaryResponse` を parse した後、operation compatibility check なしで常に `state: "compatible"`, `capabilities: Vec::new()` を返す。
|
||||
- acceptance criterion の sanitized compatibility/capabilities/diagnostics response を満たしていない。
|
||||
|
||||
2. Browser-facing diagnostic sanitization が endpoint/path leak invariant に対して不十分。
|
||||
- remote test failure path が `sanitize_backend_error(&error.to_string())` を Browser response に入れている。
|
||||
- sanitizer は `/home/`, `/Users/`, `\\`, `:\\` を含む message だけ置換するため、reqwest error の requested URL や non-home config/temp path が漏れる可能性がある。
|
||||
- Ticket は Runtime endpoint/config path/internal location を Browser-facing response に漏らさないことを要求しているため、raw backend error string ではなく fixed typed diagnostics にする必要がある。
|
||||
|
||||
3. Manual Worker launch が rejected Runtime operation の typed unsupported diagnostics を落としている。
|
||||
- `create_workspace_worker` が non-`Accepted` `WorkerOperationResult` を generic `workspace_worker_create_failed` に変換し、`result.diagnostics` を破棄している。
|
||||
- unsupported remote/runtime cases は typed sanitized diagnostics を返す必要がある。
|
||||
|
||||
4. key contracts の focused acceptance tests が不足。
|
||||
- backend は helper-level validation/sanitizer tests に寄っており、runtime connection list/add/delete/test negotiation、config persistence、restart_required、`/api/workers` POST success/unsupported diagnostics の route-level tests が足りない。
|
||||
- Web は settings model helper tests のみで、New Worker form rendering/submit-path test がない。
|
||||
|
||||
Non-blocking follow-ups:
|
||||
- manual Worker launch の `display_name` は optional と記録されているが backend/UI は non-empty を要求している。空なら default label derivation を検討。
|
||||
- Browser-facing request structs に `deny_unknown_fields` を付けると “only these fields” boundary が fail closed になる。
|
||||
- `nix build .#yoi --no-link` は dependency/resource packaging 変更ではないため未実行だが、acceptance evidence としては未検証。
|
||||
|
||||
---
|
||||
|
||||
<!-- event: implementation_report author: orchestrator at: 2026-07-02T18:11:11Z -->
|
||||
|
||||
## Implementation report
|
||||
|
||||
Review-fix implementation report:
|
||||
|
||||
- Coder Pod completed requested changes and committed follow-up `47ed0ff8 fix: harden runtime and worker launch controls` on branch `work/00001KWHHRTM9-00001KWHEM8YJ`.
|
||||
- Worktree status was clean after commit.
|
||||
- Fix changed `crates/workspace-server/src/server.rs`, `web/workspace/deno.json`, `WorkersNavSection.svelte`, and added `worker-launch.ts` / `worker-launch.test.ts`.
|
||||
- Reported fixes include lightweight runtime compatibility probes, fixed sanitized remote-test diagnostics without endpoint/path leakage, preservation of typed unsupported worker-create diagnostics, `deny_unknown_fields` on Browser-facing request structs, empty display-name default derivation, backend route/acceptance tests, and web worker-launch model tests.
|
||||
- Orchestrator reran validation:
|
||||
- `git diff --check`: pass
|
||||
- `cargo test -p yoi-workspace-server`: pass（55 lib tests + 2 main tests）
|
||||
- `cargo check -p yoi`: pass
|
||||
- `cd web/workspace && deno task test`: pass（13 tests）
|
||||
- `cd web/workspace && deno task check`: pass（0 errors / 0 warnings）
|
||||
- `nix build .#yoi --no-link` は dependency/resource packaging 変更ではないため未実行。
|
||||
- Requesting follow-up external review against `f2fead7e..47ed0ff8` and full combined implementation.
|
||||
|
||||
---
|
||||
|
||||
<!-- event: review author: reviewer at: 2026-07-02T18:20:10Z status: approve -->
|
||||
|
||||
## Review: approve
|
||||
|
||||
External follow-up review result: approve
|
||||
|
||||
Read-only follow-up review completed for both Tickets and fix commit `47ed0ff8` on top of `f2fead7e`.
|
||||
|
||||
Evidence reviewed:
|
||||
- Ticket records for `00001KWHHRTM9` and `00001KWHEM8YJ`.
|
||||
- Fix diff `f2fead7e..47ed0ff8`.
|
||||
- Relevant backend/web files including `crates/workspace-server/src/server.rs`, `config.rs`, `hosts.rs`, `worker-launch.ts`, `WorkersNavSection.svelte`, related tests/settings model files.
|
||||
- Orchestrator-reported validation pass for `git diff --check`, `cargo test -p yoi-workspace-server`, `cargo check -p yoi`, `cd web/workspace && deno task test`, and `cd web/workspace && deno task check`.
|
||||
|
||||
Reviewer findings:
|
||||
- Previous blocker 1 resolved: runtime connection test now performs lightweight negotiation/probing for Browser-relevant operations and represents unsupported/not-observed operations with typed diagnostics and `unknown`/`unsupported` capability entries instead of blanket compatibility.
|
||||
- Previous blocker 2 resolved: Browser-facing remote-test diagnostics omit raw endpoints/config paths/socket/session/store paths and use typed/sanitized diagnostics; tests assert projected responses do not contain the endpoint/runtime address.
|
||||
- Previous blocker 3 resolved: `/api/workers` keeps product-level request shape and preserves runtime rejection diagnostics while adding typed `workspace_worker_create_not_accepted` diagnostic.
|
||||
- Previous blocker 4 resolved: focused backend tests cover runtime connection test sanitization/compatibility, worker creation payload rejection, diagnostic preservation; web tests cover launch payload shaping/error handling.
|
||||
- Persisted config, live registry summaries, and test observations remain separated.
|
||||
- Browser-facing settings responses expose safe summaries rather than raw authority-bearing backend fields.
|
||||
- New Worker UI consumes `/api/workers/options` candidates and submits only product-level `/api/workers` payload.
|
||||
|
||||
Non-blocking follow-up:
|
||||
- UI could later render backend diagnostic codes/details more richly on Worker launch failure, but current behavior is sanitized and merge-ready.
|
||||
|
||||
No merge-blocking issues found.
|
||||
|
||||
---
|
||||
|
||||
<!-- event: state_changed author: orchestrator at: 2026-07-02T18:24:16Z from: inprogress to: done reason: merged_validated_review_approved field: state -->
|
||||
|
||||
## State changed
|
||||
|
||||
Merge/validation acceptance:
|
||||
|
||||
- Implementation branch `work/00001KWHHRTM9-00001KWHEM8YJ` was merged to `develop` with merge commit `4edaa73d merge: runtime worker controls`.
|
||||
- Ticket record branch was merged to `develop` with merge commit `540e55d4 merge: runtime worker ticket records` before final closure.
|
||||
- Final validation on `develop` passed:
|
||||
- `git diff --check`: pass
|
||||
- `cargo test -p yoi-workspace-server`: pass（55 lib tests + 2 main tests）
|
||||
- `cargo check -p yoi`: pass
|
||||
- `cd web/workspace && deno task test`: pass（13 tests）
|
||||
- `cd web/workspace && deno task check`: pass（0 errors / 0 warnings）
|
||||
- `yoi ticket doctor`: ok
|
||||
- `nix build .#yoi --no-link` は Cargo.lock / dependency / resource packaging / Nix 変更ではないため未実行。
|
||||
|
||||
External follow-up review approved the fix commit `47ed0ff8` and found no merge-blocking issues.
|
||||
|
||||
---
|
||||
|
||||
<!-- event: state_changed author: hare at: 2026-07-02T18:24:38Z from: done to: closed reason: closed field: state -->
|
||||
|
||||
## State changed
|
||||
|
||||
Ticket を closed にしました。
|
||||
|
||||
|
||||
---
|
||||
|
||||
<!-- event: close author: hare at: 2026-07-02T18:24:38Z status: closed -->
|
||||
|
||||
## 完了
|
||||
|
||||
完了。
|
||||
|
||||
実装内容:
|
||||
- Workspace Settings に Runtime Connections v0 を追加し、embedded Runtime を built-in / delete不可として表示するようにした。
|
||||
- remote Runtime connection の list/add/delete/test を Browser-facing API と Settings UI から扱えるようにした。
|
||||
- remote runtime config は `.yoi/workspace-backend.local.toml` の既存 `[[runtimes.remote]]` schema を typed read-modify-write で更新し、変更後は `restart_required = true` を返すようにした。
|
||||
- Runtime connection test は `/v1/runtime` の lightweight negotiation と Browser-relevant operation の compatibility/capability projection を行い、unsupported/unknown を typed sanitized diagnostics として返すようにした。
|
||||
- Browser-facing response から raw token/secret、Runtime endpoint、config path、workspace/internal paths、socket/session/store path、live handle 等が漏れないようにした。
|
||||
- Focused backend/web tests を追加した。
|
||||
|
||||
主な commit / merge:
|
||||
- implementation: `f2fead7e feat: add workspace runtime and worker controls`
|
||||
- review fix: `47ed0ff8 fix: harden runtime and worker launch controls`
|
||||
- merge to develop: `4edaa73d merge: runtime worker controls`
|
||||
- ticket-record merge before closure: `540e55d4 merge: runtime worker ticket records`
|
||||
|
||||
Review:
|
||||
- 初回 external review は request_changes。
|
||||
- follow-up external review は approve。merge-blocking issue なし。
|
||||
|
||||
Final validation on `develop`:
|
||||
- `git diff --check`: pass
|
||||
- `cargo test -p yoi-workspace-server`: pass（55 lib tests + 2 main tests）
|
||||
- `cargo check -p yoi`: pass
|
||||
- `cd web/workspace && deno task test`: pass（13 tests）
|
||||
- `cd web/workspace && deno task check`: pass（0 errors / 0 warnings）
|
||||
- `yoi ticket doctor`: ok
|
||||
|
||||
未実行:
|
||||
- `nix build .#yoi --no-link` は Cargo.lock / dependency / resource packaging / Nix 変更ではないため未実行。
|
||||
|
||||
---
|
||||
|
|
@ -1 +0,0 @@
|
|||
{"id":"orch-plan-20260702-142527-1","ticket_id":"00001KWHJ0XH6","kind":"accepted_plan","note":"Dashboard Queue authorized routing. Ticket has no blocker relations, no current inprogress Tickets, and orchestration worktree is clean.","accepted_plan":{"summary":"Workspace Browser に Settings/Admin shell と navigation を追加する。`/settings` と placeholder sections（Runtime Connections / Backend Config / Workspace Identity）を実装し、user/permission/multi-user authorization が無いことを明記する。Runtime connection mutation/API/persistence は実装しない。既存 Worker Console / Sidebar 主導線を壊さない。","branch":"work/00001KWHJ0XH6-settings-admin-shell","worktree":"/home/hare/Projects/yoi/.worktree/00001KWHJ0XH6-settings-admin-shell","role_plan":"Orchestrator が dedicated child worktree を作成し、coder Worker に `web/workspace/**` の focused write scope を委譲する。必要な場合のみ Backend read-only stateを参照するが、この Ticket では mutation API / Runtime connection persistence は実装しない。reviewer Worker は read-only で route/navigation/disclaimer/placeholders/non-leak/no fake permission model/Console導線維持/deno validation を確認する。merge/validation/done/cleanup は Orchestrator が行う。現時点では `StopPod` は使用せず、cleanup は child worktree/branch のみ行う。"},"author":"yoi-orchestrator","at":"2026-07-02T14:25:27Z"}
|
||||
|
|
@ -1,198 +0,0 @@
|
|||
---
|
||||
title: 'Workspace BrowserにSettings/Admin画面のshellとnavigationを追加する'
|
||||
state: 'closed'
|
||||
created_at: '2026-07-02T13:59:17Z'
|
||||
updated_at: '2026-07-02T14:39:02Z'
|
||||
assignee: null
|
||||
queued_by: 'workspace-panel'
|
||||
queued_at: '2026-07-02T14:24:54Z'
|
||||
---
|
||||
|
||||
## 背景
|
||||
|
||||
Workspace Browser には Worker / Runtime / Repository / Ticket などの作業 surface はあるが、Backend 設定や接続状態を扱う Settings/Admin surface はまだ無い。
|
||||
|
||||
今後 Runtime connections、Backend config、data store status、workspace identity などを UI から確認・編集する必要がある。これは普通に管理画面として設計する。ただし現状の Workspace Backend には user / permission / multi-user authorization が無いため、存在しない権限モデルを UI 上で fake しない。
|
||||
|
||||
Runtime connection 管理 UI を直接作り始めると、Settings/Admin の entry point / route / navigation / diagnostic / restart-required 表示などの共通設計と、Runtime connection config の永続化が混ざる。この Ticket では先に Settings/Admin shell と navigation だけを作り、Runtime Connections は後続 Ticket で実装する。
|
||||
|
||||
## 目的
|
||||
|
||||
- Workspace Browser に Settings/Admin surface を追加する。
|
||||
- 将来の admin UI の受け皿になる route / layout / navigation を用意する。
|
||||
- 現時点で存在しない user / permission / multi-user authorization を UI に出さない。
|
||||
- Runtime Connections などの後続 Settings section を追加できるようにする。
|
||||
- 既存の Worker Console / Sidebar UX を壊さない。
|
||||
- mutation や Runtime connection 永続化は後続 Ticket に委譲する。
|
||||
|
||||
## 位置づけ
|
||||
|
||||
Settings/Admin は Workspace Backend の管理画面である。ただし v0 では権限管理を持たない。
|
||||
|
||||
明記する制約:
|
||||
|
||||
- user account は無い。
|
||||
- role / permission model は無い。
|
||||
- multi-user authorization は無い。
|
||||
- したがって「管理者だけが操作できる」などの UI 文言や fake role を作らない。
|
||||
- 現時点の操作境界は「この Backend にアクセスできること」だけである。
|
||||
|
||||
将来の受け皿:
|
||||
|
||||
- Runtime connections。
|
||||
- Backend config / effective config view。
|
||||
- data root / store status。
|
||||
- workspace identity view。
|
||||
- restart required / sanitized diagnostics。
|
||||
- 将来の user / permission 管理。ただしこの Ticket では実装しない。
|
||||
|
||||
## UI entry point
|
||||
|
||||
Workspace Browser の sidebar に Settings/Admin entry point を追加する。
|
||||
|
||||
候補:
|
||||
|
||||
```text
|
||||
...
|
||||
SETTINGS
|
||||
```
|
||||
|
||||
または bottom utility として:
|
||||
|
||||
```text
|
||||
⚙ Settings
|
||||
```
|
||||
|
||||
v0 では既存の Worker / Repository / Ticket navigation を邪魔しない位置に置く。Worker Console が主導線であることを崩さない。
|
||||
|
||||
## Route 設計
|
||||
|
||||
SvelteKit route として Settings/Admin shell を追加する。
|
||||
|
||||
候補:
|
||||
|
||||
```text
|
||||
/settings
|
||||
/settings/runtime-connections
|
||||
/settings/backend-config
|
||||
```
|
||||
|
||||
v0 では `/settings` が overview / placeholder を表示し、section navigation から placeholder section に遷移できるところまででよい。
|
||||
|
||||
Settings section の初期候補:
|
||||
|
||||
- Runtime Connections
|
||||
- 後続 Ticket `00001KWHHRTM9` で実装する。
|
||||
- v0 shell では placeholder / empty state を表示する。
|
||||
- Backend Config
|
||||
- `.yoi/workspace-backend.local.toml` / packaged default / effective config の表示・diff の受け皿。
|
||||
- v0 shell では read-only placeholder でよい。
|
||||
- Workspace Identity
|
||||
- workspace id / display name / initialized state などの read-only 表示の受け皿。
|
||||
|
||||
## 権限モデルについての表示
|
||||
|
||||
Settings/Admin overview には、現在 user / permission model が無いことを簡潔に示す。
|
||||
|
||||
例:
|
||||
|
||||
```text
|
||||
This Workspace Backend currently has no user or permission model. Anyone with access to this backend can change these settings.
|
||||
```
|
||||
|
||||
日本語 UI なら:
|
||||
|
||||
```text
|
||||
現在、この Workspace Backend にはユーザー権限モデルがありません。この Backend にアクセスできる人は設定を変更できます。
|
||||
```
|
||||
|
||||
これは「管理画面ではない」という意味ではない。無い権限モデルをあるように見せないための注意書きである。
|
||||
|
||||
## Common UI patterns
|
||||
|
||||
Settings/Admin shell では後続 section が使う共通 pattern を用意する。
|
||||
|
||||
### Sanitized diagnostic
|
||||
|
||||
- raw path / secret / token / socket path / runtime store path を出さない方針を示す。
|
||||
- v0 は reusable component でなくても、Settings shell 内の表示 pattern として定義する。
|
||||
|
||||
### Restart required badge
|
||||
|
||||
Runtime connection や backend config の変更は Backend restart が必要になる場合がある。
|
||||
|
||||
v0 shell では badge / callout の見た目だけ用意してよい。
|
||||
|
||||
```text
|
||||
Restart required
|
||||
```
|
||||
|
||||
### Save / dirty state
|
||||
|
||||
この Ticket では mutation を実装しないため、dirty tracking の本実装は不要。ただし後続 section が使う前提として、save/cancel area を置ける layout にする。
|
||||
|
||||
## Backend API との関係
|
||||
|
||||
この Ticket では Settings mutation API は実装しない。
|
||||
|
||||
後続 Ticket では API path を次のどちらかに寄せることを検討する。
|
||||
|
||||
```http
|
||||
GET /api/settings
|
||||
GET /api/settings/runtime-connections
|
||||
```
|
||||
|
||||
または Workspace 配下であることを強調するなら:
|
||||
|
||||
```http
|
||||
GET /api/workspace/settings
|
||||
GET /api/workspace/settings/runtime-connections
|
||||
```
|
||||
|
||||
v0 shell は既存 `/api/workspace` projection などで表示可能な範囲に留めてよい。新 API を追加する場合も read-only summary に限定する。
|
||||
|
||||
## 依存関係
|
||||
|
||||
この Ticket は Runtime connection 管理 Ticket `00001KWHHRTM9` の前提とする。Runtime connection の add/delete/test/config persistence はこの Ticket では実装しない。
|
||||
|
||||
## 実装要件
|
||||
|
||||
- Workspace Browser に Settings/Admin entry point を追加する。
|
||||
- `/settings` route を追加する。
|
||||
- Settings/Admin shell layout を追加する。
|
||||
- Section navigation を追加する。
|
||||
- Runtime Connections placeholder section を追加する。
|
||||
- Backend Config placeholder section を追加する。
|
||||
- Workspace Identity placeholder / read-only section を追加する。
|
||||
- 現時点で user / permission model が無いことを UI に明記する。
|
||||
- user / role / permission の fake UI を作らない。
|
||||
- Restart required / sanitized diagnostic の表示 pattern を用意する。
|
||||
- 既存 Worker Console / Sidebar navigation と衝突しない。
|
||||
|
||||
## 受け入れ条件
|
||||
|
||||
- Sidebar または bottom utility から Settings/Admin に移動できる。
|
||||
- `/settings` が表示できる。
|
||||
- Settings/Admin shell に「現時点で user / permission model が無い」旨の注意書きがある。
|
||||
- Settings section navigation がある。
|
||||
- Runtime Connections placeholder がある。
|
||||
- Backend Config placeholder がある。
|
||||
- Workspace Identity placeholder または read-only summary がある。
|
||||
- UI 文言が fake user / role / permission model を示唆しない。
|
||||
- raw path / secret / token / socket path / runtime store path を placeholder や diagnostic に表示しない。
|
||||
- 既存 Worker Console / Runtime Console / Sidebar の主導線が壊れていない。
|
||||
- Focused tests が Settings route rendering、navigation、permission-model disclaimer、placeholder sections を確認する。
|
||||
- `cd web/workspace && deno task test` が通る。
|
||||
- `cd web/workspace && deno task check` が通る。
|
||||
- `git diff --check` が通る。
|
||||
|
||||
## 対象外
|
||||
|
||||
- Runtime connection add/delete/test 実装。
|
||||
- `.yoi/workspace-backend.local.toml` の read-modify-write API。
|
||||
- Backend config editor。
|
||||
- secret store UI。
|
||||
- user / permission UI。
|
||||
- Runtime live register / unregister。
|
||||
- Manual Coding Worker 作成 form。
|
||||
- Nix packaging に関わる変更。
|
||||
|
|
@ -1,30 +0,0 @@
|
|||
Workspace Browser に Settings/Admin shell と navigation を追加し、manual fallback review 後に orchestration branch へ merge した。
|
||||
|
||||
実装内容:
|
||||
- `/settings` route を追加。
|
||||
- Sidebar header の gear link と Sidebar 内 Settings section から Settings / Admin へ移動できるようにした。
|
||||
- Settings / Admin shell を追加し、以下の sections を配置。
|
||||
- Runtime Connections（placeholder）
|
||||
- Backend Config（placeholder）
|
||||
- Workspace Identity（read-only）
|
||||
- Runtime Connections / Backend Config は明確な placeholder とし、Runtime connection add/delete/test/persist、Backend config editor、secret UI、settings mutation API は実装していない。
|
||||
- Workspace Identity は opaque workspace id / display name / record authority context の read-only 表示に限定し、raw filesystem path を出していない。
|
||||
- browser user / role / permission / multi-user authorization model は存在しないこと、admin role を作らないことを明記。
|
||||
- sanitized diagnostics / restart-required / read-only until typed APIs exist の表示 pattern を追加。
|
||||
- Settings shell model tests を追加し、navigation、no fake browser admin model、placeholder boundaries、raw authority leak avoidance を確認。
|
||||
- Existing Worker Console / Sidebar route は維持。
|
||||
|
||||
Integrated commit:
|
||||
- `c0c6880b1a00ec367910267a3d2a0595839b3d5b feat: add settings admin shell`
|
||||
- merge: `fdad94af merge: settings admin shell`
|
||||
|
||||
Validation:
|
||||
- `deno run -A npm:@sveltejs/kit@2.49.4 sync`: success
|
||||
- `cd web/workspace && deno task test`: success (`10 passed`)
|
||||
- `cd web/workspace && deno task check`: success
|
||||
- `cd web/workspace && deno task build`: success
|
||||
- `git diff --check`: success
|
||||
|
||||
Operational note:
|
||||
- Coder/Reviewer Pod spawning was unavailable in the current Orchestrator process because `SpawnPod` tried to execute `/home/hare/.cargo/bin/yoi (deleted) pod`. This narrow web-only Ticket was implemented and reviewed directly by Orchestrator as a recorded fallback.
|
||||
- User instructed not to use `StopPod` for now after repeated stop/hang symptoms. Cleanup will remove only the child implementation worktree / branch.
|
||||
|
|
@ -1,338 +0,0 @@
|
|||
<!-- event: create author: "yoi ticket" at: 2026-07-02T13:59:17Z -->
|
||||
|
||||
## 作成
|
||||
|
||||
LocalTicketBackend によって作成されました。
|
||||
|
||||
---
|
||||
|
||||
<!-- event: plan author: hare at: 2026-07-02T14:00:20Z -->
|
||||
|
||||
## Plan
|
||||
|
||||
Workspace Browser Settings shell の先行 Ticket として詳細化した。
|
||||
|
||||
方針:
|
||||
- Settings は admin/user/permission 管理ではなく、現在の local Workspace Backend process と workspace-local config を扱う surface とする。
|
||||
- Runtime Connections / Backend Config / Workspace Identity の section 受け皿を先に作る。
|
||||
- この Ticket では mutation や Runtime connection 永続化は実装しない。
|
||||
- 後続 Runtime connection 管理 Ticket `00001KWHHRTM9` はこの Settings shell を前提にする。
|
||||
|
||||
|
||||
---
|
||||
|
||||
<!-- event: decision author: hare at: 2026-07-02T14:09:54Z -->
|
||||
|
||||
## Decision
|
||||
|
||||
Settings shell Ticket の位置づけを修正した。
|
||||
|
||||
Decision:
|
||||
- `Workspace-local Settings` という独自呼称はやめ、普通に Settings/Admin surface として扱う。
|
||||
- 管理画面ではない、という意味ではない。
|
||||
- 現時点で user / permission / multi-user authorization が無いため、それらがあるかのような fake UI / 文言を作らない、という制約だけを明記する。
|
||||
- 後続 Runtime connection management Ticket の依存先表記も Settings/Admin shell に修正した。
|
||||
|
||||
|
||||
---
|
||||
|
||||
<!-- event: intake_summary author: hare at: 2026-07-02T14:18:50Z -->
|
||||
|
||||
## Intake summary
|
||||
|
||||
Marked ready by `yoi ticket state`.
|
||||
|
||||
---
|
||||
|
||||
<!-- event: state_changed author: "yoi ticket" at: 2026-07-02T14:18:50Z from: planning to: ready reason: cli_state field: state -->
|
||||
|
||||
## State changed
|
||||
|
||||
Marked ready by `yoi ticket state`.
|
||||
|
||||
|
||||
---
|
||||
|
||||
<!-- event: state_changed author: workspace-panel at: 2026-07-02T14:24:54Z from: ready to: queued reason: queued field: state -->
|
||||
|
||||
## State changed
|
||||
|
||||
Ticket を `workspace-panel` が queued にしました。
|
||||
|
||||
|
||||
---
|
||||
|
||||
<!-- event: decision author: yoi-orchestrator at: 2026-07-02T14:25:39Z -->
|
||||
|
||||
## Decision
|
||||
|
||||
Routing decision:
|
||||
|
||||
Workspace Dashboard Queue authorized Orchestrator routing. Current state was inspected before implementation side effects.
|
||||
|
||||
Findings:
|
||||
- Ticket state: `queued`
|
||||
- Blocker relations: none
|
||||
- Current `inprogress` Tickets: 0
|
||||
- Orchestration worktree: clean
|
||||
|
||||
Decision:
|
||||
- Accept this Ticket for implementation and transition `queued -> inprogress` before child worktree / Pod side effects.
|
||||
|
||||
Plan:
|
||||
- Worktree: `/home/hare/Projects/yoi/.worktree/00001KWHJ0XH6-settings-admin-shell`
|
||||
- Branch: `work/00001KWHJ0XH6-settings-admin-shell`
|
||||
- Coder Worker will implement Workspace Browser Settings/Admin shell and navigation with focused `web/workspace/**` write scope.
|
||||
- Reviewer Worker will verify route rendering, navigation, no fake user/role/permission model, placeholder sections, sanitized diagnostic/restart-required patterns, non-leak of raw path/secret/token/socket/runtime store path, and existing Worker Console/Sidebar continuity.
|
||||
|
||||
Non-goals preserved:
|
||||
- no Runtime connection add/delete/test implementation
|
||||
- no settings mutation API
|
||||
- no backend config editor or secret store UI
|
||||
- no user/permission UI
|
||||
- no Runtime live register/unregister
|
||||
- no Nix/package changes expected
|
||||
|
||||
Operational note:
|
||||
- User instructed not to use `StopPod` for now after repeated stop/hang symptoms. Cleanup will skip role-Pod shutdown and remove only child worktree/branch unless explicitly reauthorized.
|
||||
|
||||
---
|
||||
|
||||
<!-- event: state_changed author: yoi-orchestrator at: 2026-07-02T14:25:48Z from: queued to: inprogress reason: authorized_unblocked_queue_acceptance field: state -->
|
||||
|
||||
## State changed
|
||||
|
||||
Dashboard Queue authorized routing. The Ticket has no blocker relations, no other Ticket is inprogress, and the orchestration worktree is clean. Accepting implementation before child worktree / role Pod side effects.
|
||||
|
||||
---
|
||||
|
||||
<!-- event: implementation_report author: yoi-orchestrator at: 2026-07-02T14:26:39Z -->
|
||||
|
||||
## Implementation report
|
||||
|
||||
Implementation routing diagnostic:
|
||||
|
||||
Attempted to spawn Coder Worker `yoi-coder-00001KWHJ0XH6-settings`, but `SpawnPod` failed before child startup with:
|
||||
|
||||
```text
|
||||
failed to spawn `/home/hare/.cargo/bin/yoi (deleted) pod`: No such file or directory (os error 2)
|
||||
```
|
||||
|
||||
This appears to be a runtime executable availability issue in the current Orchestrator process, not a Ticket/code implementation result.
|
||||
|
||||
Operational response:
|
||||
- The Ticket is already `inprogress` and the child worktree/branch exists.
|
||||
- Because role Pod spawning is temporarily unavailable and this Ticket is web-only / narrow-scope, Orchestrator will implement the small Settings/Admin shell directly in the child worktree, then route review if spawning becomes available; otherwise Orchestrator will perform focused validation and record the limitation.
|
||||
- `StopPod` remains unused per user instruction.
|
||||
|
||||
---
|
||||
|
||||
<!-- event: implementation_report author: yoi-orchestrator at: 2026-07-02T14:36:11Z -->
|
||||
|
||||
## Implementation report
|
||||
|
||||
Implementation report:
|
||||
|
||||
Due to `SpawnPod` failure caused by the current executable path being deleted, Orchestrator implemented the narrow web-only change directly in the child worktree.
|
||||
|
||||
Implementation commit:
|
||||
- `c0c6880b1a00ec367910267a3d2a0595839b3d5b feat: add settings admin shell`
|
||||
|
||||
Changed files:
|
||||
- `web/workspace/src/routes/settings/+page.svelte`
|
||||
- `web/workspace/src/lib/workspace-settings/SettingsPage.svelte`
|
||||
- `web/workspace/src/lib/workspace-settings/model.ts`
|
||||
- `web/workspace/src/lib/workspace-settings/model.test.ts`
|
||||
- `web/workspace/src/lib/workspace-sidebar/WorkspaceSidebar.svelte`
|
||||
- `web/workspace/src/app.css`
|
||||
- `web/workspace/deno.json`
|
||||
|
||||
Implementation summary:
|
||||
- Added `/settings` route and Settings / Admin page shell.
|
||||
- Added sidebar/header Settings navigation entry while preserving Worker Console/sidebar routes.
|
||||
- Added section navigation for Runtime Connections, Backend Config, and Workspace Identity.
|
||||
- Runtime Connections and Backend Config are explicit placeholders; Workspace Identity is read-only.
|
||||
- Added visible authority notice: no browser user/role/permission/multi-user authorization model exists and this shell does not create an admin role.
|
||||
- Added sanitized diagnostic / restart-required / read-only-until-typed-APIs patterns.
|
||||
- The page reads `/api/workspace` for opaque workspace id/display name/record authority context only; it does not expose raw filesystem path, secret, token, socket, runtime store path, or mutation control.
|
||||
- No Runtime connection mutation, settings mutation API, backend config editor, secret UI, or permission UI was added.
|
||||
|
||||
Validation:
|
||||
- `deno run -A npm:@sveltejs/kit@2.49.4 sync`: success
|
||||
- `cd web/workspace && deno task test`: success (`10 passed`)
|
||||
- `cd web/workspace && deno task check`: success
|
||||
- `cd web/workspace && deno task build`: success
|
||||
- `git diff --check`: success
|
||||
|
||||
Note:
|
||||
- Running `deno task test` before SvelteKit sync failed due stale/generated tsconfig state; after `svelte-kit sync`, the repository task succeeded. `deno task check` also runs sync.
|
||||
|
||||
---
|
||||
|
||||
<!-- event: implementation_report author: yoi-orchestrator at: 2026-07-02T14:36:39Z -->
|
||||
|
||||
## Implementation report
|
||||
|
||||
Review routing diagnostic:
|
||||
|
||||
Attempted to spawn Reviewer Worker `yoi-reviewer-00001KWHJ0XH6-settings`, but `SpawnPod` failed before child startup with the same runtime executable availability issue:
|
||||
|
||||
```text
|
||||
failed to spawn `/home/hare/.cargo/bin/yoi (deleted) pod`: No such file or directory (os error 2)
|
||||
```
|
||||
|
||||
Because role Pod spawning is unavailable in the current process and the change is narrow web-only, Orchestrator will perform a focused manual review plus validation before merge. This is recorded as an operational deviation from the normal sibling Reviewer path.
|
||||
|
||||
`StopPod` remains unused per user instruction.
|
||||
|
||||
---
|
||||
|
||||
<!-- event: review author: yoi-orchestrator at: 2026-07-02T14:37:21Z status: approve -->
|
||||
|
||||
## Review: approve
|
||||
|
||||
approve
|
||||
|
||||
Operational note:
|
||||
- Normal read-only Reviewer Worker could not be spawned because `SpawnPod` failed with current executable path `/home/hare/.cargo/bin/yoi (deleted) pod` missing. This review was therefore performed manually by Orchestrator as a narrow web-only fallback.
|
||||
|
||||
Review target:
|
||||
- `c0c6880b1a00ec367910267a3d2a0595839b3d5b feat: add settings admin shell`
|
||||
|
||||
確認した点:
|
||||
- `/settings` route が追加され、Settings / Admin shell が表示される。
|
||||
- Sidebar header gear と Sidebar の Settings section から `/settings` へ navigation できる。
|
||||
- Runtime Connections / Backend Config / Workspace Identity の sections がある。
|
||||
- Runtime Connections / Backend Config は placeholder として明示され、Runtime connection add/delete/test/persist、Backend config editor、secret UI、settings mutation API は実装されていない。
|
||||
- Workspace Identity は opaque `workspace_id` / display name / record authority context の read-only 表示であり、raw filesystem path を表示していない。
|
||||
- 「browser user / role / permission / multi-user authorization model は存在しない」「admin role を作らない」旨が明記されている。
|
||||
- sanitized diagnostics / restart-required / read-only until typed API exists の表示 pattern が追加されている。
|
||||
- 既存 Worker Console route と `runtime_id + worker_id` sidebar navigation は維持されている。
|
||||
- テストで Settings navigation、no fake admin permission model、placeholder boundaries、raw authority leak avoidance の最低限を確認している。
|
||||
|
||||
Validation:
|
||||
- `git diff --check HEAD~1..HEAD`: success
|
||||
- `deno run -A npm:@sveltejs/kit@2.49.4 sync`: success
|
||||
- `cd web/workspace && deno task test`: success (`10 passed`)
|
||||
- `cd web/workspace && deno task check`: success
|
||||
- `cd web/workspace && deno task build`: success
|
||||
|
||||
ブロッカーはない。
|
||||
|
||||
---
|
||||
|
||||
<!-- event: implementation_report author: yoi-orchestrator at: 2026-07-02T14:38:10Z -->
|
||||
|
||||
## Implementation report
|
||||
|
||||
Merge / validation report:
|
||||
|
||||
Implementation branch was integrated into the orchestration branch after manual fallback review approval.
|
||||
|
||||
Integrated commit:
|
||||
- `c0c6880b1a00ec367910267a3d2a0595839b3d5b feat: add settings admin shell`
|
||||
|
||||
Merge commit:
|
||||
- `fdad94af merge: settings admin shell`
|
||||
|
||||
Validation in orchestration worktree:
|
||||
- `deno run -A npm:@sveltejs/kit@2.49.4 sync`: success
|
||||
- `cd web/workspace && deno task test`: success (`10 passed`)
|
||||
- `cd web/workspace && deno task check`: success
|
||||
- `cd web/workspace && deno task build`: success
|
||||
- `git diff --check`: success
|
||||
|
||||
Outcome:
|
||||
- Added `/settings` route and Settings / Admin shell.
|
||||
- Added Sidebar navigation entry and header gear link to Settings / Admin.
|
||||
- Added Runtime Connections / Backend Config / Workspace Identity sections.
|
||||
- Runtime Connections and Backend Config remain explicit placeholders with no mutation API or persistence behavior.
|
||||
- Workspace Identity is read-only and avoids raw path exposure.
|
||||
- The shell explicitly states that no browser user/role/permission/multi-user authorization model exists and does not create an admin role.
|
||||
- Added sanitized diagnostic / restart-required / read-only-until-typed-APIs patterns.
|
||||
- Existing Worker Console / Sidebar routes remain intact.
|
||||
|
||||
Operational caveat:
|
||||
- Coder/Reviewer Pod spawning was unavailable in the current process because `SpawnPod` tried to execute `/home/hare/.cargo/bin/yoi (deleted) pod`. Orchestrator implemented and reviewed this narrow web-only change directly, then validated in the orchestration worktree.
|
||||
|
||||
---
|
||||
|
||||
<!-- event: state_changed author: yoi-orchestrator at: 2026-07-02T14:38:19Z from: inprogress to: done reason: implementation_merged_and_validated field: state -->
|
||||
|
||||
## State changed
|
||||
|
||||
Manual fallback review後に implementation branch を orchestration branch へ merge し、要求された web validation が成功したため done に遷移する。
|
||||
|
||||
Validation:
|
||||
- `deno run -A npm:@sveltejs/kit@2.49.4 sync`: success
|
||||
- `cd web/workspace && deno task test`: success (`10 passed`)
|
||||
- `cd web/workspace && deno task check`: success
|
||||
- `cd web/workspace && deno task build`: success
|
||||
- `git diff --check`: success
|
||||
|
||||
---
|
||||
|
||||
<!-- event: state_changed author: hare at: 2026-07-02T14:38:34Z from: done to: closed reason: closed field: state -->
|
||||
|
||||
## State changed
|
||||
|
||||
Ticket を closed にしました。
|
||||
|
||||
|
||||
---
|
||||
|
||||
<!-- event: close author: hare at: 2026-07-02T14:38:34Z status: closed -->
|
||||
|
||||
## 完了
|
||||
|
||||
Workspace Browser に Settings/Admin shell と navigation を追加し、manual fallback review 後に orchestration branch へ merge した。
|
||||
|
||||
実装内容:
|
||||
- `/settings` route を追加。
|
||||
- Sidebar header の gear link と Sidebar 内 Settings section から Settings / Admin へ移動できるようにした。
|
||||
- Settings / Admin shell を追加し、以下の sections を配置。
|
||||
- Runtime Connections（placeholder）
|
||||
- Backend Config（placeholder）
|
||||
- Workspace Identity（read-only）
|
||||
- Runtime Connections / Backend Config は明確な placeholder とし、Runtime connection add/delete/test/persist、Backend config editor、secret UI、settings mutation API は実装していない。
|
||||
- Workspace Identity は opaque workspace id / display name / record authority context の read-only 表示に限定し、raw filesystem path を出していない。
|
||||
- browser user / role / permission / multi-user authorization model は存在しないこと、admin role を作らないことを明記。
|
||||
- sanitized diagnostics / restart-required / read-only until typed APIs exist の表示 pattern を追加。
|
||||
- Settings shell model tests を追加し、navigation、no fake browser admin model、placeholder boundaries、raw authority leak avoidance を確認。
|
||||
- Existing Worker Console / Sidebar route は維持。
|
||||
|
||||
Integrated commit:
|
||||
- `c0c6880b1a00ec367910267a3d2a0595839b3d5b feat: add settings admin shell`
|
||||
- merge: `fdad94af merge: settings admin shell`
|
||||
|
||||
Validation:
|
||||
- `deno run -A npm:@sveltejs/kit@2.49.4 sync`: success
|
||||
- `cd web/workspace && deno task test`: success (`10 passed`)
|
||||
- `cd web/workspace && deno task check`: success
|
||||
- `cd web/workspace && deno task build`: success
|
||||
- `git diff --check`: success
|
||||
|
||||
Operational note:
|
||||
- Coder/Reviewer Pod spawning was unavailable in the current Orchestrator process because `SpawnPod` tried to execute `/home/hare/.cargo/bin/yoi (deleted) pod`. This narrow web-only Ticket was implemented and reviewed directly by Orchestrator as a recorded fallback.
|
||||
- User instructed not to use `StopPod` for now after repeated stop/hang symptoms. Cleanup will remove only the child implementation worktree / branch.
|
||||
|
||||
---
|
||||
|
||||
<!-- event: implementation_report author: yoi-orchestrator at: 2026-07-02T14:39:02Z -->
|
||||
|
||||
## Implementation report
|
||||
|
||||
Cleanup report:
|
||||
|
||||
- User instructed not to use `StopPod` for now after repeated stop/hang symptoms. No role Pod shutdown was attempted.
|
||||
- Child implementation worktree was removed:
|
||||
- `/home/hare/Projects/yoi/.worktree/00001KWHJ0XH6-settings-admin-shell`
|
||||
- Child implementation branch was removed:
|
||||
- `work/00001KWHJ0XH6-settings-admin-shell`
|
||||
- No root/original workspace cleanup was performed.
|
||||
- Orchestration worktree is clean after worktree/branch cleanup.
|
||||
|
||||
Note:
|
||||
- Role Pod spawning failed earlier because the current executable path was unavailable (`/home/hare/.cargo/bin/yoi (deleted) pod`), so no new role Pods from this Ticket required shutdown.
|
||||
|
||||
---
|
||||
|
|
@ -2,7 +2,7 @@ use std::net::SocketAddr;
|
|||
use std::path::{Path, PathBuf};
|
||||
use std::{fs, io};
|
||||
|
||||
use serde::{Deserialize, Serialize};
|
||||
use serde::Deserialize;
|
||||
|
||||
use crate::hosts::RemoteRuntimeConfig;
|
||||
use crate::identity::WorkspaceIdentity;
|
||||
|
|
@ -16,7 +16,7 @@ const DEFAULT_LISTEN: &str = "127.0.0.1:8787";
|
|||
const DEFAULT_FRONTEND_URL: &str = "http://127.0.0.1:5173";
|
||||
const DEFAULT_MAX_RECORDS: usize = 200;
|
||||
|
||||
#[derive(Debug, Clone, Default, Serialize, Deserialize, PartialEq, Eq)]
|
||||
#[derive(Debug, Clone, Default, Deserialize, PartialEq, Eq)]
|
||||
#[serde(deny_unknown_fields)]
|
||||
pub struct WorkspaceBackendConfigFile {
|
||||
#[serde(default)]
|
||||
|
|
@ -29,7 +29,7 @@ pub struct WorkspaceBackendConfigFile {
|
|||
pub runtimes: WorkspaceBackendRuntimesConfig,
|
||||
}
|
||||
|
||||
#[derive(Debug, Clone, Default, Serialize, Deserialize, PartialEq, Eq)]
|
||||
#[derive(Debug, Clone, Default, Deserialize, PartialEq, Eq)]
|
||||
#[serde(deny_unknown_fields)]
|
||||
pub struct WorkspaceBackendServerConfig {
|
||||
#[serde(default)]
|
||||
|
|
@ -40,7 +40,7 @@ pub struct WorkspaceBackendServerConfig {
|
|||
pub static_assets_dir: Option<PathBuf>,
|
||||
}
|
||||
|
||||
#[derive(Debug, Clone, Default, Serialize, Deserialize, PartialEq, Eq)]
|
||||
#[derive(Debug, Clone, Default, Deserialize, PartialEq, Eq)]
|
||||
#[serde(deny_unknown_fields)]
|
||||
pub struct WorkspaceBackendDataConfig {
|
||||
#[serde(default)]
|
||||
|
|
@ -51,21 +51,21 @@ pub struct WorkspaceBackendDataConfig {
|
|||
pub embedded_runtime_store_root: Option<PathBuf>,
|
||||
}
|
||||
|
||||
#[derive(Debug, Clone, Default, Serialize, Deserialize, PartialEq, Eq)]
|
||||
#[derive(Debug, Clone, Default, Deserialize, PartialEq, Eq)]
|
||||
#[serde(deny_unknown_fields)]
|
||||
pub struct WorkspaceBackendLimitsConfig {
|
||||
#[serde(default)]
|
||||
pub max_records: Option<usize>,
|
||||
}
|
||||
|
||||
#[derive(Debug, Clone, Default, Serialize, Deserialize, PartialEq, Eq)]
|
||||
#[derive(Debug, Clone, Default, Deserialize, PartialEq, Eq)]
|
||||
#[serde(deny_unknown_fields)]
|
||||
pub struct WorkspaceBackendRuntimesConfig {
|
||||
#[serde(default)]
|
||||
pub remote: Vec<RemoteRuntimeConfigFile>,
|
||||
}
|
||||
|
||||
#[derive(Debug, Clone, Serialize, Deserialize, PartialEq, Eq)]
|
||||
#[derive(Debug, Clone, Deserialize, PartialEq, Eq)]
|
||||
#[serde(deny_unknown_fields)]
|
||||
pub struct RemoteRuntimeConfigFile {
|
||||
pub id: String,
|
||||
|
|
@ -189,20 +189,6 @@ impl WorkspaceBackendConfigFile {
|
|||
}
|
||||
}
|
||||
|
||||
pub fn write_for_workspace(&self, workspace_root: impl AsRef<Path>) -> Result<()> {
|
||||
let path = Self::path_for_workspace(workspace_root);
|
||||
if let Some(parent) = path.parent() {
|
||||
fs::create_dir_all(parent)?;
|
||||
}
|
||||
let raw = toml::to_string_pretty(self).map_err(|error| {
|
||||
Error::Config(format!(
|
||||
"failed to serialize workspace backend config: {error}"
|
||||
))
|
||||
})?;
|
||||
fs::write(path, raw)?;
|
||||
Ok(())
|
||||
}
|
||||
|
||||
pub fn parse_str(raw: &str, path: impl AsRef<Path>) -> Result<Self> {
|
||||
toml::from_str(raw).map_err(|error| {
|
||||
Error::Config(format!(
|
||||
|
|
|
|||
|
|
@ -266,7 +266,6 @@ pub struct WorkerSpawnRequest {
|
|||
pub enum WorkerSpawnIntent {
|
||||
WorkspaceCompanion,
|
||||
WorkspaceOrchestrator,
|
||||
WorkspaceCoding,
|
||||
TicketRole {
|
||||
ticket_id: String,
|
||||
role: TicketWorkerRole,
|
||||
|
|
@ -2261,7 +2260,6 @@ fn embedded_profile_selector(intent: &WorkerSpawnIntent) -> ProfileSelector {
|
|||
ProfileSelector::Builtin("builtin:companion".to_string())
|
||||
}
|
||||
WorkerSpawnIntent::WorkspaceOrchestrator => ProfileSelector::RuntimeDefault,
|
||||
WorkerSpawnIntent::WorkspaceCoding => ProfileSelector::Builtin("builtin:coder".to_string()),
|
||||
}
|
||||
}
|
||||
|
||||
|
|
@ -2682,7 +2680,6 @@ fn worker_spawn_intent_label(intent: &WorkerSpawnIntent) -> &'static str {
|
|||
match intent {
|
||||
WorkerSpawnIntent::WorkspaceCompanion => "workspace_companion",
|
||||
WorkerSpawnIntent::WorkspaceOrchestrator => "workspace_orchestrator",
|
||||
WorkerSpawnIntent::WorkspaceCoding => "workspace_coding",
|
||||
WorkerSpawnIntent::TicketRole { role, .. } => match role {
|
||||
TicketWorkerRole::Intake => "ticket_intake",
|
||||
TicketWorkerRole::Orchestrator => "ticket_orchestrator",
|
||||
|
|
|
|||
File diff suppressed because it is too large
Load Diff
|
|
@ -6,7 +6,7 @@
|
|||
"dev": "deno run -A npm:vite@7.2.7 dev",
|
||||
"dev:backend": "cd ../.. && cargo run -p yoi-workspace-server -- serve --workspace . --db .yoi/workspace.db --listen 127.0.0.1:8787",
|
||||
"check": "deno run -A npm:@sveltejs/kit@2.49.4 sync && deno run -A npm:svelte-check@4.3.4 --tsconfig ./tsconfig.json",
|
||||
"test": "deno test --allow-read=src src/lib/workspace-console/model.test.ts src/lib/workspace-console/worker-console.ui.test.ts src/lib/workspace-settings/model.test.ts src/lib/workspace-sidebar/worker-launch.test.ts",
|
||||
"test": "deno test --allow-read=src src/lib/workspace-console/model.test.ts src/lib/workspace-console/worker-console.ui.test.ts",
|
||||
"build": "deno run -A npm:vite@7.2.7 build",
|
||||
"preview": "deno run -A npm:vite@7.2.7 preview"
|
||||
},
|
||||
|
|
|
|||
|
|
@ -988,308 +988,3 @@
|
|||
text-align: left;
|
||||
}
|
||||
}
|
||||
|
||||
.settings-button {
|
||||
text-decoration: none;
|
||||
cursor: pointer;
|
||||
}
|
||||
|
||||
.settings-button:hover,
|
||||
.settings-button:focus-visible,
|
||||
.settings-button.active {
|
||||
background: var(--interactive-selected);
|
||||
color: var(--accent);
|
||||
}
|
||||
|
||||
.settings-shell {
|
||||
gap: var(--space-5);
|
||||
}
|
||||
|
||||
.settings-hero,
|
||||
.settings-notice,
|
||||
.settings-section-header,
|
||||
.settings-patterns {
|
||||
display: flex;
|
||||
align-items: flex-start;
|
||||
justify-content: space-between;
|
||||
gap: var(--space-4);
|
||||
}
|
||||
|
||||
.hero-copy {
|
||||
max-width: 54rem;
|
||||
margin: 0;
|
||||
color: var(--text-muted);
|
||||
}
|
||||
|
||||
.badge {
|
||||
flex: 0 0 auto;
|
||||
border-radius: 999px;
|
||||
padding: 0.35rem 0.65rem;
|
||||
background: var(--bg-subtle);
|
||||
color: var(--text-muted);
|
||||
font-size: 0.72rem;
|
||||
font-weight: 800;
|
||||
letter-spacing: 0.06em;
|
||||
text-transform: uppercase;
|
||||
}
|
||||
|
||||
.badge.warning {
|
||||
color: var(--warning);
|
||||
}
|
||||
|
||||
.badge.success {
|
||||
color: var(--success);
|
||||
}
|
||||
|
||||
.settings-notice {
|
||||
border-left: 4px solid var(--warning);
|
||||
padding-left: var(--space-4);
|
||||
}
|
||||
|
||||
.settings-diagnostic {
|
||||
display: grid;
|
||||
gap: var(--space-1);
|
||||
max-width: 24rem;
|
||||
padding: var(--space-3) var(--space-4);
|
||||
border: 1px solid var(--line);
|
||||
border-radius: var(--radius-panel);
|
||||
background: var(--bg-raised);
|
||||
color: var(--text-muted);
|
||||
}
|
||||
|
||||
.settings-diagnostic strong {
|
||||
color: var(--text-strong);
|
||||
}
|
||||
|
||||
.settings-nav-card {
|
||||
display: flex;
|
||||
flex-wrap: wrap;
|
||||
gap: var(--space-3);
|
||||
}
|
||||
|
||||
.settings-nav-link {
|
||||
display: grid;
|
||||
gap: var(--space-1);
|
||||
min-width: min(16rem, 100%);
|
||||
padding: var(--space-3) var(--space-4);
|
||||
border: 1px solid var(--line);
|
||||
border-radius: var(--radius-panel);
|
||||
background: var(--bg-raised);
|
||||
color: inherit;
|
||||
text-decoration: none;
|
||||
}
|
||||
|
||||
.settings-nav-link:hover,
|
||||
.settings-nav-link:focus-visible {
|
||||
background: var(--interactive-hover);
|
||||
}
|
||||
|
||||
.settings-nav-link span {
|
||||
color: var(--text-strong);
|
||||
font-weight: 800;
|
||||
}
|
||||
|
||||
.settings-grid,
|
||||
.settings-pattern-grid {
|
||||
grid-template-columns: repeat(auto-fit, minmax(min(20rem, 100%), 1fr));
|
||||
}
|
||||
|
||||
.settings-section,
|
||||
.settings-patterns,
|
||||
.settings-pattern {
|
||||
display: grid;
|
||||
gap: var(--space-4);
|
||||
}
|
||||
|
||||
.settings-section ul,
|
||||
.settings-patterns ul {
|
||||
margin: 0;
|
||||
padding-left: 1.2rem;
|
||||
}
|
||||
|
||||
.settings-section li + li {
|
||||
margin-top: var(--space-2);
|
||||
}
|
||||
|
||||
.settings-identity-list {
|
||||
padding-top: var(--space-3);
|
||||
border-top: 1px solid var(--line);
|
||||
}
|
||||
|
||||
.settings-pattern {
|
||||
padding: var(--space-4);
|
||||
border-radius: var(--radius-panel);
|
||||
background: var(--bg-raised);
|
||||
}
|
||||
|
||||
.settings-pattern h3,
|
||||
.settings-pattern p {
|
||||
margin: 0;
|
||||
}
|
||||
|
||||
.status-message {
|
||||
margin: 0;
|
||||
color: var(--text-muted);
|
||||
}
|
||||
|
||||
@media (max-width: 760px) {
|
||||
.settings-hero,
|
||||
.settings-notice,
|
||||
.settings-section-header,
|
||||
.settings-patterns {
|
||||
display: grid;
|
||||
}
|
||||
}
|
||||
|
||||
.section-heading-row {
|
||||
display: flex;
|
||||
align-items: center;
|
||||
gap: 0.5rem;
|
||||
}
|
||||
|
||||
.section-action {
|
||||
margin-left: auto;
|
||||
border: 1px solid var(--line);
|
||||
border-radius: 999px;
|
||||
background: var(--bg-subtle);
|
||||
color: var(--text-strong);
|
||||
font-size: 0.72rem;
|
||||
padding: 0.2rem 0.55rem;
|
||||
cursor: pointer;
|
||||
}
|
||||
|
||||
.worker-new-form {
|
||||
display: grid;
|
||||
gap: 0.65rem;
|
||||
margin: 0.6rem 0 0.75rem;
|
||||
padding: 0.65rem;
|
||||
border: 1px solid var(--line);
|
||||
border-radius: 0.75rem;
|
||||
background: rgba(255, 255, 255, 0.03);
|
||||
}
|
||||
|
||||
.worker-new-form label,
|
||||
.settings-runtime-form label {
|
||||
display: grid;
|
||||
gap: 0.25rem;
|
||||
color: var(--text-muted);
|
||||
font-size: 0.78rem;
|
||||
}
|
||||
|
||||
.worker-new-form input,
|
||||
.worker-new-form select,
|
||||
.worker-new-form textarea,
|
||||
.settings-runtime-form input {
|
||||
width: 100%;
|
||||
border: 1px solid var(--line);
|
||||
border-radius: 0.55rem;
|
||||
background: var(--bg-raised);
|
||||
color: var(--text-strong);
|
||||
padding: 0.45rem 0.55rem;
|
||||
font: inherit;
|
||||
}
|
||||
|
||||
.worker-new-form textarea {
|
||||
resize: vertical;
|
||||
}
|
||||
|
||||
.worker-new-form button,
|
||||
.settings-runtime-form button,
|
||||
.settings-action-row button {
|
||||
border: 0;
|
||||
border-radius: 0.6rem;
|
||||
background: var(--accent);
|
||||
color: var(--bg);
|
||||
font-weight: 700;
|
||||
padding: 0.5rem 0.75rem;
|
||||
cursor: pointer;
|
||||
}
|
||||
|
||||
.worker-new-form button:disabled,
|
||||
.settings-runtime-form button:disabled,
|
||||
.settings-action-row button:disabled {
|
||||
cursor: not-allowed;
|
||||
opacity: 0.55;
|
||||
}
|
||||
|
||||
.settings-runtime-form,
|
||||
.settings-runtime-list {
|
||||
display: grid;
|
||||
gap: 0.75rem;
|
||||
margin-top: 1rem;
|
||||
}
|
||||
|
||||
.settings-runtime-form {
|
||||
border: 1px solid var(--line);
|
||||
border-radius: 1rem;
|
||||
padding: 1rem;
|
||||
background: rgba(255, 255, 255, 0.03);
|
||||
}
|
||||
|
||||
.settings-runtime-card {
|
||||
display: grid;
|
||||
gap: 0.75rem;
|
||||
border: 1px solid var(--line);
|
||||
border-radius: 1rem;
|
||||
padding: 1rem;
|
||||
background: var(--bg-raised);
|
||||
}
|
||||
|
||||
.settings-runtime-card header {
|
||||
display: flex;
|
||||
justify-content: space-between;
|
||||
gap: 1rem;
|
||||
align-items: flex-start;
|
||||
}
|
||||
|
||||
.settings-runtime-card.inactive {
|
||||
opacity: 0.86;
|
||||
}
|
||||
|
||||
.settings-identity-list.compact {
|
||||
grid-template-columns: repeat(auto-fit, minmax(9rem, 1fr));
|
||||
}
|
||||
|
||||
.settings-action-row {
|
||||
display: flex;
|
||||
gap: 0.5rem;
|
||||
flex-wrap: wrap;
|
||||
}
|
||||
|
||||
.settings-action-row .danger {
|
||||
background: var(--danger);
|
||||
color: var(--bg);
|
||||
}
|
||||
|
||||
.settings-diagnostics-list {
|
||||
display: grid;
|
||||
gap: 0.4rem;
|
||||
margin: 0;
|
||||
padding: 0;
|
||||
list-style: none;
|
||||
}
|
||||
|
||||
.settings-diagnostics-list li {
|
||||
display: grid;
|
||||
gap: 0.15rem;
|
||||
border-radius: 0.6rem;
|
||||
border: 1px solid var(--line);
|
||||
padding: 0.55rem 0.65rem;
|
||||
color: var(--text-muted);
|
||||
}
|
||||
|
||||
.settings-diagnostics-list li.error {
|
||||
border-color: rgba(255, 99, 99, 0.55);
|
||||
}
|
||||
|
||||
.settings-diagnostics-list li.warning {
|
||||
border-color: rgba(255, 205, 86, 0.55);
|
||||
}
|
||||
|
||||
.settings-test-result {
|
||||
display: grid;
|
||||
gap: 0.3rem;
|
||||
border-radius: 0.75rem;
|
||||
background: rgba(255, 255, 255, 0.04);
|
||||
padding: 0.75rem;
|
||||
}
|
||||
|
|
|
|||
|
|
@ -1,462 +0,0 @@
|
|||
<script lang="ts">
|
||||
import WorkspaceSidebar from "$lib/workspace-sidebar/WorkspaceSidebar.svelte";
|
||||
import type { WorkspaceResponse } from "$lib/workspace-sidebar/types";
|
||||
import {
|
||||
SETTINGS_PATTERNS,
|
||||
SETTINGS_PERMISSION_NOTICE,
|
||||
SETTINGS_SECTIONS,
|
||||
diagnosticLabel,
|
||||
settingsSectionHref,
|
||||
type Diagnostic,
|
||||
type RemoteRuntimeConnectionSummary,
|
||||
type RemoteRuntimeTestResponse,
|
||||
type RuntimeConnectionMutationResponse,
|
||||
type RuntimeConnectionSettingsResponse,
|
||||
type RuntimeConnectionSummary,
|
||||
} from "./model";
|
||||
|
||||
type RemoteAddForm = {
|
||||
runtime_id: string;
|
||||
display_name: string;
|
||||
endpoint: string;
|
||||
};
|
||||
|
||||
let workspace = $state<WorkspaceResponse | null>(null);
|
||||
let runtimeSettings = $state<RuntimeConnectionSettingsResponse | null>(null);
|
||||
let loading = $state(true);
|
||||
let runtimeLoading = $state(true);
|
||||
let error = $state<string | null>(null);
|
||||
let runtimeError = $state<string | null>(null);
|
||||
let mutationMessage = $state<string | null>(null);
|
||||
let mutationDiagnostics = $state<Diagnostic[]>([]);
|
||||
let tests = $state<Record<string, RemoteRuntimeTestResponse>>({});
|
||||
let deleting = $state<string | null>(null);
|
||||
let testing = $state<string | null>(null);
|
||||
let submitting = $state(false);
|
||||
let remoteForm = $state<RemoteAddForm>({
|
||||
runtime_id: "",
|
||||
display_name: "",
|
||||
endpoint: "",
|
||||
});
|
||||
|
||||
$effect(() => {
|
||||
let cancelled = false;
|
||||
|
||||
async function loadWorkspace() {
|
||||
loading = true;
|
||||
error = null;
|
||||
|
||||
try {
|
||||
const response = await fetch("/api/workspace");
|
||||
if (!response.ok) {
|
||||
throw new Error(`workspace request failed (${response.status})`);
|
||||
}
|
||||
const data = (await response.json()) as WorkspaceResponse;
|
||||
if (!cancelled) {
|
||||
workspace = data;
|
||||
}
|
||||
} catch (err) {
|
||||
if (!cancelled) {
|
||||
error = err instanceof Error ? err.message : "workspace request failed";
|
||||
}
|
||||
} finally {
|
||||
if (!cancelled) {
|
||||
loading = false;
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
async function loadRuntimeSettings() {
|
||||
runtimeLoading = true;
|
||||
runtimeError = null;
|
||||
try {
|
||||
const response = await fetch("/api/settings/runtime-connections");
|
||||
if (!response.ok) {
|
||||
throw new Error(`runtime settings request failed (${response.status})`);
|
||||
}
|
||||
const data = (await response.json()) as RuntimeConnectionSettingsResponse;
|
||||
if (!cancelled) {
|
||||
runtimeSettings = data;
|
||||
}
|
||||
} catch (err) {
|
||||
if (!cancelled) {
|
||||
runtimeError = err instanceof Error ? err.message : "runtime settings request failed";
|
||||
}
|
||||
} finally {
|
||||
if (!cancelled) {
|
||||
runtimeLoading = false;
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
loadWorkspace();
|
||||
loadRuntimeSettings();
|
||||
|
||||
return () => {
|
||||
cancelled = true;
|
||||
};
|
||||
});
|
||||
|
||||
async function submitRemoteRuntime() {
|
||||
submitting = true;
|
||||
mutationMessage = null;
|
||||
mutationDiagnostics = [];
|
||||
try {
|
||||
const response = await fetch("/api/settings/runtime-connections/remotes", {
|
||||
method: "POST",
|
||||
headers: { "content-type": "application/json" },
|
||||
body: JSON.stringify({
|
||||
runtime_id: remoteForm.runtime_id,
|
||||
display_name: remoteForm.display_name || null,
|
||||
endpoint: remoteForm.endpoint,
|
||||
}),
|
||||
});
|
||||
if (!response.ok) {
|
||||
throw new Error(await responseErrorMessage(response, "add remote Runtime failed"));
|
||||
}
|
||||
const data = (await response.json()) as RuntimeConnectionMutationResponse;
|
||||
applyRuntimeMutation(data);
|
||||
remoteForm = { runtime_id: "", display_name: "", endpoint: "" };
|
||||
} catch (err) {
|
||||
mutationMessage = err instanceof Error ? err.message : "add remote Runtime failed";
|
||||
} finally {
|
||||
submitting = false;
|
||||
}
|
||||
}
|
||||
|
||||
async function deleteRemoteRuntime(runtimeId: string) {
|
||||
deleting = runtimeId;
|
||||
mutationMessage = null;
|
||||
mutationDiagnostics = [];
|
||||
try {
|
||||
const response = await fetch(`/api/settings/runtime-connections/remotes/${encodeURIComponent(runtimeId)}`, {
|
||||
method: "DELETE",
|
||||
});
|
||||
if (!response.ok) {
|
||||
throw new Error(await responseErrorMessage(response, "delete remote Runtime failed"));
|
||||
}
|
||||
const data = (await response.json()) as RuntimeConnectionMutationResponse;
|
||||
applyRuntimeMutation(data);
|
||||
const nextTests = { ...tests };
|
||||
delete nextTests[runtimeId];
|
||||
tests = nextTests;
|
||||
} catch (err) {
|
||||
mutationMessage = err instanceof Error ? err.message : "delete remote Runtime failed";
|
||||
} finally {
|
||||
deleting = null;
|
||||
}
|
||||
}
|
||||
|
||||
async function testRemoteRuntime(runtimeId: string) {
|
||||
testing = runtimeId;
|
||||
try {
|
||||
const response = await fetch(`/api/settings/runtime-connections/remotes/${encodeURIComponent(runtimeId)}/test`, {
|
||||
method: "POST",
|
||||
});
|
||||
if (!response.ok) {
|
||||
throw new Error(await responseErrorMessage(response, "test remote Runtime failed"));
|
||||
}
|
||||
const data = (await response.json()) as RemoteRuntimeTestResponse;
|
||||
tests = { ...tests, [runtimeId]: data };
|
||||
} catch (err) {
|
||||
tests = {
|
||||
...tests,
|
||||
[runtimeId]: {
|
||||
workspace_id: runtimeSettings?.workspace_id ?? "unknown",
|
||||
runtime_id: runtimeId,
|
||||
checked_at: new Date().toISOString(),
|
||||
state: "failed",
|
||||
protocol_version: null,
|
||||
compatibility_basis: "browser request failed",
|
||||
capabilities: [],
|
||||
health_result: "failed",
|
||||
diagnostics: [
|
||||
{
|
||||
code: "browser_runtime_test_failed",
|
||||
severity: "error",
|
||||
message: err instanceof Error ? err.message : "test remote Runtime failed",
|
||||
},
|
||||
],
|
||||
},
|
||||
};
|
||||
} finally {
|
||||
testing = null;
|
||||
}
|
||||
}
|
||||
|
||||
function applyRuntimeMutation(data: RuntimeConnectionMutationResponse) {
|
||||
runtimeSettings = runtimeSettings
|
||||
? { ...runtimeSettings, remotes: data.remotes, diagnostics: data.diagnostics }
|
||||
: {
|
||||
workspace_id: data.workspace_id,
|
||||
embedded: {
|
||||
runtime_id: "embedded-worker-runtime",
|
||||
display_name: "Embedded Runtime",
|
||||
kind: "embedded_worker_runtime",
|
||||
built_in: true,
|
||||
config_managed: false,
|
||||
active: false,
|
||||
can_spawn_worker: false,
|
||||
restart_required: false,
|
||||
status: "unknown",
|
||||
diagnostics: [],
|
||||
},
|
||||
remotes: data.remotes,
|
||||
diagnostics: data.diagnostics,
|
||||
};
|
||||
mutationDiagnostics = data.diagnostics;
|
||||
mutationMessage = data.restart_required
|
||||
? "Runtime config saved. Restart the Workspace backend to apply live registry changes."
|
||||
: "Runtime config saved.";
|
||||
}
|
||||
|
||||
async function responseErrorMessage(response: Response, fallback: string): Promise<string> {
|
||||
try {
|
||||
const payload = (await response.json()) as { error?: { message?: string; code?: string } | string; message?: string };
|
||||
if (typeof payload.error === "object" && payload.error?.message) {
|
||||
return `${payload.error.code ?? "request_failed"}: ${payload.error.message}`;
|
||||
}
|
||||
if (payload.message) {
|
||||
const code = typeof payload.error === "string" ? payload.error : "request_failed";
|
||||
return `${code}: ${payload.message}`;
|
||||
}
|
||||
} catch {
|
||||
// fall through
|
||||
}
|
||||
return `${fallback} (${response.status})`;
|
||||
}
|
||||
</script>
|
||||
|
||||
<svelte:head>
|
||||
<title>Settings · Yoi Workspace</title>
|
||||
</svelte:head>
|
||||
|
||||
<div class="workspace-layout">
|
||||
<WorkspaceSidebar workspace={workspace} currentPath="/settings" />
|
||||
|
||||
<main class="shell settings-shell" aria-labelledby="settings-title">
|
||||
<section class="hero settings-hero">
|
||||
<div>
|
||||
<p class="eyebrow">Workspace Browser</p>
|
||||
<h1 id="settings-title">Settings / Admin</h1>
|
||||
<p class="hero-copy">
|
||||
Local administration surfaces for the Workspace backend. Runtime Connections v0 is editable through typed APIs; broader admin controls remain bounded placeholders.
|
||||
</p>
|
||||
</div>
|
||||
<span class="badge warning">local only</span>
|
||||
</section>
|
||||
|
||||
<section class="card settings-notice" aria-labelledby="settings-boundary-title">
|
||||
<div>
|
||||
<p class="eyebrow">Authority boundary</p>
|
||||
<h2 id="settings-boundary-title">No browser admin permission model</h2>
|
||||
<p>{SETTINGS_PERMISSION_NOTICE}</p>
|
||||
</div>
|
||||
<div class="settings-diagnostic" role="note">
|
||||
<strong>Restart-required</strong>
|
||||
<span>Runtime config changes are persisted, then applied after backend restart.</span>
|
||||
</div>
|
||||
</section>
|
||||
|
||||
<section class="settings-nav-card" aria-label="Settings sections">
|
||||
{#each SETTINGS_SECTIONS as section}
|
||||
<a class="settings-nav-link" href={settingsSectionHref(section.id)}>
|
||||
<span>{section.label}</span>
|
||||
<small>{section.status === "editable" ? "Editable" : section.status === "read-only" ? "Read-only" : "Placeholder"}</small>
|
||||
</a>
|
||||
{/each}
|
||||
</section>
|
||||
|
||||
<section class="card settings-section" id="runtime-connections" aria-labelledby="runtime-connections-title">
|
||||
<header class="settings-section-header">
|
||||
<div>
|
||||
<p class="eyebrow">editable</p>
|
||||
<h2 id="runtime-connections-title">Runtime Connections</h2>
|
||||
</div>
|
||||
<span class="badge success">typed API</span>
|
||||
</header>
|
||||
<p>{SETTINGS_SECTIONS.find((section) => section.id === "runtime-connections")?.summary}</p>
|
||||
|
||||
{#if runtimeLoading}
|
||||
<p class="status-message">Loading Runtime connections…</p>
|
||||
{:else if runtimeError}
|
||||
<p class="status-message error">Runtime connection settings unavailable: {runtimeError}</p>
|
||||
{:else if runtimeSettings}
|
||||
{@render RuntimeConnectionCard({ connection: runtimeSettings.embedded })}
|
||||
|
||||
<form class="settings-runtime-form" onsubmit={(event) => { event.preventDefault(); void submitRemoteRuntime(); }}>
|
||||
<h3>Add remote Runtime</h3>
|
||||
<p>Endpoint is submitted to the Backend but not echoed back in settings responses.</p>
|
||||
<label>
|
||||
<span>Runtime id</span>
|
||||
<input bind:value={remoteForm.runtime_id} required maxlength="96" pattern="[A-Za-z0-9_.-]+" placeholder="team-runtime" />
|
||||
</label>
|
||||
<label>
|
||||
<span>Display name</span>
|
||||
<input bind:value={remoteForm.display_name} maxlength="80" placeholder="Team Runtime" />
|
||||
</label>
|
||||
<label>
|
||||
<span>Endpoint</span>
|
||||
<input bind:value={remoteForm.endpoint} required inputmode="url" placeholder="https://runtime.example" />
|
||||
</label>
|
||||
<button type="submit" disabled={submitting}>{submitting ? "Saving…" : "Add Runtime"}</button>
|
||||
</form>
|
||||
|
||||
{#if mutationMessage}
|
||||
<p class="status-message" class:error={mutationMessage.includes("failed")}>{mutationMessage}</p>
|
||||
{/if}
|
||||
{@render DiagnosticsList({ diagnostics: mutationDiagnostics })}
|
||||
|
||||
<div class="settings-runtime-list" aria-label="Remote Runtime connections">
|
||||
<h3>Remote Runtimes</h3>
|
||||
{#if runtimeSettings.remotes.length === 0}
|
||||
<p class="status-message">No remote Runtime connections configured.</p>
|
||||
{:else}
|
||||
{#each runtimeSettings.remotes as remote (remote.runtime_id)}
|
||||
<article class="settings-runtime-card">
|
||||
{@render RuntimeConnectionCard({ connection: remote })}
|
||||
<dl class="settings-identity-list compact">
|
||||
<div>
|
||||
<dt>Endpoint</dt>
|
||||
<dd>{remote.endpoint_configured ? "configured (hidden)" : "not configured"}</dd>
|
||||
</div>
|
||||
<div>
|
||||
<dt>Token ref</dt>
|
||||
<dd>{remote.token_ref_configured ? "configured (hidden)" : "not configured"}</dd>
|
||||
</div>
|
||||
</dl>
|
||||
<div class="settings-action-row">
|
||||
<button type="button" onclick={() => void testRemoteRuntime(remote.runtime_id)} disabled={testing === remote.runtime_id}>
|
||||
{testing === remote.runtime_id ? "Testing…" : "Test"}
|
||||
</button>
|
||||
<button type="button" class="danger" onclick={() => void deleteRemoteRuntime(remote.runtime_id)} disabled={deleting === remote.runtime_id}>
|
||||
{deleting === remote.runtime_id ? "Deleting…" : "Delete"}
|
||||
</button>
|
||||
</div>
|
||||
{#if tests[remote.runtime_id]}
|
||||
{@const test = tests[remote.runtime_id]}
|
||||
<div class="settings-test-result">
|
||||
<strong>Test: {test.state}</strong>
|
||||
<span>{test.health_result} · {test.checked_at}</span>
|
||||
<p>{test.compatibility_basis}</p>
|
||||
{@render DiagnosticsList({ diagnostics: test.diagnostics })}
|
||||
</div>
|
||||
{/if}
|
||||
</article>
|
||||
{/each}
|
||||
{/if}
|
||||
</div>
|
||||
{/if}
|
||||
</section>
|
||||
|
||||
<div class="grid settings-grid">
|
||||
{#each SETTINGS_SECTIONS.filter((section) => section.id !== "runtime-connections") as section}
|
||||
<section class="card settings-section" id={section.id} aria-labelledby={`${section.id}-title`}>
|
||||
<header class="settings-section-header">
|
||||
<div>
|
||||
<p class="eyebrow">{section.status}</p>
|
||||
<h2 id={`${section.id}-title`}>{section.label}</h2>
|
||||
</div>
|
||||
{#if section.status === "placeholder"}
|
||||
<span class="badge neutral">not implemented</span>
|
||||
{:else}
|
||||
<span class="badge success">read-only</span>
|
||||
{/if}
|
||||
</header>
|
||||
<p>{section.summary}</p>
|
||||
<ul>
|
||||
{#each section.bullets as bullet}
|
||||
<li>{bullet}</li>
|
||||
{/each}
|
||||
</ul>
|
||||
|
||||
{#if section.id === "workspace-identity"}
|
||||
<dl class="settings-identity-list">
|
||||
<div>
|
||||
<dt>Workspace id</dt>
|
||||
<dd><code>{workspace?.workspace_id ?? "loading"}</code></dd>
|
||||
</div>
|
||||
<div>
|
||||
<dt>Display name</dt>
|
||||
<dd>{workspace?.display_name ?? "loading"}</dd>
|
||||
</div>
|
||||
<div>
|
||||
<dt>Record authority</dt>
|
||||
<dd>.yoi tickets/objectives through the Backend projection</dd>
|
||||
</div>
|
||||
</dl>
|
||||
{/if}
|
||||
</section>
|
||||
{/each}
|
||||
</div>
|
||||
|
||||
<section class="card settings-patterns" aria-labelledby="settings-patterns-title">
|
||||
<div>
|
||||
<p class="eyebrow">Implementation patterns</p>
|
||||
<h2 id="settings-patterns-title">How settings should appear</h2>
|
||||
</div>
|
||||
<div class="grid settings-pattern-grid">
|
||||
{#each SETTINGS_PATTERNS as pattern}
|
||||
<article class="settings-pattern">
|
||||
<h3>{pattern.title}</h3>
|
||||
<p>{pattern.body}</p>
|
||||
</article>
|
||||
{/each}
|
||||
</div>
|
||||
</section>
|
||||
|
||||
{#if loading}
|
||||
<p class="status-message">Loading workspace summary…</p>
|
||||
{:else if error}
|
||||
<p class="status-message error">Workspace summary unavailable: {error}</p>
|
||||
{/if}
|
||||
</main>
|
||||
</div>
|
||||
|
||||
{#snippet RuntimeConnectionCard({ connection }: { connection: RuntimeConnectionSummary | RemoteRuntimeConnectionSummary })}
|
||||
<article class="settings-runtime-card embedded" class:inactive={!connection.active}>
|
||||
<header>
|
||||
<div>
|
||||
<h3>{connection.display_name}</h3>
|
||||
<p><code>{connection.runtime_id}</code></p>
|
||||
</div>
|
||||
<span class="badge" class:success={connection.active} class:warning={!connection.active}>{connection.status}</span>
|
||||
</header>
|
||||
<dl class="settings-identity-list compact">
|
||||
<div>
|
||||
<dt>Kind</dt>
|
||||
<dd>{connection.kind}</dd>
|
||||
</div>
|
||||
<div>
|
||||
<dt>Built in</dt>
|
||||
<dd>{connection.built_in ? "yes" : "no"}</dd>
|
||||
</div>
|
||||
<div>
|
||||
<dt>Config managed</dt>
|
||||
<dd>{connection.config_managed ? "yes" : "no"}</dd>
|
||||
</div>
|
||||
<div>
|
||||
<dt>Spawn</dt>
|
||||
<dd>{connection.can_spawn_worker ? "available" : "unavailable"}</dd>
|
||||
</div>
|
||||
<div>
|
||||
<dt>Restart required</dt>
|
||||
<dd>{connection.restart_required ? "yes" : "no"}</dd>
|
||||
</div>
|
||||
</dl>
|
||||
{@render DiagnosticsList({ diagnostics: connection.diagnostics })}
|
||||
</article>
|
||||
{/snippet}
|
||||
|
||||
{#snippet DiagnosticsList({ diagnostics }: { diagnostics: Diagnostic[] })}
|
||||
{#if diagnostics.length > 0}
|
||||
<ul class="settings-diagnostics-list">
|
||||
{#each diagnostics as diagnostic}
|
||||
<li class={diagnostic.severity}>
|
||||
<strong>{diagnosticLabel(diagnostic)}</strong>
|
||||
<span>{diagnostic.message}</span>
|
||||
</li>
|
||||
{/each}
|
||||
</ul>
|
||||
{/if}
|
||||
{/snippet}
|
||||
|
|
@ -1,99 +0,0 @@
|
|||
import {
|
||||
SETTINGS_PATTERNS,
|
||||
SETTINGS_PERMISSION_NOTICE,
|
||||
SETTINGS_ROUTE,
|
||||
SETTINGS_SECTIONS,
|
||||
diagnosticLabel,
|
||||
settingsSectionHref,
|
||||
} from "./model.ts";
|
||||
|
||||
declare const Deno: {
|
||||
test(name: string, fn: () => void): void;
|
||||
};
|
||||
|
||||
function assert(condition: unknown, message: string): asserts condition {
|
||||
if (!condition) {
|
||||
throw new Error(message);
|
||||
}
|
||||
}
|
||||
|
||||
Deno.test("settings section navigation stays under the settings route", () => {
|
||||
assert(SETTINGS_ROUTE === "/settings", "settings route should be stable");
|
||||
|
||||
for (const section of SETTINGS_SECTIONS) {
|
||||
const href = settingsSectionHref(section.id);
|
||||
assert(
|
||||
href.startsWith("/settings#"),
|
||||
`${section.id} should link under settings`,
|
||||
);
|
||||
assert(
|
||||
href.endsWith(section.id),
|
||||
`${section.id} href should preserve section id`,
|
||||
);
|
||||
}
|
||||
});
|
||||
|
||||
Deno.test("settings shell advertises no fake browser admin model", () => {
|
||||
assert(
|
||||
SETTINGS_PERMISSION_NOTICE.includes("no browser user, role, permission"),
|
||||
"notice should explicitly deny a browser permission model",
|
||||
);
|
||||
assert(
|
||||
SETTINGS_PERMISSION_NOTICE.includes("does not create an admin role"),
|
||||
"notice should not imply an admin role exists",
|
||||
);
|
||||
});
|
||||
|
||||
Deno.test("runtime connections are editable without advertising raw authority leaks", () => {
|
||||
const runtimeSection = SETTINGS_SECTIONS.find((section) =>
|
||||
section.id === "runtime-connections"
|
||||
);
|
||||
assert(runtimeSection?.status === "editable", "Runtime Connections should be editable");
|
||||
|
||||
const allText = [
|
||||
SETTINGS_PERMISSION_NOTICE,
|
||||
...SETTINGS_SECTIONS.flatMap((section) => [
|
||||
section.label,
|
||||
section.summary,
|
||||
...section.bullets,
|
||||
]),
|
||||
...SETTINGS_PATTERNS.flatMap((pattern) => [pattern.title, pattern.body]),
|
||||
].join("\n");
|
||||
|
||||
assert(
|
||||
allText.includes("restart_required=true") || allText.includes("Restart-required"),
|
||||
"restart-required pattern should be visible",
|
||||
);
|
||||
assert(
|
||||
allText.includes("not echoed back") || allText.includes("not echoed"),
|
||||
"endpoint submission should not imply endpoint echoing",
|
||||
);
|
||||
|
||||
for (
|
||||
const forbidden of [
|
||||
"/home/",
|
||||
"socket path:",
|
||||
"token:",
|
||||
"secret:",
|
||||
"store root:",
|
||||
"config file path:",
|
||||
]
|
||||
) {
|
||||
assert(
|
||||
!allText.includes(forbidden),
|
||||
`settings copy should not expose ${forbidden}`,
|
||||
);
|
||||
}
|
||||
});
|
||||
|
||||
Deno.test("diagnostic labels preserve severity and code", () => {
|
||||
const diagnostic = {
|
||||
severity: "warning",
|
||||
code: "runtime_registry_restart_required",
|
||||
message: "Restart required.",
|
||||
} as const;
|
||||
assert(
|
||||
diagnosticLabel(diagnostic) === "warning: runtime_registry_restart_required",
|
||||
"diagnostic label should be bounded and stable",
|
||||
);
|
||||
});
|
||||
|
|
@ -1,137 +0,0 @@
|
|||
export type Diagnostic = {
|
||||
severity: "info" | "warning" | "error";
|
||||
code: string;
|
||||
message: string;
|
||||
};
|
||||
|
||||
export type SettingsSectionId =
|
||||
| "runtime-connections"
|
||||
| "backend-config"
|
||||
| "workspace-identity";
|
||||
|
||||
export type SettingsSection = {
|
||||
readonly id: SettingsSectionId;
|
||||
readonly label: string;
|
||||
readonly status: "editable" | "placeholder" | "read-only";
|
||||
readonly summary: string;
|
||||
readonly bullets: readonly string[];
|
||||
};
|
||||
|
||||
export type SettingsPattern = {
|
||||
readonly title: string;
|
||||
readonly body: string;
|
||||
};
|
||||
|
||||
export type RuntimeConnectionSummary = {
|
||||
runtime_id: string;
|
||||
display_name: string;
|
||||
kind: string;
|
||||
built_in: boolean;
|
||||
config_managed: boolean;
|
||||
active: boolean;
|
||||
can_spawn_worker: boolean;
|
||||
restart_required: boolean;
|
||||
status: string;
|
||||
diagnostics: Diagnostic[];
|
||||
};
|
||||
|
||||
export type RemoteRuntimeConnectionSummary = RuntimeConnectionSummary & {
|
||||
endpoint_configured: boolean;
|
||||
token_ref_configured: boolean;
|
||||
};
|
||||
|
||||
export type RuntimeConnectionSettingsResponse = {
|
||||
workspace_id: string;
|
||||
embedded: RuntimeConnectionSummary;
|
||||
remotes: RemoteRuntimeConnectionSummary[];
|
||||
diagnostics: Diagnostic[];
|
||||
};
|
||||
|
||||
export type RuntimeConnectionMutationResponse = {
|
||||
workspace_id: string;
|
||||
restart_required: boolean;
|
||||
remotes: RemoteRuntimeConnectionSummary[];
|
||||
diagnostics: Diagnostic[];
|
||||
};
|
||||
|
||||
export type RemoteRuntimeTestResponse = {
|
||||
workspace_id: string;
|
||||
runtime_id: string;
|
||||
checked_at: string;
|
||||
state: string;
|
||||
protocol_version?: string | null;
|
||||
compatibility_basis: string;
|
||||
capabilities: string[];
|
||||
health_result: string;
|
||||
diagnostics: Diagnostic[];
|
||||
};
|
||||
|
||||
export const SETTINGS_ROUTE = "/settings";
|
||||
|
||||
export const SETTINGS_PERMISSION_NOTICE =
|
||||
"Yoi currently has no browser user, role, permission, or multi-user authorization model. This local settings surface uses typed Backend APIs only; it does not create an admin role or grant broad mutation authority.";
|
||||
|
||||
export const SETTINGS_SECTIONS: readonly SettingsSection[] = [
|
||||
{
|
||||
id: "runtime-connections",
|
||||
label: "Runtime Connections",
|
||||
status: "editable",
|
||||
summary:
|
||||
"Manage remote Runtime connection records stored in the workspace-local Backend config. The embedded Runtime is built in and shown separately.",
|
||||
bullets: [
|
||||
"Remote connection changes are persisted through typed read-modify-write config updates and require a Backend restart before the live registry changes.",
|
||||
"The browser may submit a new endpoint, but Runtime endpoints, tokens, sockets, store roots, and config paths are not echoed back in API responses.",
|
||||
"Test negotiation is an observation only; checked_at, health, compatibility, and capability results are not persisted to local config.",
|
||||
],
|
||||
},
|
||||
{
|
||||
id: "backend-config",
|
||||
label: "Backend Config",
|
||||
status: "placeholder",
|
||||
summary:
|
||||
"General Backend config editing remains out of scope; this page only exposes the Runtime Connections v0 typed surface.",
|
||||
bullets: [
|
||||
"Only sanitized summaries belong in the browser; raw config paths, secret refs, tokens, and store roots stay backend-side.",
|
||||
"Missing-provider or invalid-config states should be displayed as typed diagnostics.",
|
||||
"No fake permission model is created to make unrelated config editing appear available.",
|
||||
],
|
||||
},
|
||||
{
|
||||
id: "workspace-identity",
|
||||
label: "Workspace Identity",
|
||||
status: "read-only",
|
||||
summary:
|
||||
"Workspace identity is presented as read-only context so operators can tell which workspace the browser is attached to.",
|
||||
bullets: [
|
||||
"Use opaque workspace ids and display names rather than raw filesystem paths.",
|
||||
"Repository/project-record authority remains backend-side and is not edited here.",
|
||||
"Identity changes need a later explicit migration flow.",
|
||||
],
|
||||
},
|
||||
];
|
||||
|
||||
export const SETTINGS_PATTERNS: readonly SettingsPattern[] = [
|
||||
{
|
||||
title: "Sanitized diagnostics",
|
||||
body:
|
||||
"Settings cards show bounded codes and operator-facing messages, not raw socket paths, credentials, token values, Runtime endpoints, or Runtime store paths.",
|
||||
},
|
||||
{
|
||||
title: "Restart-required changes",
|
||||
body:
|
||||
"Remote Runtime config updates return restart_required=true because v0 does not unregister/register live Runtime handles.",
|
||||
},
|
||||
{
|
||||
title: "Typed Runtime surface only",
|
||||
body:
|
||||
"Runtime Connections v0 is intentionally narrow: embedded is built in, remote config is add/delete/test, and broader Backend admin controls stay unavailable.",
|
||||
},
|
||||
];
|
||||
|
||||
export function settingsSectionHref(id: SettingsSectionId): string {
|
||||
return `${SETTINGS_ROUTE}#${id}`;
|
||||
}
|
||||
|
||||
export function diagnosticLabel(diagnostic: Diagnostic): string {
|
||||
return `${diagnostic.severity}: ${diagnostic.code}`;
|
||||
}
|
||||
|
|
@ -1,12 +1,6 @@
|
|||
<script lang="ts">
|
||||
import { workerConsoleHref } from '$lib/workspace-console/model';
|
||||
import { buildBrowserCreateWorkerRequest, defaultWorkerLaunchForm } from './worker-launch';
|
||||
import type {
|
||||
BrowserCreateWorkerResponse,
|
||||
ListResponse,
|
||||
Worker,
|
||||
WorkerLaunchOptionsResponse,
|
||||
} from './types';
|
||||
import type { ListResponse, Worker } from './types';
|
||||
|
||||
const MAX_VISIBLE_WORKERS = 6;
|
||||
|
||||
|
|
@ -20,24 +14,14 @@
|
|||
let error = $state<string | null>(null);
|
||||
let workers = $state<Worker[]>([]);
|
||||
let placeholder = $state<string | null>(null);
|
||||
let options = $state<WorkerLaunchOptionsResponse | null>(null);
|
||||
let optionsError = $state<string | null>(null);
|
||||
let showNewWorker = $state(false);
|
||||
let submitting = $state(false);
|
||||
let submitError = $state<string | null>(null);
|
||||
let displayName = $state('Coding Worker');
|
||||
let runtimeId = $state('');
|
||||
let profile = $state('builtin:coder');
|
||||
let initialText = $state('');
|
||||
|
||||
$effect(() => {
|
||||
const controller = new AbortController();
|
||||
void loadWorkers(controller.signal);
|
||||
void loadLaunchOptions(controller.signal);
|
||||
return () => controller.abort();
|
||||
});
|
||||
|
||||
async function loadWorkers(signal?: AbortSignal) {
|
||||
async function loadWorkers(signal: AbortSignal) {
|
||||
loading = true;
|
||||
error = null;
|
||||
placeholder = null;
|
||||
|
|
@ -63,141 +47,21 @@
|
|||
error = err instanceof Error ? err.message : 'workers request failed';
|
||||
workers = [];
|
||||
} finally {
|
||||
if (!signal?.aborted) {
|
||||
if (!signal.aborted) {
|
||||
loading = false;
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
async function loadLaunchOptions(signal?: AbortSignal) {
|
||||
optionsError = null;
|
||||
try {
|
||||
const response = await fetch('/api/workers/launch-options', { signal });
|
||||
if (!response.ok) {
|
||||
throw new Error(`worker launch options failed (${response.status})`);
|
||||
}
|
||||
const payload = (await response.json()) as WorkerLaunchOptionsResponse;
|
||||
options = payload;
|
||||
const form = defaultWorkerLaunchForm(payload, {
|
||||
runtime_id: runtimeId,
|
||||
display_name: displayName,
|
||||
profile,
|
||||
initial_text: initialText,
|
||||
});
|
||||
runtimeId = form.runtime_id;
|
||||
displayName = form.display_name;
|
||||
profile = form.profile;
|
||||
} catch (err) {
|
||||
if (err instanceof DOMException && err.name === 'AbortError') {
|
||||
return;
|
||||
}
|
||||
optionsError = err instanceof Error ? err.message : 'worker launch options failed';
|
||||
}
|
||||
}
|
||||
|
||||
async function createWorker() {
|
||||
submitError = null;
|
||||
submitting = true;
|
||||
try {
|
||||
const response = await fetch('/api/workers', {
|
||||
method: 'POST',
|
||||
headers: { 'content-type': 'application/json' },
|
||||
body: JSON.stringify(buildBrowserCreateWorkerRequest({
|
||||
runtime_id: runtimeId,
|
||||
display_name: displayName,
|
||||
profile,
|
||||
initial_text: initialText,
|
||||
})),
|
||||
});
|
||||
if (!response.ok) {
|
||||
throw new Error(await responseErrorMessage(response, 'worker create failed'));
|
||||
}
|
||||
const payload = (await response.json()) as BrowserCreateWorkerResponse;
|
||||
await loadWorkers();
|
||||
window.location.href = payload.console_href;
|
||||
} catch (err) {
|
||||
submitError = err instanceof Error ? err.message : 'worker create failed';
|
||||
} finally {
|
||||
submitting = false;
|
||||
}
|
||||
}
|
||||
|
||||
async function responseErrorMessage(response: Response, fallback: string): Promise<string> {
|
||||
try {
|
||||
const payload = (await response.json()) as { error?: { message?: string; code?: string } | string; message?: string };
|
||||
if (typeof payload.error === 'object' && payload.error?.message) {
|
||||
return `${payload.error.code ?? 'request_failed'}: ${payload.error.message}`;
|
||||
}
|
||||
if (payload.message) {
|
||||
const code = typeof payload.error === 'string' ? payload.error : 'request_failed';
|
||||
return `${code}: ${payload.message}`;
|
||||
}
|
||||
} catch {
|
||||
// fall through
|
||||
}
|
||||
return `${fallback} (${response.status})`;
|
||||
}
|
||||
</script>
|
||||
|
||||
<section class="nav-section" aria-labelledby="workers-heading">
|
||||
<div class="section-heading-row">
|
||||
<h2 id="workers-heading">workers</h2>
|
||||
<button type="button" class="section-action" onclick={() => (showNewWorker = !showNewWorker)}>
|
||||
{showNewWorker ? 'Close' : 'New'}
|
||||
</button>
|
||||
{#if !loading && !error && workers.length > 0}
|
||||
<span class="section-count">{workers.length}</span>
|
||||
{/if}
|
||||
</div>
|
||||
|
||||
{#if showNewWorker}
|
||||
<form class="worker-new-form" onsubmit={(event) => { event.preventDefault(); void createWorker(); }}>
|
||||
<label>
|
||||
<span>Display name</span>
|
||||
<input bind:value={displayName} required maxlength="80" autocomplete="off" />
|
||||
</label>
|
||||
<label>
|
||||
<span>Runtime</span>
|
||||
<select bind:value={runtimeId} required>
|
||||
{#if options?.runtimes.length}
|
||||
{#each options.runtimes as runtime}
|
||||
<option value={runtime.runtime_id} disabled={!runtime.can_spawn_worker}>
|
||||
{runtime.display_name} · {runtime.status}{runtime.built_in ? ' · embedded' : ''}
|
||||
</option>
|
||||
{/each}
|
||||
{:else}
|
||||
<option value="" disabled>No Runtime options</option>
|
||||
{/if}
|
||||
</select>
|
||||
</label>
|
||||
<label>
|
||||
<span>Profile</span>
|
||||
<select bind:value={profile} required>
|
||||
{#if options?.profiles.length}
|
||||
{#each options.profiles as candidate}
|
||||
<option value={candidate.id}>{candidate.label}</option>
|
||||
{/each}
|
||||
{:else}
|
||||
<option value="" disabled>No profile candidates</option>
|
||||
{/if}
|
||||
</select>
|
||||
</label>
|
||||
<label>
|
||||
<span>Initial text</span>
|
||||
<textarea bind:value={initialText} rows="3" placeholder="Optional first instruction"></textarea>
|
||||
</label>
|
||||
{#if optionsError}
|
||||
<p class="section-state error">{optionsError}</p>
|
||||
{/if}
|
||||
{#if submitError}
|
||||
<p class="section-state error">{submitError}</p>
|
||||
{/if}
|
||||
<button type="submit" disabled={submitting || !runtimeId || !profile}>
|
||||
{submitting ? 'Starting…' : 'Start Coding Worker'}
|
||||
</button>
|
||||
</form>
|
||||
{/if}
|
||||
|
||||
{#if loading}
|
||||
<p class="section-state">Checking workers…</p>
|
||||
{:else if error}
|
||||
|
|
|
|||
|
|
@ -11,7 +11,6 @@
|
|||
};
|
||||
|
||||
let { workspace, workspaceError = null, currentPath = '/' }: Props = $props();
|
||||
let settingsActive = $derived(currentPath.startsWith("/settings"));
|
||||
</script>
|
||||
|
||||
<aside class="workspace-sidebar" aria-label="Workspace navigation">
|
||||
|
|
@ -30,35 +29,20 @@
|
|||
{/if}
|
||||
</div>
|
||||
|
||||
<a
|
||||
<button
|
||||
class="settings-button"
|
||||
class:active={settingsActive}
|
||||
href="/settings"
|
||||
aria-label="Open Settings / Admin"
|
||||
title="Settings / Admin"
|
||||
aria-current={settingsActive ? 'page' : undefined}
|
||||
type="button"
|
||||
aria-label="Workspace settings"
|
||||
title="Workspace settings placeholder"
|
||||
disabled
|
||||
>
|
||||
⚙
|
||||
</a>
|
||||
</button>
|
||||
</header>
|
||||
|
||||
<nav class="sidebar-sections" aria-label="Workspace sections">
|
||||
<RepositoriesNavSection {workspace} {currentPath} />
|
||||
<ObjectivesNavSection {currentPath} />
|
||||
<WorkersNavSection {currentPath} />
|
||||
|
||||
<section class="nav-section" aria-labelledby="settings-heading">
|
||||
<div class="section-heading-row">
|
||||
<h2 id="settings-heading">settings</h2>
|
||||
</div>
|
||||
<ul class="nav-list" aria-label="Settings">
|
||||
<li>
|
||||
<a class="nav-item" class:active={settingsActive} href="/settings" aria-current={settingsActive ? 'page' : undefined}>
|
||||
<span class="item-title">Settings / Admin</span>
|
||||
<span class="item-meta">Backend shell and diagnostics</span>
|
||||
</a>
|
||||
</li>
|
||||
</ul>
|
||||
</section>
|
||||
</nav>
|
||||
</aside>
|
||||
|
|
|
|||
|
|
@ -93,37 +93,6 @@ export type Worker = {
|
|||
|
||||
export type WorkerOperationState = 'accepted' | 'unsupported' | 'rejected';
|
||||
|
||||
export type WorkerLaunchRuntimeOption = {
|
||||
runtime_id: string;
|
||||
display_name: string;
|
||||
built_in: boolean;
|
||||
can_spawn_worker: boolean;
|
||||
status: string;
|
||||
diagnostics: Diagnostic[];
|
||||
};
|
||||
|
||||
export type WorkerLaunchProfileCandidate = {
|
||||
id: string;
|
||||
label: string;
|
||||
description: string;
|
||||
};
|
||||
|
||||
export type WorkerLaunchOptionsResponse = {
|
||||
workspace_id: string;
|
||||
runtimes: WorkerLaunchRuntimeOption[];
|
||||
profiles: WorkerLaunchProfileCandidate[];
|
||||
diagnostics: Diagnostic[];
|
||||
};
|
||||
|
||||
export type BrowserCreateWorkerResponse = {
|
||||
workspace_id: string;
|
||||
runtime_id: string;
|
||||
worker_id: string;
|
||||
console_href: string;
|
||||
worker: Worker;
|
||||
diagnostics: Diagnostic[];
|
||||
};
|
||||
|
||||
export type WorkerInputResult = {
|
||||
state: WorkerOperationState;
|
||||
runtime_id: string;
|
||||
|
|
|
|||
|
|
@ -1,83 +0,0 @@
|
|||
import {
|
||||
buildBrowserCreateWorkerRequest,
|
||||
defaultWorkerLaunchForm,
|
||||
type WorkerLaunchFormState,
|
||||
} from './worker-launch.ts';
|
||||
|
||||
import type { WorkerLaunchOptionsResponse } from './types.ts';
|
||||
|
||||
declare const Deno: {
|
||||
test(name: string, fn: () => void): void;
|
||||
};
|
||||
|
||||
function assert(condition: unknown, message: string): asserts condition {
|
||||
if (!condition) {
|
||||
throw new Error(message);
|
||||
}
|
||||
}
|
||||
|
||||
const options: WorkerLaunchOptionsResponse = {
|
||||
workspace_id: 'workspace',
|
||||
runtimes: [
|
||||
{
|
||||
runtime_id: 'remote-runtime',
|
||||
display_name: 'Remote Runtime',
|
||||
built_in: false,
|
||||
can_spawn_worker: false,
|
||||
status: 'active',
|
||||
diagnostics: [],
|
||||
},
|
||||
{
|
||||
runtime_id: 'embedded-worker-runtime',
|
||||
display_name: 'Embedded Runtime',
|
||||
built_in: true,
|
||||
can_spawn_worker: true,
|
||||
status: 'active',
|
||||
diagnostics: [],
|
||||
},
|
||||
],
|
||||
profiles: [
|
||||
{
|
||||
id: 'runtime_default',
|
||||
label: 'Runtime default',
|
||||
description: 'Runtime default profile.',
|
||||
},
|
||||
{
|
||||
id: 'builtin:coder',
|
||||
label: 'Coding Worker',
|
||||
description: 'Coding role.',
|
||||
},
|
||||
],
|
||||
diagnostics: [],
|
||||
};
|
||||
|
||||
Deno.test('new worker form defaults to backend-published runtime and profile candidates', () => {
|
||||
const current: WorkerLaunchFormState = {
|
||||
runtime_id: '',
|
||||
display_name: '',
|
||||
profile: 'free-text-profile',
|
||||
initial_text: 'start here',
|
||||
};
|
||||
|
||||
const form = defaultWorkerLaunchForm(options, current);
|
||||
assert(form.runtime_id === 'embedded-worker-runtime', 'should choose spawn-capable runtime');
|
||||
assert(form.profile === 'builtin:coder', 'should choose backend-published coder profile');
|
||||
assert(form.display_name === 'Coding Worker', 'should derive default display name');
|
||||
assert(form.initial_text === 'start here', 'should preserve initial text');
|
||||
});
|
||||
|
||||
Deno.test('new worker submit payload exposes only browser contract fields', () => {
|
||||
const request = buildBrowserCreateWorkerRequest({
|
||||
runtime_id: 'embedded-worker-runtime',
|
||||
display_name: 'Coding Worker',
|
||||
profile: 'builtin:coder',
|
||||
initial_text: 'implement ticket',
|
||||
});
|
||||
|
||||
assert(
|
||||
JSON.stringify(Object.keys(request).sort()) ===
|
||||
JSON.stringify(['display_name', 'initial_text', 'profile', 'runtime_id'].sort()),
|
||||
'submit payload should contain only Browser-facing worker create fields',
|
||||
);
|
||||
assert(!('kind' in request), 'kind must not be exposed as a Browser request field');
|
||||
});
|
||||
|
|
@ -1,41 +0,0 @@
|
|||
import type { WorkerLaunchOptionsResponse } from './types';
|
||||
|
||||
export type WorkerLaunchFormState = {
|
||||
runtime_id: string;
|
||||
display_name: string;
|
||||
profile: string;
|
||||
initial_text: string;
|
||||
};
|
||||
|
||||
export type BrowserCreateWorkerRequest = WorkerLaunchFormState;
|
||||
|
||||
export function defaultWorkerLaunchForm(
|
||||
options: WorkerLaunchOptionsResponse | null,
|
||||
current: WorkerLaunchFormState,
|
||||
): WorkerLaunchFormState {
|
||||
const preferredRuntime = options?.runtimes.find((runtime) => runtime.can_spawn_worker && runtime.status === 'active')
|
||||
?? options?.runtimes.find((runtime) => runtime.can_spawn_worker)
|
||||
?? options?.runtimes[0];
|
||||
const preferredProfile = options?.profiles.find((candidate) => candidate.id === 'builtin:coder')
|
||||
?? options?.profiles[0];
|
||||
|
||||
return {
|
||||
runtime_id: current.runtime_id || preferredRuntime?.runtime_id || '',
|
||||
display_name: current.display_name || 'Coding Worker',
|
||||
profile: options?.profiles.some((candidate) => candidate.id === current.profile)
|
||||
? current.profile
|
||||
: preferredProfile?.id || '',
|
||||
initial_text: current.initial_text,
|
||||
};
|
||||
}
|
||||
|
||||
export function buildBrowserCreateWorkerRequest(
|
||||
form: WorkerLaunchFormState,
|
||||
): BrowserCreateWorkerRequest {
|
||||
return {
|
||||
runtime_id: form.runtime_id,
|
||||
display_name: form.display_name,
|
||||
profile: form.profile,
|
||||
initial_text: form.initial_text,
|
||||
};
|
||||
}
|
||||
|
|
@ -1,5 +0,0 @@
|
|||
<script lang="ts">
|
||||
import SettingsPage from "$lib/workspace-settings/SettingsPage.svelte";
|
||||
</script>
|
||||
|
||||
<SettingsPage />
|
||||
|
|
@ -10,7 +10,6 @@
|
|||
"skipLibCheck": true,
|
||||
"sourceMap": true,
|
||||
"strict": true,
|
||||
"module": "ESNext",
|
||||
"moduleResolution": "bundler"
|
||||
}
|
||||
}
|
||||
|
|
|
|||
Loading…
Reference in New Issue
Block a user