ticket: close embedded no-workdir policy work
This commit is contained in:
parent
2f7b809401
commit
14e704b858
|
|
@ -1,9 +1,9 @@
|
|||
---
|
||||
title: 'Embedded no-workdir Worker authority policy'
|
||||
state: 'inprogress'
|
||||
state: 'closed'
|
||||
priority: 'P1'
|
||||
created_at: '2026-07-10T20:52:43Z'
|
||||
updated_at: '2026-07-11T00:12:24Z'
|
||||
updated_at: '2026-07-11T00:13:51Z'
|
||||
assignee: null
|
||||
queued_by: 'workspace-panel'
|
||||
queued_at: '2026-07-10T22:00:07Z'
|
||||
|
|
|
|||
28
.yoi/tickets/00001KX6WVNPD/resolution.md
Normal file
28
.yoi/tickets/00001KX6WVNPD/resolution.md
Normal file
|
|
@ -0,0 +1,28 @@
|
|||
Embedded no-workdir Worker authority policy を実装・レビュー・merge・検証した。
|
||||
|
||||
実装内容:
|
||||
- Runtime launch metadata に `working_directory_required` を追加し、embedded Runtime のみ workdir optional として扱うようにした。
|
||||
- Workspace/API Worker create path で、embedded Runtime では no-workdir Worker creation を許可し、non-embedded Runtime では no-workdir creation を typed diagnostic で拒否するようにした。
|
||||
- Embedded no-workdir launch は Runtime へ working directory なしで渡され、merged `WorkerFilesystemAuthority` 境界により `WorkerFilesystemAuthority::None` になる。
|
||||
- Workdir-present embedded Worker は materialized binding を `WorkerFilesystemAuthority::Local` として保持する既存 behavior を維持。
|
||||
- Browser Worker creation UI で embedded Runtime の場合だけ “No working directory — guidance-only Worker; filesystem tools are disabled” を選べるようにした。
|
||||
- No-workdir launch では relative cwd input を隠し、filesystem tools / Bash が disabled であることを明示。
|
||||
- Tests で launch metadata、non-embedded no-workdir rejection、embedded no-workdir request construction、および existing runtime tests による no-workdir tool omission/no cwd fallback を確認。
|
||||
|
||||
Review:
|
||||
- Reviewer approved with no blockers。
|
||||
- Evidence included API optionality bounds, non-embedded rejection, authority construction path, no filesystem/Bash tool surface coverage, workdir-present behavior, and Browser labeling。
|
||||
|
||||
Merge / validation:
|
||||
- Merge commit: `2f7b8094 merge: embedded no-workdir worker policy`。
|
||||
- Final validation passed:
|
||||
- `rg 'worker\\.cwd\\(' . || true`
|
||||
- `git diff --check`
|
||||
- `cargo test -p worker-runtime --features ws-server,fs-store`
|
||||
- `cargo test -p yoi-workspace-server --lib`
|
||||
- `cargo check -p yoi`
|
||||
- `cd web/workspace && deno task check`
|
||||
- `cd web/workspace && deno task test`
|
||||
- `yoi ticket doctor`
|
||||
- `nix build .#yoi --no-link`
|
||||
- Validation log: `/run/user/1000/yoi/yoi-orchestrator/bash-output/embedded-no-workdir-final-validation-1783728763.txt`
|
||||
|
|
@ -227,3 +227,84 @@ Blockers: none。
|
|||
Non-blocking notes: none。
|
||||
|
||||
---
|
||||
|
||||
<!-- event: implementation_report author: orchestrator at: 2026-07-11T00:13:31Z -->
|
||||
|
||||
## Implementation report
|
||||
|
||||
Merge / final validation report:
|
||||
|
||||
- Reviewer approved the implementation with no blockers。
|
||||
- Merged branch `work/00001KX6WVNPD-embedded-no-workdir-policy` into orchestration branch with merge commit `2f7b8094 merge: embedded no-workdir worker policy`。
|
||||
- Final validation was rerun in `/home/hare/Projects/yoi/.worktree/orchestration` after merge。
|
||||
|
||||
Validation passed:
|
||||
- `rg 'worker\\.cwd\\(' . || true`: no matches。
|
||||
- `git diff --check`
|
||||
- `cargo test -p worker-runtime --features ws-server,fs-store`
|
||||
- `cargo test -p yoi-workspace-server --lib`
|
||||
- `cargo check -p yoi`
|
||||
- `cd web/workspace && deno task check`
|
||||
- `cd web/workspace && deno task test`
|
||||
- `yoi ticket doctor`
|
||||
- `nix build .#yoi --no-link`
|
||||
|
||||
Validation log:
|
||||
- `/run/user/1000/yoi/yoi-orchestrator/bash-output/embedded-no-workdir-final-validation-1783728763.txt`
|
||||
|
||||
Reviewed/merged implementation commit:
|
||||
- `10267869 feat: enforce embedded no-workdir worker policy`
|
||||
|
||||
---
|
||||
|
||||
<!-- event: state_changed author: orchestrator at: 2026-07-11T00:13:37Z from: inprogress to: done reason: implementation_validated field: state -->
|
||||
|
||||
## State changed
|
||||
|
||||
Implementation was reviewed, merged into orchestration branch, and final validation passed. Moving to done before closure.
|
||||
|
||||
---
|
||||
|
||||
<!-- event: state_changed author: hare at: 2026-07-11T00:13:51Z from: done to: closed reason: closed field: state -->
|
||||
|
||||
## State changed
|
||||
|
||||
Ticket を closed にしました。
|
||||
|
||||
|
||||
---
|
||||
|
||||
<!-- event: close author: hare at: 2026-07-11T00:13:51Z status: closed -->
|
||||
|
||||
## 完了
|
||||
|
||||
Embedded no-workdir Worker authority policy を実装・レビュー・merge・検証した。
|
||||
|
||||
実装内容:
|
||||
- Runtime launch metadata に `working_directory_required` を追加し、embedded Runtime のみ workdir optional として扱うようにした。
|
||||
- Workspace/API Worker create path で、embedded Runtime では no-workdir Worker creation を許可し、non-embedded Runtime では no-workdir creation を typed diagnostic で拒否するようにした。
|
||||
- Embedded no-workdir launch は Runtime へ working directory なしで渡され、merged `WorkerFilesystemAuthority` 境界により `WorkerFilesystemAuthority::None` になる。
|
||||
- Workdir-present embedded Worker は materialized binding を `WorkerFilesystemAuthority::Local` として保持する既存 behavior を維持。
|
||||
- Browser Worker creation UI で embedded Runtime の場合だけ “No working directory — guidance-only Worker; filesystem tools are disabled” を選べるようにした。
|
||||
- No-workdir launch では relative cwd input を隠し、filesystem tools / Bash が disabled であることを明示。
|
||||
- Tests で launch metadata、non-embedded no-workdir rejection、embedded no-workdir request construction、および existing runtime tests による no-workdir tool omission/no cwd fallback を確認。
|
||||
|
||||
Review:
|
||||
- Reviewer approved with no blockers。
|
||||
- Evidence included API optionality bounds, non-embedded rejection, authority construction path, no filesystem/Bash tool surface coverage, workdir-present behavior, and Browser labeling。
|
||||
|
||||
Merge / validation:
|
||||
- Merge commit: `2f7b8094 merge: embedded no-workdir worker policy`。
|
||||
- Final validation passed:
|
||||
- `rg 'worker\\.cwd\\(' . || true`
|
||||
- `git diff --check`
|
||||
- `cargo test -p worker-runtime --features ws-server,fs-store`
|
||||
- `cargo test -p yoi-workspace-server --lib`
|
||||
- `cargo check -p yoi`
|
||||
- `cd web/workspace && deno task check`
|
||||
- `cd web/workspace && deno task test`
|
||||
- `yoi ticket doctor`
|
||||
- `nix build .#yoi --no-link`
|
||||
- Validation log: `/run/user/1000/yoi/yoi-orchestrator/bash-output/embedded-no-workdir-final-validation-1783728763.txt`
|
||||
|
||||
---
|
||||
|
|
|
|||
Loading…
Reference in New Issue
Block a user