Hare/yoi
1
1
Fork 0
Code Actions Packages Releases Activity

review: approve memory prompt guidance

Browse Source
This commit is contained in:
Keisuke Hirata 2026-06-01 07:51:36 +09:00
parent ccddab6425
commit 62d88d919d
No known key found for this signature in database
3 changed files with 63 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

27
work-items/open/20260531-223506-memory-prompt-conditional-lookup/artifacts/review-20260531-memory-prompt.md Normal file
View File

@ -0,0 +1,27 @@
# Review: memory prompt conditional lookup
Implementation reviewed on branch `memory-prompt-conditional-lookup`.
Reviewed commits:
- `03256db memory: gate prompt guidance`
- `3a0c8e1 memory: clean prompt helper warning`
Verdict: approve.
Summary:
- Prompt rendering now gates normal memory/knowledge guidance according to available tool capabilities.
- Memory-disabled prompt rendering does not advertise memory tools.
- Partial-capability rendering avoids naming unavailable memory or knowledge tools.
- Normal Pod guidance now encourages somewhat more proactive small targeted lookup when prior decisions, rationale, durable preferences, tickets, policy, workflow, or project history may affect the response or action.
- Existing cautions remain: memory can be stale; current authoritative state lives in user instructions, repository files, tickets, git history, and session logs; memory should not be queried mechanically every turn; mutation tools are restricted.
- Internal memory extraction/consolidation worker prompts remain isolated from normal Pod guidance.
Review notes:
- Initial review requested one blocker fix because `cargo test -p pod prompt::` emitted a new unused `append_trailing_section` warning.
- Follow-up commit `3a0c8e1` removed the warning-producing helper path and adjusted partial-capability wording.
- Final focused review approved the follow-up. `cargo test -p pod prompt::` passed with `53 passed; 0 failed`; only an existing unrelated `llm-worker` dead-code warning remains.
Merge readiness: ready to merge.

2
work-items/open/20260531-223506-memory-prompt-conditional-lookup/item.md
View File

@ -7,7 +7,7 @@ kind: task
priority: P2
labels: [memory, prompts, tools]
created_at: 2026-05-31T22:35:06Z
updated_at: 2026-05-31T22:35:06Z
updated_at: 2026-05-31T22:51:36Z
assignee: null
legacy_ticket: null
---

35
work-items/open/20260531-223506-memory-prompt-conditional-lookup/thread.md
View File

@ -4,4 +4,39 @@
Created by tickets.sh create.
---
<!-- event: review author: hare at: 2026-05-31T22:51:36Z status: approve -->
## Review: approve
# Review: memory prompt conditional lookup
Implementation reviewed on branch `memory-prompt-conditional-lookup`.
Reviewed commits:
- `03256db memory: gate prompt guidance`
- `3a0c8e1 memory: clean prompt helper warning`
Verdict: approve.
Summary:
- Prompt rendering now gates normal memory/knowledge guidance according to available tool capabilities.
- Memory-disabled prompt rendering does not advertise memory tools.
- Partial-capability rendering avoids naming unavailable memory or knowledge tools.
- Normal Pod guidance now encourages somewhat more proactive small targeted lookup when prior decisions, rationale, durable preferences, tickets, policy, workflow, or project history may affect the response or action.
- Existing cautions remain: memory can be stale; current authoritative state lives in user instructions, repository files, tickets, git history, and session logs; memory should not be queried mechanically every turn; mutation tools are restricted.
- Internal memory extraction/consolidation worker prompts remain isolated from normal Pod guidance.
Review notes:
- Initial review requested one blocker fix because `cargo test -p pod prompt::` emitted a new unused `append_trailing_section` warning.
- Follow-up commit `3a0c8e1` removed the warning-producing helper path and adjusted partial-capability wording.
- Final focused review approved the follow-up. `cargo test -p pod prompt::` passed with `53 passed; 0 failed`; only an existing unrelated `llm-worker` dead-code warning remains.
Merge readiness: ready to merge.
---