ticket: close workflow removal work
This commit is contained in:
parent
2f260029d4
commit
66b3a38f7d
|
|
@ -1,8 +1,8 @@
|
||||||
---
|
---
|
||||||
title: 'Remove workflow tracking and workflow resources'
|
title: 'Remove workflow tracking and workflow resources'
|
||||||
state: 'inprogress'
|
state: 'closed'
|
||||||
created_at: '2026-07-15T19:02:13Z'
|
created_at: '2026-07-15T19:02:13Z'
|
||||||
updated_at: '2026-07-15T21:35:26Z'
|
updated_at: '2026-07-15T21:39:23Z'
|
||||||
assignee: null
|
assignee: null
|
||||||
queued_by: 'workspace-panel'
|
queued_by: 'workspace-panel'
|
||||||
queued_at: '2026-07-15T19:54:36Z'
|
queued_at: '2026-07-15T19:54:36Z'
|
||||||
|
|
|
||||||
41
.yoi/tickets/00001KXKJGYGD/resolution.md
Normal file
41
.yoi/tickets/00001KXKJGYGD/resolution.md
Normal file
|
|
@ -0,0 +1,41 @@
|
||||||
|
Workflow tracking / Workflow resource / Workflow invocation machinery を削除・レビュー・merge・検証した。
|
||||||
|
|
||||||
|
実装内容:
|
||||||
|
- model-visible `ActiveWorkflowList`, `ActiveWorkflowComplete`, `ActiveWorkflowCancel` tools を削除。
|
||||||
|
- Worker active-workflow durable state、extension snapshotting、compaction/rehydration handling、prompt re-injection paths を削除。
|
||||||
|
- Workflow registry/resource loading と `/workflow-slug` invocation behavior を削除。
|
||||||
|
- `crates/workflow` crate と tracked `resources/workflows/*` resources を削除。
|
||||||
|
- `WorkflowInvoke` を protocol / TUI / web generated protocol surfaces から削除。
|
||||||
|
- slash workflow completion behavior と related web console completion surface を削除。
|
||||||
|
- `.yoi/workflow` memory/workspace authority と workflow usage-source handling を削除。
|
||||||
|
- resident workflow / workflow invocation wording を prompts/docs/config から削除。
|
||||||
|
- old persisted `kind: "workflow"` `SystemItem`s は `LegacyIgnored` として bounded diagnostic/ignore behavior のみにした。
|
||||||
|
- first-class Skills support はこの Ticket では実装していない。
|
||||||
|
|
||||||
|
Review:
|
||||||
|
- 初回 review は web/generated `workflow_invoke` surface、stale workflow role/test、docs wording で `request_changes`。
|
||||||
|
- 2回目 review は slash workflow completion path で `request_changes`。
|
||||||
|
- 3回目 review は TUI test fixture が legacy workflow SystemItem を active snapshot carrier として使っている blocker で `request_changes`。
|
||||||
|
- `bc48094d fix: update workflow-free tui tests` 後の focused re-review は `approve`。
|
||||||
|
|
||||||
|
Merge / validation:
|
||||||
|
- Merge commit: `2f260029 merge: remove workflow machinery`。
|
||||||
|
- Final validation passed:
|
||||||
|
- `rg "ActiveWorkflow|active_workflow|Active workflow" . || true`
|
||||||
|
- `rg "resources/workflows|\\.yoi/workflow|workflow invocation|Resident workflows|workflow_invoke" . || true`
|
||||||
|
- `git diff --check`
|
||||||
|
- `cargo test -p ticket`
|
||||||
|
- `cargo test -p session-store --lib --tests`
|
||||||
|
- `cargo test -p worker --lib --tests`
|
||||||
|
- `cargo test -p tui --lib --tests`
|
||||||
|
- `cargo test -p yoi --tests`
|
||||||
|
- `cd web/workspace && deno task check`
|
||||||
|
- `cd web/workspace && deno task test`
|
||||||
|
- `cargo check -p yoi`
|
||||||
|
- `yoi ticket doctor`
|
||||||
|
- `nix build .#yoi --no-link`
|
||||||
|
- Validation log: `/run/user/1000/yoi/yoi-orchestrator/bash-output/workflow-removal-final-validation-1784151359.txt`
|
||||||
|
|
||||||
|
Cleanup:
|
||||||
|
- Implementation worktree/branch cleanup will be performed after close commit。
|
||||||
|
- Per user instruction, `StopPod` is not used。
|
||||||
|
|
@ -376,3 +376,111 @@ Evidence:
|
||||||
Blockers: none。
|
Blockers: none。
|
||||||
|
|
||||||
---
|
---
|
||||||
|
|
||||||
|
<!-- event: implementation_report author: orchestrator at: 2026-07-15T21:39:00Z -->
|
||||||
|
|
||||||
|
## Implementation report
|
||||||
|
|
||||||
|
Merge / final validation report:
|
||||||
|
|
||||||
|
- Reviewer approved the implementation after final TUI workflow-free snapshot test fix。
|
||||||
|
- Merged branch `work/00001KXKJGYGD-remove-workflow-tracking` into orchestration branch with merge commit `2f260029 merge: remove workflow machinery`。
|
||||||
|
- Ticket record conflicts from child branch were resolved in favor of Orchestrator-authoritative Ticket records; implementation code/resource changes were merged。
|
||||||
|
- Final validation was rerun in `/home/hare/Projects/yoi/.worktree/orchestration` after merge。
|
||||||
|
|
||||||
|
Validation passed:
|
||||||
|
- `rg "ActiveWorkflow|active_workflow|Active workflow" . || true`
|
||||||
|
- `rg "resources/workflows|\\.yoi/workflow|workflow invocation|Resident workflows|workflow_invoke" . || true`
|
||||||
|
- `git diff --check`
|
||||||
|
- `cargo test -p ticket`
|
||||||
|
- `cargo test -p session-store --lib --tests`
|
||||||
|
- `cargo test -p worker --lib --tests`
|
||||||
|
- `cargo test -p tui --lib --tests`
|
||||||
|
- `cargo test -p yoi --tests`
|
||||||
|
- `cd web/workspace && deno task check`
|
||||||
|
- `cd web/workspace && deno task test`
|
||||||
|
- `cargo check -p yoi`
|
||||||
|
- `yoi ticket doctor`
|
||||||
|
- `nix build .#yoi --no-link`
|
||||||
|
|
||||||
|
Validation log:
|
||||||
|
- `/run/user/1000/yoi/yoi-orchestrator/bash-output/workflow-removal-final-validation-1784151359.txt`
|
||||||
|
|
||||||
|
Reviewed/merged implementation commits:
|
||||||
|
- `d801b269 refactor: remove workflow machinery`
|
||||||
|
- `d30dca2d fix: remove remaining workflow invoke surfaces`
|
||||||
|
- `0b56052a fix: remove workflow completion surface`
|
||||||
|
- `bc48094d fix: update workflow-free tui tests`
|
||||||
|
|
||||||
|
Notes:
|
||||||
|
- ActiveWorkflow tools/state and Workflow resource/invocation/completion surfaces were removed。
|
||||||
|
- Legacy persisted `kind: "workflow"` SystemItems are bounded to ignored/diagnostic behavior only。
|
||||||
|
- Broad first-class Skills support was intentionally not implemented in this Ticket。
|
||||||
|
- Per user instruction, no `StopPod` cleanup was performed。
|
||||||
|
|
||||||
|
---
|
||||||
|
|
||||||
|
<!-- event: state_changed author: orchestrator at: 2026-07-15T21:39:07Z from: inprogress to: done reason: implementation_validated field: state -->
|
||||||
|
|
||||||
|
## State changed
|
||||||
|
|
||||||
|
Implementation was reviewed, merged into orchestration branch, and final validation passed. Moving to done before closure.
|
||||||
|
|
||||||
|
---
|
||||||
|
|
||||||
|
<!-- event: state_changed author: hare at: 2026-07-15T21:39:23Z from: done to: closed reason: closed field: state -->
|
||||||
|
|
||||||
|
## State changed
|
||||||
|
|
||||||
|
Ticket を closed にしました。
|
||||||
|
|
||||||
|
|
||||||
|
---
|
||||||
|
|
||||||
|
<!-- event: close author: hare at: 2026-07-15T21:39:23Z status: closed -->
|
||||||
|
|
||||||
|
## 完了
|
||||||
|
|
||||||
|
Workflow tracking / Workflow resource / Workflow invocation machinery を削除・レビュー・merge・検証した。
|
||||||
|
|
||||||
|
実装内容:
|
||||||
|
- model-visible `ActiveWorkflowList`, `ActiveWorkflowComplete`, `ActiveWorkflowCancel` tools を削除。
|
||||||
|
- Worker active-workflow durable state、extension snapshotting、compaction/rehydration handling、prompt re-injection paths を削除。
|
||||||
|
- Workflow registry/resource loading と `/workflow-slug` invocation behavior を削除。
|
||||||
|
- `crates/workflow` crate と tracked `resources/workflows/*` resources を削除。
|
||||||
|
- `WorkflowInvoke` を protocol / TUI / web generated protocol surfaces から削除。
|
||||||
|
- slash workflow completion behavior と related web console completion surface を削除。
|
||||||
|
- `.yoi/workflow` memory/workspace authority と workflow usage-source handling を削除。
|
||||||
|
- resident workflow / workflow invocation wording を prompts/docs/config から削除。
|
||||||
|
- old persisted `kind: "workflow"` `SystemItem`s は `LegacyIgnored` として bounded diagnostic/ignore behavior のみにした。
|
||||||
|
- first-class Skills support はこの Ticket では実装していない。
|
||||||
|
|
||||||
|
Review:
|
||||||
|
- 初回 review は web/generated `workflow_invoke` surface、stale workflow role/test、docs wording で `request_changes`。
|
||||||
|
- 2回目 review は slash workflow completion path で `request_changes`。
|
||||||
|
- 3回目 review は TUI test fixture が legacy workflow SystemItem を active snapshot carrier として使っている blocker で `request_changes`。
|
||||||
|
- `bc48094d fix: update workflow-free tui tests` 後の focused re-review は `approve`。
|
||||||
|
|
||||||
|
Merge / validation:
|
||||||
|
- Merge commit: `2f260029 merge: remove workflow machinery`。
|
||||||
|
- Final validation passed:
|
||||||
|
- `rg "ActiveWorkflow|active_workflow|Active workflow" . || true`
|
||||||
|
- `rg "resources/workflows|\\.yoi/workflow|workflow invocation|Resident workflows|workflow_invoke" . || true`
|
||||||
|
- `git diff --check`
|
||||||
|
- `cargo test -p ticket`
|
||||||
|
- `cargo test -p session-store --lib --tests`
|
||||||
|
- `cargo test -p worker --lib --tests`
|
||||||
|
- `cargo test -p tui --lib --tests`
|
||||||
|
- `cargo test -p yoi --tests`
|
||||||
|
- `cd web/workspace && deno task check`
|
||||||
|
- `cd web/workspace && deno task test`
|
||||||
|
- `cargo check -p yoi`
|
||||||
|
- `yoi ticket doctor`
|
||||||
|
- `nix build .#yoi --no-link`
|
||||||
|
- Validation log: `/run/user/1000/yoi/yoi-orchestrator/bash-output/workflow-removal-final-validation-1784151359.txt`
|
||||||
|
|
||||||
|
Cleanup:
|
||||||
|
- Implementation worktree/branch cleanup will be performed after close commit。
|
||||||
|
- Per user instruction, `StopPod` is not used。
|
||||||
|
|
||||||
|
---
|
||||||
|
|
|
||||||
Loading…
Reference in New Issue
Block a user