merge: sync orchestration before queue 00001KXKP2A71

This commit is contained in:
Keisuke Hirata 2026-07-16 05:27:02 +09:00
commit 74f02a0e58
No known key found for this signature in database
3 changed files with 95 additions and 2 deletions

View File

@ -0,0 +1 @@
{"id":"orch-plan-20260715-195505-1","ticket_id":"00001KXKJGYGD","kind":"accepted_plan","accepted_plan":{"summary":"Remove legacy Workflow tracking/resource/invocation machinery only. Delete ActiveWorkflow model-visible tools and durable active workflow state, remove workflow resource discovery and `/workflow-slug` invocation, delete or retire workflow crate/resources/tests, and clean prompt/docs wording. Leave Skills support to dependent follow-up Ticket `00001KXKMX0QM` and keep external state control in typed feature/tool surfaces.","branch":"work/00001KXKJGYGD-remove-workflow-tracking","worktree":"/home/hare/Projects/yoi/.worktree/00001KXKJGYGD-remove-workflow-tracking","role_plan":"Orchestrator accepts queued Ticket after inspecting Ticket/relation/plan/workspace state. Use sibling Coder for implementation in a dedicated worktree, then sibling Reviewer for read-only review. Orchestrator retains merge/final-validation/close/worktree cleanup authority. Do not call StopPod unless explicitly instructed."},"author":"orchestrator","at":"2026-07-15T19:55:05Z"}

View File

@ -1,8 +1,8 @@
---
title: 'Remove workflow tracking and workflow resources'
state: 'queued'
state: 'inprogress'
created_at: '2026-07-15T19:02:13Z'
updated_at: '2026-07-15T19:54:36Z'
updated_at: '2026-07-15T19:55:42Z'
assignee: null
queued_by: 'workspace-panel'
queued_at: '2026-07-15T19:54:36Z'

View File

@ -30,4 +30,96 @@ Marked ready by `yoi ticket state`.
Ticket を `workspace-panel` が queued にしました。
---
<!-- event: decision author: orchestrator at: 2026-07-15T19:55:37Z -->
## Decision
Routing decision: implementation_ready
Reason:
- Ticket は前回の broad Skills support scope から修正され、今回は Workflow tracking / Workflow resource / Workflow invocation path の削除に範囲が限定されている。
- Skills support は incoming dependent Ticket `00001KXKMX0QM``depends_on` として後続に分離されており、この Ticket 自身の blocker ではない。
- `TicketRelationQuery(00001KXKJGYGD)` は incoming dependency のみで、outgoing blocker はない。
- `TicketOrchestrationPlanQuery(00001KXKJGYGD)` は事前 record なし。今回 accepted plan を記録した。
- `TicketList(inprogress)` は 0 件。
- Orchestrator worktree `/home/hare/Projects/yoi/.worktree/orchestration` は clean で、既存 implementation worktree/branch は見当たらない。
Evidence checked:
- Ticket body / thread / relations / artifacts。
- `TicketRelationQuery`, `TicketOrchestrationPlanQuery`, `TicketList(inprogress)`
- Orchestrator worktree / branch / worktree state。
- Previous broad scope was corrected: current title is `Remove workflow tracking and workflow resources` and body says Agent Skills is separate follow-up。
IntentPacket:
Intent:
- Legacy Workflow tracking/resource/invocation machinery を削除する。
- ActiveWorkflow obligation state と model-visible ActiveWorkflow tools を取り除く。
- Workflow resource authority と `/workflow-slug` invocation を廃止し、prompt/docs から Workflow 固有 wording を削除する。
Binding decisions / invariants:
- この Ticket では first-class Skills support を実装しない。Skills は dependent follow-up Ticket `00001KXKMX0QM` の責務。
- Workflow を scheduler / state machine / script / external-state automation layer として残さない。
- `ActiveWorkflowList` / `ActiveWorkflowComplete` / `ActiveWorkflowCancel` は model-visible tool schema から削除する。
- Worker durable state / snapshot / compaction / rehydration / system-item extension から active workflow snapshot / obligation を削除する。
- `resources/workflows` / `.yoi/workflow` は長期 authority として扱わない。
- Ticket / Worker / workdir / queue などの外部状態制御は typed feature/tool surface に残す。
- 既存 session に ActiveWorkflow storage がある場合は、初期実装では ignore / drop / diagnostic の bounded 方針にし、過剰な migration layer を作らない。
Requirements / acceptance criteria:
- ActiveWorkflow tools が schema から消えている。
- active workflow state が Worker snapshot / compaction / rehydration に残らない。
- Workflow resource discovery / invocation path が削除されている。
- Workflow prompt wording / resident workflow advertisement が消えている。
- Workflow 関連 crate/resource/API/test が削除または不要な互換なしに整理されている。
- External state control は feature/tool surface に残る。
- affected tests と `nix build .#yoi` が通る。
Implementation latitude:
- 既存 Workflow crate/resource を削除するか、必要最小限の型削除/rename にするかは dependency graph に応じて選んでよい。
- Persisted old ActiveWorkflow state は bounded compatibility として無視/drop/diagnostic のどれかを選び、設計が大きくなる場合は escalation。
- Prompt/docs cleanup の具体的な文言は Workflow authority を広告しない範囲で local tactic とする。
Escalate if:
- ActiveWorkflow state removal が destructive session migration や broad compatibility layer を必要とする場合。
- Skills support を同時実装しないと build/API が成立しない場合。
- `/slug` など user-facing invocation の代替設計をこの Ticket 内で固定する必要が出た場合。
- Workflow に external-state authority を残さないと既存 feature が動かない場合。
Validation:
- `rg "ActiveWorkflow|active_workflow|Active workflow"` with remaining hits explained or removed。
- `rg "resources/workflows|\.yoi/workflow|workflow invocation|Resident workflows"` with remaining hits explained or removed。
- `git diff --check`
- affected crate tests such as `cargo test -p worker --lib --tests`, `cargo test -p session-store --lib --tests`, `cargo test -p yoi --tests` if CLI/input touched, and workflow crate tests if crate remains。
- `cargo check -p yoi`
- `yoi ticket doctor`
- `nix build .#yoi --no-link`
Current code map / likely touch points:
- `crates/worker/src/active_workflow.rs`, `crates/worker/src/workflow`, `crates/worker/src/controller.rs`, `crates/worker/src/worker.rs`, `crates/worker/src/prompt/*`
- `crates/workflow/*`, `resources/workflows/*`, `resources/prompts/*`
- `crates/protocol/src/lib.rs`, `crates/session-store/src/system_item.rs`
- CLI/TUI input path for `/slug` workflow invocation if present。
- docs mentioning Workflow / ActiveWorkflow / resident workflows。
Critical risks / reviewer focus:
- ActiveWorkflow tools/state still present under renamed or hidden paths。
- Workflow resource discovery/invocation surviving as hidden active path。
- Prompt/docs still advertising Workflow obligations or resident workflows。
- Accidentally implementing broad Skills support in this Ticket instead of leaving it to dependent follow-up。
- Ticket queue / Worker spawn / workdir management logic being moved into Workflow/Skill rather than remaining typed tools/features。
Next action:
- Record `queued -> inprogress`, create dedicated implementation worktree, and route to sibling Coder Pod。
---
<!-- event: state_changed author: orchestrator at: 2026-07-15T19:55:42Z from: queued to: inprogress reason: accepted_for_implementation field: state -->
## State changed
Dashboard queue authorization was inspected, no blockers were found, and an accepted plan was recorded. Moving queued Ticket to inprogress before creating worktree or spawning role Pods.
---