ticket: approve orchestrator diagnostic persistence

This commit is contained in:
Keisuke Hirata 2026-06-07 19:15:40 +09:00
parent 817f53bf77
commit 7511cd4ed4
No known key found for this signature in database
2 changed files with 29 additions and 1 deletions

View File

@ -8,7 +8,7 @@ priority: P2
labels: [tui, panel, orchestrator, diagnostic]
workflow_state: intake
created_at: 2026-06-07T09:51:42Z
updated_at: 2026-06-07T10:10:37Z
updated_at: 2026-06-07T10:15:40Z
assignee: null
legacy_ticket: null
---

View File

@ -122,4 +122,32 @@ Caveat:
External review will be delegated before merge.
---
<!-- event: review author: hare at: 2026-06-07T10:15:40Z status: approve -->
## Review: approve
Approved by `orchestrator-diagnostic-reviewer-20260607`.
No blocking findings. The implementation matches the ticket intent and is merge-ready.
Evidence:
- `Ensure` vs `Observe` is preserved. Initial load uses `Ensure`; refresh paths use `Observe`; observe does not restore/spawn.
- Prior actionable failure is retained across plain observe `missing` / `stopped` for the same Pod name.
- Plain missing without prior failure remains plain missing.
- Stale failures are cleared when Orchestrator becomes `live`, `spawned`, or `restored`.
- New `Unavailable` diagnostics supersede older ones.
- Ticket actionbar gating remains separate; lifecycle diagnostics remain in `panel.header.diagnostics`.
- Worktree is clean and merge-tree against current `develop` reports no conflict.
Reviewer validation:
- `CARGO_TARGET_DIR=/tmp/yoi-review-target cargo test -p tui multi_orchestrator --lib`
- `CARGO_TARGET_DIR=/tmp/yoi-review-target cargo test -p tui --lib`
- `cargo fmt --check`
- `git diff --check develop...HEAD`
- `nix build .#yoi --no-link`
- `CARGO_TARGET_DIR=/tmp/yoi-review-target cargo run -p yoi -- ticket doctor`
---