Hare/yoi
1
1
Fork 0
Code Actions Packages Releases Activity

ticket: record spawnpod cwd re-review

Browse Source
This commit is contained in:
Keisuke Hirata 2026-06-08 17:08:21 +09:00
parent b1346eeea3
commit 885e493ba2
No known key found for this signature in database
2 changed files with 34 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
.yoi/tickets/open/20260608-011036-allow-spawnpod-child-workspace-cwd/item.md
View File

@ -8,7 +8,7 @@ priority: 'P2'
labels: ['pod', 'spawn', 'cwd', 'worktree', 'orchestration'] labels: ['pod', 'spawn', 'cwd', 'worktree', 'orchestration']
workflow_state: 'inprogress' workflow_state: 'inprogress'
created_at: '2026-06-08T01:10:36Z' created_at: '2026-06-08T01:10:36Z'
updated_at: '2026-06-08T07:32:03Z' updated_at: '2026-06-08T08:08:10Z'
assignee: null assignee: null
legacy_ticket: null legacy_ticket: null
queued_by: 'workspace-panel' queued_by: 'workspace-panel'

33
.yoi/tickets/open/20260608-011036-allow-spawnpod-child-workspace-cwd/thread.md
View File

@ -268,3 +268,36 @@ Pending:
- No merge, close, final approval, or cleanup has occurred. - No merge, close, final approval, or cleanup has occurred.
--- ---
<!-- event: implementation_report author: orchestrator at: 2026-06-08T08:08:10Z -->
## Implementation report
Coder fix-loop completed and reviewer re-review delegated.
Coder follow-up:
- Commit: `248744f fix: keep SpawnPod cwd separate`
- Worktree: clean on branch `allow-spawnpod-child-workspace-cwd`.
- Fixes claimed:
- `SpawnPod.cwd` is passed as hidden `--tool-cwd`, while child runtime still receives inherited `--workspace <parent workspace root>`.
- Child process launch current_dir is workspace root, not tool cwd, preventing runtime context from being derived from the tool cwd.
- Adopted child startup separates runtime workspace context from tool cwd.
- `Pod` stores `workspace_root` and `pwd` separately; memory/Ticket/workflow/Profile context uses `workspace_root`, while Bash/tools/ScopedFs use `pwd`.
- Ticket role coder guidance no longer assumes mandatory `cd <worktree>` when SpawnPod cwd is available.
- Added tests proving runtime workspace and tool cwd stay separate, omitted cwd preserves prior pwd behavior, and memory layout derives from workspace root rather than tool cwd.
Coder validation reported:
- `cargo test -p pod spawn_pod`
- `cargo fmt --check`
- `git diff --check`
- `cargo run -q -p yoi -- ticket doctor`
- `nix build .#yoi`
Action taken:
- Sent updated commits and prior blocker checklist to `reviewer-spawnpod-child-cwd` for read-only re-review.
Pending:
- Await reviewer verdict before merge-ready dossier / merge-completion.
- No merge, close, final approval, or cleanup has occurred.
---