Hare/yoi
1
1
Fork 0
Code Actions Packages Releases Activity

ticket: approve agent skills implementation

Browse Source
This commit is contained in:
Keisuke Hirata 2026-07-16 09:11:00 +09:00
parent 3d5c24cc4c
commit 888ec11455
No known key found for this signature in database
2 changed files with 33 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
.yoi/tickets/00001KXKMX0QM/item.md
View File

@ -2,7 +2,7 @@
title: 'Implement Agent Skills support'
state: 'inprogress'
created_at: '2026-07-15T19:43:46Z'
updated_at: '2026-07-16T00:07:38Z'
updated_at: '2026-07-16T00:10:51Z'
assignee: null
queued_by: 'workspace-panel'
queued_at: '2026-07-15T21:26:15Z'

32
.yoi/tickets/00001KXKMX0QM/thread.md
View File

@ -380,3 +380,35 @@ Coder-reported validation passed:
Web/API types were not changed in this follow-up, so web checks were not rerun。
---
<!-- event: review author: reviewer at: 2026-07-16T00:10:51Z status: approve -->
## Review: approve
Focused re-review result: approve
Evidence:
- Previous blockers fixed:
- Skill frontmatter is now parsed through a raw YAML value。
- Unsupported/workflow-shaped keys are diagnosed as errors (`crates/workspace-server/src/skills.rs:290-302`, `457-528`)。
- Error diagnostics prevent catalog/detail/activation (`skills.rs:393-398`)。
- Regression coverage exists for `model_invokation`, `user_invocable`, `graph`, `invocation`, and generic unknown fields (`skills.rs:687-743`)。
- Worker activation/history is covered by an HTTP-backed activation test verifying backend fetch, history append, and committed `SystemItem::SkillActivation` body equality (`crates/worker/src/worker.rs:5971-6065`)。
- Focused validation passed:
- `cargo test -p yoi-workspace-server skills --lib`
- `cargo test -p worker skill --lib`
- `git diff --check`
- Worktree remained clean。
- Rechecked acceptance focus:
- Workspace backend remains the Skill catalog/detail/lint/activation authority。
- builtin/workspace override/provenance/progressive disclosure behavior remains covered。
- `allowed-tools` / scripts remain diagnostic/non-authoritative。
- no raw-path resource leakage was introduced。
- `rg` for removed Workflow/Knowledge surfaces only finds new rejection logic/tests。
Blockers: none。
Non-blocking note:
- detail/activation for invalid Skills still surface as not-found while catalog/lint carries diagnostics; acceptable for this initial authority model。
---