Hare/yoi
1
1
Fork 0
Code Actions Packages Releases Activity

review: provider trace spawn preservation

Browse Source
This commit is contained in:
Keisuke Hirata 2026-05-30 09:37:40 +09:00
parent 31bd50137d
commit 88e43f7402
No known key found for this signature in database
1 changed files with 22 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

22
work-items/open/20260529-235408-provider-stream-trace-profile-spawn/thread.md
View File

@ -28,4 +28,26 @@ Validation target:
- `./tickets.sh doctor` and `git diff --check`.
---
<!-- event: review author: hare at: 2026-05-30T00:37:40Z status: approve -->
## Review: approve
Approve.
The change narrowly fixes the hidden `--spawn-config-json` loss point by carrying the already-resolved spawner `manifest.session.record_event_trace` into `SpawnPodTool` and serializing `[session].record_event_trace = true` only when the parent has opted in. It also adds focused coverage for profile artifact preservation, spawned config preservation, disabled omission, and clarifies trace sidecar semantics as normalized provider/lifecycle diagnostics rather than byte-for-byte raw SSE.
Blocker findings: none.
Validation re-run by reviewer:
- `cargo test -p manifest profile_artifact_preserves_session_record_event_trace` — passed.
- `cargo test -p pod spawn_config` — passed, 4 tests.
- `./tickets.sh doctor` — passed.
- `git diff --check 23f234d^ 23f234d` — passed earlier during inspection.
- Worktree status is clean.
Final verdict: approve.
---