Hare/yoi
1
1
Fork 0
Code Actions Packages Releases Activity

ticket: record runtime workspace review changes

Browse Source
This commit is contained in:
Keisuke Hirata 2026-06-08 10:43:12 +09:00
parent 8587f623f7
commit 9a9c28bcc6
No known key found for this signature in database
2 changed files with 34 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
.yoi/tickets/open/20260608-000047-introduce-runtime-workspace-root-context/item.md
View File

@ -8,7 +8,7 @@ priority: 'P1'
labels: ['workspace', 'pod', 'profile', 'cli', 'panel', 'memory']
workflow_state: 'inprogress'
created_at: '2026-06-08T00:00:47Z'
updated_at: '2026-06-08T01:36:01Z'
updated_at: '2026-06-08T01:43:05Z'
assignee: null
legacy_ticket: null
queued_by: 'workspace-panel'

33
.yoi/tickets/open/20260608-000047-introduce-runtime-workspace-root-context/thread.md
View File

@ -333,3 +333,36 @@ Pending:
- No merge, close, final approval, or cleanup has occurred.
---
<!-- event: implementation_report author: orchestrator at: 2026-06-08T01:43:05Z -->
## Implementation report
Reviewer returned `request_changes`; coder fix-loop delegated.
Reviewer verdict:
- `request_changes`
Blockers:
1. Client spawn emits `--session ... --pod ...`, but `crates/pod/src/entrypoint.rs` still rejects `--session` with `--pod`.
2. Top-level `yoi --session ... --pod ...` is still rejected in `crates/yoi/src/main.rs`, contradicting the binding decision that `--pod` is runtime identity for restore and fresh create.
3. Hidden `--session-pod-name` remains in `crates/pod/src/entrypoint.rs` as a session-specific identity path, preserving the old split this bundle is meant to remove/collapse.
Reviewer evidence:
- Reviewed diff `develop...b6af761`.
- Ran focused tests for client/pod/yoi/tui/manifest/memory paths.
- Focused CLI probes showed both top-level and `yoi pod` restore forms reject `--session ... --pod ...`.
Non-blocking reviewer observations:
- Profile-derived identity removal looked aligned.
- Panel Companion/Orchestrator naming looked aligned.
- Ticket role explicit names looked aligned.
- Memory-root behavior did not appear conflated.
Action taken:
- Sent fix-loop instructions to `coder-runtime-workspace-context-2` with the three blockers and required focused tests.
- Reviewer approval is pending after coder fix report and re-review.
No merge, close, final approval, or cleanup has occurred.
---