fix: runtime retain restore facts when Stop supersedes publication
This commit is contained in:
@@ -86,6 +86,8 @@ pub enum WorkerRestoreState {
|
||||
Accepted,
|
||||
Rejected,
|
||||
RolledBack,
|
||||
/// A later Stop superseded this restore; neither rollback nor prior Accepted is asserted.
|
||||
Superseded,
|
||||
ReconciliationRequired,
|
||||
}
|
||||
|
||||
@@ -1540,13 +1542,24 @@ mod tests {
|
||||
)
|
||||
.unwrap();
|
||||
assert!(request.preparation.is_none());
|
||||
for state in [
|
||||
"accepted",
|
||||
"rejected",
|
||||
"rolled_back",
|
||||
"reconciliation_required",
|
||||
for (state, wire) in [
|
||||
(WorkerRestoreState::Accepted, "accepted"),
|
||||
(WorkerRestoreState::Rejected, "rejected"),
|
||||
(WorkerRestoreState::RolledBack, "rolled_back"),
|
||||
(WorkerRestoreState::Superseded, "superseded"),
|
||||
(
|
||||
WorkerRestoreState::ReconciliationRequired,
|
||||
"reconciliation_required",
|
||||
),
|
||||
] {
|
||||
assert!(serde_json::from_value::<WorkerRestoreState>(serde_json::json!(state)).is_ok());
|
||||
assert_eq!(
|
||||
serde_json::from_value::<WorkerRestoreState>(serde_json::json!(wire)).unwrap(),
|
||||
state
|
||||
);
|
||||
assert_eq!(
|
||||
serde_json::to_value(state).unwrap(),
|
||||
serde_json::json!(wire)
|
||||
);
|
||||
}
|
||||
assert!(
|
||||
serde_json::from_value::<WorkerRestoreState>(serde_json::json!(
|
||||
|
||||
@@ -544,8 +544,9 @@ pub struct WorkspaceWorkerSessionHistoryResponse {
|
||||
/// comparisons do not replace admission checks under the Runtime operation lock; conflicts do
|
||||
/// not trigger automatic token replacement.
|
||||
/// [`WorkerRestoreState`] Accepted means Restore committed, not that the subsequent run succeeded.
|
||||
/// Distinguish read-only preflight Rejected, confirmed RolledBack after side effects, and
|
||||
/// ReconciliationRequired needing settled-state checks. Response loss does not imply rollback.
|
||||
/// Distinguish read-only preflight Rejected, confirmed RolledBack after side effects,
|
||||
/// Superseded by a later Stop, and ReconciliationRequired needing settled-state checks.
|
||||
/// Response loss does not imply rollback.
|
||||
#[api(reqwest, axum, openapi)]
|
||||
pub trait ServerApi {
|
||||
#[get("/health", status = 200, error_status = 400)]
|
||||
@@ -10566,8 +10567,8 @@ pub enum WorkerOperationState {
|
||||
/// Cross-layer outcome of an explicit Worker restore operation.
|
||||
///
|
||||
/// `Rejected` is reserved for read-only preflight failures. Once live restore
|
||||
/// work starts, failure is either a confirmed `RolledBack` operation or a
|
||||
/// `ReconciliationRequired` result whose commit state must be reread/retried.
|
||||
/// work starts, distinguish confirmed `RolledBack`, unresolved
|
||||
/// `ReconciliationRequired`, and a later Stop's `Superseded` outcome.
|
||||
#[derive(Debug, Clone, Copy, Serialize, Deserialize, PartialEq, Eq, JsonSchema)]
|
||||
#[cfg_attr(feature = "typescript", derive(ts_rs::TS))]
|
||||
#[serde(rename_all = "snake_case")]
|
||||
@@ -10575,6 +10576,8 @@ pub enum WorkerRestoreState {
|
||||
Accepted,
|
||||
Rejected,
|
||||
RolledBack,
|
||||
/// A later Stop superseded this restore; neither rollback nor prior Accepted is asserted.
|
||||
Superseded,
|
||||
ReconciliationRequired,
|
||||
}
|
||||
|
||||
@@ -12668,6 +12671,7 @@ mod tests {
|
||||
(WorkerRestoreState::Accepted, "accepted"),
|
||||
(WorkerRestoreState::Rejected, "rejected"),
|
||||
(WorkerRestoreState::RolledBack, "rolled_back"),
|
||||
(WorkerRestoreState::Superseded, "superseded"),
|
||||
(
|
||||
WorkerRestoreState::ReconciliationRequired,
|
||||
"reconciliation_required",
|
||||
|
||||
@@ -1119,39 +1119,45 @@ mod tests {
|
||||
}
|
||||
|
||||
#[tokio::test]
|
||||
async fn rejected_resume_does_not_observe_or_open_retained_state() {
|
||||
let lifecycle = FakeBackendWorkerLifecycle {
|
||||
restore_response: restore_response(BackendWorkerRestoreState::Rejected),
|
||||
observation: session_observation(serde_json::json!({
|
||||
"availability": "unavailable",
|
||||
"reason": "retention_missing",
|
||||
"message": "must not be opened"
|
||||
})),
|
||||
calls: std::sync::Mutex::new(Vec::new()),
|
||||
};
|
||||
let target = client::BackendRuntimeTarget::new(
|
||||
"http://127.0.0.1:3000",
|
||||
"workspace-a",
|
||||
"runtime-a",
|
||||
"worker-a",
|
||||
);
|
||||
async fn settled_nonaccepted_resume_does_not_retry_observe_or_open_retained_state() {
|
||||
for state in [
|
||||
BackendWorkerRestoreState::Rejected,
|
||||
BackendWorkerRestoreState::RolledBack,
|
||||
BackendWorkerRestoreState::Superseded,
|
||||
] {
|
||||
let lifecycle = FakeBackendWorkerLifecycle {
|
||||
restore_response: restore_response(state),
|
||||
observation: session_observation(serde_json::json!({
|
||||
"availability": "unavailable",
|
||||
"reason": "retention_missing",
|
||||
"message": "must not be opened"
|
||||
})),
|
||||
calls: std::sync::Mutex::new(Vec::new()),
|
||||
};
|
||||
let target = client::BackendRuntimeTarget::new(
|
||||
"http://127.0.0.1:3000",
|
||||
"workspace-a",
|
||||
"runtime-a",
|
||||
"worker-a",
|
||||
);
|
||||
|
||||
let error = prepare_selected_worker(
|
||||
&lifecycle,
|
||||
target,
|
||||
BackendWorkerPickerIntent::Resume,
|
||||
Some(client::BackendWorkerRestoreRequest {
|
||||
expected_observation_token: "observed-worker-state".into(),
|
||||
request_id: "resume-operation".into(),
|
||||
}),
|
||||
|_| Ok(false),
|
||||
)
|
||||
.await
|
||||
.unwrap_err()
|
||||
.to_string();
|
||||
let error = prepare_selected_worker(
|
||||
&lifecycle,
|
||||
target,
|
||||
BackendWorkerPickerIntent::Resume,
|
||||
Some(client::BackendWorkerRestoreRequest {
|
||||
expected_observation_token: "observed-worker-state".into(),
|
||||
request_id: "resume-operation".into(),
|
||||
}),
|
||||
|_| panic!("settled nonaccepted restore must not offer recovery retry"),
|
||||
)
|
||||
.await
|
||||
.unwrap_err()
|
||||
.to_string();
|
||||
|
||||
assert!(error.contains("Rejected"));
|
||||
assert_eq!(*lifecycle.calls.lock().unwrap(), ["restore"]);
|
||||
assert!(error.contains(&format!("{state:?}")));
|
||||
assert_eq!(*lifecycle.calls.lock().unwrap(), ["restore"]);
|
||||
}
|
||||
}
|
||||
|
||||
#[test]
|
||||
@@ -1176,6 +1182,7 @@ mod tests {
|
||||
for state in [
|
||||
BackendWorkerRestoreState::Rejected,
|
||||
BackendWorkerRestoreState::RolledBack,
|
||||
BackendWorkerRestoreState::Superseded,
|
||||
BackendWorkerRestoreState::ReconciliationRequired,
|
||||
] {
|
||||
let mut response = restore_response(state);
|
||||
|
||||
@@ -694,6 +694,9 @@ impl runtime_api::RuntimeApi for RuntimeManagementApi {
|
||||
server_api::WorkerRestoreState::RolledBack => {
|
||||
runtime_api::WorkerRestoreState::RolledBack
|
||||
}
|
||||
server_api::WorkerRestoreState::Superseded => {
|
||||
runtime_api::WorkerRestoreState::Superseded
|
||||
}
|
||||
server_api::WorkerRestoreState::ReconciliationRequired => {
|
||||
runtime_api::WorkerRestoreState::ReconciliationRequired
|
||||
}
|
||||
@@ -744,6 +747,9 @@ impl runtime_api::RuntimeApi for RuntimeManagementApi {
|
||||
server_api::WorkerRestoreState::RolledBack => {
|
||||
runtime_api::WorkerRestoreState::RolledBack
|
||||
}
|
||||
server_api::WorkerRestoreState::Superseded => {
|
||||
runtime_api::WorkerRestoreState::Superseded
|
||||
}
|
||||
server_api::WorkerRestoreState::ReconciliationRequired => {
|
||||
runtime_api::WorkerRestoreState::ReconciliationRequired
|
||||
}
|
||||
|
||||
@@ -225,6 +225,28 @@ impl RuntimeWorkerRestoreResult {
|
||||
}
|
||||
}
|
||||
|
||||
fn superseded_by_stop(pending: Option<PendingWorkerRestore>) -> Self {
|
||||
let (code, message) = match pending {
|
||||
Some(pending) if pending.commit == RestoreCommitFact::Committed => (
|
||||
"worker_restore_committed_then_stopped",
|
||||
"Restore committed, then its execution was stopped; prior durable effects are not rolled back",
|
||||
),
|
||||
Some(pending) if pending.commit == RestoreCommitFact::LegacyUnknown => (
|
||||
"worker_restore_unknown_decision_then_stopped",
|
||||
"Restore execution was stopped; its earlier commit decision remains unknown",
|
||||
),
|
||||
Some(pending) if pending.source_repair_possible => (
|
||||
"worker_restore_source_repair_then_stopped",
|
||||
"Uncommitted Restore was stopped; prior source repair effects may remain",
|
||||
),
|
||||
_ => (
|
||||
"worker_restore_superseded_by_stop",
|
||||
"Worker Restore was superseded by confirmed Stop",
|
||||
),
|
||||
};
|
||||
Self::failed(WorkerRestoreState::Superseded, code, message)
|
||||
}
|
||||
|
||||
fn into_legacy_result(self) -> Result<WorkerDetail, RuntimeError> {
|
||||
match (self.state, self.worker) {
|
||||
(WorkerRestoreState::Accepted, Some(worker)) => Ok(worker),
|
||||
@@ -3684,11 +3706,7 @@ impl Runtime {
|
||||
worker.restore_guard.rotate();
|
||||
worker
|
||||
.restore_guard
|
||||
.finish(RuntimeWorkerRestoreResult::failed(
|
||||
WorkerRestoreState::RolledBack,
|
||||
"worker_restore_superseded_by_stop",
|
||||
"Worker Restore was superseded by Stop",
|
||||
));
|
||||
.finish(RuntimeWorkerRestoreResult::superseded_by_stop(None));
|
||||
state.persist_worker_record(&worker)?;
|
||||
let ack = WorkerLifecycleAck {
|
||||
worker_ref: worker_ref.clone(),
|
||||
@@ -4250,6 +4268,7 @@ impl Runtime {
|
||||
WorkerRestoreState::Accepted => return Ok(()),
|
||||
WorkerRestoreState::Rejected
|
||||
| WorkerRestoreState::RolledBack
|
||||
| WorkerRestoreState::Superseded
|
||||
| WorkerRestoreState::ReconciliationRequired => {}
|
||||
}
|
||||
let mut state = self.lock()?;
|
||||
@@ -4363,6 +4382,8 @@ impl Runtime {
|
||||
worker_ref.worker_id
|
||||
)));
|
||||
}
|
||||
let restore_receipt =
|
||||
RuntimeWorkerRestoreResult::superseded_by_stop(candidate.pending_restore);
|
||||
candidate.pending_stop = None;
|
||||
candidate.pending_restore = None;
|
||||
if let Some(context) = candidate.restore_candidate_context.take() {
|
||||
@@ -4373,13 +4394,7 @@ impl Runtime {
|
||||
candidate.worker_state = None;
|
||||
candidate.restore_intent = WorkerRestoreIntent::Explicit;
|
||||
|
||||
candidate
|
||||
.restore_guard
|
||||
.finish(RuntimeWorkerRestoreResult::failed(
|
||||
WorkerRestoreState::RolledBack,
|
||||
"worker_restore_superseded_by_stop",
|
||||
"Worker Restore was superseded by Stop",
|
||||
));
|
||||
candidate.restore_guard.finish(restore_receipt);
|
||||
candidate.internal_workers.clear();
|
||||
state.persist_worker_record(&candidate)?;
|
||||
let ack = WorkerLifecycleAck {
|
||||
@@ -15138,6 +15153,104 @@ mod tests {
|
||||
}
|
||||
}
|
||||
|
||||
#[cfg(feature = "fs-store")]
|
||||
#[test]
|
||||
fn stop_retains_restore_decision_evidence_in_superseded_receipt_across_restart() {
|
||||
// Component scope: real Runtime admission and durable store; execution
|
||||
// is substituted. Controller shutdown races are covered separately.
|
||||
for (commit, repaired, code) in [
|
||||
(
|
||||
RestoreCommitFact::NotCommitted,
|
||||
false,
|
||||
"worker_restore_superseded_by_stop",
|
||||
),
|
||||
(
|
||||
RestoreCommitFact::NotCommitted,
|
||||
true,
|
||||
"worker_restore_source_repair_then_stopped",
|
||||
),
|
||||
(
|
||||
RestoreCommitFact::Committed,
|
||||
false,
|
||||
"worker_restore_committed_then_stopped",
|
||||
),
|
||||
(
|
||||
RestoreCommitFact::LegacyUnknown,
|
||||
true,
|
||||
"worker_restore_unknown_decision_then_stopped",
|
||||
),
|
||||
] {
|
||||
let dir = tempfile::tempdir().unwrap();
|
||||
let options = FsRuntimeStoreOptions::new(dir.path().join("runtime"))
|
||||
.with_runtime_id("stop-restore-evidence");
|
||||
let backend = Arc::new(TestExecutionBackend::default());
|
||||
let runtime =
|
||||
Runtime::with_fs_store_and_execution_backend(options.clone(), backend.clone())
|
||||
.unwrap();
|
||||
runtime.store_config_bundle(test_bundle()).unwrap();
|
||||
let worker = runtime
|
||||
.create_worker(task_request("stop restore evidence"))
|
||||
.unwrap();
|
||||
runtime.stop_worker(&worker.worker_ref, None).unwrap();
|
||||
let request = runtime.test_restore_request(&worker.worker_ref);
|
||||
*backend.restore_result.lock().unwrap() = Some(WorkerExecutionSpawnResult::Errored(
|
||||
WorkerExecutionResult::errored(
|
||||
WorkerExecutionOperation::Restore,
|
||||
"publication not confirmed",
|
||||
),
|
||||
));
|
||||
assert_eq!(
|
||||
runtime
|
||||
.restore_worker_operation(&worker.worker_ref, request.clone())
|
||||
.unwrap()
|
||||
.state,
|
||||
WorkerRestoreState::ReconciliationRequired
|
||||
);
|
||||
{
|
||||
// Fixture represents each canonical checkpoint. Stop must keep
|
||||
// its classification, rather than infer rollback from cleanup.
|
||||
let mut state = runtime.lock().unwrap();
|
||||
let record = state.worker_mut(&worker.worker_ref).unwrap();
|
||||
let pending = record.pending_restore.as_mut().unwrap();
|
||||
pending.commit = commit;
|
||||
pending.source_repair_possible = repaired;
|
||||
state.persist_worker(&worker.worker_id).unwrap();
|
||||
}
|
||||
runtime.stop_worker(&worker.worker_ref, None).unwrap();
|
||||
let receipt = runtime
|
||||
.restore_worker_operation(&worker.worker_ref, request.clone())
|
||||
.unwrap();
|
||||
assert_eq!(receipt.state, WorkerRestoreState::Superseded);
|
||||
assert_eq!(receipt.reason_code.as_deref(), Some(code));
|
||||
assert!(receipt.worker.is_none());
|
||||
drop(runtime);
|
||||
let restarted_backend = Arc::new(TestExecutionBackend::default());
|
||||
let restarted =
|
||||
Runtime::with_fs_store_and_execution_backend(options, restarted_backend.clone())
|
||||
.unwrap();
|
||||
assert_eq!(
|
||||
restarted
|
||||
.restore_worker_operation(&worker.worker_ref, request.clone())
|
||||
.unwrap(),
|
||||
receipt
|
||||
);
|
||||
assert_eq!(*restarted_backend.restore_count.lock().unwrap(), 0);
|
||||
assert_eq!(
|
||||
restarted.worker_detail(&worker.worker_ref).unwrap().status,
|
||||
WorkerStatus::Stopped
|
||||
);
|
||||
let mut input = WorkerInput::user("must not revive");
|
||||
input.kind = WorkerInputKind::UserIfIdle;
|
||||
assert!(restarted.send_input(&worker.worker_ref, input).is_err());
|
||||
let mut stale = request;
|
||||
stale.request_id = "new-intent-with-old-token".into();
|
||||
assert!(matches!(
|
||||
restarted.restore_worker_operation(&worker.worker_ref, stale),
|
||||
Err(RuntimeError::RestoreObservationConflict { .. })
|
||||
));
|
||||
}
|
||||
}
|
||||
|
||||
#[cfg(feature = "fs-store")]
|
||||
#[test]
|
||||
fn restore_decision_reread_preserves_commit_across_uncertainty_stop_and_restart() {
|
||||
|
||||
@@ -330,6 +330,22 @@ impl Runtime {
|
||||
Err(std::sync::TryLockError::WouldBlock) => return Ok(Step::Contended),
|
||||
Err(_) => return Err(RuntimeError::StatePoisoned),
|
||||
};
|
||||
let stop_is_owned = {
|
||||
let mut state = self.lock()?;
|
||||
state.ensure_running()?;
|
||||
state.refresh_uncertain_worker_write(worker_ref)?;
|
||||
let worker = state.worker(worker_ref)?;
|
||||
worker.pending_stop.is_some()
|
||||
&& worker
|
||||
.pending_restore
|
||||
.is_some_and(|pending| pending.operation_id == operation)
|
||||
};
|
||||
if stop_is_owned {
|
||||
// Stop supersedes publication, not ownership of late resources.
|
||||
// Retain this same continuation until its cleanup is confirmed.
|
||||
self.reconcile_pending_stop_under_lock(worker_ref)?;
|
||||
return Ok(Step::Finished);
|
||||
}
|
||||
let (backend, pending) = {
|
||||
let mut state = self.lock()?;
|
||||
state.ensure_running()?;
|
||||
|
||||
@@ -94,6 +94,43 @@ mod publication {
|
||||
(release, received)
|
||||
}
|
||||
|
||||
#[test]
|
||||
#[serial_test::serial(worker_allocation)]
|
||||
fn stop_timeout_retains_autonomous_late_cleanup_and_blocks_remove_until_confirmed() {
|
||||
let mut fixture = Fixture::no_model();
|
||||
Arc::get_mut(&mut fixture.backend).unwrap().spawn_restore_timeout = Duration::from_millis(250);
|
||||
let runtime = stopped_runtime(&fixture);
|
||||
let pause = runtime.test_pause_restore_continuation();
|
||||
let worker_ref = fixture.request.worker_ref.clone();
|
||||
let scope = fixture.request.workspace_scope.as_ref().unwrap();
|
||||
let request = runtime.test_restore_request(&worker_ref);
|
||||
let before = fixture.canonical_files();
|
||||
let (release, prepared) = prepared_gate(&fixture);
|
||||
let result = runtime.restore_worker_operation_scoped(scope, &worker_ref, request.clone()).unwrap();
|
||||
prepared.recv_timeout(WAIT).unwrap();
|
||||
assert_eq!(result.state, server_api::WorkerRestoreState::ReconciliationRequired);
|
||||
let operation = durable_operation(&runtime, &worker_ref).unwrap();
|
||||
assert!(runtime.stop_worker_scoped(scope, &worker_ref, None).is_err());
|
||||
assert!(runtime.delete_worker_scoped(scope, &worker_ref).is_err());
|
||||
assert!(fixture.backend.workers.lock().unwrap().is_empty());
|
||||
release.notify_one();
|
||||
drop(pause);
|
||||
runtime.test_wait_restore_continuation(&worker_ref, operation.operation_id, WAIT);
|
||||
assert_eq!(runtime.worker_detail(&worker_ref).unwrap().status, crate::catalog::WorkerStatus::Stopped);
|
||||
assert!(durable_operation(&runtime, &worker_ref).is_none());
|
||||
assert!(fixture.backend.pending_restore(&worker_ref).unwrap().is_none());
|
||||
assert!(fixture.backend.workers.lock().unwrap().is_empty());
|
||||
assert!(fixture.backend.factory.observation_hub.get(&worker_ref).is_none());
|
||||
assert!(fixture.backend.clone().attach_worker_protocol(&worker_ref).is_err());
|
||||
let receipt = runtime.restore_worker_operation_scoped(scope, &worker_ref, request).unwrap();
|
||||
assert_eq!(receipt.state, server_api::WorkerRestoreState::Superseded);
|
||||
assert_eq!(receipt.reason_code.as_deref(), Some("worker_restore_superseded_by_stop"));
|
||||
assert_eq!(fixture.canonical_files(), before);
|
||||
fixture.assert_released();
|
||||
fixture.assert_quiet();
|
||||
assert!(runtime.delete_worker_scoped(scope, &worker_ref).unwrap().deleted);
|
||||
}
|
||||
|
||||
#[test]
|
||||
#[serial_test::serial(worker_allocation)]
|
||||
fn autonomous_late_prepare_and_publication_settle_without_another_request() {
|
||||
|
||||
@@ -5063,6 +5063,9 @@ impl WorkspaceWorkerRuntime for RemoteWorkerRuntime {
|
||||
runtime_api::WorkerRestoreState::RolledBack => {
|
||||
server_api::WorkerRestoreState::RolledBack
|
||||
}
|
||||
runtime_api::WorkerRestoreState::Superseded => {
|
||||
server_api::WorkerRestoreState::Superseded
|
||||
}
|
||||
runtime_api::WorkerRestoreState::ReconciliationRequired => {
|
||||
server_api::WorkerRestoreState::ReconciliationRequired
|
||||
}
|
||||
|
||||
+18
-9
@@ -15697,14 +15697,23 @@
|
||||
"type": "object"
|
||||
},
|
||||
"WorkerRestoreState": {
|
||||
"description": "Cross-layer outcome of an explicit Worker restore operation.\n\n`Rejected` is reserved for read-only preflight failures. Once live restore\nwork starts, failure is either a confirmed `RolledBack` operation or a\n`ReconciliationRequired` result whose commit state must be reread/retried.",
|
||||
"enum": [
|
||||
"accepted",
|
||||
"rejected",
|
||||
"rolled_back",
|
||||
"reconciliation_required"
|
||||
],
|
||||
"type": "string"
|
||||
"description": "Cross-layer outcome of an explicit Worker restore operation.\n\n`Rejected` is reserved for read-only preflight failures. Once live restore\nwork starts, distinguish confirmed `RolledBack`, unresolved\n`ReconciliationRequired`, and a later Stop's `Superseded` outcome.",
|
||||
"oneOf": [
|
||||
{
|
||||
"enum": [
|
||||
"accepted",
|
||||
"rejected",
|
||||
"rolled_back",
|
||||
"reconciliation_required"
|
||||
],
|
||||
"type": "string"
|
||||
},
|
||||
{
|
||||
"const": "superseded",
|
||||
"description": "A later Stop superseded this restore; neither rollback nor prior Accepted is asserted.",
|
||||
"type": "string"
|
||||
}
|
||||
]
|
||||
},
|
||||
"WorkerRetentionResponse": {
|
||||
"additionalProperties": false,
|
||||
@@ -18155,7 +18164,7 @@
|
||||
"info": {
|
||||
"title": "Yoi Server API",
|
||||
"version": "0.1.0",
|
||||
"x-yoi-source-digest": "sha256:5de3f3b716555717d3274b8c6a385fb66624585941628a53b8b3050cb58f8ab7"
|
||||
"x-yoi-source-digest": "sha256:4159d6baa918c9d7d3cb6ae02207aad877a69ad1dd4207beb63b271deb24176e"
|
||||
},
|
||||
"openapi": "3.1.0",
|
||||
"paths": {
|
||||
|
||||
@@ -1,6 +1,6 @@
|
||||
// @generated by yoi-companion-openapi-typescript@1. Do not edit.
|
||||
// Input: openapi/server-api.json
|
||||
// Input contract: 0.1.0 (sha256:5de3f3b716555717d3274b8c6a385fb66624585941628a53b8b3050cb58f8ab7)
|
||||
// Input contract: 0.1.0 (sha256:4159d6baa918c9d7d3cb6ae02207aad877a69ad1dd4207beb63b271deb24176e)
|
||||
// Options: companion-operation-schema-closure,openapi-3.1,strict-integer-ranges,sorted-output
|
||||
// Output: web/workspace/src/lib/generated/companion-api.ts
|
||||
// Regenerate/check: cargo run -q -p server-api --example generate_companion_api_types -- --check
|
||||
|
||||
@@ -1,6 +1,6 @@
|
||||
// @generated by yoi-repository-openapi-typescript@1. Do not edit.
|
||||
// Input: openapi/server-api.json
|
||||
// Input contract: 0.1.0 (sha256:5de3f3b716555717d3274b8c6a385fb66624585941628a53b8b3050cb58f8ab7)
|
||||
// Input contract: 0.1.0 (sha256:4159d6baa918c9d7d3cb6ae02207aad877a69ad1dd4207beb63b271deb24176e)
|
||||
// Options: repository-operation-schema-closure,openapi-3.1,format:uint64=safe-number,strict-safe-integers,sorted-output
|
||||
// Output: web/workspace/src/lib/generated/repository-api.ts
|
||||
// Regenerate/check: cargo run -q -p server-api --example generate_repository_openapi_types -- --check
|
||||
|
||||
@@ -1,6 +1,6 @@
|
||||
// @generated by yoi-runtime-openapi-typescript@1. Do not edit.
|
||||
// Input: openapi/server-api.json
|
||||
// Input contract: 0.1.0 (sha256:5de3f3b716555717d3274b8c6a385fb66624585941628a53b8b3050cb58f8ab7)
|
||||
// Input contract: 0.1.0 (sha256:4159d6baa918c9d7d3cb6ae02207aad877a69ad1dd4207beb63b271deb24176e)
|
||||
// Options: runtime-operation-schema-closure,openapi-3.1,strict-integer-ranges,sorted-output
|
||||
// Output: web/workspace/src/lib/generated/runtime-api.ts
|
||||
// Regenerate/check: cargo run -q -p server-api --example generate_runtime_api_types -- --check
|
||||
@@ -181,7 +181,7 @@ export type WorkerRestoreResponse = { result: WorkerRestoreResult; runtime_id: s
|
||||
|
||||
export type WorkerRestoreResult = { diagnostics?: Array<Diagnostic>; state: WorkerRestoreState; worker?: WorkerSummary | null; };
|
||||
|
||||
export type WorkerRestoreState = "accepted" | "rejected" | "rolled_back" | "reconciliation_required";
|
||||
export type WorkerRestoreState = "accepted" | "rejected" | "rolled_back" | "reconciliation_required" | "superseded";
|
||||
|
||||
export type WorkerRetentionResponse = { pinned: boolean; retention_state: string; runtime_id: string; worker_id: string; workspace_id: string; };
|
||||
|
||||
|
||||
@@ -1,6 +1,6 @@
|
||||
// @generated by yoi-ticket-browser-openapi-typescript@1. Do not edit.
|
||||
// Input: openapi/server-api.json
|
||||
// Input contract: 0.1.0 (sha256:5de3f3b716555717d3274b8c6a385fb66624585941628a53b8b3050cb58f8ab7)
|
||||
// Input contract: 0.1.0 (sha256:4159d6baa918c9d7d3cb6ae02207aad877a69ad1dd4207beb63b271deb24176e)
|
||||
// Options: ticket-objective-merge-request-browser-operation-schema-closure,openapi-3.1,strict-integer-ranges,sorted-output
|
||||
// Output: web/workspace/src/lib/generated/ticket-api.ts
|
||||
// Regenerate/check: cargo run -q -p server-api --example generate_ticket_api_types -- --check
|
||||
|
||||
@@ -1,6 +1,6 @@
|
||||
// @generated by yoi-worker-openapi-typescript@1. Do not edit.
|
||||
// Input: openapi/server-api.json
|
||||
// Input contract: 0.1.0 (sha256:5de3f3b716555717d3274b8c6a385fb66624585941628a53b8b3050cb58f8ab7)
|
||||
// Input contract: 0.1.0 (sha256:4159d6baa918c9d7d3cb6ae02207aad877a69ad1dd4207beb63b271deb24176e)
|
||||
// Options: worker-operation-schema-closure,openapi-3.1,strict-integer-ranges,sorted-output
|
||||
// Output: web/workspace/src/lib/generated/worker-launch-api.ts
|
||||
// Regenerate/check: cargo run -q -p server-api --example generate_worker_launch_api_types -- --check
|
||||
|
||||
@@ -363,8 +363,13 @@ export function parseWorkerRestoreResponse(
|
||||
exactKeys(result, ["state"], ["diagnostics", "worker"], `${path}.result`);
|
||||
const state = boundedString(result.state, `${path}.result.state`);
|
||||
if (
|
||||
!["accepted", "rejected", "rolled_back", "reconciliation_required"]
|
||||
.includes(state)
|
||||
![
|
||||
"accepted",
|
||||
"rejected",
|
||||
"rolled_back",
|
||||
"superseded",
|
||||
"reconciliation_required",
|
||||
].includes(state)
|
||||
) {
|
||||
fail(`${path}.result.state`, "has an unknown value");
|
||||
}
|
||||
|
||||
@@ -427,7 +427,12 @@ test.each(["switch", "dispose"] as const)(
|
||||
);
|
||||
|
||||
function restoreResponse(
|
||||
state: "accepted" | "rejected" | "rolled_back" | "reconciliation_required",
|
||||
state:
|
||||
| "accepted"
|
||||
| "rejected"
|
||||
| "rolled_back"
|
||||
| "superseded"
|
||||
| "reconciliation_required",
|
||||
extra = {},
|
||||
) {
|
||||
return Response.json({
|
||||
@@ -461,7 +466,13 @@ test.each(["stopped", "idle", "running", "paused", "unavailable"] as const)(
|
||||
);
|
||||
|
||||
test.each(
|
||||
["accepted", "rejected", "rolled_back", "reconciliation_required"] as const,
|
||||
[
|
||||
"accepted",
|
||||
"rejected",
|
||||
"rolled_back",
|
||||
"superseded",
|
||||
"reconciliation_required",
|
||||
] as const,
|
||||
)(
|
||||
"Restore classifies %s through the shared helper, without treating HTTP 200 as success",
|
||||
async (state) => {
|
||||
@@ -470,10 +481,11 @@ test.each(
|
||||
const unsubscribe = workspaceAlerts.subscribe((value) => {
|
||||
alerts = value;
|
||||
});
|
||||
const request = vi.fn(async (input: RequestInfo | URL) =>
|
||||
String(input).endsWith("/restore")
|
||||
? restoreResponse(state)
|
||||
: Response.json(plan())
|
||||
const request = vi.fn(
|
||||
async (input: RequestInfo | URL, _init?: RequestInit) =>
|
||||
String(input).endsWith("/restore")
|
||||
? restoreResponse(state)
|
||||
: Response.json(plan()),
|
||||
);
|
||||
vi.stubGlobal("fetch", request);
|
||||
render(WorkersPage, { data: data() });
|
||||
@@ -498,6 +510,16 @@ test.each(
|
||||
screen.queryByRole("button", { name: "Retry Restore Catalog worker" }),
|
||||
),
|
||||
).toBe(state === "reconciliation_required");
|
||||
expect(
|
||||
request.mock.calls.filter(([url]) => String(url).endsWith("/restore")),
|
||||
).toHaveLength(1);
|
||||
expect(
|
||||
request.mock.calls
|
||||
.filter(([, init]) => init?.method && init.method !== "GET")
|
||||
.map(([url]) => String(url)),
|
||||
).toEqual([
|
||||
"/api/w/page-test/runtimes/runtime-a/workers/worker-a/restore",
|
||||
]);
|
||||
// The response is never projected into the catalog by the action.
|
||||
expect(screen.getByRole("cell", { name: "stopped" })).toBeTruthy();
|
||||
unsubscribe();
|
||||
|
||||
@@ -305,6 +305,7 @@ Deno.test("Restore classification never promotes nonaccepted results and preserv
|
||||
"accepted",
|
||||
"rejected",
|
||||
"rolled_back",
|
||||
"superseded",
|
||||
"reconciliation_required",
|
||||
] as const
|
||||
) {
|
||||
|
||||
@@ -173,12 +173,13 @@ function restoredWorker() {
|
||||
restore_observation_token: "generation-b",
|
||||
};
|
||||
}
|
||||
Deno.test("Restore parser preserves all four states and optional Workspace summary", () => {
|
||||
Deno.test("Restore parser preserves typed outcomes and optional Workspace summary", () => {
|
||||
for (
|
||||
const state of [
|
||||
"accepted",
|
||||
"rejected",
|
||||
"rolled_back",
|
||||
"superseded",
|
||||
"reconciliation_required",
|
||||
]
|
||||
) {
|
||||
|
||||
Reference in New Issue
Block a user