fix: update workflow-free tui tests

This commit is contained in:
Keisuke Hirata 2026-07-16 06:32:07 +09:00
parent 0b56052a44
commit bc48094dde
No known key found for this signature in database
4 changed files with 28 additions and 14 deletions

View File

@ -2,7 +2,7 @@
title: 'Remove workflow tracking and workflow resources' title: 'Remove workflow tracking and workflow resources'
state: 'inprogress' state: 'inprogress'
created_at: '2026-07-15T19:02:13Z' created_at: '2026-07-15T19:02:13Z'
updated_at: '2026-07-15T21:22:40Z' updated_at: '2026-07-15T21:32:07Z'
assignee: null assignee: null
queued_by: 'workspace-panel' queued_by: 'workspace-panel'
queued_at: '2026-07-15T19:54:36Z' queued_at: '2026-07-15T19:54:36Z'

View File

@ -209,4 +209,27 @@ Validation:
- nix build .#yoi --no-link -> exit 0 - nix build .#yoi --no-link -> exit 0
---
<!-- event: implementation_report author: hare at: 2026-07-15T21:32:07Z -->
## Implementation report
Follow-up fix for focused TUI re-review blocker.
Summary:
- Updated `live_system_snapshot_replaces_task_store` so the task-store snapshot fixture is carried by active `task_reminder` SystemItem text instead of a legacy `kind: "workflow"` item.
- Legacy workflow SystemItems remain ignored/drop-diagnostic only; no workflow active behavior was re-enabled.
- While running the requested full TUI suite, updated stale dashboard routing-message test assertions to match the already workflow-free queue guidance.
Validation:
- cargo test -p tui --lib live_system_snapshot_replaces_task_store -- --nocapture -> exit 0
- cargo test -p tui --lib live_legacy_workflow_system_item_is_ignored -- --nocapture -> exit 0
- git diff --check -> exit 0
- cargo test -p tui --lib --tests -> exit 0
- cargo check -p yoi -> exit 0
- yoi ticket doctor -> exit 0
- nix build .#yoi --no-link -> exit 0
--- ---

View File

@ -3584,12 +3584,11 @@ mod completion_flow_tests {
```json\n{\n \"tasks\": [\n {\n \"taskid\": 4,\n \ ```json\n{\n \"tasks\": [\n {\n \"taskid\": 4,\n \
\"status\": \"inprogress\",\n \"subject\": \"from snapshot\",\n \ \"status\": \"inprogress\",\n \"subject\": \"from snapshot\",\n \
\"description\": \"d\"\n }\n ]\n}\n```\n"; \"description\": \"d\"\n }\n ]\n}\n```\n";
// Snapshot text injected as a workflow body (kind doesn't matter // Snapshot text injected through an active system item kind; legacy
// for task-store parsing, only the text contents do). // workflow items are intentionally ignored and must not carry active state.
app.handle_worker_event(Event::SystemItem { app.handle_worker_event(Event::SystemItem {
item: serde_json::json!({ item: serde_json::json!({
"kind": "workflow", "kind": "task_reminder",
"slug": "task-snapshot",
"body": snapshot, "body": snapshot,
}), }),
}); });

View File

@ -826,17 +826,9 @@ fn ticket_queue_notification_message_carries_routing_contract() {
assert!(message.contains("before any worktree/SpawnWorker implementation side effects")); assert!(message.contains("before any worktree/SpawnWorker implementation side effects"));
assert!(message.contains("After inprogress acceptance")); assert!(message.contains("After inprogress acceptance"));
assert!(message.contains("implementation worktree")); assert!(message.contains("implementation worktree"));
assert!(message.contains("`.worktree/<task-name>`"));
assert!(message.contains("tracked `.yoi` project records visible")); assert!(message.contains("tracked `.yoi` project records visible"));
assert!( assert!(message.contains("generated/local/runtime/log/lock/secret-like `.yoi` paths excluded"));
message.contains(
"`.yoi/memory` plus local/runtime/log/lock/secret-like `.yoi` paths excluded"
)
);
assert!(message.contains("sibling coder/reviewer Workers")); assert!(message.contains("sibling coder/reviewer Workers"));
assert!(message.contains("sibling coder/reviewer Workers"));
assert!(message.contains("coder narrow child-worktree write scope"));
assert!(message.contains("reviewer read-only by default"));
assert!(message.contains( assert!(message.contains(
"integrate the implementation branch into the orchestration branch automatically" "integrate the implementation branch into the orchestration branch automatically"
)); ));