Hare/yoi
1
1
Fork 0
Code Actions Packages Releases Activity

ticket: approve runtime worker implementation

Browse Source
This commit is contained in:
Keisuke Hirata 2026-07-03 03:20:17 +09:00
parent 50016b122c
commit c2c594411d
No known key found for this signature in database
4 changed files with 62 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
.yoi/tickets/00001KWHEM8YJ/item.md
View File

@ -2,7 +2,7 @@
title: 'Workspace Browserから手動Coding Workerを作成する導線を追加する'
state: 'inprogress'
created_at: '2026-07-02T12:59:57Z'
updated_at: '2026-07-02T18:11:11Z'
updated_at: '2026-07-02T18:20:10Z'
assignee: null
queued_by: 'workspace-panel'
queued_at: '2026-07-02T16:13:24Z'

30
.yoi/tickets/00001KWHEM8YJ/thread.md
View File

@ -260,3 +260,33 @@ Review-fix implementation report:
- Requesting follow-up external review against `f2fead7e..47ed0ff8` and full combined implementation.
---
<!-- event: review author: reviewer at: 2026-07-02T18:20:10Z status: approve -->
## Review: approve
External follow-up review result: approve
Read-only follow-up review completed for both Tickets and fix commit `47ed0ff8` on top of `f2fead7e`.
Evidence reviewed:
- Ticket records for `00001KWHHRTM9` and `00001KWHEM8YJ`.
- Fix diff `f2fead7e..47ed0ff8`.
- Relevant backend/web files including `crates/workspace-server/src/server.rs`, `config.rs`, `hosts.rs`, `worker-launch.ts`, `WorkersNavSection.svelte`, related tests/settings model files.
- Orchestrator-reported validation pass for `git diff --check`, `cargo test -p yoi-workspace-server`, `cargo check -p yoi`, `cd web/workspace && deno task test`, and `cd web/workspace && deno task check`.
Reviewer findings:
- Previous blocker 1 resolved: runtime connection test now performs lightweight negotiation/probing for Browser-relevant operations and represents unsupported/not-observed operations with typed diagnostics and `unknown`/`unsupported` capability entries instead of blanket compatibility.
- Previous blocker 2 resolved: Browser-facing remote-test diagnostics omit raw endpoints/config paths/socket/session/store paths and use typed/sanitized diagnostics; tests assert projected responses do not contain the endpoint/runtime address.
- Previous blocker 3 resolved: `/api/workers` keeps product-level request shape and preserves runtime rejection diagnostics while adding typed `workspace_worker_create_not_accepted` diagnostic.
- Previous blocker 4 resolved: focused backend tests cover runtime connection test sanitization/compatibility, worker creation payload rejection, diagnostic preservation; web tests cover launch payload shaping/error handling.
- Persisted config, live registry summaries, and test observations remain separated.
- Browser-facing settings responses expose safe summaries rather than raw authority-bearing backend fields.
- New Worker UI consumes `/api/workers/options` candidates and submits only product-level `/api/workers` payload.
Non-blocking follow-up:
- UI could later render backend diagnostic codes/details more richly on Worker launch failure, but current behavior is sanitized and merge-ready.
No merge-blocking issues found.
---

2
.yoi/tickets/00001KWHHRTM9/item.md
View File

@ -2,7 +2,7 @@
title: 'Workspace Backend Runtime接続の管理画面と永続configを追加する'
state: 'inprogress'
created_at: '2026-07-02T13:54:52Z'
updated_at: '2026-07-02T18:11:11Z'
updated_at: '2026-07-02T18:20:10Z'
assignee: null
queued_by: 'workspace-panel'
queued_at: '2026-07-02T16:45:19Z'

30
.yoi/tickets/00001KWHHRTM9/thread.md
View File

@ -280,3 +280,33 @@ Review-fix implementation report:
- Requesting follow-up external review against `f2fead7e..47ed0ff8` and full combined implementation.
---
<!-- event: review author: reviewer at: 2026-07-02T18:20:10Z status: approve -->
## Review: approve
External follow-up review result: approve
Read-only follow-up review completed for both Tickets and fix commit `47ed0ff8` on top of `f2fead7e`.
Evidence reviewed:
- Ticket records for `00001KWHHRTM9` and `00001KWHEM8YJ`.
- Fix diff `f2fead7e..47ed0ff8`.
- Relevant backend/web files including `crates/workspace-server/src/server.rs`, `config.rs`, `hosts.rs`, `worker-launch.ts`, `WorkersNavSection.svelte`, related tests/settings model files.
- Orchestrator-reported validation pass for `git diff --check`, `cargo test -p yoi-workspace-server`, `cargo check -p yoi`, `cd web/workspace && deno task test`, and `cd web/workspace && deno task check`.
Reviewer findings:
- Previous blocker 1 resolved: runtime connection test now performs lightweight negotiation/probing for Browser-relevant operations and represents unsupported/not-observed operations with typed diagnostics and `unknown`/`unsupported` capability entries instead of blanket compatibility.
- Previous blocker 2 resolved: Browser-facing remote-test diagnostics omit raw endpoints/config paths/socket/session/store paths and use typed/sanitized diagnostics; tests assert projected responses do not contain the endpoint/runtime address.
- Previous blocker 3 resolved: `/api/workers` keeps product-level request shape and preserves runtime rejection diagnostics while adding typed `workspace_worker_create_not_accepted` diagnostic.
- Previous blocker 4 resolved: focused backend tests cover runtime connection test sanitization/compatibility, worker creation payload rejection, diagnostic preservation; web tests cover launch payload shaping/error handling.
- Persisted config, live registry summaries, and test observations remain separated.
- Browser-facing settings responses expose safe summaries rather than raw authority-bearing backend fields.
- New Worker UI consumes `/api/workers/options` candidates and submits only product-level `/api/workers` payload.
Non-blocking follow-up:
- UI could later render backend diagnostic codes/details more richly on Worker launch failure, but current behavior is sanitized and merge-ready.
No merge-blocking issues found.
---