ticket: reroute workspace identity fixes
This commit is contained in:
parent
fac79dc962
commit
ddd2f86e26
|
|
@ -2,7 +2,7 @@
|
||||||
title: 'Persist local Workspace identity in .yoi/workspace.toml'
|
title: 'Persist local Workspace identity in .yoi/workspace.toml'
|
||||||
state: 'inprogress'
|
state: 'inprogress'
|
||||||
created_at: '2026-06-23T06:43:28Z'
|
created_at: '2026-06-23T06:43:28Z'
|
||||||
updated_at: '2026-06-23T07:24:58Z'
|
updated_at: '2026-06-23T07:25:27Z'
|
||||||
assignee: null
|
assignee: null
|
||||||
queued_by: 'workspace-panel'
|
queued_by: 'workspace-panel'
|
||||||
queued_at: '2026-06-23T06:47:18Z'
|
queued_at: '2026-06-23T06:47:18Z'
|
||||||
|
|
|
||||||
|
|
@ -279,3 +279,29 @@ Reviewer notes generated ignored artifacts from validation remained in worktree:
|
||||||
- `web/workspace/build/`
|
- `web/workspace/build/`
|
||||||
|
|
||||||
---
|
---
|
||||||
|
|
||||||
|
<!-- event: comment author: yoi-orchestrator at: 2026-06-23T07:25:27Z -->
|
||||||
|
|
||||||
|
## Comment
|
||||||
|
|
||||||
|
Rerouted request-changes feedback to Coder Pod `yoi-coder-00001KVSKGDYS`.
|
||||||
|
|
||||||
|
Requested fix:
|
||||||
|
- `WorkspaceIdentity::load_or_init` must return the identity actually persisted/read from `.yoi/workspace.toml`。
|
||||||
|
- Missing-file creation must handle local bootstrap races without returning an unpersisted generated identity。
|
||||||
|
- Avoid or safely handle TOCTOU / fixed temp-file clobbering around `workspace.toml.tmp`。
|
||||||
|
- Add focused deterministic test coverage if feasible。
|
||||||
|
|
||||||
|
Validation requested after fix:
|
||||||
|
- `cargo fmt --check`
|
||||||
|
- `cargo test -p yoi-workspace-server`
|
||||||
|
- `cargo check -p yoi-workspace-server`
|
||||||
|
- `cd web/workspace && deno task check && deno task build`
|
||||||
|
- `git diff --check`
|
||||||
|
- `git diff --cached --check`
|
||||||
|
- `cargo run -p yoi -- ticket doctor`
|
||||||
|
- `nix build .#yoi --no-link`
|
||||||
|
|
||||||
|
Coder was also asked to remove ignored validation artifacts before reporting。
|
||||||
|
|
||||||
|
---
|
||||||
|
|
|
||||||
Loading…
Reference in New Issue
Block a user