Hare/yoi
1
1
Fork 0
Code Actions Packages Releases Activity

ticket: record identity simplification third review

Browse Source
This commit is contained in:
Keisuke Hirata 2026-06-09 13:36:05 +09:00
parent 08ff812ce4
commit dfe3749af9
No known key found for this signature in database
2 changed files with 30 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
.yoi/tickets/open/20260608-110940-simplify-ticket-identity-fields/item.md
View File

@ -8,7 +8,7 @@ priority: 'P1'
labels: ['ticket', 'schema', 'identity', 'migration', 'orchestrator'] labels: ['ticket', 'schema', 'identity', 'migration', 'orchestrator']
workflow_state: 'inprogress' workflow_state: 'inprogress'
created_at: '2026-06-08T11:09:40Z' created_at: '2026-06-08T11:09:40Z'
updated_at: '2026-06-09T04:28:16Z' updated_at: '2026-06-09T04:35:54Z'
assignee: null assignee: null
queued_by: 'workspace-panel' queued_by: 'workspace-panel'
queued_at: '2026-06-09T02:13:30Z' queued_at: '2026-06-09T02:13:30Z'

29
.yoi/tickets/open/20260608-110940-simplify-ticket-identity-fields/thread.md
View File

@ -500,3 +500,32 @@ Coder validation reported passed:
Coder reports no remaining requested surface or design conflict. Coder reports no remaining requested surface or design conflict.
--- ---
<!-- event: review author: reviewer-simplify-ticket-identity-fields at: 2026-06-09T04:35:54Z status: request_changes -->
## Review: request changes
Review result: request_changes
The previous three blockers were fixed, and the requested validation set passed. However, one stale old-bucket TUI test setup remains and a focused test fails.
Blocking issue:
- `crates/tui/src/multi_pod.rs` still contains an old bucket path in test setup:
- `.yoi/tickets/open/done-ticket`
- Focused test failure:
- `cargo test -p tui ticket_close_action_blocks_existing_resolution_without_moving_ticket`
- exits 101 because the test writes `resolution.md` under `.yoi/tickets/open/done-ticket/`, but the current flat layout no longer creates that parent path.
This is a test/helper path rather than production runtime behavior, but the Ticket requires completion of the flat `.yoi/tickets/<ticket-id>/` migration and no current old-bucket route. Executable tests should not encode old bucket paths.
Positive evidence:
- Built-in Ticket feature root validation no longer requires `open/`, `pending/`, `closed/` buckets.
- Maintained workflows/docs no longer expose `TicketStatus`, pending routing, or `defer_pending` as current guidance.
- Main requested validation passed: `cargo test -p pod ticket`, `cargo test -p ticket`, `cargo test -p yoi ticket_cli`, `cargo test -p tui ticket_action --no-run`, `cargo test -p tui workspace_panel`, `cargo fmt --check`, `git diff --check`, `cargo run -q -p yoi -- ticket doctor`, `cargo check --workspace`, `nix build .#yoi`.
Required fix:
- Update the stale TUI test setup in `crates/tui/src/multi_pod.rs` to the flat layout/current state schema.
- Run the failing focused test: `cargo test -p tui ticket_close_action_blocks_existing_resolution_without_moving_ticket`.
- Re-run the relevant focused validation and core checks before re-review.
---