4.6 KiB
4.6 KiB
Created
Created by tickets.sh create.
Plan
Implementation plan:
- Remove or demote the
insomnia-podCargo binary target if active code/tests no longer require it; keeppodas a library crate. - Update Nix packaging/install checks and flake app outputs so the package exposes only
insomnia; install checks should callinsomnia pod --help. - Update devshell wrapper behavior. Since internal default spawning now uses
current_exe() + ["pod"], the oldinsomnia-podwrapper should be removed unless a focused dev reason remains. - Update current user docs (
docs/nix.md,docs/pod-factory.md, manifest/profile docs, architecture docs) frominsomnia-podtoinsomnia pod. Do not rewrite historical work-item artifacts. - Validate runtime parser/help, internal spawn/restore tests, Nix build, doctor, and diff check.
Review: approve
External reviewer: remove-insomnia-pod-reviewer-20260531
Reviewed implementation commit: 0d7d3c7bf1e1becb85ca8322e4b72730a91e3513 (cli: remove insomnia-pod binary output)
Verdict: approve
Summary:
- The implementation removes the old
insomnia-podinstalled/runtime alias and keeps Pod runtime process separation viainsomnia pod .... podis now library-only (autobins = false),pod::entrypointremains available, and the oldcrates/pod/src/main.rsbinary target is gone.- Nix/package/devshell/docs were updated so the primary installed command is
insomnia,apps.insomnia-podis no longer advertised, and install checks useinsomnia pod --helpplus a negative check forbin/insomnia-pod. - Internal spawn/restore paths use
PodRuntimeCommand::resolve()andprefix_args()with defaultcurrent_exe() + ["pod"];INSOMNIA_POD_COMMANDremains executable-only.
Requirements mapping:
- Acceptance criteria are satisfied: installed output no longer exposes
bin/insomnia-pod;flake.nixno longer advertisesapps.insomnia-pod;insomnia pod --helpremains the runtime entrypoint; relevant tests and docs were updated. - No hidden non-goal changes were found: no
tuicrate rename, no controller/runtime process merge, and no Pod protocol or runtime flag semantic change.
Blockers: none.
Non-blocking follow-ups:
- A test name in
crates/pod/src/entrypoint.rsstill contains old-ish wording (subcommand_help_uses_insomnia_pod_invocation) even though the test contents useinsomnia pod; renaming it later would improve readability. docs/plan/network-peering.mdstill has generic wording around a "pod binary"; this is not a user-facinginsomnia-podcommand example and is not blocking.
Validation adequacy:
- Coder-reported validation covers fmt, parser/unit/integration tests,
cargo check, Nix build/install smoke,nix flake check, ticket doctor, and diff whitespace check. - Reviewer performed read-only static review, clean status/diff inspection, residual
insomnia-podsearch, andgit diff --check.
Closed
Removed the old insomnia-pod installed/runtime alias and completed the next single-binary CLI phase.
Implementation:
- Removed the
insomnia-podbinary target from thepodcrate and made it library-only withautobins = false. - Deleted the old
crates/pod/src/main.rswrapper while keepingpod::entrypointforinsomnia pod .... - Updated runtime command resolution to default to the current
insomniaexecutable plus thepodprefix argument, while preserving executable-onlyINSOMNIA_POD_COMMANDoverride behavior. - Updated Nix packaging so
.#insomniainstallsbin/insomniaand asserts thatbin/insomnia-podis absent. - Removed
apps.insomnia-podfromflake.nixand removed the devshellinsomnia-podwrapper. - Updated current docs to use
insomnia pod ...instead of the old user-facinginsomnia-pod ...command.
Review:
- External reviewer
remove-insomnia-pod-reviewer-20260531approved implementation commit0d7d3c7bf1e1becb85ca8322e4b72730a91e3513. - Review was recorded in
thread.mdbefore merge.
Validation on develop after merge:
cargo fmt --checkcargo test -p tui parse_pod_subcommand_uses_runtime_modecargo test -p pod-commandcargo test -p pod --lib discovery::testscargo test -p pod --test spawn_pod_testcargo check -p tui -p pod -p clientnix build .#insomnia./result/bin/insomnia pod --helptest ! -e ./result/bin/insomnia-pod./tickets.sh doctorgit diff --check