1.9 KiB
1.9 KiB
Removed runtime filesystem resource discovery for bundled assets and removed INSOMNIA_RESOURCE_DIR as an active configuration surface.
Implementation:
- Removed
RESOURCE_DIR_ENV,resource_dir(), andbuiltin_profiles_dir()frommanifest::paths. - Embedded builtin Lua profile source (
default.lua) and exposed builtin profile metadata without fake filesystem paths. - Preserved user/project registry profile and explicit path profile filesystem semantics.
- Replaced manifest-side builtin model context lookup with an embedded
resources/models/builtin.tomlsource, avoiding amanifest -> providerdependency. - Removed installed runtime
share/insomnia/resourcespackaging and checks from Nix package output. - Updated environment/Nix/pod-factory docs so runtime resource directory and
INSOMNIA_RESOURCE_DIRare no longer supported/documented surfaces.
Review:
- External reviewer
remove-resource-dir-reviewer-20260531approved implementation commit365ec8b7fad008ab36bdc4de3adadb3696739a07. - Reviewer found no blockers. A suggested non-blocking future regression test for embedded profile local
requirediagnostics was recorded in the review thread.
Validation after merge:
cargo fmt --checkcargo test -p manifest profilecargo test -p provider catalogcargo test -p pod promptcargo check -p manifest -p provider -p pod -p tui./tickets.sh doctorgit diff --checkrg -n 'INSOMNIA_RESOURCE_DIR|RESOURCE_DIR_ENV|resource_dir\(|builtin_profiles_dir\(' crates docs package.nix || trueproduced no active hits.nix build .#insomniatest -x result/bin/insomniatest ! -e result/bin/insomnia-podtest ! -e result/share/insomnia/resourcesresult/bin/insomnia pod --help
Note:
- Initial post-merge validation hit
No space left on devicewhile linking.cargo cleanfreed build artifacts, after which Rust and Nix validation passed.