2.1 KiB
2.1 KiB
Moved product CLI/binary ownership from tui to insomnia.
Implementation:
- Moved
PodRuntimeCommandfrom the transitionalinsomniahelper role intoclient, so lower crates no longer depend on the product CLI crate. - Made
tuia library implementation crate and exposed launch APIs for already-parsed modes/options. - Added the
insomniapackage binary entrypoint and moved top-level CLI parsing/dispatch there. - Routed
insomnia pod ...throughpod::entrypointfrom theinsomniacrate. - Routed
insomnia memory lint ...from theinsomniacrate. - Kept normal TUI launch behavior for resume, multi-Pod dashboard, Pod name,
--pod, and--sessionmodes. - Updated packaging so
package.nixbuilds packageinsomniaand still exposes onlybin/insomnia. - Updated active development/docs references away from
cargo run -p tui -- ....
Review:
- External reviewer
insomnia-cli-owner-reviewer-20260531initially requested changes for a parser regression around--resumecombined with Pod selection. - Fix commit
37281b6restored mutual exclusion for-r --pod,--pod -r, and-r <podname>, and improved--multi --poddiagnostics. - Reviewer approved after re-review.
Validation after merge:
cargo fmt --checkcargo check -p client -p pod -p tui -p insomniacargo test -p clientcargo test -p podcargo test -p tuicargo test -p insomniacargo run -p insomnia -- --helpcargo run -p insomnia -- pod --helpcargo run -p insomnia -- memory lint --help- invalid/conflict CLI smoke tests for
--session not-a-uuid,-r --pod,--pod -r, and-r <podname> - dependency checks confirming
client,pod, andtuido not depend oninsomnia, andtuidoes not depend onpod nix build .#insomniatest -x ./result/bin/insomniatest ! -e ./result/bin/insomnia-pod./result/bin/insomnia pod --help./tickets.sh doctorgit diff --checkrg "cargo run -p tui" docs README.md crates package.nix flake.nix || trueproduced no active hits.
Notes:
- Validation emitted pre-existing dead-code warnings in
llm-worker/tuibut passed.