Hare/yoi
1
1
Fork 0
Code Actions Packages Releases Activity
24118a0f3c
yoi/.yoi/tickets/00001KW76E8EG/thread.md

9.3 KiB
Raw Blame History

作成

LocalTicketBackend によって作成されました。

Plan

Workspace Backend embedded Runtime の fs-store 永続化について詳細化した。

調査済み事実:

  • worker-runtime には Runtime::with_fs_store_and_execution_backend(...) と FsRuntimeStoreOptions が存在する。
  • workspace-server は現在 worker-runtime を ws-server feature のみで使っており、fs-store feature が有効ではない。
  • WorkspaceApi::new_with_execution_backend(...) は EmbeddedWorkerRuntime::new_memory_with_execution_backend(...) を呼んでいる。
  • ServerConfig は Runtime store root を持っていない。
  • worker-runtime の restore は live execution handle を復元せず WorkerExecutionStatus::unconnected() / execution_handle: None にする。

実装方針:

  • workspace-server で worker-runtime の fs-store feature を有効化する。
  • ServerConfig に embedded Runtime store root を追加する。
  • CLI/default path は user data 配下の workspace_id 別 path にする。
  • EmbeddedWorkerRuntime に fs-store backed constructor を追加し、Runtime::with_fs_store_and_execution_backend(...) を通す。
  • Workspace Backend の通常 constructor から memory-backed Runtime を使う経路を外す。
  • restart 後は catalog / transcript / ConfigBundle を復元し、live execution handle は connected として偽装しない。

Intake summary

Marked ready by yoi ticket state.

State changed

Marked ready by yoi ticket state.

State changed

Ticket を workspace-panel が queued にしました。

Decision

Routing decision:

Workspace Dashboard Queue authorized Orchestrator routing, so the Ticket and current workspace state were inspected.

Findings:

  • Ticket state: queued
  • Outgoing dependency: depends_on 00001KW7726H9
  • Blocking Ticket 00001KW7726H9 is currently inprogress.
  • Current inprogress Tickets: 00001KW7726H9
  • Orchestration worktree: clean

Decision:

  • Leave 00001KW76E8EG queued and do not create a child worktree / role Pod yet.
  • Reason: embedded Runtime fs-store persistence should persist the canonical Runtime Worker creation model, not an embedded-only bypass. That canonical creation path is currently being implemented in 00001KW7726H9.

Next routing condition:

  • Re-evaluate this Ticket after 00001KW7726H9 is merged, validated, and closed, or after an explicit replan changes the dependency.

Decision

Routing decision:

00001KW7726H9 has been merged, validated, closed, and cleaned up, so this Ticket's dependency is now resolved. Current workspace state was inspected before implementation side effects.

Findings:

  • Ticket state: queued
  • Dependencies on 00001KW55B33B and 00001KW7726H9 are resolved/closed.
  • Current inprogress Tickets: 0
  • Orchestration worktree: clean
  • 00001KW7835H0 remains queued and is related to this fs-store migration. Run embedded Runtime fs-store persistence first, then re-evaluate old Pod crate removal.

Decision:

  • Accept this Ticket for implementation and transition queued -> inprogress before child worktree / Pod side effects.

Plan:

  • Worktree: /home/hare/Projects/yoi/.worktree/00001KW76E8EG-embedded-runtime-fs-store
  • Branch: work/00001KW76E8EG-embedded-runtime-fs-store
  • Coder Worker will implement the Workspace Backend embedded Runtime fs-store switch and focused restart/persistence tests.
  • Reviewer Worker will verify fs-store feature enablement, ServerConfig store-root authority, restart restore behavior, ConfigBundle/transcript restore, stale execution diagnostic, Browser-facing non-leak, and production memory-backed bypass absence.

Operational note:

  • User instructed not to use StopPod for now after repeated stop/hang symptoms. Cleanup will skip role-Pod shutdown and remove only child worktree/branch unless explicitly reauthorized.

State changed

Dependencies 00001KW55B33B and 00001KW7726H9 are closed, no Ticket is currently inprogress, and the orchestration worktree is clean. Accepting implementation before child worktree / role Pod side effects.

Implementation report

Implementation kickoff:

  • Worktree created: /home/hare/Projects/yoi/.worktree/00001KW76E8EG-embedded-runtime-fs-store
  • Branch: work/00001KW76E8EG-embedded-runtime-fs-store
  • Coder Worker spawned: yoi-coder-00001KW76E8EG-fs-store

Scope notes:

  • Coder write scope is limited to crates/workspace-server/**, crates/worker-runtime/**, crates/worker/**, root Cargo.toml, Cargo.lock, and package.nix if needed.
  • Coder is instructed not to modify Ticket records and not to operate in root/orchestration worktrees.

Implementation focus:

  • enable worker-runtime fs-store feature in workspace-server
  • add ServerConfig embedded Runtime store root
  • default store root under user data / workspace id, not under project records or .yoi/tickets
  • add fs-store backed EmbeddedWorkerRuntime constructor using Runtime::with_fs_store_and_execution_backend
  • normal WorkspaceApi constructor uses fs-store, not new_memory_with_execution_backend
  • restart restores Runtime catalog / Worker snapshot / transcript / ConfigBundle store
  • live execution handle is not falsely connected after restart; stale/unconnected diagnostic/projection remains explicit
  • Browser-facing APIs do not expose store root / raw path / execution handle
  • tests cover fs-store restore, ConfigBundle/transcript restore, execution stale/unconnected restore, memory-backed production bypass absence, and store-root non-leak

Implementation report

Implementation report:

実装・検証・commit 完了。Ticket ファイル編集、merge、close、cleanup は未実施。

Commit:

  • 736b05c6 feat: persist embedded workspace runtime in fs store

変更概要:

  • workspace-server で worker-runtime の fs-store feature を有効化。
  • ServerConfig に embedded_runtime_store_root を追加し、既定値を user data 配下の workspace-server/<workspace_id>/embedded-runtime に設定。
  • 通常の WorkspaceApi 生成経路を EmbeddedWorkerRuntime::new_memory_with_execution_backend から new_fs_store_with_execution_backend に切り替え。
  • Runtime::with_fs_store_and_execution_backend を使う fs-store backed constructor を追加。
  • 再起動後の Worker は live handle 接続済みと偽らず、stale / unconnected の診断を Browser API projection に残すようにした。
  • store root / raw path / handle が Browser API に出ないことをテスト。
  • package.nix の cargoHash を更新。

追加・更新テスト:

  • fs-store restart restore:
    • catalog / Worker snapshot
    • ConfigBundle
    • transcript
    • stale execution projection / input rejection
  • store root isolation / non-leak
  • 既存 workspace-server tests は明示的 temp store root を使うよう調整。

Validation:

  • cargo fmt: success
  • cargo fmt -- --check: success
  • cargo test -p yoi-workspace-server: success
  • cargo test -p worker-runtime --features "ws-server fs-store": success
  • cargo check -p yoi: success
  • git diff --check: success
  • nix build .#yoi: success

作業後状態:

  • branch: work/00001KW76E8EG-embedded-runtime-fs-store
  • git status --short: clean

Residual risks:

  • 特記すべき未解決リスクなし。再起動後の実行 handle は復元せず stale/unconnected として扱う設計どおり。

Implementation report

Review kickoff:

Reviewer Worker spawned for 00001KW76E8EG implementation.

  • Reviewer Worker: yoi-reviewer-00001KW76E8EG-fs-store
  • Review target commit: 736b05c6 feat: persist embedded workspace runtime in fs store
  • Review mode: read-only implementation worktree review

Review focus:

  • workspace-server enables worker-runtime fs-store feature
  • ServerConfig has authoritative embedded Runtime store root defaulting under user data / workspace id, not project records
  • normal WorkspaceApi uses fs-store backed EmbeddedWorkerRuntime, not memory-backed runtime
  • restart restores catalog / Worker snapshot / ConfigBundle / transcript
  • execution handle after restart is stale/unconnected diagnostic, not falsely connected
  • Browser APIs do not leak store root / raw path / execution handle
  • production path cannot accidentally use memory-backed runtime
  • focused tests cover these behaviors