2.1 KiB
2.1 KiB
Ticket role Pod launcher is complete and merged.
Implementation:
4bf0e27 feat: add ticket role pod launcherdd70517 fix: harden ticket role launch execution- merge commit:
3d6c1ab merge: add ticket role launcher
Summary:
- Added
crates/client/src/ticket_role.rsas a reusable client-level Ticket role launch layer. - Added launch planning for fixed Ticket roles using
.yoi/ticket.config.toml:- intake
- orchestrator
- coder
- reviewer
- investigator
- Kept TUI free from
podinternals; TUI can useclient. - Generated first-run input as
Segment::WorkflowInvokeplusSegment::Text. - Kept Profile responsible for durable system/role behavior.
- Did not add role-level
system_instructionsupport. - Exposed unresolved
launch_promptrefs in plans/text without treating them as system instructions. - Added execution API using
spawn_pod,PodClient, andMethod::Runwith acceptance confirmation. - Top-level execution now rejects
profile = "inherit"withUnsupportedInheritProfilerather than passing invalid--profile inheritsemantics. - Run delivery waits for acceptance evidence (
UserMessage,InvokeStart UserSend, orTurnStart) and reports error/close/timeout.
Review:
- External sibling review initially requested changes for two blockers:
- invalid top-level execution of
inheritprofile; - no first-run acceptance confirmation.
- invalid top-level execution of
- Both blockers were fixed in
dd70517. - Re-review approved with no blockers.
Non-blocker follow-ups:
- Add fake-socket/client execution tests for acceptance/rejection/close/timeout behavior.
- Add aggregate prompt/list caps; current implementation bounds individual fields but not list length globally.
- TUI/CLI integration should surface
UnsupportedInheritProfileclearly or require concrete role profiles until an inheritance-aware launch path exists.
Post-merge validation passed:
cargo test -p client ticketcargo test -p ticketcargo check --workspace --all-targetscargo fmt --checkgit diff --check./tickets.sh doctornix build .#yoi --no-link
This clears the prerequisite for tui-ticket-role-actions.