3.3 KiB
3.3 KiB
Agent Skills support を実装・レビュー・merge・検証した。
実装内容:
- first-class Skill schema/types と Workspace HTTP client support を追加。
- Workspace backend に Skill discovery / lint / catalog / detail / activation を追加。
- Workspace API endpoints を追加:
GET /api/w/{workspace_id}/skillsGET /api/w/{workspace_id}/skills/lintGET /api/w/{workspace_id}/skills/{name}GET /api/w/{workspace_id}/skills/{name}/activate
yoi-workspace-server skills list|lint|showCLI surface を追加。- Web Workspace API helpers/types を追加。
- builtin Skill resource
resources/skills/agent-skills/SKILL.mdを追加。 - Worker Skill activation method を追加し、
WorkspaceClient::Http経由で Skill activation を取得し、SystemItem::SkillActivationを commit し、Skill body を engine history に append するようにした。 - Prompt guidance を更新し、Skills は procedural LLM guidance であり external state authority ではないことを明示。
Skill behavior:
- Workspace Skills are read from
.yoi/skills/<skill-name>/SKILL.md。 - Lint validates required
name/description, parent-dir match, name length/pattern, description bounds, optionallicense/compatibility/ string-mapmetadata。 - Unknown frontmatter keys are lint errors。
- Workflow/projection/invocation-shaped keys such as
model_invokation,user_invocable,graph,invocationare explicitly rejected withunsupported_workflow_frontmatter_field。 allowed-toolsis parsed/diagnosed as experimental ignored/non-authoritative metadata。- Builtin and workspace Skills are loaded deterministically; workspace Skills override builtin Skills with path-free provenance。
- Catalog responses contain lightweight metadata only; detail/activation returns full
SKILL.mdbody。 - References/assets/scripts are Skill-relative and non-executable/non-authoritative; no raw absolute paths are exposed。
- No
/skill-namesyntax, Workflow compatibility path, or Knowledge active support was added。
Review:
- Initial review requested changes for silently accepted unsupported Workflow frontmatter and missing Worker activation/history coverage。
4ddfccee fix: reject unsupported skill fieldsadded unsupported-key diagnostics/regression tests and Worker activation/history tests。- Focused re-review approved with no blockers。
- Non-blocking note: detail/activation for invalid Skills returns not-found while catalog/lint carries diagnostics; acceptable for this initial authority model。
Merge / validation:
- Merge commit:
1611e04d merge: agent skills support。 - Final validation passed:
- Regression grep for removed Workflow/Knowledge active surfaces。
git diff --checkcargo test -p yoi-workspace-server --libcargo test -p worker --lib --testscargo test -p yoi --testscd web/workspace && deno task checkcd web/workspace && deno task testcargo check -p yoi-workspace-servercargo check -p yoiyoi ticket doctornix build .#yoi --no-link
- Validation log:
/run/user/1000/yoi/yoi-orchestrator/bash-output/agent-skills-final-validation-1784160679.txt
Cleanup:
- Implementation worktree/branch cleanup will be performed after close commit。
- Per user instruction,
StopPodis not used。