1.5 KiB
1.5 KiB
Created
Created by tickets.sh create.
Review: approve
Reviewed implementation commit d5d50a3 fix: suppress pod socket peer disconnect noise from branch work/pod-socket-peer-disconnect-noise.
Result: approved.
The implementation correctly separates normal peer disconnect read errors from invalid method payloads in crates/pod/src/ipc/server.rs:
ConnectionReset,ConnectionAborted,BrokenPipe, andUnexpectedEofnow close only the affected connection.- Those peer disconnects no longer broadcast
Event::Errorto unrelated clients. - malformed/schema-invalid Method lines still return a clear
InvalidRequesterror to the offending connection.
Focused tests cover both paths:
peer_disconnect_read_errors_are_connection_closeinvalid_data_is_not_peer_disconnectsocket_schema_invalid_method_returns_errorsocket_malformed_method_returns_errorsocket_peer_close_without_method_does_not_broadcast_error
Validation reported by implementer:
cargo fmt --checkpassedcargo test -p pod ipc::server -- --nocapturepassedcargo test -p pod --test controller_test socket_ -- --nocapturepassed
Full cargo test -p pod --test controller_test -- --nocapture still has unrelated empty-turn rollback failures; the new socket tests passed within that run and the failing area is unrelated to this IPC disconnect change.