Hare/yoi
1
1
Fork 0
Code Actions Packages Releases Activity
a92fe5ca0a
yoi/.yoi/tickets/00001KTR81P9X/thread.md

10 KiB
Raw Blame History

作成

LocalTicketBackend によって作成されました。

Decision

決定:

  • pod::feature は API / contribution substrate として扱い、Plugin や MCP の権限管理を担わせない。
  • Plugin は pod::feature をユーザー向け package/config/runtime 形式で使わせる層であり、Plugin permission / trust policy は Plugin layer で定義する。
  • MCP は pod::feature 上に protocol-backed integration layer を構築するが、MCP server enablement / command-env-secret policy / trust boundary / MCP-specific permission は MCP layer が独自に持つ。
  • MCP local stdio server の OS-level side effects は Yoi feature authority では制御できないため、feature-layer authority / grant を MCP や Plugin の permission model に流用しない。

反映:

  • 00001KTR81P9X は authority ではなく provider lifecycle / dynamic contribution / normal ToolRegistry path / untrusted normalization に絞る。
  • 00001KTR82RB7 は MCP 固有の explicit config と trust model を持つ。
  • 00001KSXRQ4G8 と 00001KT0Z4BK8 は Plugin permission を Plugin layer として扱い、MCP を初期 Plugin packaging/runtime から分離する。

Intake summary

Marked ready by yoi ticket state.

State changed

Marked ready by yoi ticket state.

State changed

Ticket を workspace-panel が queued にしました。

Decision

Routing decision: implementation_ready

Reason:

  • Ticket is queued and requirements/acceptance criteria for feature-layer provider/service lifecycle and dynamic contributions are specified.
  • Outgoing depends_on 00001KV0SP0TY is satisfied: HostAuthority cleanup is done and merged.
  • Relation/orchestration plan checks show no remaining blocker.
  • Scope is API/contribution substrate only; Plugin/MCP permission/trust policy remains out of scope.

IntentPacket:

  • Extend pod::feature so protocol-backed providers can contribute startup-discovered tools/services/background lifecycle diagnostics through ordinary ToolRegistry / Worker / permission / history / bounded-result paths.

Binding invariants:

  • Do not introduce HostAuthority or replacement feature-layer authority grants.
  • Do not implement MCP protocol/trust policy or Plugin permission policy here.
  • Dynamic schemas must be stable for a run; provider metadata/output is untrusted; tool calls must go through normal permission/history/result paths.

Validation:

  • focused feature/provider tests, affected crate tests, cargo fmt --check, git diff --check, cargo check --workspace --all-targets, and nix build .#yoi if feasible.

State changed

Ticket evidence, satisfied dependency on HostAuthority cleanup, relation records, orchestration plan, and clean workspace state were checked. No blockers remain; accept for implementation before worktree/spawn side effects.

Implementation report

Implemented provider feature API for Ticket 00001KTR81P9X.

Summary:

  • Extended pod::feature descriptors with ProtocolProviderDeclaration and provider lifecycle state/diagnostic reporting.
  • Added ProtocolProviderContribution and FeatureInstallContext::protocol_providers() so startup-discovered provider tools, services, and background task declarations register through the existing feature install pipeline.
  • Provider tools are materialized once at startup and then installed as ordinary Worker tool definitions, preserving stable schemas for the run and normal permission/history/bounded-result execution paths.
  • Unavailable providers record lifecycle diagnostics and skip discovered contributions without adding a separate feature authority layer.
  • Added focused tests for ready providers, failed providers, undeclared providers, and stable dynamic tool metadata.

Validation:

  • PASS: cargo fmt --check
  • PASS: cargo test -p pod feature::tests
  • PASS: cargo check --workspace --all-targets
  • PASS: git diff --check
  • FAIL (pre-existing/unrelated prompt assertion): cargo test -p pod fails in prompt::catalog::tests::pod_orchestration_guidance_section_renders_resource_body and prompt::system::tests::pod_orchestration_guidance_is_included_for_pod_management_tools, both expecting the phrase worktree status, diff, and test results.
  • FAIL (environment/resource): nix build --no-link .#yoi compiles through the Rust crates but fails during final binary link with No space left on device.

Risks/notes:

  • This does not implement MCP protocol, MCP trust policy, plugin permissions, subprocess management, or a replacement HostAuthority-style grant layer.
  • Provider metadata and diagnostics remain install-report data; actual provider tool execution goes through the normal Worker/tool machinery.

Review: approve

Review: approve

Reviewed implementation commit 053a4f90 against Ticket 00001KTR81P9X and base routing commit f709fc10.

Evidence:

  • Diff is limited to the Ticket record and crates/pod/src/feature.rs.
  • The provider API extension stays in pod::feature as a contribution/reporting substrate: ProviderId, ProtocolProviderDeclaration, ProtocolProviderLifecycleState, ProtocolProviderContribution, lifecycle diagnostics, and FeatureInstallContext::protocol_providers() were added without introducing HostAuthority, grant replacement types, MCP trust policy, plugin permission policy, subprocess management, or ToolRegistry/history bypasses.
  • Startup-discovered provider tools are materialized once during feature installation and then registered through Worker::register_tools, preserving stable schemas for the run and normal Worker permission/history/result machinery.
  • Ready providers can contribute tools, service declarations, and background task declarations through the existing feature install report/registry surfaces; unavailable providers record lifecycle diagnostics and skip discovered contributions instead of panicking or installing stale tools.
  • Diagnostics cover undeclared provider ids, duplicate tool names through the shared tool registrar, and failed lifecycle states.
  • API shape is type-oriented and localized; I did not find broad compatibility glue or authority-layer leakage.

Validation performed:

  • PASS cargo fmt --check
  • PASS git diff --check f709fc10..HEAD
  • PASS cargo test -p pod feature::tests (17 passed)
  • PASS cargo check --workspace --all-targets
  • FAIL cargo test -p pod: 323 passed / 2 failed in the same prompt assertion tests reported by Coder (prompt::catalog::tests::pod_orchestration_guidance_section_renders_resource_body, prompt::system::tests::pod_orchestration_guidance_is_included_for_pod_management_tools, both expecting worktree status, diff, and test results). The reviewed diff does not touch prompt resources or those prompt modules, so I classify this as unrelated/pre-existing for this Ticket.

Risks / notes:

  • I did not rerun nix build; Coder reported a final-link No space left on device after Rust compilation. Focused Rust validation passed.
  • Permission denial and bounded-result behavior are not reimplemented in this diff; they are intentionally inherited because provider tools are installed as ordinary Worker tools.

Implementation report

Integration outcome: merged and validated.

  • Implementation branch: ticket-00001KTR81P9X-feature-provider-api
  • Implementation commit: 053a4f90 feat: add protocol provider feature contributions
  • Review commit: d0e8d791 ticket: approve feature provider api
  • Orchestrator merge commit: 3d140dbb merge: feature provider api

Reviewer result:

  • approve。Provider API extension stays in the contribution/reporting substrate, does not reintroduce HostAuthority/grants, does not implement MCP trust/plugin permission policy, and uses ordinary ToolRegistry/Worker/history/permission paths.

Orchestrator validation after merge:

  • cargo fmt --check: PASS
  • git diff --check: PASS
  • cargo test -p pod feature::tests: PASS
  • cargo check --workspace --all-targets: PASS

Not run:

  • nix build .#yoi: skipped at integration because prior Coder run hit host disk pressure during final link; this change did not modify dependencies, Cargo.lock, packaging, or source filters. Recent package validation was performed on adjacent E2E/Profile work.

Residual notes:

  • Full cargo test -p pod is known to fail unrelated prompt assertion tests expecting old guidance text. Reviewer classified those as unrelated/pre-existing to this feature API diff.

Next:

  • Mark Ticket done and clean up child coder/reviewer Pods plus implementation worktree/branch.

State changed

Implementation branch was reviewed, approved, merged into the Orchestrator branch as 3d140dbb, and validated in the Orchestrator worktree. Feature-provider focused tests, formatting, diff check, and workspace check passed. Ticket implementation work is done; closure remains separate.

State changed

Ticket を closed にしました。

完了

Closed after prior done-state completion.